gitlab-dangerfiles 2.7.1 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '083c7ae273083c8b4a4e62ae6b6ef18a86f541770681aec50e01e70f15e62953'
-  data.tar.gz: 0ec743dea037dbc84a59adc29acf405d834e1110aaf9e86320f935868dce3e34
+  metadata.gz: e0819c79b914e2025eecc3b05a52227a9012ceafeac3300032e1abb129706440
+  data.tar.gz: 117a9710932852cf1845d8a8c3a27f331bbe65da0cccdf13f044858d915ea0c1
 SHA512:
-  metadata.gz: ecc770656df082b0cec24b6293ec92f118cd04ed7d654c65f3791fad283dbfa53583c14c33a93b29f0dc79e921ee8cdddc9d2c062ba1cc9e8e97f44e05244121
-  data.tar.gz: b92837330d8edef3136ff37751589592a7a4b2cb6c1f4204e982a1b2bcce236f7cd09e8501b1190c79ff4c4590cbe63ed5b02567d3b377435cc3c7db3c83a747
+  metadata.gz: c93c2983a4a0ebba6f3c94d0b81a1da7ba9fad9eb98573a5862e3d6501ff76614501907bb5d492942a47472160d2db5d1a96fcebdad280379cd3e03a43c5f113
+  data.tar.gz: 734bbb0e6894d8de57f4d48546aca9f085447556662dbc64ba99f7cb39ea166b5a75f3d1099077e09d17f44d3687a9fe733451fa06310e02d906209b6003bcae

data/.gitlab/merge_request_templates/Release.md

@@ -1,12 +1,13 @@
-<!-- Replace `<NEW_VERSION>` with the previous release here, and `<COMMIT_UPDATING_VERSION>`
-with the latest commit from this merge request. -->
-- Diff: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/compare/v<NEW_VERSION>...<COMMIT_UPDATING_VERSION>
+<!-- Replace `<PREVIOUS_VERSION>` with the previous version number here, `<COMMIT_UPDATING_VERSION>` with the latest
+commit from this merge request, and `<NEW_VERSION>` with the upcoming version number. -->
+## Diff
 
-- Checklist before merging:
-  - [ ] Diff link is up-to-date.
-  - [ ] Based on the diff, `version.rb` is updated, according to [SemVer](https://semver.org).
+https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/compare/v<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
 
-- Checklist after merging:
-  - [ ] Check that automatic release notes (generated following the same process as https://docs.gitlab.com/ee/development/changelog.html) are correct.
+## Checklist
+
+- [ ] Diff link is up-to-date.
+- [ ] Check the release notes: https://gitlab.com/api/v4/projects/gitlab-org%2Fruby%2Fgems%2Fgitlab-dangerfiles/repository/changelog?version=<NEW_VERSION>
+- [ ] Based on the diff and the release notes, `version.rb` is updated, according to [SemVer](https://semver.org).
 
 /label ~"type::maintenance" ~"static code analysis"

data/.gitlab-ci.yml

@@ -28,12 +28,6 @@ workflow:
       - Gemfile.lock
     policy: pull
 
-danger-review:
-  extends: .default
-  stage: test
-  script:
-    - bundle exec danger --fail-on-errors=true --verbose
-
 test:rspec:
   extends: .default
   stage: test
@@ -52,7 +46,9 @@ include:
   - template: Security/SAST.gitlab-ci.yml
   - template: Security/Secret-Detection.gitlab-ci.yml
   - project: 'gitlab-org/quality/pipeline-common'
-    file: '/ci/gem-release.yml'
+    file:
+      - '/ci/danger-review.yml'
+      - '/ci/gem-release.yml'
 
 # run security jobs on MRs
 # see: https://gitlab.com/gitlab-org/gitlab/-/issues/218444#note_478761991

data/gitlab-dangerfiles.gemspec

@@ -8,15 +8,15 @@ Gem::Specification.new do |spec|
 
   spec.summary = %q{This gem provides common Dangerfile and plugins for GitLab projects.}
   spec.description = %q{This gem provides common Dangerfile and plugins for GitLab projects.}
-  spec.homepage = "https://gitlab.com/gitlab-org/gitlab-dangerfiles"
+  spec.homepage = "https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles"
   spec.license = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")
 
   spec.metadata["allowed_push_host"] = "https://rubygems.org"
 
   spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://gitlab.com/gitlab-org/gitlab-dangerfiles"
-  spec.metadata["changelog_uri"] = "https://gitlab.com/gitlab-org/gitlab-dangerfiles/-/releases"
+  spec.metadata["source_code_uri"] = "https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles"
+  spec.metadata["changelog_uri"] = "https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/releases"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

data/lib/danger/plugins/roulette.rb

@@ -22,7 +22,7 @@ module Danger
     #
     # @return [Gitlab::Dangerfiles::Teammate]
     def team_mr_author
-      company_members.find { |person| person.username == helper.mr_author }
+      @team_mr_author ||= company_members.find { |person| person.username == helper.mr_author }
     end
 
     # Assigns GitLab team members to be reviewer and maintainer
@@ -36,6 +36,7 @@ module Danger
     def spin(project = nil, categories = [nil], timezone_experiment: false)
       project = (project || helper.config.project_name).downcase
       categories = categories.map { |category| category&.downcase }
+      categories.reject! { |category| integrations_reject_category?(category, project) }
 
       spins = categories.sort_by(&:to_s).map do |category|
         including_timezone = INCLUDE_TIMEZONE_FOR_CATEGORY.fetch(category, timezone_experiment)
@@ -106,6 +107,14 @@ module Danger
       person.username == helper.mr_author
     end
 
+    # @param [String] category name
+    # @return [Boolean]
+    def integrations_reject_category?(category, project)
+      # Reject integrations categories if the MR author has reviewing abilities for the category.
+      team_mr_author&.integrations_be?(project, category, helper.mr_labels) ||
+        team_mr_author&.integrations_fe?(project, category, helper.mr_labels)
+    end
+
     def new_random(seed)
       Random.new(Digest::MD5.hexdigest(seed).to_i(16))
     end

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "2.7.1"
+    VERSION = "2.8.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.8.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-13 00:00:00.000000000 Z
+date: 2022-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-gitlab
@@ -170,14 +170,14 @@ files:
 - lib/gitlab/dangerfiles/weightage.rb
 - lib/gitlab/dangerfiles/weightage/maintainers.rb
 - lib/gitlab/dangerfiles/weightage/reviewers.rb
-homepage: https://gitlab.com/gitlab-org/gitlab-dangerfiles
+homepage: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles
 licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-  homepage_uri: https://gitlab.com/gitlab-org/gitlab-dangerfiles
-  source_code_uri: https://gitlab.com/gitlab-org/gitlab-dangerfiles
-  changelog_uri: https://gitlab.com/gitlab-org/gitlab-dangerfiles/-/releases
+  homepage_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles
+  source_code_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles
+  changelog_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/releases
 post_install_message: 
 rdoc_options: []
 require_paths: