gitlab-dangerfiles 2.2.2 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f81554a60bebe4dbb5cec0a4499df086b580778f5bd2d82a67613a9af166a78
-  data.tar.gz: 83c066d44caca9a1bf05386269f15d92b781891e90b1f3e709cf190faffbb773
+  metadata.gz: 9514e55b5f6bd5a29333c3d08cd1cb2b6a0a61dc3f07a363625a60e52708095a
+  data.tar.gz: '05359002275ba7bf06b2aca1d6a9a0acc8f149765ff87970bf12ebcb29b3f796'
 SHA512:
-  metadata.gz: d9369900511e47644c72f843f52f8b212528f1604a50a07427cab956822974ea9b71f5051a4d8313cf962a7430b9ea150c0f3deeca3ed2360542729b1f79d279
-  data.tar.gz: 9d2cc70542f4df753a6d30d194a43c883a1960aefe517f0b1001609ec47cb764c9c90b7a166d633b7a50a4e49a046bc90cdb56b5c3ed0d02c052909458453d65
+  metadata.gz: 6309c8416ef0952e275acce5ec3fe12bbc72658857ad253e6fd92c86acc5d2d6a952cbb87f80b5d32073d6d9c5eb521482417e7ecfcfc1c93502107a11fbfa62
+  data.tar.gz: 99c591108c94959166847f6bc11f2b0f7bcf7a1114c4176d982ecdbbc8c5cd6c3bef6edca889a6cd3dc0d5902077fcaa117835a521e9eb9d4bfd590a16161cbf

data/README.md

@@ -7,7 +7,7 @@ The goal of this gem is to centralize Danger plugins and rules that to be used b
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'gitlab-dangerfiles'
+gem 'gitlab-dangerfiles', require: false
 ```
 
 And then execute:
@@ -29,6 +29,8 @@ $ gem install gitlab-dangerfiles
 In your project's `Dangerfile`, add the following two line to import the plugins and rules from this gem:
 
 ```ruby
+require 'gitlab-dangerfiles'
+
 # Get an instance of Gitlab::Dangerfiles
 gitlab_dangerfiles = Gitlab::Dangerfiles::Engine.new(self)
 

data/lib/danger/plugins/helper.rb

@@ -17,7 +17,9 @@ module Danger
       none: "",
       qa: "~QA",
       test: "~test ~Quality for `spec/features/*`",
+      # Deprecated as of 2.3.0 in favor of tooling
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
+      tooling: "~tooling for CI, Danger",
       ci_template: '~"ci::templates"',
       product_intelligence: '~"product intelligence"',
     }.freeze
@@ -211,7 +213,7 @@ module Danger
     #                   +filename_regex+ is the regex pattern to match file names. +changes_regex+ is the regex pattern to
     #                   match changed lines in files that match +filename_regex+
     #
-    # @return [Array<Symbol>] the categories a file is in, e.g., +[:frontend]+, +[:backend]+, or +%i[frontend engineering_productivity]+
+    # @return [Array<Symbol>] the categories a file is in, e.g., +[:frontend]+, +[:backend]+, or +%i[frontend tooling]+
     #   using filename regex (+filename_regex+) and specific change regex (+changes_regex+) from the given +categories+ hash.
     def categories_for_file(filename, categories)
       _, categories = categories.find do |key, _|

data/lib/danger/plugins/roulette.rb

@@ -58,7 +58,7 @@ module Danger
             # Fetch an already picked backend reviewer, or pick one otherwise
             spin.reviewer = backend_spin&.reviewer || spin_for_category(project, :backend, timezone_experiment: including_timezone).reviewer
           end
-        when :engineering_productivity
+        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
           if spin.maintainer.nil?
             # Fetch an already picked backend maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer

data/lib/gitlab/dangerfiles/teammate.rb

@@ -95,7 +95,7 @@ module Gitlab
           area = role[/Software Engineer in Test(?:.*?, (\w+))/, 1]
 
           area && labels.any?("devops::#{area.downcase}") if kind == :reviewer
-        when :engineering_productivity
+        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
           return false unless role[/Engineering Productivity/]
           return true if kind == :reviewer
           return true if capabilities(project).include?("#{kind} engineering_productivity")

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "2.2.2"
+    VERSION = "2.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.3.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-09 00:00:00.000000000 Z
+date: 2021-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-gitlab