gitignores 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4137f3ee5e7252e4a21dd063ee66d6aff600d91a40176123fb1617c31c7adb4d
-  data.tar.gz: 33b576db764596fcb3f3599c4d2a041e784a44f481f6c47f1df20bca197f1d07
+  metadata.gz: 5a2c227bbcd01fc5db4de822d7fbb850c8d49427f0e09166f0e5a3578cd5db82
+  data.tar.gz: 8b62d2036dba2ec308cf162ef23fa6f1a0cbc9e862f9201f9a76162f0f60a3ee
 SHA512:
-  metadata.gz: b353d55a750199b592aabdd5b3e5fce773c7059b0f45ff260dbe12ca661856fc3bc5d96c795ec0e6d9cc8ec5b71b7eab8a04d9e1d5df133e9424c694af132dfa
-  data.tar.gz: 5f8fdf97265decc4d6b6ad1cb2859300060d29730d593abf7589b3ae437e9f61d9e5a6d4c0d7a31e8f404c1dd6a783cc670242735277e3da227f0f4602af89ef
+  metadata.gz: b352a098f1efe529bee8f45e99a9634e3b519581cfc96496ed07eec9e17914e7e6affaf04ea636df643d8f347a09af3405cd252dbd959a088037a26832859ab7
+  data.tar.gz: bbd5907f97d298cbfb8581554631c054144b088ef2f64639e69e395e51f5e6a68f184d6c4a7d1f89213dcee17a38abf2f7afce00fbbe92470d249f8ef95bbab5

data/CHANGELOG.md

@@ -1,3 +1,25 @@
+## 0.1.2 (2025-07-11)
+
+Compatibility:
+
+  - Add Ruby 3.x compatibility by replacing deprecated `Dir.exists?` and `File.exists?` methods
+  - Update GLI gem from 2.13.3 to 2.21.5 to fix ERB deprecation warnings
+  - Fix deprecated `Rake::RDocTask`, now uses `RDoc::Task`
+  - Add Ruby version requirement (>= 2.5.0) to gemspec
+
+Security:
+
+  - Fix potential shell command injection vulnerability by using `system()` instead of backticks
+
+Features:
+
+  - Update OS gitignore name from 'OSX' to 'macOS' to match current GitHub repository structure
+
+Development:
+
+  - Update RSpec stubbing syntax to modern `allow().to receive()` pattern
+  - Add proper error handling for git operations with custom exception classes
+
 ## 0.0.3 (2015-05-25)
 
 Features:

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    gitignores (0.1.1)
-      gli (= 2.13.3)
+    gitignores (0.1.2)
+      gli (= 2.21.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.4.4)
-    gli (2.13.3)
+    gli (2.21.5)
     rake (13.0.3)
     rdoc (6.3.0)
     rspec (3.10.0)
@@ -35,4 +35,4 @@ DEPENDENCIES
   rspec
 
 BUNDLED WITH
-   2.1.4
+   2.6.9

data/Rakefile

@@ -1,3 +1,4 @@
+require 'bundler/gem_tasks'
 require 'rake/clean'
 require 'rubygems'
 require 'rubygems/package_task'
@@ -6,7 +7,7 @@ require 'rspec/core/rake_task'
 
 CLEAN << 'tmp'
 
-Rake::RDocTask.new do |rd|
+RDoc::Task.new do |rd|
   rd.main = "README.rdoc"
   rd.rdoc_files.include("README.rdoc","lib/**/*.rb","bin/**/*")
   rd.title = 'gitignores'
@@ -14,14 +15,9 @@ end
 
 include Rake::DSL
 
-Bundler::GemHelper.install_tasks
 
 RSpec::Core::RakeTask.new do |t|
 end
 
-spec = eval(File.read('gitignores.gemspec'))
-
-Gem::PackageTask.new(spec) do |pkg|
-end
 
 task :default => [:spec]

data/bin/gitignores

@@ -33,11 +33,11 @@ Use the list command to show possible values for snippet names.
 )
 arg 'snippet', :multiple
 command :add do |c|
-  c.desc 'include snippets for operating systems OSX, Windows, Linux'
+  c.desc 'include snippets for operating systems macOS, Windows, Linux'
   c.switch :os, :negatable => false
   c.action do |global_options,options,args|
     if (options[:os])
-      args.concat ['OSX', 'Windows', 'Linux']
+      args.concat ['macOS', 'Windows', 'Linux']
     end
     args.uniq!
     $gitignores.add(args)

data/gitignores.gemspec

@@ -9,6 +9,7 @@ Gem::Specification.new do |gem|
   gem.platform = Gem::Platform::RUBY
   gem.summary = Gitignores::SUMMARY
   gem.homepage = 'https://github.com/gilday/gitignore-builder'
+  gem.required_ruby_version = '>= 2.5.0'
   
   gem.files = `git ls-files`.split("
 ")
@@ -18,6 +19,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency('rake')
   gem.add_development_dependency('rdoc')
   gem.add_development_dependency('rspec')
-  gem.add_runtime_dependency('gli','2.13.3')
+  gem.add_runtime_dependency('gli','2.21.5')
 end
 

data/lib/gitignores/builder.rb

@@ -15,8 +15,8 @@ module Gitignores
 
     def find_gitignores_by_name(ignores) 
       ignores.collect { |x| 
-        path = File.exists?("#{@local_repository}/#{x}.gitignore") ? "#{@local_repository}/#{x}.gitignore" : "#{@local_repository}/Global/#{x}.gitignore"
-        unless File.exists? path
+        path = File.exist?("#{@local_repository}/#{x}.gitignore") ? "#{@local_repository}/#{x}.gitignore" : "#{@local_repository}/Global/#{x}.gitignore"
+        unless File.exist? path
           raise GitignoreNotFoundException.new(x), "File #{path} does not exist"
         end
         File.expand_path(path)

data/lib/gitignores/exceptions.rb

@@ -5,4 +5,7 @@ module Gitignores
       @ignore_name = ignore_name
     end
   end
+  
+  class GitCloneError < RuntimeError; end
+  class GitPullError < RuntimeError; end
 end

data/lib/gitignores/fetcher.rb

@@ -1,4 +1,5 @@
 require 'gitignores'
+require 'shellwords'
 
 module Gitignores
   class GitignoreFetcher
@@ -16,7 +17,7 @@ module Gitignores
     # If @update_ignores? is set, will try to update the latest gitignores
     # Will store all gitignores in the @local_repository
     def fetch_gitignores()
-      unless (Dir.exists?(@local_repository))
+      unless (Dir.exist?(@local_repository))
         @git.clone @remote_repository, @local_repository
       end
       if @update_ignores
@@ -37,12 +38,14 @@ module Gitignores
   class Git
 
     def clone(repository, directory)
-       `git clone #{repository} #{directory}`
+      system('git', 'clone', repository, directory)
+      raise GitCloneError, "Failed to clone #{repository}" unless $?.success?
     end
 
     def pull(directory) 
       Dir.chdir(directory) {
-        `git pull`
+        system('git', 'pull')
+        raise GitPullError, "Failed to pull in #{directory}" unless $?.success?
       }
     end
   end

data/lib/gitignores/version.rb

@@ -1,5 +1,5 @@
 module Gitignores
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 
   SUMMARY = "Generates .gitignore"
 

data/spec/gitignore_fetcher_spec.rb

@@ -11,7 +11,7 @@ describe Git do
     FileUtils.rm_rf(test_repository)
     @git.clone '.', test_repository
 
-    expect(File.exists?(test_repository)).to be true
+    expect(File.exist?(test_repository)).to be true
     expect(Dir[test_repository].empty?).to be false
   end
 end
@@ -34,7 +34,7 @@ describe GitignoreFetcher do
 
     it "updates the repository when given update flag" do
       @fetcher.update_ignores = true
-      @mockGit.stub(:clone)
+      allow(@mockGit).to receive(:clone)
       expect(@mockGit).to receive(:pull).with(anything())
 
       @fetcher.fetch_gitignores
@@ -44,7 +44,7 @@ describe GitignoreFetcher do
   describe "#list_gitignores" do
 
     it "finds all gitignores in the directory and returns their names in a list" do
-      @mockGit.stub(:clone)
+      allow(@mockGit).to receive(:clone)
       @fetcher.local_repository = FAKE_IGNORES
       ignores = @fetcher.list_gitignores
 

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: gitignores
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Johnathan Gilday
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-05 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -58,15 +57,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.13.3
+        version: 2.21.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.13.3
-description:
+        version: 2.21.5
 email: me@johnathangilday.com
 executables:
 - gitignores
@@ -96,7 +94,6 @@ files:
 homepage: https://github.com/gilday/gitignore-builder
 licenses: []
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -105,15 +102,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Generates .gitignore
 test_files: []