github_deprecations 0.0.1 → 0.0.2

data/CHANGELOG.md

@@ -0,0 +1,3 @@
+## 0.0.2
+
+* errors in configuration will warn, but not raise errors

data/lib/github_deprecations/version.rb

@@ -1,3 +1,3 @@
 module GithubDeprecations
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/github_deprecations.rb

@@ -10,9 +10,19 @@ module GithubDeprecations
     config = Config.new(options)
     blk.call(config) if blk
     config
+  rescue ArgumentError => e
+    $stderr.puts "Missing config parameters for GithubDeprecations"
+    Noop.new
   end
   module_function :configure
 
+  # All methods are noop and returns itself
+  class Noop
+    def method_missing(name, *args, &block)
+      self
+    end
+  end
+
   class Config < Hashie::Dash  # add Dash#verify! so that it's not checked on initialization
     property :login,       :required => true
     property :oauth_token, :required => true

data/test/github_deprecations/worker_test.rb

@@ -0,0 +1,42 @@
+require 'test_helper'
+
+class GithubDeprecations::WorkerTest < Test::Unit::TestCase
+  def setup
+    @worker = GithubDeprecations::Worker.new({
+      :login       => 'jch',
+      :oauth_token => 'oauth2token',
+      :repo        => 'org/repo-name',
+      :labels      => []
+    })
+    # name, start, ending, transaction_id, payload. see ActiveSupport::Notifications::Event
+    @event = [
+      'deprecation.rails',
+      '2012-07-27 20:33:56 -0700',
+      '2012-07-27 20:34:03 -0700',
+      '13',
+      {
+        :message   => "DEPRECATION WARNING: Ooga Booga. (called from irb_binding at (irb):1)",
+        :callstack => ['stack1', 'stack2']
+      }
+    ]
+  end
+
+  def test_create_issue
+    # name, start, ending, transaction_id, payload
+    @worker.stubs(:find_issue).returns(nil)
+    @worker.expects(:create_issue)
+    @worker.submit_issue!(@event)
+  end
+
+  def test_update_existing_issue
+    issue = stub(:number => '5')
+    @worker.stubs(:find_issue).returns(issue)
+    @worker.expects(:update_issue).with('5', any_parameters, any_parameters)
+    @worker.submit_issue!(@event)
+  end
+
+  def test_title_normalization
+    normalized = @worker.normalize_title("DEPRECATION WARNING: Ooga Booga. (called from irb_binding at (irb):1)")
+    assert_equal "Ooga Booga.", normalized
+  end
+end

data/test/github_deprecations_test.rb

@@ -1,42 +1,25 @@
 require 'test_helper'
+require 'stringio'
 
-class GithubDeprecations::WorkerTest < Test::Unit::TestCase
-  def setup
-    @worker = GithubDeprecations::Worker.new({
-      :login       => 'jch',
-      :oauth_token => 'oauth2token',
-      :repo        => 'org/repo-name',
-      :labels      => []
-    })
-    # name, start, ending, transaction_id, payload. see ActiveSupport::Notifications::Event
-    @event = [
-      'deprecation.rails',
-      '2012-07-27 20:33:56 -0700',
-      '2012-07-27 20:34:03 -0700',
-      '13',
-      {
-        :message   => "DEPRECATION WARNING: Ooga Booga. (called from irb_binding at (irb):1)",
-        :callstack => ['stack1', 'stack2']
-      }
-    ]
+class GithubDeprecationsTest < Test::Unit::TestCase
+  def capture_stderr(&blk)
+    io = StringIO.new
+    old_io, $stderr = $stderr, io
+    blk.call
+    $stderr.string
+  ensure
+    $stderr = old_io
   end
 
-  def test_create_issue
-    # name, start, ending, transaction_id, payload
-    @worker.stubs(:find_issue).returns(nil)
-    @worker.expects(:create_issue)
-    @worker.submit_issue!(@event)
+  def test_configure_fails_silently
+    output = capture_stderr do
+      GithubDeprecations.configure
+    end
+    assert_equal output, "Missing config parameters for GithubDeprecations\n"
   end
 
-  def test_update_existing_issue
-    issue = stub(:number => '5')
-    @worker.stubs(:find_issue).returns(issue)
-    @worker.expects(:update_issue).with('5', any_parameters, any_parameters)
-    @worker.submit_issue!(@event)
-  end
-
-  def test_title_normalization
-    normalized = @worker.normalize_title("DEPRECATION WARNING: Ooga Booga. (called from irb_binding at (irb):1)")
-    assert_equal "Ooga Booga.", normalized
+  def test_configure_fails_noop
+    # shouldn't raise no method error
+    GithubDeprecations.configure.register!
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_deprecations
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -115,6 +115,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -122,6 +123,7 @@ files:
 - github_deprecations.gemspec
 - lib/github_deprecations.rb
 - lib/github_deprecations/version.rb
+- test/github_deprecations/worker_test.rb
 - test/github_deprecations_test.rb
 - test/integration_test.rb
 - test/test_helper.rb
@@ -150,6 +152,7 @@ signing_key:
 specification_version: 3
 summary: Create GitHub issues based on ActiveSupport deprecation errors
 test_files:
+- test/github_deprecations/worker_test.rb
 - test/github_deprecations_test.rb
 - test/integration_test.rb
 - test/test_helper.rb