github_concern 0.0.4 → 0.1.0

data/README.markdown

@@ -24,7 +24,7 @@ gem 'github_concern', :git => 'http://github.com/adamgamble/github_concern.git'
     bundle install
 
 Now github\_concern is available to your application.  Next, add a service hook
-to your github repo that posts to http://your\_url/github\_integration
+to your github repo that posts to http://your\_url/github\_integration?token=some_unique_token
 
 Add this to config/initializers/github\_concern.rb:
 
@@ -32,6 +32,7 @@ Add this to config/initializers/github\_concern.rb:
 GithubConcern::Engine.config do |gc|
   gc.user_lambda = lambda {|email| User.find_by_email email}
   gc.user_class  = User
+  gc.token       = "some_unique_token"
 end
 ```
 

data/app/controllers/github_controller.rb

@@ -1,5 +1,6 @@
 class GithubController < ApplicationController
   def payload
+    render :nothing => true, :status => 404 and return unless params.keys.include?("token") && params["token"] == GithubConcern::Engine.token
     render :nothing => true, :status => 500 and return unless params["payload"]
     GitPush.create(:payload => JSON.parse(params["payload"]))
     render :nothing => true, :status => 200

data/lib/github_concern/engine.rb

@@ -3,6 +3,7 @@ module GithubConcern
   class Engine < Rails::Engine
     @@github_concerns = {}
     @@callback_lambdas = []
+    @@token = ""
 
     def self.config
       yield(self)
@@ -26,6 +27,14 @@ module GithubConcern
       end
     end
 
+    def self.token= _token
+      @@token = _token
+    end
+
+    def self.token
+      @@token
+    end
+
     def self.user_lambda= find_user_lambda
       @@user_lambda = find_user_lambda
     end

data/lib/github_concern/version.rb

@@ -1,3 +1,3 @@
 module GithubConcern
-  VERSION = "0.0.4"
+  VERSION = "0.1.0"
 end

data/spec/controllers/github_controller_spec.rb

@@ -3,14 +3,25 @@ require 'spec_helper'
 describe GithubController do
   describe "POST payload" do
     it "returns 500 when not sending a payload" do
-      post :payload
+      post :payload, :token => GithubConcern::Engine.token
       response.code.should == "500"
     end
 
-    describe "when sending a valid payload" do
+    describe "when sending a valid payload with an invalid token" do
       before(:each) do
         payload = valid_payload_hash.to_json
-        post :payload, :payload => payload
+        post :payload, :payload => payload, :token => "my_token"
+      end
+
+      it "should return a 404" do
+        response.code.should == "404"
+      end
+    end
+
+    describe "when sending a valid payload and a valid token" do
+      before(:each) do
+        payload = valid_payload_hash.to_json
+        post :payload, :payload => payload, :token => GithubConcern::Engine.token
       end
 
       it "returns 200 when sending a valid payload" do

data/spec/internal/config/initializers/github_concern.rb

@@ -1,6 +1,7 @@
 GithubConcern::Engine.config do |gc|
   gc.user_lambda = lambda {|email| User.find_by_email email}
   gc.user_class  = User
+  gc.token       = "my_github_token"
 end
 
 Module.constants.select do |constant_name|