github-v3-api 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f692dff20ddbd6902535cc3e21c21daad15011a7
-  data.tar.gz: 94e3d1a031dd93bdfd43300a8e33bbf110a9da44
+  metadata.gz: ac5a14f8e48660b650280828fb50755370ed06ed
+  data.tar.gz: 2c36d07918f201c1af217d18960efd286a1d0237
 SHA512:
-  metadata.gz: decad8e4794a5b87bf3f22b292226791bcd672df7f2f70326bd1fbd6bfa6f61eb2a8ce9d15510bc37eafe9f68dd3529657f96862a2e7492778109d6cf76a3564
-  data.tar.gz: 6d45d0bcaa1e25d2fdbfb4dab2201ee80f35a209dc5f2d19b23bc74beb83910f5592f9b6eeeb7b6afe87beab724bac700e1df962ec11eef7450b39f9883f2dcf
+  metadata.gz: 790bb64597d4826870654f48a57246cb001be5040b8426a3c41cc2d6d7324fb45de09e55b8f3fc397b37797f9c3fb9ebb65fe93de15913c45a0e1f3043bf2b86
+  data.tar.gz: d1916ed66542c9029348558d6bdd232561368033f33a40f86a9c9a8b8387c3b432d8f2a6ecdb6f395a010ed550447f1f2157ed8c0fc2231af25a38b14e743a03

data/lib/github_v3_api.rb

@@ -34,8 +34,13 @@ class GitHubV3API
   # +access_token+ owner's authorization.
   #
   # +access_token+:: an OAuth2 access token from GitHub
-  def initialize(access_token)
+  def initialize(access_token, api_url='https://api.github.com', header={})
     @access_token = access_token
+    @api_url = api_url
+    @header = {:accept => :json,
+               :authorization => "token #{@access_token}",
+               :user_agent => "rubygem-github-v3-api"}
+    @header.merge!(header) if header.is_a?(Hash)
   end
 
   # Entry-point for access to the GitHub Users API
@@ -71,14 +76,13 @@ class GitHubV3API
   end
 
   def get(path, params={}) #:nodoc:
-    result = RestClient.get("https://api.github.com" + path,
-                            {:accept => :json,
-                             :authorization => "token #{@access_token}"}.merge({:params => params}))
+    result = RestClient.get(@api_url + path,
+                            @header.merge({:params => params}))
     result_data = JSON.parse(result)
     # check for pagination
     link = result.headers[:link]
     if link then
-      re_relnext = /<https:\/\/api.github.com([^>]*)>; *rel="next"/
+      re_relnext = %r!<#{@api_url}([^>]*)>; *rel="next"!
       relnext_path = link.match re_relnext
       if relnext_path && relnext_path[1] then
         next_data = self.get(relnext_path[1], params)
@@ -91,27 +95,24 @@ class GitHubV3API
   end
 
   def post(path, params={}) #:nodoc:
-    result = RestClient.post("https://api.github.com" + path, JSON.generate(params),
-                            {:accept => :json,
-                             :authorization => "token #{@access_token}"})
+    result = RestClient.post(@api_url + path, JSON.generate(params),
+                             @header)
     JSON.parse(result)
   rescue RestClient::Unauthorized
     raise Unauthorized, "The access token is invalid according to GitHub"
   end
 
   def patch(path, params={}) #:nodoc:
-    result = RestClient.post("https://api.github.com" + path, JSON.generate(params),
-                            {:accept => :json,
-                             :authorization => "token #{@access_token}"})
+    result = RestClient.post(@api_url + path, JSON.generate(params),
+                             @header)
     JSON.parse(result)
   rescue RestClient::Unauthorized
     raise Unauthorized, "The access token is invalid according to GitHub"
   end
 
   def delete(path) #:nodoc:
-    result = RestClient.delete("https://api.github.com" + path,
-                            {:accept => :json,
-                             :authorization => "token #{@access_token}"})
+    result = RestClient.delete(@api_url + path,
+                               @header)
     JSON.parse(result)
   rescue RestClient::Unauthorized
     raise Unauthorized, "The access token is invalid according to GitHub"

data/lib/github_v3_api/repos_api.rb

@@ -24,6 +24,13 @@ class GitHubV3API
       @connection = connection
     end
 
+    def public_repos
+      @connection.get('/repositories').map do |repo_data|
+        GitHubV3API::Repo.new(self, repo_data)
+      end
+    end
+    
+    
     # Returns an array of GitHubV3API::Repo instances representing the
     # user's public and private repos
     def list

data/lib/github_v3_api/users_api.rb

@@ -35,6 +35,12 @@ class GitHubV3API
       user_data = @connection.get("/users/#{username}")
       GitHubV3API::User.new_with_all_data(self, user_data)
     end
-    
+
+    # Returns an array of all GitHubV3API::User instances in the server.
+    def all
+      @connection.get("/users").map do |user_data|
+        GitHubV3API::User.new_with_all_data(self, user_data)
+      end
+    end
   end
 end

data/lib/github_v3_api/version.rb

@@ -1,3 +1,3 @@
 class GitHubV3API
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

data/spec/github_v3_api_spec.rb

@@ -1,27 +1,32 @@
 require 'spec_helper'
 
 describe GitHubV3API do
+  let(:auth_token)  { 'abcde' }
+  let(:test_header) { {:accept => :json,
+                       :authorization => "token #{auth_token}",
+                       :user_agent => 'rubygem-github-v3-api'} }
+
   it 'is initialized with an OAuth2 access token' do
-    lambda { GitHubV3API.new('abcde') }.should_not raise_error
+    lambda { GitHubV3API.new(auth_token) }.should_not raise_error
   end
 
   describe '#orgs' do
     it 'returns an instance of GitHubV3API::OrgsAPI' do
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.orgs.should be_kind_of GitHubV3API::OrgsAPI
     end
   end
 
   describe '#repos' do
     it 'returns an instance of GitHubV3API::ReposAPI' do
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.repos.should be_kind_of GitHubV3API::ReposAPI
     end
   end
 
   describe "#issues" do
     it "returns an instance of GitHubV3API::IssuesAPI" do
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.issues.should be_kind_of GitHubV3API::IssuesAPI
     end
   end
@@ -29,19 +34,19 @@ describe GitHubV3API do
   describe '#get' do
     it 'does a get request to the specified path at the GitHub API server and adds the access token' do
       rcs = String.new('[]')
-      rcs.stub!(:headers).and_return({})
+      allow(rcs).to receive(:headers) { {} }
       RestClient.should_receive(:get) \
-        .with('https://api.github.com/some/path', {:accept => :json, :authorization => 'token abcde', :params => {}}) \
+        .with('https://api.github.com/some/path', test_header.merge({:params => {}})) \
         .and_return(rcs)
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.get('/some/path')
     end
 
     it 'returns the result of parsing the result body as JSON' do
       rcs = String.new('[{"foo": "bar"}]')
-      rcs.stub!(:headers).and_return({})
-      RestClient.stub!(:get => rcs)
-      api = GitHubV3API.new('abcde')
+      allow(rcs).to receive(:headers) { {} }
+      allow(RestClient).to receive(:get) { rcs }
+      api = GitHubV3API.new(auth_token)
       api.get('/something').should == [{"foo" => "bar"}]
     end
 
@@ -49,23 +54,23 @@ describe GitHubV3API do
       headers_next = { :link => 'Link: <https://api.github.com/some/nextpath>; rel="next", <https://api.github.com/some/lastpath>; rel="last"' }
       headers_last = { :link => 'Link: <https://api.github.com/some/prevpath>; rel="previous", <https://api.github.com/some/lastpath>; rel="last"' }
       rcs_next = String.new('[]')
-      rcs_next.stub!(:headers).and_return(headers_next)
+      allow(rcs_next).to receive(:headers) { headers_next }
       rcs_last = String.new('[]')
-      rcs_last.stub!(:headers).and_return(headers_last)
+      allow(rcs_last).to receive(:headers) { headers_last }
 
       RestClient.should_receive(:get) \
-        .with('https://api.github.com/some/path',     {:accept => :json, :authorization => 'token abcde', :params => {}}) \
+        .with('https://api.github.com/some/path', test_header.merge({:params => {}})) \
         .and_return(rcs_next)
       RestClient.should_receive(:get) \
-        .with('https://api.github.com/some/nextpath', {:accept => :json, :authorization => 'token abcde', :params => {}}) \
+        .with('https://api.github.com/some/nextpath', test_header.merge({:params => {}})) \
         .and_return(rcs_last)
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.get('/some/path')
     end
 
     it 'raises GitHubV3API::Unauthorized instead of RestClient::Unauthorized' do
-      RestClient.stub!(:get).and_raise(RestClient::Unauthorized)
-      api = GitHubV3API.new('abcde')
+      allow(RestClient).to receive(:get) { raise(RestClient::Unauthorized) }
+      api = GitHubV3API.new(auth_token)
       lambda { api.get('/something') }.should raise_error(GitHubV3API::Unauthorized)
     end
   end
@@ -75,9 +80,9 @@ describe GitHubV3API do
       data = {:title => 'omgbbq'}
       json = JSON.generate(data)
       RestClient.should_receive(:post) \
-        .with('https://api.github.com/some/path', json, {:accept => :json, :authorization => 'token abcde'}) \
+        .with('https://api.github.com/some/path', json, test_header) \
         .and_return('{}')
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.post('/some/path', data)
     end
   end
@@ -87,9 +92,9 @@ describe GitHubV3API do
       data = {:title => 'omgbbq'}
       json = JSON.generate(data)
       RestClient.should_receive(:post) \
-        .with('https://api.github.com/some/path', json, {:accept => :json, :authorization => 'token abcde'}) \
+        .with('https://api.github.com/some/path', json, test_header) \
         .and_return('{}')
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.patch('/some/path', data)
     end
   end
@@ -97,9 +102,9 @@ describe GitHubV3API do
   describe "#delete" do
     it 'does a delete request to the specified path at the GitHub API server and adds the access token' do
       RestClient.should_receive(:delete) \
-        .with('https://api.github.com/some/path', {:accept => :json, :authorization => 'token abcde'}) \
+        .with('https://api.github.com/some/path',  test_header) \
         .and_return('{}')
-      api = GitHubV3API.new('abcde')
+      api = GitHubV3API.new(auth_token)
       api.delete('/some/path')
     end
   end

data/spec/issue_spec.rb

@@ -6,7 +6,7 @@ describe GitHubV3API::Issue do
       fields = %w(url html_url number state title body user labels assignee
                   milestone comments pull_request closed_at created_at updated_at)
       fields.each do |f|
-        repo = GitHubV3API::Issue.new_with_all_data(stub('api'), {f.to_s => 'foo'})
+        repo = GitHubV3API::Issue.new_with_all_data(double('api'), {f.to_s => 'foo'})
         repo.methods.should include(f.to_sym)
         repo.send(f).should == 'foo'
       end

data/spec/issues_api_spec.rb

@@ -4,7 +4,7 @@ describe GitHubV3API::IssuesAPI do
   describe "#list" do
     context "options = nil" do
       it "returns issues for a user" do
-        connection = mock(GitHubV3API)
+        connection = double(GitHubV3API)
         connection.should_receive(:get).with('/issues', {}).and_return([:issue_hash1, :issue_hash2])
         api = GitHubV3API::IssuesAPI.new(connection)
         GitHubV3API::Issue.should_receive(:new).with(api, :issue_hash1).and_return(:issue1)
@@ -16,7 +16,7 @@ describe GitHubV3API::IssuesAPI do
 
     context "options = {:user => 'octocat', :repo => 'hello-world'}" do
       it "returns issues for a repo" do
-        connection = mock(GitHubV3API)
+        connection = double(GitHubV3API)
         connection.should_receive(:get).with("/repos/octocat/hello-world/issues", {}).and_return([:issue_hash1, :issue_hash2])
         api = GitHubV3API::IssuesAPI.new(connection)
         GitHubV3API::Issue.should_receive(:new).with(api, :issue_hash1).and_return(:issue1)
@@ -29,7 +29,7 @@ describe GitHubV3API::IssuesAPI do
 
   describe '#get' do
     it 'returns a fully-hydrated Issue object for the specified user, repo, and issue id' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/repos/octocat/hello-world/issues/1234', {}).and_return(:issue_hash)
       api = GitHubV3API::IssuesAPI.new(connection)
       GitHubV3API::Issue.should_receive(:new_with_all_data).with(api, :issue_hash).and_return(:issue)
@@ -37,7 +37,7 @@ describe GitHubV3API::IssuesAPI do
     end
 
     it 'raises GitHubV3API::NotFound instead of a RestClient::ResourceNotFound' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get) \
         .and_raise(RestClient::ResourceNotFound)
       api = GitHubV3API::IssuesAPI.new(connection)
@@ -47,7 +47,7 @@ describe GitHubV3API::IssuesAPI do
 
   describe "#create" do
     it 'returns a fully-hydrated Issue object for the specified user, repo, and issue that was created' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       data = {:title => "omgbbq"}
       connection.should_receive(:post).with('/repos/octocat/hello-world/issues', data).and_return(:issue_hash)
       api = GitHubV3API::IssuesAPI.new(connection)
@@ -56,7 +56,7 @@ describe GitHubV3API::IssuesAPI do
     end
 
     it "raises GitHubV3API::MissingRequiredData when data[:title] is missing" do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_not_receive(:post)
       api = GitHubV3API::IssuesAPI.new(connection)
       lambda { api.create('octocat', 'hello-world', {}) }.should raise_error(GitHubV3API::MissingRequiredData)
@@ -65,7 +65,7 @@ describe GitHubV3API::IssuesAPI do
 
   describe "#update" do
     it 'returns a fully-hydrated Issue object for the specified user, repo, and issue that was updated' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       data = {:body => "lol, wtf"}
       connection.should_receive(:patch).with('/repos/octocat/hello-world/issues/1234', data).and_return(:issue_hash)
       api = GitHubV3API::IssuesAPI.new(connection)
@@ -73,4 +73,4 @@ describe GitHubV3API::IssuesAPI do
       api.update('octocat', 'hello-world', 1234, data).should == :issue
     end
   end
-end
+end

data/spec/org_spec.rb

@@ -9,7 +9,7 @@ describe GitHubV3API::Org do
         private_gists private_repos public_gists public_repos space
         total_private_repos type url)
       fields.each do |f|
-        org = GitHubV3API::Org.new_with_all_data(stub('api'), {f.to_s => 'foo'})
+        org = GitHubV3API::Org.new_with_all_data(double('api'), {f.to_s => 'foo'})
         org.methods.should include(f.to_sym)
         org.send(f).should == 'foo'
       end
@@ -18,7 +18,7 @@ describe GitHubV3API::Org do
 
   describe '#[]' do
     it 'returns the org data for the specified key' do
-      api = mock(GitHubV3API::OrgsAPI)
+      api = double(GitHubV3API::OrgsAPI)
       api.should_receive(:get).with('github') \
         .and_return(GitHubV3API::Org.new(api, 'login' => 'github', 'company' => 'GitHub'))
       org = GitHubV3API::Org.new(api, 'login' => 'github')
@@ -26,7 +26,7 @@ describe GitHubV3API::Org do
     end
 
     it 'only fetches the data once' do
-      api = mock(GitHubV3API::OrgsAPI)
+      api = double(GitHubV3API::OrgsAPI)
       api.should_receive(:get).once.with('github') \
         .and_return(GitHubV3API::Org.new(api, 'login' => 'github', 'company' => 'GitHub'))
       org = GitHubV3API::Org.new(api, 'login' => 'github')
@@ -38,7 +38,7 @@ describe GitHubV3API::Org do
 
   describe '#repos' do
     it 'returns an array of Repo objects that belong to this org' do
-      api = mock(GitHubV3API::OrgsAPI)
+      api = double(GitHubV3API::OrgsAPI)
       api.should_receive(:list_repos).with('github').and_return([:repo1, :repo2])
       org = GitHubV3API::Org.new_with_all_data(api, 'login' => 'github')
       org.repos.should == [:repo1, :repo2]
@@ -47,7 +47,7 @@ describe GitHubV3API::Org do
 
   describe '#members'do
     it 'returns an array of User objects who are members of this org' do
-      api = mock(GitHubV3API::OrgsAPI)
+      api = double(GitHubV3API::OrgsAPI)
       api.should_receive(:list_members).with('github').and_return([:user1, :user2])
 
       org = GitHubV3API::Org.new_with_all_data(api, 'login' => 'github')
@@ -57,7 +57,7 @@ describe GitHubV3API::Org do
 
   describe '#public_members'do
     it 'returns an array of User objects who are public members of this org' do
-      api = mock(GitHubV3API::OrgsAPI)
+      api = double(GitHubV3API::OrgsAPI)
       api.should_receive(:list_public_members).with('github').and_return([:user1, :user2])
 
       org = GitHubV3API::Org.new_with_all_data(api, 'login' => 'github')

data/spec/orgs_api_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe GitHubV3API::OrgsAPI do
   describe '#list' do
     it 'returns the public and private orgs for the authenticated user' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/user/orgs').and_return([:org_hash1, :org_hash2])
       api = GitHubV3API::OrgsAPI.new(connection)
       GitHubV3API::Org.should_receive(:new).with(api, :org_hash1).and_return(:org1)
@@ -15,7 +15,7 @@ describe GitHubV3API::OrgsAPI do
 
   describe '#get' do
     it 'returns a fully-hydrated Org object for the specified org login' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/orgs/octocat').and_return(:org_hash)
       api = GitHubV3API::OrgsAPI.new(connection)
       GitHubV3API::Org.should_receive(:new_with_all_data).with(api, :org_hash).and_return(:org)
@@ -25,7 +25,7 @@ describe GitHubV3API::OrgsAPI do
 
   describe '#list_repos' do
     it 'returns the public and private repos for the specified org' do
-      connection = mock(GitHubV3API, :repos => :repos_api)
+      connection = double(GitHubV3API, :repos => :repos_api)
       connection.should_receive(:get) \
         .with('/orgs/github/repos') \
         .and_return([:repo1_hash, :repo2_hash])
@@ -42,7 +42,7 @@ describe GitHubV3API::OrgsAPI do
 
   describe '#list_members' do
     it 'returns the list of members for the specified org' do
-      connection = mock(GitHubV3API, :users => :users_api)
+      connection = double(GitHubV3API, :users => :users_api)
       connection.should_receive(:get).once.with('/orgs/github/members') \
         .and_return([:user_hash1, :user_hash2])
 
@@ -59,7 +59,7 @@ describe GitHubV3API::OrgsAPI do
 
   describe '#list_public_members' do
     it 'returns the list of public members for the specified org' do
-      connection = mock(GitHubV3API, :users => :users_api)
+      connection = double(GitHubV3API, :users => :users_api)
       connection.should_receive(:get).once.with('/orgs/github/public_members') \
         .and_return([:user_hash1, :user_hash2])
 

data/spec/repo_spec.rb

@@ -7,7 +7,7 @@ describe GitHubV3API::Repo do
           has_wiki homepage html_url language master_branch name open_issues
           organization owner parent private pushed_at size source url watchers)
       fields.each do |f|
-        repo = GitHubV3API::Repo.new_with_all_data(stub('api'), {f.to_s => 'foo'})
+        repo = GitHubV3API::Repo.new_with_all_data(double('api'), {f.to_s => 'foo'})
         repo.methods.should include(f.to_sym)
         repo.send(f).should == 'foo'
       end
@@ -16,14 +16,14 @@ describe GitHubV3API::Repo do
 
   describe '#[]' do
     it 'returns the repo data for the specified key' do
-      api = stub(GitHubV3API::ReposAPI)
+      api = double(GitHubV3API::ReposAPI)
       repo = GitHubV3API::Repo \
         .new_with_all_data(api, 'name' => 'hello-world', 'owner' => {'login' => 'octocat'})
       repo['name'].should == 'hello-world'
     end
 
     it 'only fetches the data once' do
-      api = mock(GitHubV3API::ReposAPI)
+      api = double(GitHubV3API::ReposAPI)
       api.should_receive(:get).once.with('octocat', 'hello-world') \
         .and_return(GitHubV3API::Repo.new(api, 'name' => 'hello-world', 'owner' => {'login' => 'octocat'}, 'private' => true))
       repo = GitHubV3API::Repo.new(api, 'name' => 'hello-world', 'owner' => {'login' => 'octocat'})
@@ -35,7 +35,7 @@ describe GitHubV3API::Repo do
 
   describe '#owner_login' do
     it 'returns the login name of the repo owner' do
-      api = stub(GitHubV3API::ReposAPI)
+      api = double(GitHubV3API::ReposAPI)
       repo = GitHubV3API::Repo.new_with_all_data(api, 'owner' => {'login' => 'octocat'})
       repo.owner_login.should == 'octocat'
     end
@@ -43,7 +43,7 @@ describe GitHubV3API::Repo do
 
   describe '#list_collaborators' do
     it 'returns an array of User objects who are collaborating on this repo' do
-      api = mock(GitHubV3API::ReposAPI)
+      api = double(GitHubV3API::ReposAPI)
       api.should_receive(:list_collaborators).once.with(
         'octocat', 'hello-world').and_return([:user1, :user2, :user3])
 
@@ -55,7 +55,7 @@ describe GitHubV3API::Repo do
 
   describe '#list_watchers' do
     it 'returns an array of User objects who are watching this repo' do
-      api = mock(GitHubV3API::ReposAPI)
+      api = double(GitHubV3API::ReposAPI)
       api.should_receive(:list_watchers).once.with(
         'octocat', 'hello-world').and_return([:user1, :user2, :user3])
 
@@ -67,7 +67,7 @@ describe GitHubV3API::Repo do
 
   describe '#list_forks' do
     it 'returns an array of Repo objects which were forked from this repo' do
-      api = mock(GitHubV3API::ReposAPI)
+      api = double(GitHubV3API::ReposAPI)
       api.should_receive(:list_forks).once.with(
         'octocat', 'hello-world').and_return([:repo1, :repo2, :repo3])
 

data/spec/repos_api_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe GitHubV3API::ReposAPI do
   describe '#list' do
     it 'returns the public and private repos for the authenticated user' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/user/repos').and_return([:repo_hash1, :repo_hash2])
       api = GitHubV3API::ReposAPI.new(connection)
       GitHubV3API::Repo.should_receive(:new).with(api, :repo_hash1).and_return(:repo1)
@@ -15,7 +15,7 @@ describe GitHubV3API::ReposAPI do
 
   describe '#get' do
     it 'returns a fully-hydrated Repo object for the specified user and repo name' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/repos/octocat/hello-world').and_return(:repo_hash)
       api = GitHubV3API::ReposAPI.new(connection)
       GitHubV3API::Repo.should_receive(:new_with_all_data).with(api, :repo_hash).and_return(:repo)
@@ -23,7 +23,7 @@ describe GitHubV3API::ReposAPI do
     end
 
     it 'raises GitHubV3API::NotFound instead of a RestClient::ResourceNotFound' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get) \
         .and_raise(RestClient::ResourceNotFound)
       api = GitHubV3API::ReposAPI.new(connection)
@@ -33,7 +33,7 @@ describe GitHubV3API::ReposAPI do
 
   describe "#list_collaborators" do
     it 'returns a list of Users who are collaborating on the specified repo' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with(
         '/repos/octocat/hello-world/collaborators').and_return([:user_hash1, :user_hash2])
       connection.should_receive(:users).twice.and_return(:users_api)
@@ -49,7 +49,7 @@ describe GitHubV3API::ReposAPI do
 
   describe "#list_watchers" do
     it 'returns a list of Users who are watching the specified repo' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with(
         '/repos/octocat/hello-world/watchers').and_return([:user_hash1, :user_hash2])
       connection.should_receive(:users).twice.and_return(:users_api)
@@ -65,7 +65,7 @@ describe GitHubV3API::ReposAPI do
 
   describe "#list_forks" do
     it 'returns a list of Repos which were forked from the specified repo' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with(
         '/repos/octocat/hello-world/forks').and_return([:repo_hash1, :repo_hash2])
       api = GitHubV3API::ReposAPI.new(connection)

data/spec/user_api_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe GitHubV3API::UsersAPI do
   describe '#current' do
     it 'returns the user data for the authenticated user' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/user').and_return(:user_hash1)
       api = GitHubV3API::UsersAPI.new(connection)
       GitHubV3API::User.should_receive(:new).with(api, :user_hash1).and_return(:user1)
@@ -14,7 +14,7 @@ describe GitHubV3API::UsersAPI do
 
   describe '#get' do
     it 'returns a fully-hydrated User object for the specified user login' do
-      connection = mock(GitHubV3API)
+      connection = double(GitHubV3API)
       connection.should_receive(:get).with('/users/octocat').and_return(:user_hash)
       api = GitHubV3API::UsersAPI.new(connection)
       GitHubV3API::User.should_receive(:new_with_all_data).with(api, :user_hash).and_return(:user)

data/spec/user_spec.rb

@@ -8,7 +8,7 @@ describe GitHubV3API::User do
                   html_url created_at type total_private_repos owned_private_repos 
                   private_gists disk_usage collaborators)
       fields.each do |f|
-        user = GitHubV3API::User.new_with_all_data(stub('api'), {f.to_s => 'foo'})
+        user = GitHubV3API::User.new_with_all_data(double('api'), {f.to_s => 'foo'})
         user.methods.should include(f.to_sym)
         user.send(f).should == 'foo'
       end
@@ -17,7 +17,7 @@ describe GitHubV3API::User do
 
   describe '#[]' do
     it 'returns the user data for the specified key' do
-      api = mock(GitHubV3API::UsersAPI)
+      api = double(GitHubV3API::UsersAPI)
       api.should_receive(:get).with('github') \
         .and_return(GitHubV3API::User.new(api, 'login' => 'github', 'name' => 'GitHub'))
       user = GitHubV3API::User.new(api, 'login' => 'github')
@@ -25,7 +25,7 @@ describe GitHubV3API::User do
     end
 
     it 'only fetches the data once' do
-      api = mock(GitHubV3API::UsersAPI)
+      api = double(GitHubV3API::UsersAPI)
       api.should_receive(:get).once.with('github') \
         .and_return(GitHubV3API::User.new(api, 'login' => 'github', 'name' => 'GitHub'))
       user = GitHubV3API::User.new(api, 'login' => 'github')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-v3-api
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - John Wilger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-29 00:00:00.000000000 Z
+date: 2014-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -166,7 +166,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Ruby Client for the GitHub v3 API