github-pages-health-check 1.7.3 → 1.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb41e9f55a6bba28f9fa077b54b9a52bae3bf5f4
-  data.tar.gz: bb1148932d9a479162202e5fec212307469b2f0a
+  metadata.gz: 03a16a95ebcc2d31fe9f0de07cc2a00018d8a604
+  data.tar.gz: 4358dbd798f76a759a8876daf4d7811f14b6c135
 SHA512:
-  metadata.gz: adbf9c16daa505c35b2bd8caf45689f1c28dded8524a65d65d5b9af9e380bc0ca60a49ae3c29559c5695dcdbdec2a4c209829e03680927753c65de94d506179f
-  data.tar.gz: ec9b09bca3faf4027edb5aa8a66a8bd4e05a4180ec6d536f5079f47f1ae8a9bdf9db0c385c9f9fed1ab61f11040eb27ecdd5fec2b728715191b5892bc0423265
+  metadata.gz: 794287ba5221e2c5ea8506594167309b9a9de12c6b887206b5b4a575b3c42e9b3b86918e506624cf6da134a72510ceeebfb0125c8cabb0ee0b66ba88559008b9
+  data.tar.gz: fe84086c554d3faf80742e607086cbbcf7eeb04a114edb7871200dc860849e9549d44189948fa80c9d27df796da221d34279f2473861982e083390d97a3696c6

data/lib/github-pages-health-check/caa.rb

@@ -10,6 +10,8 @@ module GitHubPages
       attr_reader :error
 
       def initialize(host)
+        raise ArgumentError, "host cannot be nil" if host.nil?
+
         @host = host
       end
 
@@ -36,7 +38,12 @@ module GitHubPages
       private
 
       def get_caa_records(domain)
-        query(domain).select { |r| r.type == "CAA" && r.property_tag == "issue" }
+        return [] if domain.nil?
+        query(domain).select { |r| issue_caa_record?(r) }
+      end
+
+      def issue_caa_record?(record)
+        record.type == Dnsruby::Types::CAA && record.property_tag == "issue"
       end
 
       def query(domain)
@@ -44,8 +51,8 @@ module GitHubPages
         resolver.retry_times = 2
         resolver.query_timeout = 2
         begin
-          resolver.query(domain, "CAA", "IN").answer
-        rescue StandardError => e
+          resolver.query(domain, Dnsruby::Types::CAA).answer
+        rescue Dnsruby::ResolvError => e
           @error = e
           []
         end

data/lib/github-pages-health-check/domain.rb

@@ -149,9 +149,9 @@ module GitHubPages
         PublicSuffix.domain(host) == host
       end
 
-      # Should the domain be an apex record?
+      # Should the domain use an A record?
       def should_be_a_record?
-        !pages_domain? && (apex_domain? || mx_records_present?)
+        !pages_io_domain? && (apex_domain? || mx_records_present?)
       end
 
       def should_be_cname_record?
@@ -187,6 +187,11 @@ module GitHubPages
       end
 
       # Is the host a *.github.io domain?
+      def pages_io_domain?
+        !!host.match(/\A[\w-]+\.github\.(io)\.?\z/i)
+      end
+
+      # Is the host a *.github.(io|com) domain?
       def pages_domain?
         !!host.match(/\A[\w-]+\.github\.(io|com)\.?\z/i)
       end
@@ -356,7 +361,7 @@ module GitHubPages
       private
 
       def caa
-        @caa ||= GitHubPages::HealthCheck::CAA.new(absolute_domain)
+        @caa ||= GitHubPages::HealthCheck::CAA.new(host)
       end
 
       # The domain's response to HTTP(S) requests, following redirects

data/lib/github-pages-health-check/version.rb

@@ -2,6 +2,6 @@
 
 module GitHubPages
   module HealthCheck
-    VERSION = "1.7.3".freeze
+    VERSION = "1.7.4".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.7.3
+  version: 1.7.4
 platform: ruby
 authors:
 - GitHub, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-25 00:00:00.000000000 Z
+date: 2018-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable