github-pages-health-check 1.5.2 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d3b8567c83bea6d71a00bfa878f77446ddb1a90
-  data.tar.gz: b6b76abc5386ad5ced55b8619a706b6a24e8f53a
+  metadata.gz: 8b652203571fcd28e71238157d64c7861ba3d3e1
+  data.tar.gz: e005dab3f20c5390bc9bbc955d3a5a4d822d0031
 SHA512:
-  metadata.gz: 9055a0a7a3ca91d351005c28a5e4638622c62023ea381f35ccf245e2bd270bb173e2167a1289c0818611b9625a38cbf98a46162889d9a188edfeb3aafab08eb8
-  data.tar.gz: 99fdfc406f256287a3de46c69f15e5459bfd5b45ce9a4af8cf20e09548fd74952283d7151f17413fd561fc3cf017c17eccc378c9696bb22a847a628b14b005d5
+  metadata.gz: b49caaa83fd1d02e3cb8b40673c71fcc127ab68475b9a7235d3a77919740f51abe49c6a6e85cbb61c7aa6e502a04fc4d9b3ac624f9b7372250f250f5f322baf6
+  data.tar.gz: f9c8c763608f4c09ccb5d0e4782f501c606a37ce179b29c231307231803ee4719f3e43b3b112b6c4b2284c09ed416d94bac726917ec32a91c0b56472ab9bdb67

data/lib/github-pages-health-check/caa.rb

@@ -36,16 +36,19 @@ module GitHubPages
       private
 
       def get_caa_records(domain)
+        query(domain).select { |r| r.type == "CAA" && r.property_tag == "issue" }
+      end
+
+      def query(domain)
         resolver = Dnsruby::Resolver.new
         resolver.retry_times = 2
         resolver.query_timeout = 2
-        nspack = begin
-          resolver.query(domain, "CAA", "IN")
+        begin
+          resolver.query(domain, "CAA", "IN").answer
         rescue StandardError => e
           @error = e
-          return []
+          []
         end
-        nspack.answer.select { |r| r.type == "CAA" && r.property_tag == "issue" }
       end
     end
   end

data/lib/github-pages-health-check/domain.rb

@@ -5,6 +5,11 @@ module GitHubPages
     class Domain < Checkable
       attr_reader :host
 
+      GITHUB_DATACENTER_ADDRESSES = %w(
+        192.30.252.153
+        192.30.252.154
+      ).freeze
+
       LEGACY_IP_ADDRESSES = [
         # Legacy GitHub Datacenter
         "207.97.227.245",
@@ -63,12 +68,16 @@ module GitHubPages
         "43.249.72.133",
         "43.249.73.133",
         "43.249.74.133",
-        "43.249.75.133"
+        "43.249.75.133",
+
+        *GITHUB_DATACENTER_ADDRESSES
       ].freeze
 
       CURRENT_IP_ADDRESSES = %w(
-        192.30.252.153
-        192.30.252.154
+        185.199.108.153
+        185.199.109.153
+        185.199.110.153
+        185.199.111.153
       ).freeze
 
       HASH_METHODS = %i[
@@ -330,7 +339,8 @@ module GitHubPages
 
       # Can an HTTPS certificate be issued for this domain?
       def https_eligible?
-        (cname_to_github_user_domain? || fastly_ip?) && caa.lets_encrypt_allowed?
+        (cname_to_github_user_domain? || pointed_to_github_pages_ip?) &&
+          caa.lets_encrypt_allowed?
       end
 
       # Any errors querying CAA records

data/lib/github-pages-health-check/version.rb

@@ -2,6 +2,6 @@
 
 module GitHubPages
   module HealthCheck
-    VERSION = "1.5.2"
+    VERSION = "1.6.0"
   end
 end

data/script/fmt

@@ -0,0 +1,5 @@
+#!/bin/bash
+#/ Usage: script/fmt [args]
+#/ Runs rubocop with the given arguments.
+
+bundle exec rubocop -D -S $@

data/script/test

@@ -3,4 +3,4 @@
 set -e
 
 bundle exec rspec $@
-bundle exec rubocop -D -S $@
+script/fmt $@

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: 1.6.0
 platform: ruby
 authors:
 - GitHub, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-29 00:00:00.000000000 Z
+date: 2018-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -208,6 +208,7 @@ files:
 - script/check-cdn-ips
 - script/cibuild
 - script/console
+- script/fmt
 - script/release
 - script/test
 - script/update-cdn-ips