github-pages-health-check 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad338ea604a8549ea8d86009de6cdd7d8c578eb81d14d2f2ebf96b5fc7791cbe
-  data.tar.gz: 1241ab1285cf8d4e15cc9e56ee701b40241eede4740ce4090deb055c3b460ef0
+  metadata.gz: 0efaa0f152ba42dc46cb2318b8449419caea4b842a9af8a6fb8a9aae21b8bf1f
+  data.tar.gz: 0761afbdb3743f66dd8d5145b530819181326b152959f487dfdb8bc7441c9980
 SHA512:
-  metadata.gz: aff974999ece850cf655e4cd1234806ddc8974c30e3b70eb1c3d8095d716c4be27ba23d343436bf28fd04f6ac3c9da0de676d079e25b0fc6d68b2e848b289c08
-  data.tar.gz: 44d14037c06a29e2be93da02040464894eedb72fa33b704a96dff152d31e438863e10fad54c69877182267e0f53949ee4d64e3e414a3748785c915e14f73cadf
+  metadata.gz: e8f23616476a3645b10082d875aaa7f468860ce689fd8330f788f187f1a06c775727c26ffa613c0ea1be431d41cf2b928ddf8f4c920fd717775f65cfe9f17222
+  data.tar.gz: ce4b1d0a6f096d382b67df7e0228add9f0f2fed378f8190b3d6a446c69bfd4a46af23cc13969b5f38cf6422902605887c2c2076ff40c0255813f0549c56d97e1

data/lib/github-pages-health-check/domain.rb

@@ -80,13 +80,13 @@ module GitHubPages
       ].freeze
 
       HASH_METHODS = %i[
-        host uri dns_resolves? proxied? cloudflare_ip? fastly_ip?
-        old_ip_address? a_record? cname_record? mx_records_present?
-        valid_domain? apex_domain? should_be_a_record?
+        host uri nameservers dns_resolves? proxied? cloudflare_ip?
+        fastly_ip? old_ip_address? a_record? cname_record?
+        mx_records_present? valid_domain? apex_domain? should_be_a_record?
         cname_to_github_user_domain? cname_to_pages_dot_github_dot_com?
         cname_to_fastly? pointed_to_github_pages_ip? pages_domain?
-        served_by_pages? valid? reason valid_domain?
-        https? enforces_https? https_error https_eligible? caa_error
+        served_by_pages? valid? reason valid_domain? https?
+        enforces_https? https_error https_eligible? caa_error
       ].freeze
 
       def self.redundant(host)
@@ -362,7 +362,7 @@ module GitHubPages
       # Can an HTTPS certificate be issued for this domain?
       def https_eligible?
         (cname_to_github_user_domain? || pointed_to_new_primary_ips?) &&
-          caa.lets_encrypt_allowed?
+          !aaaa_record_present? && caa.lets_encrypt_allowed?
       end
 
       # Any errors querying CAA records

data/lib/github-pages-health-check/redundant_check.rb

@@ -27,7 +27,7 @@ module GitHubPages
       private
 
       def checks
-        @checks ||= %i[default authoritative].map do |ns|
+        @checks ||= %i[default authoritative public].map do |ns|
           GitHubPages::HealthCheck::Domain.new(domain, :nameservers => ns)
         end
       end
@@ -35,6 +35,10 @@ module GitHubPages
       def check_with_default_nameservers
         @check_with_default_nameservers ||= checks.find { |c| c.nameservers == :default }
       end
+
+      def check_with_public_nameservers
+        @check_with_public_nameservers ||= checks.find { |c| c.nameservers == :public }
+      end
     end
   end
 end

data/lib/github-pages-health-check/resolver.rb

@@ -8,6 +8,10 @@ module GitHubPages
         :query_timeout => 5,
         :dnssec        => false
       }.freeze
+      PUBLIC_NAMESERVERS = %w(
+        8.8.8.8
+        1.1.1.1
+      ).freeze
 
       class << self
         def default_resolver
@@ -40,6 +44,10 @@ module GitHubPages
                         Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge(
                           :nameservers => authoritative_nameservers
                         ))
+                      when :public
+                        Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge(
+                          :nameservers => PUBLIC_NAMESERVERS
+                        ))
                       when Array
                         Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge(
                           :nameservers => nameservers

data/lib/github-pages-health-check/version.rb

@@ -2,6 +2,6 @@
 
 module GitHubPages
   module HealthCheck
-    VERSION = "1.10.0".freeze
+    VERSION = "1.11.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - GitHub, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-16 00:00:00.000000000 Z
+date: 2018-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable