github-pages-health-check 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f409efbf6ec37c64dfbfe36da471390fe9ea878
-  data.tar.gz: 678295ff98baed01729af19b92d48bd1ddbc3209
+  metadata.gz: aa3d74adf88a4ef1a35fe97bb48a41c4ddf355c1
+  data.tar.gz: 6087da3407bc4f842b86663f115d12aeff5b3e40
 SHA512:
-  metadata.gz: 14f33be101c2b6cc8ad42e827642c05b0c30579e4cb6445dd8bfde8480041cd45873b8cc13ce5e7b00a242e2f0b740b5165fdf3d9cac183f1f1eae6f39e6d0df
-  data.tar.gz: e65246b1a721c6bfe00d446fda2a1eb675b9df92128de07dd75424297e0c4e3507ce0a237c717432e28789f4092a1f5737669b0d3ce6352359f202856cf250ef
+  metadata.gz: 1a9290587e49058b6bf7b162b3bf64c0395255039c38484f02386fcb4d1476ee491d6f1554cc5e09ffce95997ecb3a045c4dd22708afef32b81768210b8c4df8
+  data.tar.gz: e0804bdec43fd0a892d005df9bae2dcdea39e478ff2f26af215f0ed71c14f5f1f622b5e52469303a7952c4c6da5c0640f8538a0c705271faa25814547e97c583

data/lib/github-pages-health-check.rb

@@ -29,7 +29,7 @@ module GitHubPages
     autoload :Printer,    "github-pages-health-check/printer"
 
     # DNS and HTTP timeout, in seconds
-    TIMEOUT = 10
+    TIMEOUT = 5
 
     TYPHOEUS_OPTIONS = {
       :followlocation  => true,

data/lib/github-pages-health-check/domain.rb

@@ -34,7 +34,8 @@ module GitHubPages
 
       # Runs all checks, raises an error if invalid
       def check!
-        raise Errors::InvalidDNSError unless dns_resolves?
+        raise Errors::InvalidDomainError unless valid_domain?
+        raise Errors::InvalidDNSError    unless dns_resolves?
         return true if proxied?
         raise Errors::DeprecatedIPError      if deprecated_ip?
         raise Errors::InvalidARecordError    if invalid_a_record?
@@ -45,7 +46,7 @@ module GitHubPages
 
       def deprecated_ip?
         return @deprecated_ip if defined? @deprecated_ip
-        @deprecated_ip = (a_record? && old_ip_address?)
+        @deprecated_ip = (valid_domain? && a_record? && old_ip_address?)
       end
 
       def invalid_a_record?
@@ -73,10 +74,16 @@ module GitHubPages
       # Is this domain an apex domain, meaning a CNAME would be innapropriate
       def apex_domain?
         return @apex_domain if defined?(@apex_domain)
-
-        answers = Resolv::DNS.open { |dns|
-          dns.getresources(absolute_domain, Resolv::DNS::Resource::IN::NS)
-        }
+        return unless valid_domain?
+
+          answers = begin
+            Resolv::DNS.open { |dns|
+              dns.timeouts = TIMEOUT
+              dns.getresources(absolute_domain, Resolv::DNS::Resource::IN::NS)
+            }
+          rescue Timeout::Error, NoMethodError
+            []
+          end
 
         @apex_domain = answers.any?
       end
@@ -154,6 +161,7 @@ module GitHubPages
       # Returns an array of DNS answers
       def dns
         return @dns if defined? @dns
+        return unless valid_domain?
         @dns = Timeout.timeout(TIMEOUT) do
           GitHubPages::HealthCheck.without_warnings do
             Net::DNS::Resolver.start(absolute_domain).answer unless host.nil?
@@ -198,6 +206,7 @@ module GitHubPages
 
       def served_by_pages?
         return @served_by_pages if defined? @served_by_pages
+        return unless dns_resolves?
 
         @served_by_pages = begin
           response = Typhoeus.head(uri, TYPHOEUS_OPTIONS)

data/lib/github-pages-health-check/version.rb

@@ -1,5 +1,5 @@
 module GitHubPages
   module HealthCheck
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: github-pages-health-check
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - GitHub, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-17 00:00:00.000000000 Z
+date: 2016-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-dns
@@ -212,7 +212,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.1
 signing_key: 
 specification_version: 4
 summary: Checks your GitHub Pages site for commons DNS configuration issues