github-ldap 1.0.10 → 1.0.11

data/github-ldap.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "github-ldap"
-  spec.version       = "1.0.10"
+  spec.version       = "1.0.11"
   spec.authors       = ["David Calavera"]
   spec.email         = ["david.calavera@gmail.com"]
   spec.description   = %q{Ldap authentication for humans}

data/lib/github/ldap/domain.rb

@@ -73,7 +73,10 @@ module GitHub
       # Returns the user if the login matches any `uid`.
       # Returns nil if there are no matches.
       def user?(login)
-        rs = search(limit: 1, filter: Net::LDAP::Filter.eq(@uid, login))
+        rs = search(
+          filter: Net::LDAP::Filter.eq(@uid, login),
+          attributes: [],
+          limit: 1)
         rs and rs.first
       end
 

data/test/domain_test.rb

@@ -109,6 +109,10 @@ class GitHubLdapDomainTest < Minitest::Test
     assert !@domain.user?('foobar'), 'Expected uid `foobar` to not exist.'
   end
 
+  def test_user_returns_every_attribute
+    assert_equal ['calavera@github.com'], @domain.user?('calavera')[:mail]
+  end
+
   def test_auth_binds
     user = @domain.user?('calavera')
     assert @domain.auth(user, 'secret'), 'Expected user to be bound.'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github-ldap
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
   prerelease: 
 platform: ruby
 authors: