github-ds 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1aaf710b392b3606a470e855ffc6df96bb8d02d
-  data.tar.gz: a0ccd759cda221b0749c2868e3b55f03aa800589
+  metadata.gz: e3dda4d4ed9f093a4e3d098f5701f804bde5fc55
+  data.tar.gz: ee1f88f94fcd6986913b9c4ee1dc85269b8bb108
 SHA512:
-  metadata.gz: 6b557340535961e3e89fe98a4f5cb84cad5b66d44accff0bec41398677d6d0f9e40df761da62360aae7083ce4a4df4c31be38750767d404eeb6f208b25af5312
-  data.tar.gz: 0fa602a4a8de432e7db165aacef4207e81daa4e03c8c0907aa7a48278f0aa5ae03ebc0dbf9949008bd62dc512151285e8a96bce293571bad4b0184fddfa7ba3b
+  metadata.gz: dcff9123a791a1ca4e81f2db9faef112331712070cf5920465c4bcd46c42eabc36b48626f80eeff886dd8791e98e0d6611be9b94b7f20ff179b17fe585ee2f9d
+  data.tar.gz: a30eed58460e4f4e9430f12fe41f6ab1537eb1f3b07a33d990606cb62b8e19dedd079ac210da68105ff8f30dec56b91e2f5ebd9213606882dcf6b32e31067014

data/.gitignore

@@ -8,3 +8,4 @@
 /spec/reports/
 /tmp/
 /test/tmp/
+/db/

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.2.1
+
+Additions
+
+* `Result.new` without block returns `true` for `ok?` https://github.com/github/github-ds/pull/19
+
 ## 0.2.0
 
 Fixes

data/examples/example_setup.rb

@@ -10,16 +10,29 @@ attempts = 0
 begin
   ActiveRecord::Base.establish_connection({
     adapter: "mysql2",
+    username: "root",
     database: "github_ds_test",
   })
   ActiveRecord::Base.connection.execute("DROP TABLE IF EXISTS `key_values`")
-  require "generators/github/ds/templates/migration"
+
+  # remove db tree if present so we can start fresh
+  db_path = root_path.join("db")
+  db_path.rmtree if db_path.exist?
+
+  # use generator to create the migration
+  require "rails/generators"
+  require "generators/github/ds/active_record_generator"
+  Rails::Generators.invoke "github:ds:active_record"
+
+  # require migration and run it so we have the key values table
+  require db_path.join("migrate").children.first.to_s
   ActiveRecord::Migration.verbose = false
   CreateKeyValuesTable.up
 rescue
   raise if attempts >= 1
   ActiveRecord::Base.establish_connection({
     adapter: "mysql2",
+    username: "root",
   })
   ActiveRecord::Base.connection.execute("CREATE DATABASE `github_ds_test`")
   attempts += 1

data/examples/sql_with_connection.rb

@@ -7,6 +7,7 @@ class SomeModel < ActiveRecord::Base
   establish_connection({
     adapter: "mysql2",
     database: "github_ds_test",
+    username: "root",
   })
 end
 

data/lib/generators/github/ds/active_record_generator.rb

@@ -1,5 +1,5 @@
 require "rails/generators/active_record"
-
+require "rails/version"
 module Github
   module Ds
     module Generators
@@ -10,12 +10,22 @@ module Github
         source_paths << File.join(File.dirname(__FILE__), "templates")
 
         def create_migration_file
-          migration_template "migration.rb", "db/migrate/create_key_values_table.rb"
+          migration_template "migration.rb", "db/migrate/create_key_values_table.rb", migration_version: migration_version
         end
 
         def self.next_migration_number(dirname)
           ::ActiveRecord::Generators::Base.next_migration_number(dirname)
         end
+
+        def self.migration_version
+          if Rails.version.start_with?('5')
+            "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+          end
+        end
+
+        def migration_version
+          self.class.migration_version
+        end
       end
     end
   end

data/lib/generators/github/ds/templates/migration.rb

@@ -1,4 +1,4 @@
-class CreateKeyValuesTable < ActiveRecord::Migration
+class CreateKeyValuesTable < ActiveRecord::Migration<%= migration_version %>
   def self.up
     create_table :key_values do |t|
       t.string :key, :null => false

data/lib/github/ds/version.rb

@@ -1,5 +1,5 @@
 module GitHub
   module DS
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/lib/github/result.rb

@@ -15,7 +15,7 @@ module GitHub
     #
     def initialize
       begin
-        @value = yield
+        @value = yield if block_given?
         @error = nil
       rescue => e
         @error = e

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github-ds
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-22 00:00:00.000000000 Z
+date: 2017-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord