gitarro 0.1.52 → 0.1.53

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9394fd417107857cfbf9e58db40b1478605986aa
-  data.tar.gz: d939f4b1b3210fa0693a1fc7b5365cbb710b0f60
+  metadata.gz: ed7728ce69392b49eb64ed39ead778e1c57c1ff0
+  data.tar.gz: 238ca7702d9a0253f578240a17f225c3abc8c1d4
 SHA512:
-  metadata.gz: 62e98475342aee2a999c3d7b1b831f56f6bcbc947897f23740e6b6c8e4c7325335372fa4d13a9c9e05b0ade36c7bb208e8d7eddf0af97ff929e9c060745ccc39
-  data.tar.gz: 9a395dd70ecc830c6febfdbae0f65baf4e2d68714315d380d3cdeaa929830119dc9edd87d01c3b078e1c4f61b462678a3685bff00c5f74197ae4e8040059ade3
+  metadata.gz: 762011a475cc4c1dd77b788cce6d3f0fa6a491be52f7c723ad842689d2cb88121a9b6e128d9d8677bbe35fc76cb1956cb2b73c90b6349d8a2f4c43fb17aba68a
+  data.tar.gz: 2c2d61721b17aa0e1f381e45a441c298d463ca3bb3899fb61c143b2c60196ad698be3a0e6a7b0d8d9b2933dca97558b496ecaa79078b211e198f69b544ace585

data/bin/gitarro

@@ -19,8 +19,6 @@ prs.each do |pr|
   break if b.triggered_by_pr_number?(pr)
   # retrigger if magic word found
   b.retrigger_check(pr)
-  # check if changelog test was enabled
-  break if b.changelog_active?(pr, comm_st)
   # 0) do test for unreviewed pr
   break if b.unreviewed_new_pr?(pr, comm_st)
   # we run the test in 2 conditions:

data/lib/gitarro/backend.rb

@@ -97,40 +97,12 @@ module CachingOctokit
     Octokit.middleware = stack
   end
 
-  # by default is false, enable only via option
+  # if true we dont need the cache
   def generate_cache?
     @cachehttp
   end
 end
 
-# this module have helper methods for changelog tests
-# it will be removed soon, but it helps to extract all
-# changelog code from backend class
-module ChangelogTests
-  def magic_comment?(pr_num)
-    @client.issue_comments(@repo, pr_num).any? do |com|
-      com.body.include?('no changelog needed!')
-    end
-  end
-
-  def do_changelog_test(pr)
-    # if the pr contains changes on .changes file, test ok
-    test_status = 'failure'
-    test_status = 'success' if pr_all_files_type(pr.number, @file_type).any?
-    test_status = 'success' if magic_comment?(pr.number)
-    create_status(pr, test_status)
-    test_status
-  end
-
-  # do the changelog test and set status
-  def changelog_changed?(pr, comm_st)
-    return false unless @changelog_test
-    # only execute 1 time, don"t run if test is failed, or ok
-    return false if failed_status?(comm_st) || success_status?(comm_st)
-    do_changelog_test(pr)
-  end
-end
-
 # This is a private class, which has the task to execute/run tests
 # called by Backend
 class TestExecutor
@@ -169,6 +141,7 @@ class TestExecutor
     ENV['GITARRO_PR_AUTHOR'] = pr.head.user.login.to_s
     ENV['GITARRO_PR_TITLE'] = pr.title.to_s
     ENV['GITARRO_PR_NUMBER'] = pr.number.to_s
+    ENV['GITARRO_PR_TARGET_REPO'] = @repo
   end
 
   def script_exists?(script)
@@ -181,10 +154,7 @@ end
 # were we execute the tests and so on
 class Backend
   attr_accessor :options, :client, :gbexec
-  # changelog tests module ( FIXME  remove this once changelog
-  # tests are gone from backend and run separately
   include CachingOctokit
-  include ChangelogTests
   include GitHubPrOperations
 
   # public method of backend
@@ -229,14 +199,6 @@ class Backend
     launch_test_and_setup_status(pr)
   end
 
-  # FIXME: remove this pub. method once changelog test are separated
-  # public method, trigger changelogtest if option active
-  def changelog_active?(pr, comm_st)
-    return false unless @changelog_test
-    return false unless changelog_changed?(pr, comm_st)
-    true
-  end
-
   def unreviewed_new_pr?(pr, comm_st)
     return unless commit_is_unreviewed?(comm_st)
     pr_all_files_type(pr.number, @file_type)
@@ -253,7 +215,6 @@ class Backend
     #  we dont run the tests
     return false unless context_present?(comm_st) == false ||
                         pending_pr?(comm_st)
-    return true if changelog_active?(pr, comm_st)
     return false unless pr_all_files_type(pr.number, @file_type).any?
     print_test_required
     exit(0) if @check
@@ -340,11 +301,6 @@ class Backend
   def retrigger_needed?(pr)
     # we want redo sometimes tests
     return false unless retriggered_by_comment?(pr.number, @context)
-    # changelog trigger
-    if @changelog_test
-      do_changelog_test(pr)
-      return false
-    end
     # if check is set, the comment in the trigger job will be del.
     # so setting it to pending, it will be remembered
     pr_all_files_type(pr.number, @file_type).any?

data/lib/gitarro/opt_parser.rb

@@ -81,14 +81,6 @@ module OptionalOptions
     end
   end
 
-  def changelog_opt(opt)
-    desc = 'Check if the PR includes a changelog entry ' \
-           '(Automatically sets --file ".changes").'
-    opt.on('--changelogtest', desc) do |changelogtest|
-      @options[:changelog_test] = changelogtest
-    end
-  end
-
   def pr_number(opt)
     desc = 'Specify the PR number instead of checking all of them. ' \
            'Force to rerun against a specific PR number,' \
@@ -112,7 +104,6 @@ module OptionalOptions
     desc_opt(opt)
     check_opt(opt)
     file_opt(opt)
-    changelog_opt(opt)
     url_opt(opt)
     pr_number(opt)
     https_opt(opt)
@@ -178,7 +169,6 @@ class OptParserInternal
   # set some default values
   def defaults_false
     @options[:check] = false if @options[:check].nil?
-    @options[:changelog_test] = false if @options[:changelog_test].nil?
     @options[:target_url] = '' if @options[:target_url].nil?
     @options[:https] = false if @options[:https].nil?
     @options[:changed_since] = -1 if @options[:changed_since].nil?
@@ -187,7 +177,6 @@ class OptParserInternal
 
   def defaults_to_text
     desc = 'use option -d to set a custom test description.'
-    @options[:file_type] = '.changes' if @options[:changelog_test]
     @options[:description] = desc if @options[:description].nil?
     @options[:file_type] = 'notype' if @options[:file_type].nil?
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitarro
 version: !ruby/object:Gem::Version
-  version: 0.1.52
+  version: 0.1.53
 platform: ruby
 authors:
 - Dario Maiocchi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-14 00:00:00.000000000 Z
+date: 2017-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: english
@@ -25,131 +25,131 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: netrc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.9'
+        version: '0.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.9'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: minitest-reporters
+  name: octokit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '4.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '4.7'
 - !ruby/object:Gem::Dependency
-  name: netrc
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
-  name: octokit
+  name: faraday-http-cache
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.5'
-  type: :runtime
+        version: '5.9'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.5'
+        version: '5.9'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
-  type: :runtime
+        version: '1.1'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
-  type: :runtime
+        version: '10.5'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '10.5'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
-  type: :runtime
+        version: '0.49'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '0.49'
 - !ruby/object:Gem::Dependency
-  name: faraday-http-cache
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :runtime
+        version: '3.6'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.6'
 description: gitarro run tests on GitHub PRs using almost any script,language or binary,
   it integrate easy with other tools.
 email: dmaiocchi@suse.com