gitarro 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ccdb6d7e8c2822e5d5d3fe1927b230682c66c23e
-  data.tar.gz: 6420d8c9820c8304af0360ad33735e48fb720b38
+  metadata.gz: e97e8143aeaa4f46f345b4f4b8bdd0f6f96ff678
+  data.tar.gz: cfefb556f4e12c71ed59c0bb4ae5348413aac8c2
 SHA512:
-  metadata.gz: 202efc92cb0f803c0ad60864778bc29a37a3172c61ab5311eafcf6a1ab6a95dab1bea7b086895d2d5a4b1e567ab34441fb686810b6d438d6ba914f33caefd89f
-  data.tar.gz: 96096a7ac449182c9c7cafa55d770b81f76c3c77516f1d26ebd3448c79a2523f8e078755d70db98384e13995c248e55ba9f152ef619bb58f6bf1999562e941ad
+  metadata.gz: 900c16bda6d9c65c8bb7098a984546a8cd699747152edab67bb893e94f283c242d257b7248a8094e583d94a4dfe249023fa8f06f0c9ea5abbb692407cf33f03b
+  data.tar.gz: f04932ba29a8c41bc177c6405cc71b6b311deee27306bbb376d6fd0ee8d04d72da5be4d86a127e8aa6299cae8c7122ff9ed7b6f99a4227856d32968265355688

data/lib/gitarro/backend.rb

@@ -9,6 +9,70 @@ require_relative 'opt_parser'
 require_relative 'git_op'
 require 'active_support'
 
+# this module perform basic operations
+# on prs and contain helper functions
+# that use octokit client for retrieving info
+# about the PR or commit
+module GitHubPrOperations
+  # check if the commit of a pr is on pending
+  def pending_pr?(comm_st)
+    # 2) pending
+    (0..comm_st.statuses.size - 1).any? do |pr_status|
+      comm_st.statuses[pr_status]['context'] == @context &&
+        comm_st.statuses[pr_status]['state'] == 'pending'
+    end
+  end
+
+  # check it the cm of pr contain the context from gitarro already
+  def context_present?(cm_st)
+    # 1) context_present == false  triggers test. >
+    # this means  the PR is not with context tagged
+    (0..cm_st.statuses.size - 1).any? do |pr_status|
+      cm_st.statuses[pr_status]['context'] == @context
+    end
+  end
+
+  # if the pr has travis test and one custom, we will have 2 elements.
+  # in this case, if the 1st element doesn't have the state property
+  # state property is "pending", failure etc.
+  # if we don't have this, so we have 0 status
+  # the PRs is "unreviewed"
+  def commit_is_unreviewed?(comm_st)
+    puts comm_st.statuses[0]['state']
+    return false
+  rescue NoMethodError
+    return true
+  end
+
+  def success_status?(comm_st)
+    (0..comm_st.statuses.size - 1).any? do |pr_status|
+      comm_st.statuses[pr_status]['context'] == @context &&
+        comm_st.statuses[pr_status]['state'] == 'success'
+    end
+  end
+
+  def failed_status?(comm_st)
+    (0..comm_st.statuses.size - 1).any? do |pr_status|
+      comm_st.statuses[pr_status]['context'] == @context &&
+        comm_st.statuses[pr_status]['state'] == 'failure'
+    end
+  end
+
+  # Create a status for a PR
+  def create_status(pr, status)
+    client.create_status(@repo, pr.head.sha, status, context: @context,
+                                                     description: @description,
+                                                     target_url: @target_url)
+  end
+
+  # Return true if the PR was updated in less than the value of variable sec
+  # or if sec < 0 (the check was disabled)
+  # GitHub considers a PR updated when there is a new commit or a new comment
+  def pr_last_update_less_than(pr, sec)
+    Time.now.utc - pr.updated_at < sec || sec < 0 ? true : false
+  end
+end
+
 # by default enabled (faraday_cache in memory, will be deleted
 # after gitarro run 2nd time. usefull for -C check option
 # and performance, since we cache)
@@ -100,7 +164,7 @@ class TestExecutor
   end
 end
 
-# this the public class is the backend of gitarro,
+# this the main public class is the backend of gitarro,
 # were we execute the tests and so on
 class Backend
   attr_accessor :options, :client, :gbexec
@@ -108,6 +172,8 @@ class Backend
   # tests are gone from backend and run separately
   include CachingOctokit
   include ChangelogTests
+  include GitHubPrOperations
+
   # public method of backend
   def initialize(option = nil)
     @options = option.nil? ? OptParser.new.cmdline_options : option
@@ -161,7 +227,7 @@ class Backend
   def unreviewed_new_pr?(pr, comm_st)
     return unless commit_is_unreviewed?(comm_st)
     pr_all_files_type(pr.number, @file_type)
-    return if empty_files_changed_by_pr(pr)
+    return if empty_files_changed_by_pr?(pr)
     # gb.check is true when there is a job running as scheduler
     # which doesn't execute the test but trigger another job
     print_test_required
@@ -216,20 +282,6 @@ class Backend
     puts '[TESTREQUIRED=true] PR requires test'
   end
 
-  # Create a status for a PR
-  def create_status(pr, status)
-    client.create_status(@repo, pr.head.sha, status, context: @context,
-                                                     description: @description,
-                                                     target_url: @target_url)
-  end
-
-  # Return true if the PR was updated in less than the value of variable sec
-  # or if sec < 0 (the check was disabled)
-  # GitHub considers a PR updated when there is a new commit or a new comment
-  def pr_last_update_less_than(pr, sec)
-    Time.now.utc - pr.updated_at < sec || sec < 0 ? true : false
-  end
-
   # this function setup first pending to PR, then execute the tests
   # then set the status according to the results of script executed.
   # pr_head = is the PR branch
@@ -266,56 +318,10 @@ class Backend
     ff
   end
 
-  # check if the commit of a pr is on pending
-  def pending_pr?(comm_st)
-    # 2) pending
-    (0..comm_st.statuses.size - 1).any? do |pr_status|
-      comm_st.statuses[pr_status]['context'] == @context &&
-        comm_st.statuses[pr_status]['state'] == 'pending'
-    end
-  end
-
-  # check it the cm of pr contain the context from gitarro already
-  def context_present?(cm_st)
-    # 1) context_present == false  triggers test. >
-    # this means  the PR is not with context tagged
-    (0..cm_st.statuses.size - 1).any? do |pr_status|
-      cm_st.statuses[pr_status]['context'] == @context
-    end
-  end
-
-  # if the pr has travis test and one custom, we will have 2 elements.
-  # in this case, if the 1st element doesn't have the state property
-  # state property is "pending", failure etc.
-  # if we don't have this, so we have 0 status
-  # the PRs is "unreviewed"
-  def commit_is_unreviewed?(comm_st)
-    puts comm_st.statuses[0]['state']
-    return false
-  rescue NoMethodError
-    return true
-  end
-
-  def success_status?(comm_st)
-    (0..comm_st.statuses.size - 1).any? do |pr_status|
-      comm_st.statuses[pr_status]['context'] == @context &&
-        comm_st.statuses[pr_status]['state'] == 'success'
-    end
-  end
-
-  def failed_status?(comm_st)
-    (0..comm_st.statuses.size - 1).any? do |pr_status|
-      comm_st.statuses[pr_status]['context'] == @context &&
-        comm_st.statuses[pr_status]['state'] == 'failure'
-    end
-  end
-
   # control if the pr change add any files, specified
   # it can be also a dir
-  def empty_files_changed_by_pr(pr)
-    return if pr_all_files_type(pr.number, @file_type).any?
-    puts "no files of type #{@file_type} found! skipping"
-    true
+  def empty_files_changed_by_pr?(pr)
+    pr_all_files_type(pr.number, @file_type).any?
   end
 
   def retrigger_needed?(pr)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitarro
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Dario Maiocchi