git-review 0.5.0 → 0.5.1

data/lib/git-review.rb

@@ -17,7 +17,7 @@ class GitReview
     puts '   list [--reverse]          List all open requests.'
     puts '   show <number> [--full]    Show details of a single request.'
     puts '   browse <number>           Open a browser window and review a specified request.'
-    # puts '   checkout <number>         Checkout a specified request\'s changes to your local repository.'
+    puts '   checkout <number>         Checkout a specified request\'s changes to your local repository.'
     puts '   accept <number>           Accept a specified request by merging it into master.'
     puts '   decline <number>          Decline and close a specified request.'
     puts '   create                    Create a new request.'
@@ -25,27 +25,22 @@ class GitReview
 
   # List all open requests.
   def list
-    puts "Open requests for '#{source_repo}/#{source_branch}'"
-    option = @args.shift
     open_requests = get_pull_info
-    open_requests.reverse! if option == '--reverse'
-    # TODO: Refactor to get rid of unnecessary variables and computation.
-    count = 0
+    if open_requests.size == 0
+      puts "No open requests for '#{source_repo}/#{source_branch}'"
+      return
+    end
+    puts "Open requests for '#{source_repo}/#{source_branch}'"
     puts 'ID     Date       Comments   Title'
+    open_requests.reverse! if @args.shift == '--reverse'
     open_requests.each do |pull|
+      next unless not_merged?(pull['head']['sha'])
       line = []
       line << format_text(pull['number'], 6)
       line << format_text(Date.parse(pull['created_at']).strftime('%d-%b-%y'), 10)
       line << format_text(pull['comments'], 10)
       line << format_text(pull['title'], 94)
-      sha = pull['head']['sha']
-      if not_merged?(sha)
-        puts line.join ' '
-        count += 1
-      end
-    end
-    if count == 0
-      puts ' -- No open requests. --'
+      puts line.join ' '
     end
   end
 
@@ -80,9 +75,9 @@ class GitReview
   end
 
   # Checkout a specified request's changes to your local repository.
-  # TODO: Implement this.
   def checkout
-    puts 'Under construction... ;-)'
+    return unless review_exists?
+    git "co origin/#{@review['head']['ref']}"
   end
 
   # Accept a specified request by merging it into master.

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: git-review
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 0
   - 5
-  - 0
-  version: 0.5.0
+  - 1
+  version: 0.5.1
 platform: ruby
 authors: 
 - Dominik Bamberger, Cristian Messel