git-lint 11.0.0 → 11.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '09bc2331e668a1ed5e6851a60926668d1d392f4addd54a49ffed7fba63d78fcd'
-  data.tar.gz: b5937a91c8e8e100e054ef5209f5eb594c8facbca2fbd974acf637f3a147527d
+  metadata.gz: 1a398440d3a796edbf3a4b4d1e93feb848e5ce64b5e7ba5cfdc88125232467f5
+  data.tar.gz: 1ffb61ebc1605e237c633325b11421c508e06419e0c93ffa89a7820592177f39
 SHA512:
-  metadata.gz: 6219f9cd5dad3b933a99ce75873c2f9bc8142f5cbf03c6886d2351b29fb1575396b2f4ddc0aff045b0cad546fe14419bd34d90dc1b6262a978d9991523e42a2c
-  data.tar.gz: a98ad6176494113b9eec2cde32f24412f6e4c361e240afed7260c90cc8e50f384f3d3a23a85f49e430566392d26e619d25fc066b5420f893257bd1642d88f009
+  metadata.gz: 4bc2132df51e741c9c4b6486d66dc15e3e6939404d0131af907f3c7a4300bed0f649e9afe7ef0a3d38f4576736c0eb74ab2d166340ff9a652f4e6ea3a084fb5e
+  data.tar.gz: 6971baf71e978c16005c37b02bc7ff3550e5177b4b630919ae3df7938775d8e5c518ff1107f1aa3c49def405cae42d043a1c150ce886d8585beb9ca568096613

checksums.yaml.gz.sig

@@ -1,3 +1,4 @@
-X�1{I���r��&ο�me�ok�_�ʬig8�ٯ��R�ű��ߩ���H��2�#Los�\��`��������;Ѧ�����%��$���*2x�qψud���2�:	�:}y���ɷY�%�%�|�N;}P����4$�ZS]e#	��~�a�p��Q�z��lM&[_rEva���E�b�����s�lT�,!��;��.�kB�{��v�郁Q>3��p�:@��Ie�������Ȁ�#}�	SL���c���<��lH��N��w��,i�D^A���Ŏ�o�ص_L��1
-�
-��p5�'��v�n1ٿd5���4^t�^'h_}���3F����Y�w� �2O~!&H���Y��	'v��N��q�e��~�1L�
+,X��qB�c�d��U<��ZT*�q]y�d�j�O(� y.{X�p�����}%ϒ��v\(Љ�k9�_�nN�36
ltY���bdءX��Q�
���GN���
+���7���Sض�\eA���"֒�Q�E��;k��ܚ�����
���:�7���kN�����H�6~��?F
+B�+��8]k���V(vLbag�[�>�IP&�SR�8�d��P&��û���Q��P��u
+�N�e��%�@˫��x���Q�E���iJ�0��Mx��ń.y[��pe���W���O�W88�X�,��o���8�0�Į4�Wrۅ�\!�2J��
��������[U��4�O����"]����@މi}���x>���yeek�Ϟ�@�W�[

data/README.adoc

@@ -590,7 +590,7 @@ and provides the missing spec to ensure this doesn't happen again.
 Ensures a minimum number of lines are present within the commit body. Lines with empty characters
 (i.e. whitespace, carriage returns, etc.) are considered to be empty.
 
-Automatically ignores _fixup!_ commits as they are not meant to have bodies.
+Automatically ignores _fixup!_ directives because they are not meant to have bodies.
 
 ==== Commit Body Tracker Shorthand
 
@@ -675,7 +675,7 @@ Added documentation
 Added documentation
 ....
 
-Automatically ignores _amend!_, _fixup!_, or _squash!_ commit prefixes.
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
 
 ==== Commit Subject Length
 
@@ -690,7 +690,7 @@ lenient than the link:http://tbaggery.com/2008/04/19/a-note-about-git-commit-mes
 rule] as it gives one the ability to formulate a more descriptive subject line without being too
 wordy or suffer being word wrapped.
 
-Automatically ignores _fixup!_ or _squash!_ commit prefixes when calculating subject length.
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
 
 ==== Commit Subject Prefix
 
@@ -737,8 +737,7 @@ Each prefix is delimited by a space which is the default setting but can be cust
 Whatever you choose for a delimiter will not affect Git's special bang prefixes as described in the
 tip below.
 
-💡 This analyzer automatically ignores _amend!_, _fixup!_, or _squash!_ commit prefixes when used as
-a Git Hook in order to not disturb interactive rebase workflows.
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
 
 ==== Commit Subject Suffix
 
@@ -960,6 +959,8 @@ Milestone: patch
 
 This key is mandatory by default which means the key must always be present unless the repository is unpublished (i.e. has no origin). When the repository is unpublished, this gives you the freedom to release your initial version (i.e. 0.0.0) without this trailer. Once published, you'll need the trailer. To make the key optional, set mandatory to `false`.
 
+Automatically ignores _amend!_, _fixup!_, and _squash!_ directives.
+
 ==== Commit Trailer Milestone Value
 
 [options="header"]

data/git-lint.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name = "git-lint"
-  spec.version = "11.0.0"
+  spec.version = "11.0.1"
   spec.authors = ["Brooke Kuhlmann"]
   spec.email = ["brooke@alchemists.io"]
   spec.homepage = "https://alchemists.io/projects/git-lint"

data/lib/git/lint/analyzers/commit_trailer_milestone_key.rb

@@ -7,9 +7,7 @@ module Git
       class CommitTrailerMilestoneKey < Abstract
         include Dependencies[:git, setting: "trailers.milestone"]
 
-        def valid?
-          optional? && affected_commit_trailers.empty?
-        end
+        def valid? = !mandatory? && affected_commit_trailers.empty?
 
         def issue
           return {} if valid?
@@ -32,13 +30,13 @@ module Git
 
         private
 
-        def optional?
-          return true unless mandatory?
+        def mandatory?
+          return false if commit.directive?
 
-          commit.trailers.any? { it.key == setting.name }
-        end
+          missing = commit.trailers.none? { it.key == setting.name }
 
-        def mandatory? = settings.commits_trailer_milestone_key_mandatory && git.origin?
+          settings.commits_trailer_milestone_key_mandatory && git.origin? && missing
+        end
 
         def hint_prefix
           settings.commits_trailer_milestone_key_mandatory ? "Use (manditory)" : "Use"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-lint
 version: !ruby/object:Gem::Version
-  version: 11.0.0
+  version: 11.0.1
 platform: ruby
 authors:
 - Brooke Kuhlmann