git-fastclone 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b86bd9aa9bc5a377dd7d5b7b456eb0de1aee7ffd1e746642775d08042e9714f
-  data.tar.gz: '08dff02e06757c022c7ee0fec4890261c3d3efbee76130f2c7f4e0c2cdd91361'
+  metadata.gz: 62066971856b4d6e34def960d0ec1214082d546f94a5ffe58b048eb5715511f0
+  data.tar.gz: d04c4ac8c866a011b3b6b279b3a9f2e719c6d284314086f91f4c73b189443f50
 SHA512:
-  metadata.gz: ce36dfc95ed1d5621fc32df5721d1b796e1cdbb58c11952351dd124bf14a784bef8624e23bde74be3a3c848fff320201639b0e7737be44c8860860a0fb99a019
-  data.tar.gz: 77a296e5b3c6ea817fef4c0ca6df39c4f33e8f35626fd896d4f41ff9c201bf8de15c57a0543e7a8aac4cf63f7de352a00b01844c964657fb20192abbce3790a4
+  metadata.gz: d807b912fd16fc82e3ce6ea2a3d568f37d1a946efdb750e7279baafa2a0c8206b2b6b298165321a0dd6306a975aacc873f0863c7ff18259b0b0126dd3c83f299
+  data.tar.gz: 0dde85446cad33944b3e1e61327b4656c435312fd6ef169b2b82fc4506d6e6bcedebdb0c808b5bdb52e7b0249472c2f033fa86647cadb6626dbcc953efaa6645

data/lib/git-fastclone/version.rb

@@ -2,5 +2,5 @@
 
 # Version string for git-fastclone
 module GitFastCloneVersion
-  VERSION = '1.5.0'
+  VERSION = '1.5.1'
 end

data/lib/git-fastclone.rb

@@ -162,14 +162,15 @@ module GitFastClone
           options[:config] = config
         end
 
-        opts.on('--lock-timeout N', 'Timeout in seconds to acquire a lock on any reference repo.
-                Default is 0 which waits indefinitely.') do |timeout_secs|
+        opts.on('--lock-timeout N', 'Timeout in seconds to acquire a lock on any reference repo.',
+                'Default is 0 which waits indefinitely.') do |timeout_secs|
           self.flock_timeout_secs = timeout_secs.to_i
         end
 
-        opts.on('--pre-clone-hook command',
-                'An optional command that should be invoked before cloning mirror repo') do |command|
-          options[:pre_clone_hook] = command
+        opts.on('--pre-clone-hook script_file',
+                'An optional file that should be invoked before cloning mirror repo',
+                'No-op when a file is missing') do |script_file|
+          options[:pre_clone_hook] = script_file
         end
       end.parse!
     end
@@ -452,7 +453,13 @@ module GitFastClone
     private def trigger_pre_clone_hook_if_needed(url, mirror, attempt_number)
       return if Dir.exist?(mirror) || !options.include?(:pre_clone_hook)
 
-      popen2e_wrapper(options[:pre_clone_hook], url.to_s, mirror.to_s, attempt_number.to_s, quiet: !verbose)
+      hook_command = options[:pre_clone_hook]
+      unless File.exist?(File.expand_path(hook_command))
+        puts 'pre_clone_hook script is missing' if verbose
+        return
+      end
+
+      popen2e_wrapper(hook_command, url.to_s, mirror.to_s, attempt_number.to_s, quiet: !verbose)
     end
   end
 end

data/spec/git_fastclone_runner_spec.rb

@@ -146,11 +146,13 @@ describe GitFastClone::Runner do
       end
     end
 
-    context 'with pre-clone-hook errors' do
+    context 'with pre-clone-hook' do
       let(:pre_clone_hook) { '/some/command' }
       before(:each) do
         subject.options[:pre_clone_hook] = pre_clone_hook
         subject.reference_dir = placeholder_arg
+        allow(File).to receive(:exist?).and_call_original
+        allow(File).to receive(:exist?).with(pre_clone_hook).and_return(true)
         allow(subject).to receive(:with_git_mirror).and_call_original
         allow(subject).to receive(:with_reference_repo_lock) do |_url, &block|
           block.call
@@ -192,6 +194,22 @@ describe GitFastClone::Runner do
 
         subject.clone(placeholder_arg, nil, '.', 'config')
       end
+
+      context 'non-existing script' do
+        before(:each) do
+          allow(File).to receive(:exist?).with(pre_clone_hook).and_return(false)
+        end
+
+        it 'does not invoke hook command' do
+          allow(subject).to receive(:fail_on_error)
+          expect(subject).not_to receive(:popen2e_wrapper).with(
+            pre_clone_hook, 'PH', 'PH/PH', '0',
+            { quiet: true }
+          )
+
+          subject.clone(placeholder_arg, nil, '.', 'config')
+        end
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-fastclone
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Michael Tauraso
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-23 00:00:00.000000000 Z
+date: 2024-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize