girlscout 0.3.3 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f51e5197d44b448205a29b9c253290619142581c
-  data.tar.gz: 2a27f4873b5c1b9348375c244bfef7e923cff04a
+SHA256:
+  metadata.gz: de5ee14889bf953e416b87030e72390494e1d054d3741bda1583cdafdb233577
+  data.tar.gz: 7b462a2aedf9b630ceee7c602e42fa81015218b005afc3242f2c85b22e30a48d
 SHA512:
-  metadata.gz: 542365f59c405828a792cd50832735ed98cebdd82b77ccdfd4e5ad99b4a0a39f1441e6d72f0f282f3c8a37aa58a8741b556b31f7fe244d8f3fc70a6760f110fe
-  data.tar.gz: bb6175189fbe0abcc532b9c2c623c96788b97e0bd4a089f580927a6a9935efdd30600dce459c74cffc76a3749fbe0e2be6a131746a0902edcff5caec3a41fcf9
+  metadata.gz: a4871a86d2ef4c2bb7952966553c90b79f36ab1a2467e9da120bea156a5c30ac08c23f609ce5fd27426d6f434aac9cc96c7ace9998fa6cefaebfca8011cea58a
+  data.tar.gz: ad3eac246d498eedf109bbb024c28b97982215055d1e31b247e92a6df08462ccbc08d8d2c6114fc24ee4a94c90cb21c0cace29c9be9f249b1f47167dae7ab1e7

data/lib/girlscout.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'excon'
 
 require 'girlscout/resource'

data/lib/girlscout/attachment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Attachment < GirlScout::Object
   end

data/lib/girlscout/concerns/has_attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   module Concerns
     module HasAttributes
@@ -21,7 +23,7 @@ module GirlScout
         @attributes.key?(attr_key(key))
       end
 
-      def respond_to?(method_name, include_all=false)
+      def respond_to_missing?(method_name, include_all = false)
         key?(method_name) || super
       end
 
@@ -35,12 +37,11 @@ module GirlScout
       protected
 
       def normalize_attributes(attr)
-        attr = attr || @attributes
+        attr ||= @attributes
         attr = attr.attributes if attr.respond_to?(:attributes)
 
-        attr.inject({}) do |hash,(k,v)|
+        attr.each_with_object({}) do |(k, v), hash|
           hash[attr_key(k)] = v
-          hash
         end
       end
 
@@ -51,4 +52,3 @@ module GirlScout
     end
   end
 end
-

data/lib/girlscout/concerns/has_resource.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   module Concerns
     module HasResource
@@ -33,4 +35,3 @@ module GirlScout
     end
   end
 end
-

data/lib/girlscout/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   DEFAULT_API_PREFIX = 'https://api.helpscout.net/v1'
 

data/lib/girlscout/conversation.rb

@@ -1,37 +1,39 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Conversation < GirlScout::Object
     endpoint '/conversations'
 
     class << self
       def find(id)
-        Conversation.new(resource["/#{id}"].get["item"])
+        Conversation.new(resource["/#{id}"].get['item'])
       end
 
       def create(attributes)
         attributes = attributes.as_json if attributes.respond_to?(:as_json)
-        attributes["reload"] ||= true
-        Conversation.new(resource.post(payload: attributes)["item"])
+        attributes['reload'] ||= true
+        Conversation.new(resource.post(payload: attributes)['item'])
       end
     end
 
     def customer
-      @customer ||= Customer.new(self["customer"] || {})
+      @customer ||= Customer.new(self['customer'] || {})
     end
 
     def threads
-      @threads ||= (self["threads"] || []).map { |attr| Thread.new(attr) }
+      @threads ||= (self['threads'] || []).map { |attr| Thread.new(attr) }
     end
 
     def mailbox
-      @mailbox ||= Mailbox.new(self["mailbox"] || {})
+      @mailbox ||= Mailbox.new(self['mailbox'] || {})
     end
 
     def as_json
       # TODO: Test
       json = super.dup
-      json["customer"] = customer.as_json if key?("customer")
-      json["threads"] = threads.map(&:as_json) if key?("threads")
-      json["mailbox"] = mailbox.as_json if key?("mailbox")
+      json['customer'] = customer.as_json if key?('customer')
+      json['threads'] = threads.map(&:as_json) if key?('threads')
+      json['mailbox'] = mailbox.as_json if key?('mailbox')
       json
     end
   end

data/lib/girlscout/customer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Customer < GirlScout::Object
     endpoint '/customers'
@@ -8,13 +10,13 @@ module GirlScout
       end
 
       def find(id)
-        Customer.new(resource["/#{id}"].get["item"])
+        Customer.new(resource["/#{id}"].get['item'])
       end
     end
 
     def as_json
       json = super
-      json["type"] = "customer"
+      json['type'] = 'customer'
       json
     end
   end

data/lib/girlscout/error.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Error < ::StandardError
     include GirlScout::Concerns::HasAttributes
 
-    def initialize(attr={})
+    def initialize(attr = {})
       @attributes = normalize_attributes(attr)
-      super @attributes["error"]
+      super @attributes['error']
     end
   end
 end

data/lib/girlscout/folder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Folder < GirlScout::Object
   end

data/lib/girlscout/list.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module GirlScout
   class List < GirlScout::Object
     include Enumerable
 
     attr_accessor :item_class
-    alias_method :size, :count
-    alias_method :length, :count
+    alias size count
+    alias length count
 
     def initialize(attr, item_class)
       super(attr)
@@ -12,7 +14,7 @@ module GirlScout
     end
 
     def items
-      @items ||= (@attributes["items"] || []).map do |attr|
+      @items ||= (@attributes['items'] || []).map do |attr|
         @item_class.new(attr)
       end
     end

data/lib/girlscout/mailbox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Mailbox < GirlScout::Object
     endpoint '/mailboxes'
@@ -8,7 +10,7 @@ module GirlScout
       end
 
       def find(id)
-        Mailbox.new(resource["/#{id}"].get["item"])
+        Mailbox.new(resource["/#{id}"].get['item'])
       end
     end
 

data/lib/girlscout/object.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Object
     include GirlScout::Concerns::HasAttributes
     include GirlScout::Concerns::HasResource
 
-    def initialize(attr={}, options={})
+    def initialize(attr = {}, options = {})
       @attributes = normalize_attributes(attr)
       @resource   = options[:resource] if options[:resource]
     end

data/lib/girlscout/resource.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module GirlScout
   class Resource
-    METHODS = [:get, :put, :post, :patch, :delete]
+    METHODS = %i[get put post patch delete].freeze
 
-    def initialize(url: "")
+    def initialize(url: '')
       @url = url
     end
 
@@ -17,42 +19,27 @@ module GirlScout
     end
 
     METHODS.each do |method|
-      define_method(method) do |payload: nil, query: nil, &block|
+      define_method(method) do |payload: nil, query: nil|
         options = { method: method }
         if payload
           options[:body] = JSON.generate(payload)
           options[:headers] ||= {}
-          options[:headers]["Content-Type"] = "application/json"
-        end
-        if query
-          options[:query] = query
+          options[:headers]['Content-Type'] = 'application/json'
         end
+        options[:query] = query if query
 
         request(options)
       end
     end
 
-    def request(options={})
+    def request(options = {})
       auth = { user: Config.api_key, password: 'X' }
       response = Excon.new(url, auth).request(options)
-      if 400 <= response.status && response.status < 600
-        raise GirlScout::Error.new(JSON.parse(response.body))
+      if response.status >= 400 && response.status < 600
+        raise GirlScout::Error, JSON.parse(response.body)
       end
 
       JSON.parse(response.body)
     end
-
-    private
-
-    def parse(response)
-      JSON.load(response)
-    end
-
-    def serialize(payload)
-      payload.to_json
-    end
-
-    def call
-    end
   end
 end

data/lib/girlscout/search.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Search < GirlScout::Object
     endpoint '/search'

data/lib/girlscout/thread.rb

@@ -1,20 +1,29 @@
+# frozen_string_literal: true
+
 module GirlScout
   class Thread < GirlScout::Object
     def attachments
-      @attachments ||= (self["attachments"] || []).map { |attr| Attachment.new(attr) }
+      @attachments ||= (self['attachments'] || []).map do |attr|
+        Attachment.new(attr)
+      end
     end
 
     def created_by
-      return @created_by if defined? @created_by and @created_by
+      @created_by = nil unless defined? @created_by
+      return @created_by if @created_by
 
-      attr = @attributes["createdBy"]
-      creator_type = "GirlScout::#{attr["type"].capitalize}".constantize rescue User
+      attr = @attributes['createdBy']
+      creator_type = begin
+                       "GirlScout::#{attr['type'].capitalize}".constantize
+                     rescue StandardError
+                       User
+                     end
       @created_by ||= creator_type.new(attr)
     end
 
     def as_json
       json = super
-      json["createdBy"] = created_by.as_json if key?("created_by")
+      json['createdBy'] = created_by.as_json if key?('created_by')
       json
     end
   end

data/lib/girlscout/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GirlScout
   class User < GirlScout::Object
     endpoint '/users'
@@ -8,17 +10,17 @@ module GirlScout
       end
 
       def find(id)
-        User.new(resource["/#{id}"].get["item"])
+        User.new(resource["/#{id}"].get['item'])
       end
 
       def me
-        find("me")
+        find('me')
       end
     end
 
     def as_json
       json = super
-      json["type"] = "user"
+      json['type'] = 'user'
       json
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: girlscout
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.0
 platform: ruby
 authors:
 - Chakrit Wichian
@@ -16,56 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.62'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
-- !ruby/object:Gem::Dependency
-  name: faraday
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.62'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -100,56 +86,98 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.9'
+        version: '5.11'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.11'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.9'
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: overcommit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.46'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.46'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.2'
+        version: '12.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.3'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.58'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.2'
+        version: '0.58'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 description: Provides integration with HelpScout REST API.
 email: chakrit@omise.co
 executables: []
@@ -192,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Integrate your support tooling with HelpScout API.