ghost_in_the_post 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d5264602db0f4c3dff7764e85b40b297046a9a55
-  data.tar.gz: 289c490672985941a51227c4a9133ec1ba9e175c
+  metadata.gz: 8fdee37440de2543663fe6262bbb9462814f01dd
+  data.tar.gz: 015968eca2634d160b1902de601061f3c7538e6f
 SHA512:
-  metadata.gz: c7b6aca158ff83c738d9cb85d01d7011d9cae5d8e47a8f5ed6650dc394086a216217ab2e7c557796fbe02583b0c6489d959caa90c00e3ff1376bc3c38aa20f75
-  data.tar.gz: 40ae64bdf2f34875db66564f55de75b23563ed87595fe10102fc894e78ea091abf67e0d0c9572106c65fc1e358a74f0be406d1a19bf9d44737eb481f1ddc9fb2
+  metadata.gz: 2aadad0634b972c587c121282b199f53820300a91d1fb950aa2fc2b3ea3c3bbfbf7cbca9aee87c8da2fd05f47952c9c2283c6782205fb43a0831c51470c412b9
+  data.tar.gz: f34444669b33981f2057279e08c637cd168a4bc0c1d3aa18a060fbfe3066292ea2aad7b75a42850f04e6a0a74b82a713910c1aeb980a9e4353bc4715bd136876

data/lib/ghost_in_the_post.rb

@@ -4,11 +4,17 @@ module GhostInThePost
     :phantomjs_path,
     :includes,
     :remove_js_tags,
+    :timeout,
+    :wait_event,
   ]
+  DEFAULT_TIMEOUT = 1000
+  DEFAULT_WAIT_EVENT = "ghost_in_the_post:done"
   private_constant :ATTRIBUTE_NAMES
   cattr_reader(*ATTRIBUTE_NAMES)
 
   @@phantomjs_path = nil #setting this to nil helps testing
+  @@timeout = DEFAULT_TIMEOUT
+  @@wait_event = DEFAULT_WAIT_EVENT
   @@includes = []
   @@remove_js_tags = true
 
@@ -17,6 +23,8 @@ module GhostInThePost
     @@phantomjs_path = new_config[:phantomjs_path]
     @@includes = Array(new_config[:includes])
     @@remove_js_tags = new_config[:remove_js_tags].nil? ? true : new_config[:remove_js_tags]
+    @@timeout = new_config[:timeout] || DEFAULT_TIMEOUT
+    @@wait_event = new_config[:wait_event] || DEFAULT_WAIT_EVENT
     raise ArgumentError, "GhostInThePost.config.phantomjs_path is not set" if self.phantomjs_path.nil?
   end
 

data/lib/ghost_in_the_post/automatic.rb

@@ -1,6 +1,6 @@
 module GhostInThePost
   module Automatic
-    attr_accessor :included_scripts
+    attr_accessor :included_scripts, :ghost_timeout, :ghost_wait_event
 
     def include_script(*paths)
       @included_scripts ||= []
@@ -12,6 +12,8 @@ module GhostInThePost
         email.extend GhostOnCommand
         email.extend GhostOnDelivery
         email.included_scripts = @included_scripts
+        email.ghost_timeout = @ghost_timeout
+        email.ghost_wait_event = @ghost_wait_event
       end
     end
 

data/lib/ghost_in_the_post/ghost_on_command.rb

@@ -1,9 +1,9 @@
 module GhostInThePost
   module GhostOnCommand
-    attr_accessor :included_scripts
+    attr_accessor :included_scripts, :ghost_timeout, :ghost_wait_event
 
     def ghost
-      MailGhost.new(self, included_scripts).execute
+      MailGhost.new(self, ghost_timeout, ghost_wait_event, included_scripts).execute
     end
   end
 end

data/lib/ghost_in_the_post/mail_ghost.rb

@@ -1,9 +1,11 @@
 module GhostInThePost
   class MailGhost
-    attr_reader :email, :included_scripts
+    attr_reader :email, :included_scripts, :timeout, :wait_event
 
-    def initialize(email, included_scripts)
+    def initialize(email, timeout=nil, wait_event=nil, included_scripts=[])
       @email = email
+      @timeout = timeout
+      @wait_event = wait_event
       @included_scripts = Array(included_scripts).compact
     end
 
@@ -24,7 +26,7 @@ module GhostInThePost
     end
 
     def ghost_html(old_html)
-      PhantomTransform.new(old_html, included_scripts).transform
+      PhantomTransform.new(old_html, timeout, wait_event, included_scripts).transform
     end
   end
 end

data/lib/ghost_in_the_post/mailer.rb

@@ -1,6 +1,6 @@
 module GhostInThePost
   module Mailer
-    attr_accessor :included_scripts
+    attr_accessor :included_scripts, :ghost_timeout, :ghost_wait_event
 
     def include_script(*paths)
       @included_scripts ||= []
@@ -11,6 +11,8 @@ module GhostInThePost
       super.tap do |email|
         email.extend GhostOnCommand
         email.included_scripts = included_scripts
+        email.ghost_timeout = @ghost_timeout
+        email.ghost_wait_event = @ghost_wait_event
       end
     end
 

data/lib/ghost_in_the_post/phantom/staticize.js

@@ -1,15 +1,26 @@
 "use strict";
 var system  = require('system'),
     page    = require('webpage').create(),
-    html    = system.args[1], //the email to be processed
+    address = system.args[1], //tmp file of the html to be processed
     no_script = system.args[2] == "true",
-    include = system.args[3]; //the injected js file
+    include = system.args[3], //tmp file for the injected js file
+    timeout = parseInt(system.args[4]) || 1000, //return page contents after a timeout
+    wait_event = system.args[5]; //return page contents after an event
 
-page.onLoadFinished = function(status) {
-  //load included scripts to be loaded on the dom
-  if(!!include){
-    page.injectJs(include);
-  }
+//write out to console to export contents
+//and get out of here
+function finish(){
+  console.log(page.content); 
+  phantom.exit(); 
+}
+ 
+page.onLoadFinished = function(status){
+  //catch wait_event
+  page.onCallback = finish
+  page.evaluate(function(finish, wait_event) {
+    document.addEventListener(wait_event, window.callPhantom, false)
+  }, finish, wait_event)
+  //clear script tags
   if(no_script) {
     page.evaluate(function(){
       var script_tags = document.getElementsByTagName("script");
@@ -18,10 +29,13 @@ page.onLoadFinished = function(status) {
       }
     })
   }
-  //write out to console to export contents
-  console.log(page.content); 
-  phantom.exit(); //get out of here
+  //load included scripts to be loaded on the dom
+  if(!!include){
+    page.injectJs(include);
+  }
+  if(timeout > 0){
+    setTimeout(finish, timeout);//timout to bailout after a period
+  }
 };
-//load html content
-page.setContent(html, 'http://www.whatever.com');
 
+page.open("file://"+address)

data/lib/ghost_in_the_post/phantom_transform.rb

@@ -2,55 +2,60 @@ module GhostInThePost
   class PhantomTransform
     PHANTOMJS_SCRIPT = File.expand_path('../phantom/staticize.js', __FILE__)
 
-    def initialize(html, included_scripts=[])
+    def initialize(html, timeout=nil, wait_event=nil, included_scripts=[])
       @html = html
+      @timeout = timeout || GhostInThePost.timeout
+      @wait_event = wait_event || GhostInThePost.wait_event
       @included_scripts = Array(included_scripts).compact
     end
 
     def transform
-      injectable_scripts.any? ? transform_with_injections : simple_transform
+      output = @html
+      begin
+        htmlfile = html_file()
+        jsfile = js_file()
+        p command(htmlfile, jsfile)
+        output = IO.popen(command(htmlfile, jsfile)){|io| io.read}
+      ensure
+        htmlfile.unlink unless htmlfile.nil?
+        jsfile.unlink unless jsfile.nil?
+      end
+      output
     end
 
     private
 
-    def command
+    def command(htmlfile, jsfile)
       [
         GhostInThePost.phantomjs_path, 
         PHANTOMJS_SCRIPT, 
-        @html,
-        GhostInThePost.remove_js_tags
-      ]
+        htmlfile.path,
+        GhostInThePost.remove_js_tags,
+        jsfile.path,
+        @timeout,
+        @wait_event,
+      ].map(&:to_s)
     end
 
-    #there is scripts to inject so create a tmp file to put them all in
-    def transform_with_injections
-      #set output to just html so that if there is an error that is caught it will
-      #at least return valid html
-      output = @html
-      begin
-        #generate a tempfile with all the js that we need so that phantom can inject
-        #easily and not have to max out a single command
-        file = Tempfile.new(['inject', '.js'])
-        injectable_scripts.map do |script|
-          asset = find_asset_in_pipeline(script)
-          file.write(asset.to_s) unless asset.nil?
-        end.compact
-        file.close #closing the file makes it accessible by phantom
-
-        #generate the html with the javascript
-        output = IO.popen(command + [file.path]){|io| io.read}
-
-        file.unlink
-      rescue => e
-        #clean up the temp file
-        file.unlink
-      end
-      output
+    #generate a tempfile with all the html that we need so that phantom can inject
+    #easily and not have to max out a single command
+    def html_file
+      file = Tempfile.new(['inject', '.html'])
+      file.write(@html)
+      file.close #closing the file makes it accessible by phantom
+      file
     end
 
-    #no scripts to inject so just run the command
-    def simple_transform
-      IO.popen(command){|io| io.read}
+    #generate a tempfile with all the js that we need so that phantom can inject
+    #easily and not have to max out a single command
+    def js_file
+      jsfile = Tempfile.new(['inject', '.js'])
+      injectable_scripts.map do |script|
+        asset = find_asset_in_pipeline(script)
+        jsfile.write(asset.to_s) unless asset.nil?
+      end.compact
+      jsfile.close #closing the file makes it accessible by phantom
+      jsfile
     end
 
     def injectable_scripts

data/lib/ghost_in_the_post/version.rb

@@ -1,3 +1,3 @@
 module GhostInThePost
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/dummy/Gemfile

@@ -1,3 +1,7 @@
 source 'https://rubygems.org'
 gem 'rails', '4.2.3'
 gem 'ghost_in_the_post', :path => '../..'
+
+group :development do
+  gem 'pry'
+end

data/spec/dummy/Gemfile.lock

@@ -44,6 +44,7 @@ GEM
       tzinfo (~> 1.1)
     arel (6.0.3)
     builder (3.2.2)
+    coderay (1.1.0)
     concurrent-ruby (1.0.0)
     concurrent-ruby (1.0.0-java)
     erubis (2.7.0)
@@ -56,12 +57,17 @@ GEM
       nokogiri (>= 1.5.9)
     mail (2.6.3)
       mime-types (>= 1.16, < 3)
+    method_source (0.8.2)
     mime-types (2.99)
     mini_portile2 (2.0.0)
     minitest (5.8.4)
     nokogiri (1.6.7.2)
       mini_portile2 (~> 2.0.0.rc2)
     nokogiri (1.6.7.2-java)
+    pry (0.10.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
     rack (1.6.4)
     rack-test (0.6.3)
       rack (>= 1.0)
@@ -90,6 +96,7 @@ GEM
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (10.5.0)
+    slop (3.6.0)
     sprockets (3.5.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -109,6 +116,7 @@ PLATFORMS
 
 DEPENDENCIES
   ghost_in_the_post!
+  pry
   rails (= 4.2.3)
 
 BUNDLED WITH

data/spec/dummy/log/development.log

@@ -214,3 +214,59 @@ AutoMailer#normal_email: processed outbound mail in 42.0ms
   Rendered auto_mailer/normal_email.text (4.0ms)
 
 AutoMailer#normal_email: processed outbound mail in 415.0ms
+  Rendered auto_mailer/normal_email.html.erb (1.9ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 218.4ms
+  Rendered auto_mailer/normal_email.html.erb (0.1ms)
+  Rendered auto_mailer/normal_email.text (0.0ms)
+
+AutoMailer#normal_email: processed outbound mail in 10.3ms
+  Rendered auto_mailer/normal_email.html.erb (1.7ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 222.5ms
+  Rendered auto_mailer/normal_email.html.erb (1.8ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 221.7ms
+  Rendered auto_mailer/normal_email.html.erb (1.9ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 217.4ms
+  Rendered auto_mailer/normal_email.html.erb (0.1ms)
+  Rendered auto_mailer/normal_email.text (0.1ms)
+
+AutoMailer#normal_email: processed outbound mail in 11.7ms
+  Rendered auto_mailer/normal_email.html.erb (0.1ms)
+  Rendered auto_mailer/normal_email.text (0.1ms)
+
+AutoMailer#normal_email: processed outbound mail in 14.3ms
+  Rendered auto_mailer/normal_email.html.erb (4.9ms)
+  Rendered auto_mailer/normal_email.text (0.7ms)
+
+AutoMailer#normal_email: processed outbound mail in 318.1ms
+  Rendered auto_mailer/normal_email.html.erb (2.0ms)
+  Rendered auto_mailer/normal_email.text (0.4ms)
+
+AutoMailer#normal_email: processed outbound mail in 226.4ms
+  Rendered auto_mailer/normal_email.html.erb (0.1ms)
+  Rendered auto_mailer/normal_email.text (0.0ms)
+
+AutoMailer#normal_email: processed outbound mail in 8.6ms
+  Rendered auto_mailer/normal_email.html.erb (2.1ms)
+  Rendered auto_mailer/normal_email.text (0.4ms)
+
+AutoMailer#normal_email: processed outbound mail in 226.5ms
+  Rendered auto_mailer/normal_email.html.erb (2.0ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 218.6ms
+  Rendered auto_mailer/normal_email.html.erb (1.1ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 180.1ms
+  Rendered auto_mailer/normal_email.html.erb (1.8ms)
+  Rendered auto_mailer/normal_email.text (0.3ms)
+
+AutoMailer#normal_email: processed outbound mail in 224.1ms

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/4PgfVpd4CZQ0vAsVTl2KDb1z4f6GLl4mXIc3jSrahHM.cache

@@ -0,0 +1,2 @@
+[o:Set:
+@hash{	I"environment-version:ETTI"environment-paths;TTI"Zprocessors:type=application/javascript&file_type=application/javascript&pipeline=self;TTI"1file-digest://app/assets/javascripts/test.js;TT

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/6wWiAXBcdY6PLKOIhXQ6c8h9UtViuvdLcEO6wXK3mh0.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/test.js?type=application/javascript&pipeline=self&id=12b05e7da72de9b196b844829893c6dd17135d893a81b9a1872199b8189a69da:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/J_D4gpddr1KPVysTvEE48iHsNzrL5Pbj8S5ZNt3PhA4.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/application.js?type=application/javascript&id=24a76124d867ad27aa7510f40701c74430d66668ae273445d54914f5c29b5ef8:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/xstXMnjOlL2Ynn6MaI9bxlRnhTPYdgCIeOWnWphFSlA.cache

@@ -0,0 +1 @@
+I"
�app/assets/javascripts/application.js?type=application/javascript&pipeline=self&id=e3a979bc569cf175e48bf432cbfc5f77aa2bcf282931866a1f4a71d049d118ab:ET

data/spec/dummy/tmp/cache/assets/sprockets/v3.0/zUYxDxkUr_FKBi6fF7kellqyG52AoZbYItHMUq17DJo.cache

@@ -0,0 +1 @@
+"%f�먞3���@�����Ŝ���q�3|b��ϡB�

data/spec/lib/ghost_in_the_post/ghost_on_command_spec.rb

@@ -12,7 +12,9 @@ module GhostInThePost
       end
       it "should create a MailGhost" do
         email.included_scripts = ["test"]
-        expect(MailGhost).to receive(:new).with(email, ["test"]).and_call_original
+        email.ghost_timeout = 1000
+        email.ghost_wait_event = "test"
+        expect(MailGhost).to receive(:new).with(email, 1000, "test", ["test"]).and_call_original
         email.ghost
       end
       it "should apply included scripts to the mail ghost" do

data/spec/lib/ghost_in_the_post/mail_ghost_spec.rb

@@ -5,10 +5,12 @@ module GhostInThePost
   describe MailGhost do
     let(:email) { Mail.new }
     let(:included_scripts) { ["application.js"] }
-    subject(:ghost) { MailGhost.new(email, included_scripts) }
+    subject(:ghost) { MailGhost.new(email, 1000, "wait", included_scripts) }
 
     it "takes an email and options" do
       expect(ghost.email).to eq(email)
+      expect(ghost.timeout).to eq(1000)
+      expect(ghost.wait_event).to eq("wait")
       expect(ghost.included_scripts).to eq(included_scripts)
     end
 
@@ -44,7 +46,7 @@ module GhostInThePost
 
       it "adjusts the html part using Roadie" do
         document = double "A document", transform: "transformed HTML"
-        expect(PhantomTransform).to receive(:new).with(html, included_scripts).and_return document
+        expect(PhantomTransform).to receive(:new).with(html,1000, "wait", included_scripts).and_return document
         ghost.execute
         expect(email.body.decoded).to eq("transformed HTML")
       end
@@ -62,7 +64,7 @@ module GhostInThePost
 
       it "adjusts the html part using Roadie" do
         document = double "A document", transform: "transformed HTML"
-        expect(PhantomTransform).to receive(:new).with(html, included_scripts).and_return document
+        expect(PhantomTransform).to receive(:new).with(html,1000, "wait", included_scripts).and_return document
         ghost.execute
         expect(email.html_part.body.decoded).to eq("transformed HTML")
       end

data/spec/lib/ghost_in_the_post/phantom_transform_spec.rb

@@ -5,7 +5,7 @@ module GhostInThePost
     let(:html){"<html><head><script></script></head><body><div id='test'></div></body></html>"}
     let(:js){"(function(){document.getElementById('test').innerHTML='complete';})()"}
     let(:included_scripts){["application.js"]}
-    subject {PhantomTransform.new(html, included_scripts)}
+    subject {PhantomTransform.new(html, nil, nil,included_scripts)}
 
     before :each do
       GhostInThePost.config = {phantomjs_path: "this/is/path"}
@@ -14,121 +14,106 @@ module GhostInThePost
 
     describe "#initialize" do
       it "should set html" do
-        pt = PhantomTransform.new(html, included_scripts)
+        pt = PhantomTransform.new(html, nil, nil, included_scripts)
         expect(pt.instance_variable_get(:@html)).to eq(html)
       end
+      it "should set the timeout" do
+        pt = PhantomTransform.new(html, 45, nil, included_scripts)
+        expect(pt.instance_variable_get(:@timeout)).to eq(45)
+      end
+      it "should set the default timeout if none given" do
+        pt = PhantomTransform.new(html, nil, nil, included_scripts)
+        expect(pt.instance_variable_get(:@timeout)).to eq(GhostInThePost.timeout)
+      end
+      it "should set the wait event" do
+        pt = PhantomTransform.new(html, nil, "my wait", included_scripts)
+        expect(pt.instance_variable_get(:@wait_event)).to eq("my wait")
+      end
+      it "should set the default wait event if none given" do
+        pt = PhantomTransform.new(html, nil, nil, included_scripts)
+        expect(pt.instance_variable_get(:@wait_event)).to eq(GhostInThePost.wait_event)
+      end
       it "should set included_scripts" do
-        pt = PhantomTransform.new(html, included_scripts)
+        pt = PhantomTransform.new(html, nil, nil, included_scripts)
         expect(pt.instance_variable_get(:@included_scripts)).to eq(included_scripts)
       end
       it "should default included_scripts to an array" do
-        pt = PhantomTransform.new(html, nil)
+        pt = PhantomTransform.new(html, nil, nil, nil)
         expect(pt.instance_variable_get(:@included_scripts)).to eq([])
       end
     end
 
     describe "#transform" do
+      let(:html_path) {"/this/is/htmlpath"}
+      let(:js_path) {"/this/is/js_path"}
 
       before :each do
         allow(IO).to receive(:popen)
+        allow(Rails.application).to receive(:assets){{"application.js": js}}
       end
 
-      context "with included_scripts" do
-        let(:path) {"/this/is/path"}
-
-        before :each do
-          allow(IO).to receive(:popen)
-          allow(Rails.application).to receive(:assets){
-            {
-              "application.js": "asset string"
-            }
-          }
-          allow_any_instance_of(Tempfile).to receive(:path){path}
-        end
-
-        it "should call transform_with_injections" do
-          expect(subject).to receive(:transform_with_injections)
-          subject.transform
-        end
-
-        it "should create a temp file, write to it and unlink it" do
-          file = Object.new
-          expect(subject).to receive(:injectable_scripts).twice{included_scripts}
-          expect(subject).to receive(:find_asset_in_pipeline).once.with(included_scripts.first){""}
-          expect(Tempfile).to receive(:new).with(['inject', '.js']){file}
-          allow(file).to receive(:path){path}
-          expect(file).to receive(:write)
-          expect(file).to receive(:close)
-          expect(file).to receive(:unlink)
-          subject.transform
-        end
-
-        it "should call IO.popen with arguments" do
-          expect(IO).to receive(:popen).with([
-            GhostInThePost.phantomjs_path, 
-            GhostInThePost::PhantomTransform::PHANTOMJS_SCRIPT, 
-            html,
-            GhostInThePost.remove_js_tags,
-            path
-          ])
-          subject.transform
-        end
-
-        it "should return the result of IO.popen with arguments" do
-          allow(IO).to receive(:popen) {"this is the end"}
-          expect(subject.transform).to eq("this is the end")
-        end
-
-        it "should return the html if there was an error" do
-          file = Object.new
-          allow(Tempfile).to receive(:new).with(['inject', '.js']){file}
-          allow(file).to receive(:path){path}
-          allow(file).to receive(:write)
-          allow(file).to receive(:close)
-          allow(file).to receive(:unlink)
-          allow(IO).to receive(:popen) {raise ArgumentError}
-          expect(subject.transform).to eq(html)
-        end
-
-        it "should unlink file even if there was an error" do
-          file = Object.new
-          allow(Tempfile).to receive(:new).with(['inject', '.js']){file}
-          allow(file).to receive(:path){path}
-          allow(file).to receive(:write)
-          allow(file).to receive(:close)
-          allow(file).to receive(:unlink)
-          allow(IO).to receive(:popen) {raise ArgumentError}
-          subject.transform
-        end                                               
+      it "should create a temp file for the html" do
+        file = Object.new
+        expect(subject).to receive(:html_file){file}
+        allow(file).to receive(:path){html_path}
+        expect(file).to receive(:unlink)
+        subject.transform
+      end
 
+      it "should create a temp file for the js" do
+        file = Object.new
+        expect(subject).to receive(:js_file){file}
+        allow(file).to receive(:path){js_path}
+        expect(file).to receive(:unlink)
+        subject.transform
       end
 
-      context "without included_scripts" do
-        let(:pt){PhantomTransform.new(html)}
-
-        it "should call simple_transform" do
-          expect(pt).to receive(:simple_transform)
-          pt.transform
-        end
-
-        it "should call IO.popen with arguments" do
-          expect(IO).to receive(:popen).with([
-            GhostInThePost.phantomjs_path, 
-            GhostInThePost::PhantomTransform::PHANTOMJS_SCRIPT, 
-            html,
-            GhostInThePost.remove_js_tags
-          ])
-          pt.transform
-        end
-
-        it "should return the result of IO.popen with arguments" do
-          allow(IO).to receive(:popen) {"this is the end"}
-          expect(pt.transform).to eq("this is the end")
-        end
+      it "should call IO.popen with arguments" do
+        html_file = Object.new
+        expect(subject).to receive(:html_file){html_file}
+        allow(html_file).to receive(:path){html_path}
+        allow(html_file).to receive(:unlink)
+
+        js_file = Object.new
+        expect(subject).to receive(:js_file){js_file}
+        allow(js_file).to receive(:path){js_path}
+        allow(js_file).to receive(:unlink)
+
+        expect(IO).to receive(:popen).with([
+          GhostInThePost.phantomjs_path, 
+          GhostInThePost::PhantomTransform::PHANTOMJS_SCRIPT, 
+          html_path,
+          GhostInThePost.remove_js_tags.to_s,
+          js_path,
+          "1000",
+          "ghost_in_the_post:done",
+        ])
+
+        subject.transform
+      end
 
+      it "should return the result of IO.popen with arguments" do
+        allow(IO).to receive(:popen) {"this is the end"}
+        expect(subject.transform).to eq("this is the end")
       end
-    end
 
+      it "should unlink file even if there was an error" do
+        html_file = Object.new
+        expect(subject).to receive(:html_file){html_file}
+        allow(html_file).to receive(:path){html_path}
+        expect(html_file).to receive(:unlink)
+
+        js_file = Object.new
+        expect(subject).to receive(:js_file){js_file}
+        allow(js_file).to receive(:path){js_path}
+        expect(js_file).to receive(:unlink)
+
+        allow(IO).to receive(:popen) {raise ArgumentError}
+
+        expect{subject.transform}.to raise_error ArgumentError
+      end
+
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ghost_in_the_post
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Tim Anema
@@ -118,14 +118,19 @@ files:
 - spec/dummy/log/development.log
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/1hVihiFdBkDBsuCvA1I2vuFa9N6p-5zQ-qKvf4vz7jA.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/23mzeUAO-pIzGJ1n84Dbg25udWeSiBcd6e_QsDihWQc.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/4PgfVpd4CZQ0vAsVTl2KDb1z4f6GLl4mXIc3jSrahHM.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/6544SZAu2zCeDrdro4h3izdKNXVvHzstwz12UxeiJoA.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/6wWiAXBcdY6PLKOIhXQ6c8h9UtViuvdLcEO6wXK3mh0.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/BMI0IB92xLhvUPcr_K0JuSk8zczmrEEbJCd3qwHauhQ.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/GtqgDsC0JMsKfj0x5uQrbPcSS3QIPIzLKrq2fGJDBf0.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/IFLV6zTaBXU1ccodbD3QJ4xUIOEix_Fbb7j8wsxrHw8.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/J_D4gpddr1KPVysTvEE48iHsNzrL5Pbj8S5ZNt3PhA4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/Lc8lcXR-AibSZCIbx_imdfIOmD-zbZ_pwSNMs0o0Dos.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/O9gjtBITAGlfzUwc2DT5N0GW2bo2b2yQ64gnQljLogM.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/OQXwnC5z5STtd87Tr2dz1QBt4iZ8PoZTH8KBtBlUGnE.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/OZ04c215C4Euu3scfhmxmte0o_tZOVWTqrv61cpy7H4.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/UbKcvOd2xh3MJoKxz4l4RHMy5IupdsiDoSllZDvYCZA.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/XuOqk2dVOcltjkihZ8J_u5Pbcm9Of5KFkjyihP6-5tc.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/_Bn81xMZj4dS_W5s9uSDhtEdpRZtsc21rcKEYAPCsZY.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/_Cw52w24AWZEbxLmduyWBMA6Y1OmJiEm1VNn7pY4rtk.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/_HO5Nyj_TzTxVwa4OOf_0UJfBCmjgkv7NsRU29AD5Oo.cache
@@ -138,7 +143,10 @@ files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/oB1njyQ78MOMRf_5TvuYzHleeI8eke5-FDIIVl7qas0.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/pEhaat2KBd5SrT7szC_8R1_6hK17FTpvoRFkmCRSD3M.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/qxbw0jMkxTNeM5T2QovOD9vTyvjHVjBN5tZdwBf519A.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/xstXMnjOlL2Ynn6MaI9bxlRnhTPYdgCIeOWnWphFSlA.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/y98HqYF9nxOk8t_j3BKv9Nc4LuSAEzhER7rCCvOM6xI.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/zRSH1x7PsiRf9MSILPhc4GKDjRo4xaFNd41wHFCtJSo.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/zUYxDxkUr_FKBi6fF7kellqyG52AoZbYItHMUq17DJo.cache
 - spec/lib/ghost_in_the_post/automatic_spec.rb
 - spec/lib/ghost_in_the_post/ghost_on_command_spec.rb
 - spec/lib/ghost_in_the_post/mail_ghost_spec.rb
@@ -206,7 +214,9 @@ test_files:
 - spec/dummy/log/development.log
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/1hVihiFdBkDBsuCvA1I2vuFa9N6p-5zQ-qKvf4vz7jA.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/23mzeUAO-pIzGJ1n84Dbg25udWeSiBcd6e_QsDihWQc.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/4PgfVpd4CZQ0vAsVTl2KDb1z4f6GLl4mXIc3jSrahHM.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/6544SZAu2zCeDrdro4h3izdKNXVvHzstwz12UxeiJoA.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/6wWiAXBcdY6PLKOIhXQ6c8h9UtViuvdLcEO6wXK3mh0.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/_Bn81xMZj4dS_W5s9uSDhtEdpRZtsc21rcKEYAPCsZY.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/_Cw52w24AWZEbxLmduyWBMA6Y1OmJiEm1VNn7pY4rtk.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/_HO5Nyj_TzTxVwa4OOf_0UJfBCmjgkv7NsRU29AD5Oo.cache
@@ -217,6 +227,7 @@ test_files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/GtqgDsC0JMsKfj0x5uQrbPcSS3QIPIzLKrq2fGJDBf0.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/hZi1k6tpxxCGYxRe7zY74ItcOI8gZrREOpGuA8JSpGg.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/IFLV6zTaBXU1ccodbD3QJ4xUIOEix_Fbb7j8wsxrHw8.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/J_D4gpddr1KPVysTvEE48iHsNzrL5Pbj8S5ZNt3PhA4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/Lc8lcXR-AibSZCIbx_imdfIOmD-zbZ_pwSNMs0o0Dos.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/n6_6RjvPX2rCv5dytbSnnDrGwAj1ZcPfninuNUeP_iE.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/nXo-w2o4zQBM_uSUnniuP53t5erBbSZPecMED9YnzQI.cache
@@ -226,7 +237,12 @@ test_files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/OZ04c215C4Euu3scfhmxmte0o_tZOVWTqrv61cpy7H4.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/pEhaat2KBd5SrT7szC_8R1_6hK17FTpvoRFkmCRSD3M.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/qxbw0jMkxTNeM5T2QovOD9vTyvjHVjBN5tZdwBf519A.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/UbKcvOd2xh3MJoKxz4l4RHMy5IupdsiDoSllZDvYCZA.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/xstXMnjOlL2Ynn6MaI9bxlRnhTPYdgCIeOWnWphFSlA.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/XuOqk2dVOcltjkihZ8J_u5Pbcm9Of5KFkjyihP6-5tc.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/y98HqYF9nxOk8t_j3BKv9Nc4LuSAEzhER7rCCvOM6xI.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/zRSH1x7PsiRf9MSILPhc4GKDjRo4xaFNd41wHFCtJSo.cache
+- spec/dummy/tmp/cache/assets/sprockets/v3.0/zUYxDxkUr_FKBi6fF7kellqyG52AoZbYItHMUq17DJo.cache
 - spec/lib/ghost_in_the_post/automatic_spec.rb
 - spec/lib/ghost_in_the_post/ghost_on_command_spec.rb
 - spec/lib/ghost_in_the_post/mail_ghost_spec.rb