ghn 2.0.0.pre4 → 2.0.0.pre5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 94e945b6b2fbd6ef4b6fe02f0bd0d8e896e58d21
-  data.tar.gz: 63a952e82cac9bca5789a03c4d607c5e4d6fdbcc
+  metadata.gz: a6530b32dbc20799ac48e639138fe9581eb76b1b
+  data.tar.gz: 1e75ba2866a8a1bbfc9696892642bf8bff2108ad
 SHA512:
-  metadata.gz: cd5608d589b9cf25ff8d70306ea09947289c0118ec96078a69fdfe8a26e9373fe2868ba668ccef3eaceebe35f56e220be0ea59f8c20c96a97194c2ccc45bdb85
-  data.tar.gz: 0866278f8a9f23040f01be99d1fb201b629fd61c50a158f1384e8e9ba2db82fd08cd5e27d890e4226ee28c4e00f7c2b2a9440439ed31d1212bd1ae895b8d7758
+  metadata.gz: 0c04b79a4ff9798adc6b1081164f26546c7de2fbd69546d8d5cfb62372dace75243434733d7f11d5256fa42ce3b5bcf0cb2769d26b664c2ebadf03450f13df3c
+  data.tar.gz: d251d40c9d795ef9cc4862f92cc9c0fb5be798c35b0aa9a65f6ac49b4eeb54de5075b068cb2fdac556afd06cef5dd5d665672846fd8128f43c1443a3a43f5db9

data/README.md

@@ -50,6 +50,17 @@ Please set **ghn.token** to your `.gitconfig`.
 
 You can also set access token via `GHN_ACCESS_TOKEN` environment variable.
 
+## Follow issuecomment anchor
+
+If you provide `--follow-issuecomment` option, or set git config `ghn.followissuecomment` to "yes", "on" or "true",
+ghn follows #issuecomment- anchor URL as like GitHub's official notification link.
+
+    $ ghn open --follow-issuecomment
+
+    $ git config --global ghn.followissuecomment true
+
+Commandline option overrides git config setting as well.
+
 ## Contributing
 
 1. Fork it

data/lib/ghn/collector.rb

@@ -1,19 +1,22 @@
 class Ghn
   class Collector
-    def initialize(client, repo_full_name = nil)
+    attr_reader :client, :repo_full_name, :follow_issuecomment
+
+    def initialize(client, repo_full_name = nil, follow_issuecomment = false)
       @client = client
       @repo_full_name = repo_full_name
+      @follow_issuecomment = follow_issuecomment
     end
 
     def collect(page = 1)
-      notifications = if @repo_full_name
-                        @client.repo_notifications(@repo_full_name, page: page)
+      notifications = if repo_full_name
+                        client.repo_notifications(repo_full_name, page: page)
                       else
-                        @client.notifications(page: page)
+                        client.notifications(page: page)
                       end
       @count = notifications.count
       notifications.map { |notification|
-        Notification.new(notification).type_class.new(notification).url
+        Notification.new(notification, follow_issuecomment).type_class.new(notification, follow_issuecomment).url
       }.compact
     end
 

data/lib/ghn/commands.rb

@@ -1,6 +1,7 @@
 class Ghn
   class Commands < Thor
     class_option :all, type: :boolean, aliases: '-a', desc: 'List/Open all unread notifications'
+    class_option :follow_issuecomment, type: :boolean, desc: 'Follow issuecomment anchor URL'
 
     desc 'list NAME', 'List unread notifications'
     def list(name = nil)
@@ -20,7 +21,7 @@ class Ghn
 
     def collect(repo_full_name = nil)
       threads = []
-      collector = Collector.new(client, repo_full_name)
+      collector = Collector.new(client, repo_full_name, follow_issuecomment?)
       # Unfortunately, GitHub v3 Notifications API doesn't accept octokit's auto_paginate option
       # because this API doesn't return Link header so far.
       loop.with_index(1) do |_, page|
@@ -40,6 +41,17 @@ class Ghn
       @aliases ||= Aliases.new
     end
 
+    def follow_issuecomment?
+      val = (options['follow_issuecomment'] || `git config ghn.followissuecomment`.chomp).to_s
+      if val.empty?
+        false
+      elsif val.match(/off|no|false/i)
+        false
+      else
+        true
+      end
+    end
+
     def access_token
       @access_token ||=
         case

data/lib/ghn/notification.rb

@@ -1,9 +1,10 @@
 class Ghn
   class Notification
-    attr_reader :notification
+    attr_reader :notification, :follow_issuecomment
 
-    def initialize(notification)
+    def initialize(notification, follow_issuecomment)
       @notification = notification
+      @follow_issuecomment = follow_issuecomment
     end
 
     def type_class
@@ -14,7 +15,7 @@ class Ghn
     end
 
     def url
-      if comment?
+      if follow_issuecomment && comment?
         "https://github.com/#{repo_full_name}/#{type}/#{thread_number}#issuecomment-#{comment_number}"
       else
         "https://github.com/#{repo_full_name}/#{type}/#{thread_number}"

data/lib/ghn/version.rb

@@ -1,3 +1,3 @@
 class Ghn
-  VERSION = "2.0.0.pre4"
+  VERSION = "2.0.0.pre5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ghn
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre4
+  version: 2.0.0.pre5
 platform: ruby
 authors:
 - Kensuke Nagae
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-24 00:00:00.000000000 Z
+date: 2014-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor