gherkin_lint 0.3.1 → 0.4.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 5e776cabb83c6f00b485d9e88b7193bfd421ab79
+  data.tar.gz: 63e15be6fb1920e3a587b75163af5d18b959f3d3
+SHA512:
+  metadata.gz: 03ccf86a4b33104ba1cb5f65d98df1a72a660ebb27a53997be9c38b95a1271ea2ced2c55522e10dbd2a25c57e4d141ebcca647d6ffd1617885b9b6ddf5ae1e65
+  data.tar.gz: 31f0d3b395b1e4661d5d0705429c4a057008c719a0fcebffecf68b423e73778279d37d2f77cccdc0f7978787f48005e24dc0a566aa61820d46d5099db71b30fb

data/.rubocop.yml

@@ -1,24 +1,30 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-02-28 15:30:26 +0100 using RuboCop version 0.37.2.
+# on 2016-08-11 02:27:52 +0200 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 16
+
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 119
+  Max: 121
 
-# Offense count: 28
+# Offense count: 33
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 118
+  Max: 116
 
 # Offense count: 1
 # Cop supports --auto-correct.
-Performance/Casecmp:
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
   Exclude:
-    - 'lib/gherkin_lint/linter/invalid_file_name.rb'
+    - 'lib/gherkin_lint/linter/file_name_differs_feature_name.rb'

data/Gemfile

@@ -1,7 +1,7 @@
 source 'https://rubygems.org'
 gem 'aruba'
 gem 'amatch'
-gem 'gherkin', '=2.12.2'
+gem 'gherkin', '>=4.0.0'
 gem 'gherkin_format'
 gem 'gherkin_language'
 gem 'rake'

data/Rakefile

@@ -11,12 +11,12 @@ end
 
 desc 'Publishes the Gem'
 task :push do
-  sh 'gem push gherkin_lint-0.3.1.gem'
+  sh 'gem push gherkin_lint-0.4.0.gem'
 end
 
 desc 'Checks ruby style'
 task :rubocop do
-#  sh 'rubocop'
+  sh 'rubocop'
 end
 
 task test: :rubocop

data/gherkin_lint.gemspec

@@ -1,14 +1,14 @@
 Gem::Specification.new do |s|
   s.name        = 'gherkin_lint'
-  s.version     = '0.3.1'
-  s.date        = '2016-05-01'
+  s.version     = '0.4.0'
+  s.date        = '2016-08-11'
   s.summary     = 'Gherkin Lint'
   s.description = 'Lint Gherkin Files'
   s.authors     = ['Stefan Rohe']
   s.homepage    = 'http://github.com/funkwerk/gherkin_lint/'
   s.files       = `git ls-files`.split("\n")
   s.executables = s.files.grep(%r{^bin/}) { |file| File.basename(file) }
-  s.add_runtime_dependency 'gherkin', ['= 2.12.2']
+  s.add_runtime_dependency 'gherkin', ['>= 4.0.0']
   s.add_runtime_dependency 'term-ansicolor', ['>= 1.3.2']
   s.add_runtime_dependency 'amatch', ['>= 0.3.0']
   s.add_runtime_dependency 'engtagger', ['>=0.2.0']

data/lib/gherkin_lint.rb

@@ -1,7 +1,6 @@
-gem 'gherkin', '=2.12.2'
+gem 'gherkin', '>=4.0.0'
 
-require 'gherkin/formatter/json_formatter'
-require 'gherkin/parser/parser'
+require 'gherkin/parser'
 require 'gherkin_lint/linter/avoid_outline_for_single_example'
 require 'gherkin_lint/linter/avoid_period'
 require 'gherkin_lint/linter/avoid_scripting'
@@ -29,7 +28,6 @@ require 'gherkin_lint/linter/unknown_variable'
 require 'gherkin_lint/linter/unused_variable'
 require 'gherkin_lint/linter/use_background'
 require 'gherkin_lint/linter/use_outline'
-require 'stringio'
 require 'multi_json'
 require 'set'
 
@@ -102,8 +100,7 @@ module GherkinLint
     end
 
     def parse(file)
-      content = File.read file
-      to_json(content, file)
+      to_json File.read(file)
     end
 
     def report
@@ -122,13 +119,11 @@ module GherkinLint
       LINTER.map { |lint| "disable#{lint.new.class.name.split('::').last}" }
     end
 
-    def to_json(input, file = 'generated.feature')
-      io = StringIO.new
-      formatter = Gherkin::Formatter::JSONFormatter.new(io)
-      parser = Gherkin::Parser::Parser.new(formatter, true)
-      parser.parse(input, file, 0)
-      formatter.done
-      MultiJson.load io.string
+    def to_json(input)
+      parser = Gherkin::Parser.new
+      scanner = Gherkin::TokenScanner.new input
+
+      parser.parse(scanner)
     end
 
     def print(issues)

data/lib/gherkin_lint/linter.rb

@@ -13,9 +13,9 @@ module GherkinLint
 
     def features
       @files.each do |file, content|
-        content.each do |feature|
-          yield(file, feature)
-        end
+        feature = content[:feature]
+
+        yield(file, feature)
       end
     end
 
@@ -25,39 +25,40 @@ module GherkinLint
 
     def scenarios
       elements do |file, feature, scenario|
-        next if scenario['keyword'] == 'Background'
+        next if scenario[:type] == :Background
         yield(file, feature, scenario)
       end
     end
 
     def filled_scenarios
       scenarios do |file, feature, scenario|
-        next unless scenario.include? 'steps'
+        next unless scenario.include? :steps
         yield(file, feature, scenario)
       end
     end
 
     def steps
       elements do |file, feature, scenario|
-        next unless scenario.include? 'steps'
-        scenario['steps'].each { |step| yield(file, feature, scenario, step) }
+        next unless scenario.include? :steps
+        scenario[:steps].each { |step| yield(file, feature, scenario, step) }
       end
     end
 
     def backgrounds
       elements do |file, feature, scenario|
-        next unless scenario['keyword'] == 'Background'
+        next unless scenario[:type] == :Background
         yield(file, feature, scenario)
       end
     end
 
     def elements
       @files.each do |file, content|
-        content.each do |feature|
-          next unless feature.key? 'elements'
-          feature['elements'].each do |scenario|
-            yield(file, feature, scenario)
-          end
+        feature = content[:feature]
+
+        next if feature.nil?
+        next unless feature.key? :children
+        feature[:children].each do |scenario|
+          yield(file, feature, scenario)
         end
       end
     end
@@ -75,7 +76,8 @@ module GherkinLint
 
     def filter_tag(data, tag)
       return data.select { |item| !tag?(item, tag) }.map { |item| filter_tag(item, tag) } if data.class == Array
-      return data unless data.class == Hash
+      return {} if (data.class == Hash) && (data.include? :feature) && tag?(data[:feature], tag)
+      return data unless data.respond_to? :each_pair
       result = {}
 
       data.each_pair { |key, value| result[key] = filter_tag(value, tag) }
@@ -84,8 +86,8 @@ module GherkinLint
 
     def tag?(data, tag)
       return false if data.class != Hash
-      return false unless data.key? 'tags'
-      data['tags'].map { |item| item['name'] }.include? "@#{tag}"
+      return false unless data.include? :tags
+      data[:tags].map { |item| item[:name] }.include? "@#{tag}"
     end
 
     def suppress_tags(data, tags)
@@ -94,7 +96,7 @@ module GherkinLint
       result = {}
 
       data.each_pair do |key, value|
-        value = suppress(value, tags) if key == 'tags'
+        value = suppress(value, tags) if key == :tags
 
         result[key] = suppress_tags(value, tags)
       end
@@ -102,7 +104,7 @@ module GherkinLint
     end
 
     def suppress(data, tags)
-      data.select { |item| !tags.map { |tag| "@#{tag}" }.include? item['name'] }
+      data.select { |item| !tags.map { |tag| "@#{tag}" }.include? item[:name] }
     end
 
     def lint
@@ -110,17 +112,17 @@ module GherkinLint
     end
 
     def reference(file, feature = nil, scenario = nil, step = nil)
-      return file if feature.nil? || feature['name'].empty?
-      result = "#{file} (#{line(feature, scenario, step)}): #{feature['name']}"
-      result += ".#{scenario['name']}" unless scenario.nil? || scenario['name'].empty?
-      result += " step: #{step['name']}" unless step.nil?
+      return file if feature.nil? || feature[:name].empty?
+      result = "#{file} (#{line(feature, scenario, step)}): #{feature[:name]}"
+      result += ".#{scenario[:name]}" unless scenario.nil? || scenario[:name].empty?
+      result += " step: #{step[:text]}" unless step.nil?
       result
     end
 
     def line(feature, scenario, step)
-      line = feature.nil? ? nil : feature['line']
-      line = scenario['line'] unless scenario.nil?
-      line = step['line'] unless step.nil?
+      line = feature.nil? ? nil : feature[:location][:line]
+      line = scenario[:location][:line] unless scenario.nil?
+      line = step[:location][:line] unless step.nil?
       line
     end
 
@@ -133,19 +135,22 @@ module GherkinLint
     end
 
     def gather_tags(element)
-      return [] unless element.include? 'tags'
-      element['tags'].map { |tag| tag['name'][1..-1] }
+      return [] unless element.include? :tags
+      element[:tags].map { |tag| tag[:name][1..-1] }
     end
 
     def render_step(step)
-      value = "#{step['keyword']}#{step['name']}"
-      value += "\n#{step['doc_string']['value']}" if step.include? 'doc_string'
-      if step.include? 'rows'
-        value += step['rows'].map do |row|
-          row['cells'].join '|'
-        end.join "|\n"
-      end
+      value = "#{step[:keyword]}#{step[:text]}"
+      value += render_step_argument step[:argument] if step.include? :argument
       value
     end
+
+    def render_step_argument(argument)
+      return "\n#{argument[:content]}" if argument[:type] == :DocString
+      result = argument[:rows].map do |row|
+        "|#{row[:cells].map { |cell| cell[:value] }.join '|'}|"
+      end.join "\n"
+      "\n#{result}"
+    end
   end
 end

data/lib/gherkin_lint/linter/avoid_outline_for_single_example.rb

@@ -5,11 +5,11 @@ module GherkinLint
   class AvoidOutlineForSingleExample < Linter
     def lint
       scenarios do |file, feature, scenario|
-        next unless scenario['keyword'] == 'Scenario Outline'
+        next unless scenario[:type] == :ScenarioOutline
 
-        next unless scenario.key? 'examples'
-        next if scenario['examples'].length > 1
-        next if scenario['examples'].first['rows'].length > 2
+        next unless scenario.key? :examples
+        next if scenario[:examples].length > 1
+        next if scenario[:examples].first[:tableBody].length > 1
 
         references = [reference(file, feature, scenario)]
         add_error(references, 'Better write a scenario')

data/lib/gherkin_lint/linter/avoid_period.rb

@@ -5,11 +5,11 @@ module GherkinLint
   class AvoidPeriod < Linter
     def lint
       scenarios do |file, feature, scenario|
-        next unless scenario.key? 'steps'
+        next unless scenario.key? :steps
 
-        scenario['steps'].each do |step|
+        scenario[:steps].each do |step|
           references = [reference(file, feature, scenario, step)]
-          add_error(references) if step['name'].strip.end_with? '.'
+          add_error(references) if step[:text].strip.end_with? '.'
         end
       end
     end

data/lib/gherkin_lint/linter/avoid_scripting.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class AvoidScripting < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        steps = filter_when_steps scenario['steps']
+        steps = filter_when_steps scenario[:steps]
 
         next if steps.length <= 1
         references = [reference(file, feature, scenario)]
@@ -14,9 +14,9 @@ module GherkinLint
     end
 
     def filter_when_steps(steps)
-      steps = steps.drop_while { |step| step['keyword'] != 'When ' }
-      steps = steps.reverse.drop_while { |step| step['keyword'] != 'Then ' }.reverse
-      steps.select { |step| step['keyword'] != 'Then ' }
+      steps = steps.drop_while { |step| step[:keyword] != 'When ' }
+      steps = steps.reverse.drop_while { |step| step[:keyword] != 'Then ' }.reverse
+      steps.select { |step| step[:keyword] != 'Then ' }
     end
   end
 end

data/lib/gherkin_lint/linter/background_does_more_than_setup.rb

@@ -5,8 +5,8 @@ module GherkinLint
   class BackgroundDoesMoreThanSetup < Linter
     def lint
       backgrounds do |file, feature, background|
-        next unless background.key? 'steps'
-        invalid_steps = background['steps'].select { |step| step['keyword'] == 'When ' || step['keyword'] == 'Then ' }
+        next unless background.key? :steps
+        invalid_steps = background[:steps].select { |step| step[:keyword] == 'When ' || step[:keyword] == 'Then ' }
         next if invalid_steps.empty?
         references = [reference(file, feature, background, invalid_steps[0])]
         add_error(references, 'Just Given Steps allowed')

data/lib/gherkin_lint/linter/background_requires_multiple_scenarios.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class BackgroundRequiresMultipleScenarios < Linter
     def lint
       backgrounds do |file, feature, background|
-        scenarios = feature['elements'].select { |element| element['keyword'] != 'Background' }
+        scenarios = feature[:children].select { |element| element[:type] != :Background }
         next if scenarios.length >= 2
 
         references = [reference(file, feature, background)]

data/lib/gherkin_lint/linter/bad_scenario_name.rb

@@ -5,12 +5,12 @@ module GherkinLint
   class BadScenarioName < Linter
     def lint
       scenarios do |file, feature, scenario|
-        next if scenario['name'].empty?
+        next if scenario[:name].empty?
         references = [reference(file, feature, scenario)]
         description = 'Prefer to rely just on Given and When steps when name your scenario to keep it stable'
         bad_words = %w(test verif check)
         bad_words.each do |bad_word|
-          add_error(references, description) if scenario['name'].downcase.include? bad_word
+          add_error(references, description) if scenario[:name].downcase.include? bad_word
         end
       end
     end

data/lib/gherkin_lint/linter/be_declarative.rb

@@ -10,7 +10,7 @@ module GherkinLint
 
     def lint
       filled_scenarios do |file, feature, scenario|
-        scenario['steps'].each do |step|
+        scenario[:steps].each do |step|
           references = [reference(file, feature, scenario, step)]
           add_warning(references, 'no verb') unless verb? step
         end
@@ -18,7 +18,7 @@ module GherkinLint
     end
 
     def verb?(step)
-      tagged = tagger.add_tags step['name']
+      tagged = tagger.add_tags step[:text]
       step_verbs = verbs tagged
 
       !step_verbs.empty?

data/lib/gherkin_lint/linter/file_name_differs_feature_name.rb

@@ -5,9 +5,9 @@ module GherkinLint
   class FileNameDiffersFeatureName < Linter
     def lint
       features do |file, feature|
-        next unless feature.include? 'name'
+        next unless feature.include? :name
         expected_feature_name = title_case file
-        next if feature['name'].casecmp(expected_feature_name) == 0
+        next if feature[:name].casecmp(expected_feature_name) == 0
         references = [reference(file, feature)]
         add_error(references, "Feature name should be '#{expected_feature_name}'")
       end

data/lib/gherkin_lint/linter/invalid_step_flow.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class InvalidStepFlow < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        steps = scenario['steps'].select { |step| step['keyword'] != 'And ' && step['keyword'] != 'But ' }
+        steps = scenario[:steps].select { |step| step[:keyword] != 'And ' && step[:keyword] != 'But ' }
         last_step_is_an_action(file, feature, scenario, steps)
         given_after_non_given(file, feature, scenario, steps)
         verification_before_action(file, feature, scenario, steps)
@@ -14,7 +14,7 @@ module GherkinLint
 
     def last_step_is_an_action(file, feature, scenario, steps)
       references = [reference(file, feature, scenario, steps.last)]
-      add_error(references, 'Last step is an action') if steps.last['keyword'] == 'When '
+      add_error(references, 'Last step is an action') if steps.last[:keyword] == 'When '
     end
 
     def given_after_non_given(file, feature, scenario, steps)
@@ -22,16 +22,16 @@ module GherkinLint
       steps.each do |step|
         references = [reference(file, feature, scenario, step)]
         description = 'Given after Action or Verification'
-        add_error(references, description) if step['keyword'] == 'Given ' && last_step['keyword'] != 'Given '
+        add_error(references, description) if step[:keyword] == 'Given ' && last_step[:keyword] != 'Given '
         last_step = step
       end
     end
 
     def verification_before_action(file, feature, scenario, steps)
       steps.each do |step|
-        break if step['keyword'] == 'When '
+        break if step[:keyword] == 'When '
         references = [reference(file, feature, scenario, step)]
-        add_error(references, 'Missing Action') if step['keyword'] == 'Then '
+        add_error(references, 'Missing Action') if step[:keyword] == 'Then '
       end
     end
   end

data/lib/gherkin_lint/linter/missing_example_name.rb

@@ -5,10 +5,10 @@ module GherkinLint
   class MissingExampleName < Linter
     def lint
       scenarios do |file, feature, scenario|
-        next unless scenario.key? 'examples'
-        next unless scenario['examples'].length > 1
-        scenario['examples'].each do |example|
-          name = example.key?('name') ? example['name'].strip : ''
+        next unless scenario.key? :examples
+        next unless scenario[:examples].length > 1
+        scenario[:examples].each do |example|
+          name = example.key?(:name) ? example[:name].strip : ''
           next unless name.empty?
           references = [reference(file, feature, scenario)]
           add_error(references, 'No Example Name')

data/lib/gherkin_lint/linter/missing_feature_description.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class MissingFeatureDescription < Linter
     def lint
       features do |file, feature|
-        name = feature.key?('description') ? feature['description'].strip : ''
+        name = feature.key?(:description) ? feature[:description].strip : ''
         next unless name.empty?
         references = [reference(file, feature)]
         add_error(references, 'Favor a user story as description')

data/lib/gherkin_lint/linter/missing_feature_name.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class MissingFeatureName < Linter
     def lint
       features do |file, feature|
-        name = feature.key?('name') ? feature['name'].strip : ''
+        name = feature.key?(:name) ? feature[:name].strip : ''
         next unless name.empty?
         references = [reference(file, feature)]
         add_error(references, 'No Feature Name')

data/lib/gherkin_lint/linter/missing_scenario_name.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class MissingScenarioName < Linter
     def lint
       scenarios do |file, feature, scenario|
-        name = scenario.key?('name') ? scenario['name'].strip : ''
+        name = scenario.key?(:name) ? scenario[:name].strip : ''
         references = [reference(file, feature, scenario)]
         next unless name.empty?
         add_error(references, 'No Scenario Name')

data/lib/gherkin_lint/linter/missing_test_action.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class MissingTestAction < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        when_steps = scenario['steps'].select { |step| step['keyword'] == 'When ' }
+        when_steps = scenario[:steps].select { |step| step[:keyword] == 'When ' }
         next unless when_steps.empty?
         references = [reference(file, feature, scenario)]
         add_error(references, 'No \'When\'-Step')

data/lib/gherkin_lint/linter/missing_verification.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class MissingVerification < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        then_steps = scenario['steps'].select { |step| step['keyword'] == 'Then ' }
+        then_steps = scenario[:steps].select { |step| step[:keyword] == 'Then ' }
         next unless then_steps.empty?
         references = [reference(file, feature, scenario)]
         add_error(references, 'No verification step')

data/lib/gherkin_lint/linter/same_tag_for_all_scenarios.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class SameTagForAllScenarios < Linter
     def lint
       features do |file, feature|
-        next unless feature.include? 'elements'
+        next unless feature.include? :children
 
         lint_scenarios file, feature
         lint_examples file, feature
@@ -16,7 +16,7 @@ module GherkinLint
       tags = gather_same_tags feature
       return if tags.nil?
       return if tags.empty?
-      return unless feature['elements'].length > 1
+      return unless feature[:children].length > 1
       references = [reference(file, feature)]
       tags.each do |tag|
         next if tag == '@skip'
@@ -26,10 +26,10 @@ module GherkinLint
     end
 
     def lint_examples(file, feature)
-      feature['elements'].each do |scenario|
+      feature[:children].each do |scenario|
         tags = gather_same_tags_for_outline scenario
         next if tags.nil? || tags.empty?
-        next unless scenario['examples'].length > 1
+        next unless scenario[:examples].length > 1
         references = [reference(file, feature, scenario)]
         tags.each do |tag|
           next if tag == '@skip'
@@ -41,10 +41,10 @@ module GherkinLint
 
     def gather_same_tags(feature)
       result = nil
-      feature['elements'].each do |scenario|
-        next if scenario['keyword'] == 'Background'
-        return nil unless scenario.include? 'tags'
-        tags = scenario['tags'].map { |tag| tag['name'] }
+      feature[:children].each do |scenario|
+        next if scenario[:type] == :Background
+        return nil unless scenario.include? :tags
+        tags = scenario[:tags].map { |tag| tag[:name] }
         result = tags if result.nil?
         result &= tags
       end
@@ -53,10 +53,10 @@ module GherkinLint
 
     def gather_same_tags_for_outline(scenario)
       result = nil
-      return result unless scenario.include? 'examples'
-      scenario['examples'].each do |example|
-        return nil unless example.include? 'tags'
-        tags = example['tags'].map { |tag| tag['name'] }
+      return result unless scenario.include? :examples
+      scenario[:examples].each do |example|
+        return nil unless example.include? :tags
+        tags = example[:tags].map { |tag| tag[:name] }
         result = tags if result.nil?
         result &= tags
       end

data/lib/gherkin_lint/linter/too_clumsy.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class TooClumsy < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        characters = scenario['steps'].map { |step| step['name'].length }.inject(0, :+)
+        characters = scenario[:steps].map { |step| step[:text].length }.inject(0, :+)
         next if characters < 400
         references = [reference(file, feature, scenario)]
         add_error(references, "Used #{characters} Characters")

data/lib/gherkin_lint/linter/too_long_step.rb

@@ -5,9 +5,9 @@ module GherkinLint
   class TooLongStep < Linter
     def lint
       steps do |file, feature, scenario, step|
-        next if step['name'].length < 80
+        next if step[:text].length < 80
         references = [reference(file, feature, scenario, step)]
-        add_error(references, "Used #{step['name'].length} characters")
+        add_error(references, "Used #{step[:text].length} characters")
       end
     end
   end

data/lib/gherkin_lint/linter/too_many_different_tags.rb

@@ -31,8 +31,8 @@ module GherkinLint
     end
 
     def tags_for_feature(feature)
-      return [] unless feature.include? 'elements'
-      gather_tags(feature) + feature['elements'].map { |scenario| gather_tags(scenario) }.flatten
+      return [] unless feature.include? :children
+      gather_tags(feature) + feature[:children].map { |scenario| gather_tags(scenario) }.flatten
     end
   end
 end

data/lib/gherkin_lint/linter/too_many_steps.rb

@@ -5,9 +5,9 @@ module GherkinLint
   class TooManySteps < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        next if scenario['steps'].length < 10
+        next if scenario[:steps].length < 10
         references = [reference(file, feature, scenario)]
-        add_error(references, "Used #{scenario['steps'].length} Steps")
+        add_error(references, "Used #{scenario[:steps].length} Steps")
       end
     end
   end

data/lib/gherkin_lint/linter/unique_scenario_names.rb

@@ -6,8 +6,8 @@ module GherkinLint
     def lint
       references_by_name = Hash.new []
       scenarios do |file, feature, scenario|
-        next unless scenario.key? 'name'
-        scenario_name = "#{feature['name']}.#{scenario['name']}"
+        next unless scenario.key? :name
+        scenario_name = "#{feature[:name]}.#{scenario[:name]}"
         references_by_name[scenario_name] = references_by_name[scenario_name] + [reference(file, feature, scenario)]
       end
       references_by_name.each do |name, references|

data/lib/gherkin_lint/linter/unknown_variable.rb

@@ -6,7 +6,7 @@ module GherkinLint
     def lint
       filled_scenarios do |file, feature, scenario|
         known_vars = Set.new known_variables scenario
-        scenario['steps'].each do |step|
+        scenario[:steps].each do |step|
           step_vars(step).each do |used_var|
             next if known_vars.include? used_var
             references = [reference(file, feature, scenario)]
@@ -17,10 +17,15 @@ module GherkinLint
     end
 
     def step_vars(step)
-      vars = gather_vars step['name']
-      vars += gather_vars step['doc_string']['value'] if step.key? 'doc_string'
-      vars + (step['rows'] || []).map do |row|
-        row['cells'].map { |value| gather_vars value }.flatten
+      vars = gather_vars step[:text]
+      return vars unless step.include? :argument
+      vars + gather_vars_from_argument(step[:argument])
+    end
+
+    def gather_vars_from_argument(argument)
+      return gather_vars argument[:content] if argument[:type] == :DocString
+      (argument[:rows] || []).map do |row|
+        row[:cells].map { |value| gather_vars value[:value] }.flatten
       end.flatten
     end
 
@@ -29,9 +34,9 @@ module GherkinLint
     end
 
     def known_variables(scenario)
-      (scenario['examples'] || []).map do |example|
-        next unless example.key? 'rows'
-        example['rows'].first['cells'].map(&:strip)
+      (scenario[:examples] || []).map do |example|
+        next unless example.key? :tableHeader
+        example[:tableHeader][:cells].map { |cell| cell[:value].strip }
       end.flatten
     end
   end

data/lib/gherkin_lint/linter/unused_variable.rb

@@ -5,10 +5,10 @@ module GherkinLint
   class UnusedVariable < Linter
     def lint
       scenarios do |file, feature, scenario|
-        next unless scenario.key? 'examples'
-        scenario['examples'].each do |example|
-          next unless example.key? 'rows'
-          example['rows'].first['cells'].each do |variable|
+        next unless scenario.key? :examples
+        scenario[:examples].each do |example|
+          next unless example.key? :tableHeader
+          example[:tableHeader][:cells].map { |cell| cell[:value] }.each do |variable|
             references = [reference(file, feature, scenario)]
             add_error(references, "'<#{variable}>' is unused") unless used?(variable, scenario)
           end
@@ -18,9 +18,10 @@ module GherkinLint
 
     def used?(variable, scenario)
       variable = "<#{variable}>"
-      return false unless scenario.key? 'steps'
-      scenario['steps'].each do |step|
-        return true if step['name'].include? variable
+      return false unless scenario.key? :steps
+      scenario[:steps].each do |step|
+        return true if step[:text].include? variable
+        next unless step.include? :argument
         return true if used_in_docstring?(variable, step)
         return true if used_in_table?(variable, step)
       end
@@ -28,13 +29,13 @@ module GherkinLint
     end
 
     def used_in_docstring?(variable, step)
-      step.key?('doc_string') && step['doc_string']['value'].include?(variable)
+      step[:argument][:type] == :DocString && step[:argument][:content].include?(variable)
     end
 
     def used_in_table?(variable, step)
-      return false unless step.key? 'rows'
-      step['rows'].each do |row|
-        row['cells'].each { |value| return true if value.include?(variable) }
+      return false unless step[:argument][:type] == :DataTable
+      step[:argument][:rows].each do |row|
+        row[:cells].each { |value| return true if value[:value].include?(variable) }
       end
       false
     end

data/lib/gherkin_lint/linter/use_background.rb

@@ -17,20 +17,20 @@ module GherkinLint
 
     def scenarios_with_steps(feature)
       scenarios = 0
-      return 0 unless feature.key? 'elements'
-      feature['elements'].each do |scenario|
-        next unless scenario.include? 'steps'
+      return 0 unless feature.key? :children
+      feature[:children].each do |scenario|
+        next unless scenario.include? :steps
         scenarios += 1
       end
       scenarios
     end
 
     def gather_givens(feature)
-      return unless feature.include? 'elements'
+      return unless feature.include? :children
       has_non_given_step = false
-      feature['elements'].each do |scenario|
-        next unless scenario.include? 'steps'
-        has_non_given_step = true unless scenario['steps'].first['keyword'] == 'Given '
+      feature[:children].each do |scenario|
+        next unless scenario.include? :steps
+        has_non_given_step = true unless scenario[:steps].first[:keyword] == 'Given '
       end
       return if has_non_given_step
 
@@ -40,11 +40,11 @@ module GherkinLint
     end
 
     def expanded_steps(feature)
-      feature['elements'].each do |scenario|
-        next unless scenario['keyword'] != 'Background'
-        next unless scenario.include? 'steps'
-        prototypes = [render_step(scenario['steps'].first)]
-        prototypes = expand_examples(scenario['examples'], prototypes) if scenario.key? 'examples'
+      feature[:children].each do |scenario|
+        next unless scenario[:type] != :Background
+        next unless scenario.include? :steps
+        prototypes = [render_step(scenario[:steps].first)]
+        prototypes = expand_examples(scenario[:examples], prototypes) if scenario.key? :examples
         prototypes.each { |prototype| yield prototype }
       end
     end
@@ -58,10 +58,12 @@ module GherkinLint
 
     def expand_outlines(sentence, example)
       result = []
-      headers = example['rows'][0]['cells']
-      example['rows'].slice(1, example['rows'].length).each do |row|
+      headers = example[:tableHeader][:cells].map { |cell| cell[:value] }
+      example[:tableBody].each do |row| # .slice(1, example[:tableBody].length).each do |row|
         modified_sentence = sentence.dup
-        headers.zip(row['cells']).map { |key, value| modified_sentence.gsub!("<#{key}>", value) }
+        headers.zip(row[:cells].map { |cell| cell[:value] }).map do |key, value|
+          modified_sentence.gsub!("<#{key}>", value)
+        end
         result.push modified_sentence
       end
       result

data/lib/gherkin_lint/linter/use_outline.rb

@@ -28,10 +28,10 @@ module GherkinLint
 
     def gather_scenarios(file, feature)
       scenarios = []
-      return scenarios unless feature.include? 'elements'
-      feature['elements'].each do |scenario|
-        next unless scenario['keyword'] == 'Scenario'
-        next unless scenario.include? 'steps'
+      return scenarios unless feature.include? :children
+      feature[:children].each do |scenario|
+        next unless scenario[:type] == :Scenario
+        next unless scenario.include? :steps
         scenarios.push generate_reference(file, feature, scenario)
       end
       scenarios
@@ -40,7 +40,7 @@ module GherkinLint
     def generate_reference(file, feature, scenario)
       reference = {}
       reference[:reference] = reference(file, feature, scenario)
-      reference[:text] = scenario['steps'].map { |step| render_step(step) }.join ' '
+      reference[:text] = scenario[:steps].map { |step| render_step(step) }.join ' '
       reference
     end
   end

metadata

@@ -1,94 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: gherkin_lint
 version: !ruby/object:Gem::Version
-  version: 0.3.1
-  prerelease: 
+  version: 0.4.0
 platform: ruby
 authors:
 - Stefan Rohe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-01 00:00:00.000000000 Z
+date: 2016-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.12.2
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.12.2
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: term-ansicolor
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.2
 - !ruby/object:Gem::Dependency
   name: amatch
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: engtagger
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.2
 description: Lint Gherkin Files
@@ -98,8 +87,8 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .rubocop.yml
-- .travis.yml
+- ".rubocop.yml"
+- ".travis.yml"
 - Dockerfile
 - Gemfile
 - Guardfile
@@ -169,26 +158,25 @@ files:
 - lib/gherkin_lint/linter/use_outline.rb
 homepage: http://github.com/funkwerk/gherkin_lint/
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Gherkin Lint
 test_files: []