gherkin_lint 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ada6bfa04c433aad9b3d227c5ae836b79d0dc7c
-  data.tar.gz: 22345665cd0d4f7985f22ba857ae8a6d61cd3713
+  metadata.gz: 0115886cf68f342c7e96db6fed9b810821d39586
+  data.tar.gz: bc8c412c92394916145f3b4998e1455a942f1ef0
 SHA512:
-  metadata.gz: dce80fc451a1cecbd88da1a7efdc27d8e1d35fd3674a10865082f1d42b6156ecea8827132dd8772d0afba59237e969e5974ebb4e19c89639d9731370e0483739
-  data.tar.gz: 7814679c1fbefbfdf15870578adeffd530a849fb62c01c94ebb36dea68a26c395a91eea505cbf1aef86f44f9301324bfb38e616eb50f2e3d71609c7e624da5cc
+  metadata.gz: 5b1fb9da007d9908a43ea4ae5d7b9c4cad6604b9030306e9a254cab5cc0680011b2de551bf16a2556951620cfc82279b2521f11e8ee53e8b4cc5088c6b5fa0df
+  data.tar.gz: 1f5c003ef09b1bb24bf732816a43982ca7605ce541a60af1971094f694e3b30d03551e3de2fe87ef4fe1b2b97ef6234ec112d277c1bda2e2369d130aa0db3219

data/lib/gherkin_lint.rb

@@ -146,7 +146,7 @@ class GherkinLint
     end
   end
 
-  # service class to lint for backgrond that does more than setup
+  # service class to lint for background that does more than setup
   class BackgroundDoesMoreThanSetup < Linter
     def lint
       backgrounds do |file, feature, background|
@@ -159,6 +159,19 @@ class GherkinLint
     end
   end
 
+  # service class to lint for background requires multiple scenario
+  class BackgroundRequiresMultipleScenarios < Linter
+    def lint
+      backgrounds do |file, feature, background|
+        scenarios = feature['elements'].select { |element| element['keyword'] != 'Background' }
+        next if scenarios.length >= 2
+
+        references = [reference(file, feature, background)]
+        add_issue(references, "There are just #{scenarios.length} scenarios")
+      end
+    end
+  end
+
   # service class to lint for missing feature names
   class MissingFeatureName < Linter
     def lint
@@ -241,14 +254,14 @@ class GherkinLint
       steps.each do |step|
         break if step['keyword'] == 'When '
         references = [reference(file, feature, scenario, step)]
-        description = 'Verification before action'
+        description = 'Missing Action'
         add_issue(references, description) if step['keyword'] == 'Then '
       end
     end
   end
 
-  # service class to lint for invalid scenario names
-  class InvalidScenarioName < Linter
+  # service class to lint for bad scenario names
+  class BadScenarioName < Linter
     def lint
       scenarios do |file, feature, scenario|
         next if scenario['name'].empty?
@@ -267,13 +280,52 @@ class GherkinLint
     def lint
       files do |file|
         base = File.basename file
-        next if base == base.downcase
+        next unless base != base.downcase || base =~ /[ -]/
         references = [reference(file)]
         add_issue(references, 'Feature files should be snake_cased')
       end
     end
   end
 
+  # service class to lint for unknown variables
+  class UnknownVariable < Linter
+    def lint
+      scenarios do |file, feature, scenario|
+        known_vars = known_variables scenario
+        scenario['steps'].each do |step|
+          step_vars(step).each do |used_var|
+            next if known_vars.include? used_var
+            references = [reference(file, feature, scenario)]
+            add_issue(references, "'<#{used_var}>' is unknown")
+          end
+        end
+      end
+    end
+
+    def step_vars(step)
+      vars = gather_vars step['name']
+      vars += gather_vars step['doc_string']['value'] if step.key? 'doc_string'
+      if step.key? 'rows'
+        vars += step['rows'].map do |row|
+          row['cells'].map { |value| gather_vars value }.flatten
+        end.flatten
+      end
+      vars
+    end
+
+    def gather_vars(string)
+      string.scan(/<.+>/).map { |val| val[1..-2] }
+    end
+
+    def known_variables(scenario)
+      return Set.new unless scenario.key? 'examples'
+      Set.new(scenario['examples'].map do |example|
+        next unless example.key? 'rows'
+        example['rows'].first['cells'].map(&:strip)
+      end.flatten)
+    end
+  end
+
   # service class to lint for unused variables
   class UnusedVariable < Linter
     def lint
@@ -313,8 +365,8 @@ class GherkinLint
     end
   end
 
-  # service class to lint for avoiding colons
-  class AvoidColon < Linter
+  # service class to lint for avoiding periods
+  class AvoidPeriod < Linter
     def lint
       scenarios do |file, feature, scenario|
         next unless scenario.key? 'steps'
@@ -328,8 +380,10 @@ class GherkinLint
   end
 
   LINTER = [
-    AvoidColon,
+    AvoidPeriod,
     BackgroundDoesMoreThanSetup,
+    BackgroundRequiresMultipleScenarios,
+    BadScenarioName,
     MissingExampleName,
     MissingFeatureDescription,
     MissingFeatureName,
@@ -337,9 +391,9 @@ class GherkinLint
     MissingTestAction,
     MissingVerification,
     InvalidFileName,
-    InvalidScenarioName,
     InvalidStepFlow,
     UniqueScenarioNames,
+    UnknownVariable,
     UnusedVariable
   ]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gherkin_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Stefan Rohe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-02 00:00:00.000000000 Z
+date: 2015-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin