gherkin_lint 0.0.12 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e189dc06dc67de9babbb162719f6a6076e7fdca
-  data.tar.gz: 67b05bc5a362173d4224a851a2bf9e4fb7dd0717
+  metadata.gz: 9f6a87e94f184beadb3e93477e179de06cabd490
+  data.tar.gz: 051d3c873a7089ff9981738391a848cb8b77f7f2
 SHA512:
-  metadata.gz: c26e21bf005148159ce63c68f66528bd4778727cc78fad916ff05af61229fba638b108ddaa0c88f5c2fab7313e25f262ea95d04a7b01d15f138977d0707b91b8
-  data.tar.gz: e995a0d94ee6ad6199ea24461c89f53c4f2dea05b640bc2da542a227c949f8fce361cd743bcf07045ffd06834d0f786dafcec82bd65ad48e5bc248513edd0487
+  metadata.gz: 8b13bf8e881f58d0e5a53d72c5449c4feb17272f065b60d807887047af1a6aba8ebba2ff41692eafe9e76cd6805b97398758048a1ec67ed2f2f597921eee8493
+  data.tar.gz: b96ccffdae892aae560a77c5bc4c4ca9f5ecaa556dbbb46478c1ca775f1bf0f95182c85996f05b939f9268a1608f0df24857f0dec235b574e1606694a07773a8

data/Dockerfile

@@ -0,0 +1,5 @@
+FROM ruby
+MAINTAINER think@hotmail.de
+
+RUN gem install gherkin_lint --no-format-exec
+CMD gherkin_lint

data/Gemfile

@@ -1,7 +1,7 @@
 source 'https://rubygems.org'
 gem 'aruba'
 gem 'amatch'
-gem 'gherkin'
+gem 'gherkin', '=2.12.2'
 gem 'gherkin_format'
 gem 'gherkin_language'
 gem 'rake'

data/README.md

@@ -1,6 +1,7 @@
 # Lint Gherkin Files
 
 [![Build Status](https://travis-ci.org/funkwerk/gherkin_lint.svg)](https://travis-ci.org/funkwerk/gherkin_lint)
+[![Code Climate](https://codeclimate.com/github/funkwerk/gherkin_lint/badges/gpa.svg)](https://codeclimate.com/github/funkwerk/gherkin_lint)
 
 This tool lints gherkin files.
 

data/Rakefile

@@ -11,7 +11,7 @@ end
 
 desc 'Publishes the Gem'
 task :push do
-  sh 'gem push gherkin_lint-0.0.11.gem'
+  sh 'gem push gherkin_lint-0.0.13.gem'
 end
 
 desc 'Checks ruby style'

data/features/support/env.rb

@@ -1,5 +1,5 @@
 require 'aruba/cucumber'
 
 Before do
-  @aruba_timeout_seconds = 10  # too slow on sloppy machines
+  @aruba_timeout_seconds = 10 # too slow on sloppy machines
 end

data/features/unknown_variable.feature

@@ -35,6 +35,23 @@ Feature: Unknown Variable
 
       """
 
+  Scenario: Unknown Step Variable Even For Missing Examples
+    Given a file named "lint.feature" with:
+      """
+      Feature: Test
+        Scenario Outline: A
+          When <baz> and <bar>
+      """
+    When I run `ruby lint.rb`
+    Then it should fail with exactly:
+      """
+      UnknownVariable - '<baz>' is unknown
+        lint.feature (2): Test.A
+      UnknownVariable - '<bar>' is unknown
+        lint.feature (2): Test.A
+
+      """
+
   Scenario: Unknown Table Variable
     Given a file named "lint.feature" with:
       """

data/gherkin_lint.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = 'gherkin_lint'
-  s.version     = '0.0.12'
-  s.date        = '2015-07-26'
+  s.version     = '0.0.13'
+  s.date        = '2016-01-17'
   s.summary     = 'Gherkin Lint'
   s.description = 'Lint Gherkin Files'
   s.authors     = ['Stefan Rohe']

data/lib/gherkin_lint.rb

@@ -1,3 +1,5 @@
+gem 'gherkin', '=2.12.2'
+
 require 'gherkin/formatter/json_formatter'
 require 'gherkin/parser/parser'
 require 'gherkin_lint/linter/avoid_outline_for_single_example'
@@ -58,7 +60,7 @@ module GherkinLint
       UnusedVariable,
       UseBackground,
       UseOutline
-    ]
+    ].freeze
 
     def initialize
       @files = {}
@@ -71,29 +73,26 @@ module GherkinLint
     end
 
     def enable(enabled_linter)
-      @linter = []
-      enabled_linter = Set.new enabled_linter
-      LINTER.each do |linter|
-        new_linter = linter.new
-        next unless enabled_linter.include? new_linter.class.name.split('::').last
-        register_linter new_linter
-      end
+      set_linter(enabled_linter)
     end
 
     def disable(disabled_linter)
+      set_linter([], disabled_linter)
+    end
+
+    def set_linter(enabled_linter, disabled_linter = [])
       @linter = []
+      enabled_linter = Set.new enabled_linter
       disabled_linter = Set.new disabled_linter
       LINTER.each do |linter|
         new_linter = linter.new
-        next if disabled_linter.include? new_linter.class.name.split('::').last
-        register_linter new_linter
+        name = new_linter.class.name.split('::').last
+        next unless enabled_linter.include? name
+        next if disabled_linter.include? name
+        @linter.push new_linter
       end
     end
 
-    def register_linter(linter)
-      @linter.push linter
-    end
-
     def analyze(file)
       @files[file] = parse file
     end

data/lib/gherkin_lint/linter.rb

@@ -24,42 +24,38 @@ module GherkinLint
     end
 
     def scenarios
-      @files.each do |file, content|
-        content.each do |feature|
-          next unless feature.key? 'elements'
-          feature['elements'].each do |scenario|
-            next if scenario['keyword'] == 'Background'
-            yield(file, feature, scenario)
-          end
-        end
+      elements do |file, feature, scenario|
+        next if scenario['keyword'] == 'Background'
+        yield(file, feature, scenario)
       end
     end
 
     def filled_scenarios
       scenarios do |file, feature, scenario|
         next unless scenario.include? 'steps'
-        yield(file, feature, scenario)  
+        yield(file, feature, scenario)
       end
     end
 
     def steps
-      @files.each do |file, content|
-        content.each do |feature|
-          next unless feature.key? 'elements'
-          feature['elements'].each do |scenario|
-            next unless scenario.include? 'steps'
-            scenario['steps'].each { |step| yield(file, feature, scenario, step) }
-          end
-        end
+      elements do |file, feature, scenario|
+        next unless scenario.include? 'steps'
+        scenario['steps'].each { |step| yield(file, feature, scenario, step) }
       end
     end
 
     def backgrounds
+      elements do |file, feature, scenario|
+        next unless scenario['keyword'] == 'Background'
+        yield(file, feature, scenario)
+      end
+    end
+
+    def elements
       @files.each do |file, content|
         content.each do |feature|
           next unless feature.key? 'elements'
           feature['elements'].each do |scenario|
-            next unless scenario['keyword'] == 'Background'
             yield(file, feature, scenario)
           end
         end

data/lib/gherkin_lint/linter/unknown_variable.rb

@@ -5,7 +5,7 @@ module GherkinLint
   class UnknownVariable < Linter
     def lint
       filled_scenarios do |file, feature, scenario|
-        known_vars = known_variables scenario
+        known_vars = Set.new known_variables scenario
         scenario['steps'].each do |step|
           step_vars(step).each do |used_var|
             next if known_vars.include? used_var
@@ -19,12 +19,9 @@ module GherkinLint
     def step_vars(step)
       vars = gather_vars step['name']
       vars += gather_vars step['doc_string']['value'] if step.key? 'doc_string'
-      if step.key? 'rows'
-        vars += step['rows'].map do |row|
-          row['cells'].map { |value| gather_vars value }.flatten
-        end.flatten
-      end
-      vars
+      vars + (step['rows'] || []).map do |row|
+        row['cells'].map { |value| gather_vars value }.flatten
+      end.flatten
     end
 
     def gather_vars(string)
@@ -32,11 +29,10 @@ module GherkinLint
     end
 
     def known_variables(scenario)
-      return Set.new unless scenario.key? 'examples'
-      Set.new(scenario['examples'].map do |example|
+      (scenario['examples'] || []).map do |example|
         next unless example.key? 'rows'
         example['rows'].first['cells'].map(&:strip)
-      end.flatten)
+      end.flatten
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gherkin_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors:
 - Stefan Rohe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-26 00:00:00.000000000 Z
+date: 2016-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".rubocop.yml"
 - ".travis.yml"
+- Dockerfile
 - Gemfile
 - Guardfile
 - LICENSE
@@ -155,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.3
+rubygems_version: 2.2.5
 signing_key: 
 specification_version: 4
 summary: Gherkin Lint