gherkin_lint 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 11cc0a47c8a7370b13d39e6d4dc5fcaa3b053107
-  data.tar.gz: f6bb350fc776da6541e866596f431335d77421c5
+  metadata.gz: 2e4d03b90d6a2f4bd7636cac2dd5431826c9d24d
+  data.tar.gz: 2aedfa50a7bf08385172fa3aa0be2abf10b678a2
 SHA512:
-  metadata.gz: 529b9779a5e7e05269b6bf41dd06a4b8cc47f11f5a175a3d7631fc5b54e8d6346adc7c2e204cdac94a4b0c7a1077408b7fa0329fb8f71bb267a9987f0d0844a5
-  data.tar.gz: 51c2705c48aa1f5b6d0336a3070abeedc7dc0a63273818f47f61c9090a5a635b86dc27342720f26df95e6e3062805f3c733ba3141cc1ebdece99234d317d9516
+  metadata.gz: 0b83df2773e425662bd91751a4fc4e69cf537c8818cf006807d9cee20d8f8d95dbb15473fe45e53ed67748989025e9aeea12fcc86ff3abde9fdba45cfa9be795
+  data.tar.gz: 907364cb9b95b90dc1d1a1beaa0c2a03a6ba9d6366d44a724d5398192d862a1c3df4ea6c8bdba7f8f8086cc0d1d032ca46abf99d73e0ad331275bd6d7f9692f3

data/lib/gherkin_lint.rb

@@ -521,6 +521,22 @@ class GherkinLint
     end
   end
 
+  # service class to lint for avoiding outline for single example
+  class AvoidOutlineForSingleExample < Linter
+    def lint
+      scenarios do |file, feature, scenario|
+        next unless scenario['keyword'] == 'Scenario Outline'
+
+        next unless scenario.key? 'examples'
+        next if scenario['examples'].length > 1
+        next if scenario['examples'].first['rows'].length > 2
+
+        references = [reference(file, feature, scenario)]
+        add_issue(references, 'Better write a scenario')
+      end
+    end
+  end
+
   # service class to lint for using same tag on all scenarios
   class SameTagForAllScenarios < Linter
     def lint
@@ -554,6 +570,7 @@ class GherkinLint
   class UseBackground < Linter
     def lint
       features do |file, feature|
+        next if scenarios_with_steps(feature) <= 1
         givens = gather_givens feature
         next if givens.nil?
         next if givens.length <= 1
@@ -563,17 +580,23 @@ class GherkinLint
       end
     end
 
+    def scenarios_with_steps(feature)
+      scenarios = 0
+      feature['elements'].each do |scenario|
+        next unless scenario.include? 'steps'
+        scenarios += 1
+      end
+      scenarios
+    end
+
     def gather_givens(feature)
       return unless feature.include? 'elements'
       has_non_given_step = false
-      scenarios = 0
       feature['elements'].each do |scenario|
         next unless scenario.include? 'steps'
-        scenarios += 1
         has_non_given_step = true unless scenario['steps'].first['keyword'] == 'Given '
       end
       return if has_non_given_step
-      return if scenarios <= 1
 
       result = []
       expanded_steps(feature) { |given| result.push given }
@@ -654,6 +677,7 @@ class GherkinLint
 
   LINTER = [
     AvoidPeriod,
+    AvoidOutlineForSingleExample,
     BackgroundDoesMoreThanSetup,
     BackgroundRequiresMultipleScenarios,
     BadScenarioName,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gherkin_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Stefan Rohe