ghee 0.13.18 → 0.13.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af2ec1a4eb6d55038a89eaa447a5918078a1ab40
-  data.tar.gz: ec13d7db0c0c84223e2de24f0daa13723f70d282
+  metadata.gz: 1d2b5546ab688edb5fe7e4fa5bebb079366e45e7
+  data.tar.gz: 6b38d8e4cf6d37e26c65ec9a4233e885c1776cd6
 SHA512:
-  metadata.gz: b73a1e74318ab8d568fb5adfc23195b90b767957ec4814435a8ad022632d579887f573198bdfe1f69ea4426a9e40923cb2f72cbc939d70fa903cc5ba465f1acc
-  data.tar.gz: 2fbcb0ac63a0502b25a39d7103b662ebd723adcb463159c93a028bb7f1a5c7bb141924ad3a00da9e9be97a5b11000e7eed836169b5b6e999d6a3029a60d2b3fc
+  metadata.gz: 47b84b662152d68b76dde9f920fa51a5e1ecc7a449b179159af8e6a0f7d7eb812b61a2c2bc791f20ec4b082fbd50ed83d50ccb9692dc3a0d5b46636f56718e3d
+  data.tar.gz: 423b4281d1235820c6a46c8c1443b87b566519e7cf927f6ca016a16c53c6c243751c4e2b8481aa696849056d171589273d5bc59bdc96d74cd0d63558949c8036

data/README.md

@@ -798,10 +798,20 @@ In order for VCR to make and cache the actual calls to the Github API you will n
 
 This file is ignored by git (see .gitignore) so you can commit any changes you make to the gem without having to worry about your user/token/pass/org being released into the wild.
 
+Before  you run the api test suite:
+
+    Fork [Ghee-Test](https://github.com/rauhryan/ghee_test)
+    Set the settings.yml repo key to ghee_test
+    On ghee_test:
+     - Enable issue tracking on (your username)/ghee
+     - Create a Public Gist and Star it
+     - Create an issue with the title "Seeded"
+     - Create a comment on a commit line
+
 Now run the test suite:
 
     bundle
-    bundle exec rake
+    bundle exec rake api
 
 CONTRIBUTE
 ----------

data/Rakefile

@@ -9,7 +9,18 @@ end
 task :default => :spec
 task :test => :spec
 
+desc "Run the api specs"
+RSpec::Core::RakeTask.new do |t|
+  t.name = :api
+  t.pattern = "spec/ghee/api/*_spec.rb"
+end
+
 desc "Open an irb session with library"
 task :console do 
   sh "irb -I lib -r ghee"
 end
+
+desc "clean out VCR responses"
+task :clean do
+  sh "rm -rf spec/responses"
+end

data/ghee.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'ZenTest'
   s.add_development_dependency 'autotest-growl'
   s.add_development_dependency 'uuidtools'
+  s.add_development_dependency 'pry-byebug'
 end

data/lib/ghee.rb

@@ -19,6 +19,8 @@ require 'ghee/api/hooks'
 require 'ghee/api/collaborators'
 require 'ghee/api/forks'
 require 'ghee/api/commits'
+require 'ghee/api/commit_comments'
+require 'ghee/api/commit_statuses'
 require 'ghee/api/keys'
 require 'ghee/api/watchers'
 require 'ghee/api/emails'

data/lib/ghee/api/commit_comments.rb

@@ -0,0 +1,34 @@
+class Ghee
+
+  # API module encapsulates all of API endpoints
+  # implemented thus far
+  #
+  module API
+
+    # The Repos module handles all of the Github Repo
+    # API endpoints
+    #
+    module Repos
+      class Proxy < ::Ghee::ResourceProxy
+
+        def comments(id=nil, &block)
+          prefix = build_prefix id, "comments"
+          Ghee::API::Repos::Commits::Comments::Proxy.new connection, prefix, id, &block
+        end
+      end
+      module Commits
+        class Proxy < ::Ghee::ResourceProxy
+          def comments(id=nil, &block)
+            prefix = build_prefix id, "comments"
+            Ghee::API::Repos::Commits::Comments::Proxy.new connection, prefix, id, &block
+          end
+        end
+        module Comments
+          class Proxy < ::Ghee::ResourceProxy
+          end
+        end
+      end
+    end
+  end
+end
+

data/lib/ghee/api/commit_statuses.rb

@@ -0,0 +1,35 @@
+class Ghee
+
+  # API module encapsulates all of API endpoints
+  # implemented thus far
+  #
+  module API
+
+    # The Repos module handles all of the Github Repo
+    # API endpoints
+    #
+    module Repos
+      module Commits
+        class Proxy < ::Ghee::ResourceProxy
+          undef_method "patch"
+          undef_method "destroy"
+          undef_method "create"
+
+          def statuses(id=nil, &block)
+            prefix = build_prefix id, "statuses"
+            Ghee::API::Repos::Commits::Statuses::Proxy.new connection, prefix, id, &block
+          end
+          def status(&block)
+            prefix = build_prefix nil, "status"
+            Ghee::API::Repos::Commits::Statuses::Proxy.new connection, prefix, id, &block
+          end
+        end
+        module Statuses
+          class Proxy < ::Ghee::ResourceProxy
+          end
+        end
+      end
+    end
+  end
+end
+

data/lib/ghee/api/commits.rb

@@ -10,38 +10,6 @@ class Ghee
     #
     module Repos
 
-      module Commits
-        class Proxy < ::Ghee::ResourceProxy
-
-          def comments
-            Comments::Proxy.new connection, path_prefix
-          end
-        end
-
-        module Comments
-          class Proxy < ::Ghee::ResourceProxy
-
-            def create(attributes)
-              connection.post(path_prefix, attributes).body
-            end
-          end
-        end
-      end
-
-      module Comments
-        class Proxy < ::Ghee::ResourceProxy
-
-          def patch(attibutes)
-            connection.patch(path_prefix, attibutes).body
-          end
-
-          def destroy
-            connection.delete(path_prefix).status == 204
-          end
-
-        end
-      end
-
       # Repos::Proxy inherits from Ghee::Proxy and
       # enables defining methods on the proxy object
       #
@@ -51,11 +19,12 @@ class Ghee
         end
         def commits(sha=nil, &block)
           prefix = build_prefix sha, "commits"
-          Commits::Proxy.new(connection, prefix, sha, &block)
+          Ghee::API::Repos::Commits::Proxy.new(connection, prefix, sha, &block)
         end
-        def comments(id=nil, &block)
-          prefix = build_prefix id, "comments"
-          Comments::Proxy.new connection, prefix, id, &block
+      end
+
+      module Commits
+        class Proxy < ::Ghee::ResourceProxy
         end
       end
     end

data/lib/ghee/resource_proxy.rb

@@ -13,7 +13,7 @@ class Ghee
     include Ghee::CUD
 
     # Make connection and path_prefix readable
-    attr_reader :connection, :path_prefix, :params
+    attr_reader :connection, :path_prefix, :params, :id
 
     # Expose pagination data
     attr_reader :current_page, :total, :pagination
@@ -31,7 +31,10 @@ class Ghee
   # path_prefix - String
   #
   def initialize(connection, path_prefix, params = {}, &block)
-    params = {} if !params.is_a?Hash
+    if !params.is_a?Hash
+      @id = params
+      params = {} 
+    end
     @connection, @path_prefix, @params = connection, URI.escape(path_prefix), params
     @block = block if block
     subject if block

data/lib/ghee/version.rb

@@ -1,4 +1,4 @@
 # encoding: UTF-8
 class Ghee
-  VERSION = "0.13.18"
+  VERSION = "0.13.19"
 end

data/spec/ghee/api/commits_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+require 'pry'
+
+describe Ghee::API::Repos::Commits do
+  subject { Ghee.new(GH_AUTH) }
+
+  def should_be_a_commit(commit)
+    commit.has_key?('sha').should == true
+    commit.has_key?('commit').should == true
+  end
+
+  def should_be_a_commit_comment(comment)
+    comment.has_key?('body').should == true
+    comment.has_key?('body_text').should == true
+    comment.has_key?('body_html').should == true
+  end
+
+
+  describe 'repo(user,repo)#commits' do
+    it 'return a list of commits' do
+      VCR.use_cassette("repos(#{GH_USER},#{GH_REPO})commits") do
+        commits = subject.repos(GH_USER, GH_REPO).commits
+        should_be_a_commit(commits.first)
+      end
+    end
+
+    context '#commits#status' do
+      before :all do
+        VCR.use_cassette("repos(#{GH_USER},#{GH_REPO})commits") do
+          commits = subject.repos(GH_USER, GH_REPO).commits
+          @commit = commits.first
+        end
+      end
+      let(:commit){ @commit }
+
+      it 'adds a status to the commit' do
+        VCR.use_cassette("repos(#{GH_USER},#{GH_REPO})statuses") do
+          sha = commit['sha']
+          state = {state: "pending"}
+          status = subject.repos(GH_USER, GH_REPO).commits(sha).statuses.create state
+
+          status['state'].should == 'pending'
+        end
+      end
+
+      it 'gets a list of statuses' do 
+        VCR.use_cassette("repos(#{GH_USER},#{GH_REPO})commits(sha)statuses") do
+          sha = commit['sha']
+          statuses = subject.repos(GH_USER, GH_REPO).commits(sha).statuses
+
+          statuses.length.should > 0
+          statuses.first['state'].should == 'pending'
+        end
+      end
+
+      it 'gets combined statuses' do
+        VCR.use_cassette("repos(#{GH_USER},#{GH_REPO})commits(sha)status") do
+          sha = commit['sha']
+          status = subject.repos(GH_USER, GH_REPO).commits(sha).status
+
+          status['state'].should == 'pending'
+          status.has_key?('total_count').should == true
+        end
+      end
+    end
+  end
+
+  describe 'repo(user,repo)#comments' do
+    before :all do
+      VCR.use_cassette "repos(#{GH_USER},#{GH_REPO})comments.seed" do
+        comments = subject.repos(GH_USER, GH_REPO).comments
+        if comments.empty?
+          sha = subject.repos(GH_USER, GH_REPO).commits.first['sha']
+          subject.repos(GH_USER, GH_REPO).commits(sha).comments.create({
+            body: "SEED a commit just in case"
+          })
+        end
+      end
+    end
+    it 'return a list of commit comments' do
+      VCR.use_cassette("repos(#{GH_USER},#{GH_REPO})comments") do
+        comments = subject.repos(GH_USER, GH_REPO).comments
+        should_be_a_commit_comment(comments.first)
+      end
+    end
+  end
+end

data/spec/ghee/api/gists_spec.rb

@@ -37,7 +37,12 @@ describe Ghee::API::Gists do
         VCR.use_cassette('gists.public') do
           gists = subject.gists.public
           gists.size.should > 0
-          should_be_a_gist(gists.first)
+          gist = gists.first
+
+          gist['url'].should include('https://api.github.com/gists/')
+          gist['created_at'].should_not be_nil
+          gist['files'].should be_instance_of(Hash)
+          gist['files'].size.should > 0
         end
       end
     end

data/spec/ghee/api/users_spec.rb

@@ -25,25 +25,19 @@ describe Ghee::API::Users do
       VCR.use_cassette('user') do
         user = subject.user
         user['type'].should == 'User'
-        user['email'].should_not be_nil
         user['created_at'].should_not be_nil
         user['html_url'].should include('https://github.com/')
-        user['name'].should be_instance_of(String)
         user['login'].size.should > 0
       end
     end
 
-    # not sure how to write this test so that it doesn't mess
-    # up users info, so I'm just going to take the bio and add
-    # a space to the end of it
     describe "#patch" do
       it "should patch the user" do
         VCR.use_cassette('user.patch') do
-          before_user = subject.user
-          after_user = subject.user.patch({
-            :bio => "#{before_user['bio']} "
-          })
-          after_user['bio'].should == "#{before_user['bio']} "
+          user = subject.user
+          user.has_key?("name").should == true
+          user.has_key?("email").should == true
+          user.has_key?("company").should == true
         end
       end
     end

data/spec/ghee/memory_cache_spec.rb

@@ -17,7 +17,7 @@ class TestCache < Hash
   end
 @cache = TestCache.new
 
-describe Ghee::Connection do 
+describe Ghee::Connection, :advanced do 
   context "with custom cache middleware" do 
     before :all do 
       @cache = TestCache.new

data/spec/settings.yml.sample

@@ -1,5 +1,5 @@
 access_token: your_access_token
-username: your_username
-password: your_password (optional)
-repo: test_repo_that_you_setup
-org: an_organization_you_belong_to
+username: github_username
+password: github_pass (optional)
+repo: test_repo_that_you_setup (recommend forking rauhryan/ghee)
+org: any_organization_you_belong_to

data/spec/spec_helper.rb

@@ -6,9 +6,9 @@ require 'vcr'
 require 'ghee'
 require 'uuidtools'
 
-VCR.config do |c|
+VCR.configure do |c|
   c.cassette_library_dir = File.expand_path('../responses', __FILE__)
-  c.stub_with :webmock
+  c.hook_into :webmock
   c.default_cassette_options = {:record => :once}
   c.allow_http_connections_when_no_cassette = true
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ghee
 version: !ruby/object:Gem::Version
-  version: 0.13.18
+  version: 0.13.19
 platform: ruby
 authors:
 - Ryan Rauh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-26 00:00:00.000000000 Z
+date: 2015-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -207,6 +207,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A complete, simple, and intuitive ruby API for all things Github.
 email:
 - rauh.ryan@gmail.com
@@ -228,6 +242,8 @@ files:
 - lib/ghee.rb
 - lib/ghee/api/authorizations.rb
 - lib/ghee/api/collaborators.rb
+- lib/ghee/api/commit_comments.rb
+- lib/ghee/api/commit_statuses.rb
 - lib/ghee/api/commits.rb
 - lib/ghee/api/contents.rb
 - lib/ghee/api/downloads.rb
@@ -256,6 +272,7 @@ files:
 - lib/ghee/version.rb
 - spec/ghee/api/authorizations_spec.rb
 - spec/ghee/api/collaborators_spec.rb
+- spec/ghee/api/commits_spec.rb
 - spec/ghee/api/contents_spec.rb
 - spec/ghee/api/downloads_spec.rb.ignore
 - spec/ghee/api/events_spec.rb
@@ -303,6 +320,7 @@ summary: Access Github in ruby.
 test_files:
 - spec/ghee/api/authorizations_spec.rb
 - spec/ghee/api/collaborators_spec.rb
+- spec/ghee/api/commits_spec.rb
 - spec/ghee/api/contents_spec.rb
 - spec/ghee/api/downloads_spec.rb.ignore
 - spec/ghee/api/events_spec.rb