geti 1.7.0 → 1.8.0

data/Gemfile

@@ -1,4 +1,4 @@
-source :rubygems
+source 'https://rubygems.org'
 
 gem 'savon', "~> 1.0"
 gem 'httpi'

data/Gemfile.lock

@@ -1,5 +1,5 @@
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
     akami (1.2.0)
       gyoku (>= 0.4.0)

data/VERSION

@@ -1 +1 @@
-1.7.0
+1.8.0

data/geti.gemspec

@@ -0,0 +1,83 @@
+# Generated by jeweler
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = "geti"
+  s.version = "1.8.0"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Jamie Macey"]
+  s.date = "2013-03-19"
+  s.description = "API wrapper for GETI, an ACH provider"
+  s.email = "jamie@tracefunc.com"
+  s.extra_rdoc_files = [
+    "LICENSE.txt",
+    "README.rdoc"
+  ]
+  s.files = [
+    ".document",
+    "Gemfile",
+    "Gemfile.lock",
+    "Guardfile",
+    "LICENSE.txt",
+    "README.rdoc",
+    "Rakefile",
+    "VERSION",
+    "certify.rb",
+    "config/test_credentials.yml.example",
+    "doc/.DS_Store",
+    "doc/implementation_notes.md",
+    "doc/readme.txt",
+    "geti.gemspec",
+    "lib/geti.rb",
+    "lib/geti/app_client.rb",
+    "lib/geti/auth_client.rb",
+    "lib/geti/client.rb",
+    "lib/geti/response.rb",
+    "lib/geti/terminal_settings.rb",
+    "spec/geti_app_client_spec.rb",
+    "spec/geti_auth_client_spec.rb",
+    "spec/helper.rb",
+    "spec/remote/geti_app_client_spec.rb",
+    "spec/remote/geti_auth_client_spec.rb",
+    "spec/remote/sample.pdf"
+  ]
+  s.homepage = "http://github.com/jamie/geti"
+  s.licenses = ["MIT"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = "1.8.24"
+  s.summary = "API wrapper for GETI, an ACH provider"
+
+  if s.respond_to? :specification_version then
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<savon>, ["~> 1.0"])
+      s.add_runtime_dependency(%q<httpi>, [">= 0"])
+      s.add_runtime_dependency(%q<httpclient>, [">= 0"])
+      s.add_development_dependency(%q<rake>, ["< 0.9"])
+      s.add_development_dependency(%q<bundler>, [">= 0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.8.4"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
+    else
+      s.add_dependency(%q<savon>, ["~> 1.0"])
+      s.add_dependency(%q<httpi>, [">= 0"])
+      s.add_dependency(%q<httpclient>, [">= 0"])
+      s.add_dependency(%q<rake>, ["< 0.9"])
+      s.add_dependency(%q<bundler>, [">= 0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
+      s.add_dependency(%q<rcov>, [">= 0"])
+    end
+  else
+    s.add_dependency(%q<savon>, ["~> 1.0"])
+    s.add_dependency(%q<httpi>, [">= 0"])
+    s.add_dependency(%q<httpclient>, [">= 0"])
+    s.add_dependency(%q<rake>, ["< 0.9"])
+    s.add_dependency(%q<bundler>, [">= 0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
+    s.add_dependency(%q<rcov>, [">= 0"])
+  end
+end
+

data/lib/geti/app_client.rb

@@ -284,7 +284,12 @@ class Geti::AppClient < Geti::Client
   end
 
   def comments(opts)
-    [taxpayer_info(opts), ip_address(opts)].compact.join(', ')
+    [taxpayer_info(opts), ip_address(opts), email_address(opts)].compact.join(', ')
+  end
+
+  def email_address(opts)
+    return unless opts[:email]
+    "Email: %s" % opts[:email]
   end
 
   def ip_address(opts)

data/spec/geti_app_client_spec.rb

@@ -52,6 +52,7 @@ describe Geti::AppClient do
       :account_number => "123456789",
 
       :ip => '127.0.0.1',
+      :email => 'bob@example.com'
     }
   end
 
@@ -152,17 +153,37 @@ describe Geti::AppClient do
     describe 'comments field' do
       before do
         client = Geti::AppClient.new(test_credentials, {})
-        @xml = client.data(Builder::XmlMarkup.new, request_payload)
+        @full_xml = client.data(Builder::XmlMarkup.new, request_payload)
+
+        client = Geti::AppClient.new(test_credentials, {})
+        payload = request_payload.dup
+        payload.delete(:ip)
+        payload.delete(:email)
+        @sparse_xml = client.data(Builder::XmlMarkup.new, payload)
       end
 
       it 'fills with taxpayer info' do
-        @xml =~ /merchComments="([^"]+)"/
+        @full_xml =~ /merchComments="([^"]+)"/
+        $1.should match("Tax Info: Carl Cogsley - 123456789")
+
+        @sparse_xml =~ /merchComments="([^"]+)"/
         $1.should match("Tax Info: Carl Cogsley - 123456789")
       end
 
       it 'fills with signup IP' do
-        @xml =~ /merchComments="([^"]+)"/
+        @full_xml =~ /merchComments="([^"]+)"/
         $1.should match("Signup IP: 127.0.0.1")
+
+        @sparse_xml =~ /merchComments="([^"]+)"/
+        $1.should_not match("IP")
+      end
+
+      it 'fills with signup email' do
+        @full_xml =~ /merchComments="([^"]+)"/
+        $1.should match("Email: bob@example.com")
+
+        @sparse_xml =~ /merchComments="([^"]+)"/
+        $1.should_not match("Email")
       end
     end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: geti
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 55
   prerelease: 
   segments: 
   - 1
-  - 7
+  - 8
   - 0
-  version: 1.7.0
+  version: 1.8.0
 platform: ruby
 authors: 
 - Jamie Macey
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-02-07 00:00:00 Z
+date: 2013-03-19 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   requirement: &id001 !ruby/object:Gem::Requirement 
@@ -28,10 +28,10 @@ dependencies:
         - 1
         - 0
         version: "1.0"
+  version_requirements: *id001
+  name: savon
   prerelease: false
   type: :runtime
-  name: savon
-  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
@@ -42,10 +42,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  version_requirements: *id002
+  name: httpi
   prerelease: false
   type: :runtime
-  name: httpi
-  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
@@ -56,10 +56,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  version_requirements: *id003
+  name: httpclient
   prerelease: false
   type: :runtime
-  name: httpclient
-  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
@@ -71,10 +71,10 @@ dependencies:
         - 0
         - 9
         version: "0.9"
+  version_requirements: *id004
+  name: rake
   prerelease: false
   type: :development
-  name: rake
-  version_requirements: *id004
 - !ruby/object:Gem::Dependency 
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
@@ -85,10 +85,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  version_requirements: *id005
+  name: bundler
   prerelease: false
   type: :development
-  name: bundler
-  version_requirements: *id005
 - !ruby/object:Gem::Dependency 
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
@@ -101,10 +101,10 @@ dependencies:
         - 8
         - 4
         version: 1.8.4
+  version_requirements: *id006
+  name: jeweler
   prerelease: false
   type: :development
-  name: jeweler
-  version_requirements: *id006
 - !ruby/object:Gem::Dependency 
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
@@ -115,10 +115,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  version_requirements: *id007
+  name: rcov
   prerelease: false
   type: :development
-  name: rcov
-  version_requirements: *id007
 description: API wrapper for GETI, an ACH provider
 email: jamie@tracefunc.com
 executables: []
@@ -142,6 +142,7 @@ files:
 - doc/.DS_Store
 - doc/implementation_notes.md
 - doc/readme.txt
+- geti.gemspec
 - lib/geti.rb
 - lib/geti/app_client.rb
 - lib/geti/auth_client.rb