geti 1.4.0 → 1.5.0

data/VERSION

@@ -1 +1 @@
-1.4.0
+1.5.0

data/lib/geti/app_client.rb

@@ -194,7 +194,7 @@ class Geti::AppClient < Geti::Client
           :merchAchFlatFee    => "",
           :merchNonAchFlatFee => "",
           :merchPercentFee    => "",
-          :merchComments      => taxpayer_info(opts),
+          :merchComments      => comments(opts),
           :merchReturnFee     => "",
           # TODO: Web Address
           # TODO: Email address
@@ -283,6 +283,15 @@ class Geti::AppClient < Geti::Client
     }
   end
 
+  def comments(opts)
+    [taxpayer_info(opts), ip_address(opts)].compact.join(', ')
+  end
+
+  def ip_address(opts)
+    return unless opts[:ip]
+    "Signup IP: %s" % opts[:ip]
+  end
+
   def taxpayer_info(opts)
     "Tax Info: %s - %s" % [opts[:taxpayer_name], opts[:taxpayer_id]]
   end

data/spec/geti_app_client_spec.rb

@@ -50,6 +50,8 @@ describe Geti::AppClient do
 
       :routing_number => "490000018",
       :account_number => "123456789",
+
+      :ip => '127.0.0.1',
     }
   end
 
@@ -147,6 +149,23 @@ describe Geti::AppClient do
       client.board_merchant_ach(request_payload)
     end
 
+    describe 'comments field' do
+      before do
+        client = Geti::AppClient.new(test_credentials, {})
+        @xml = client.data(Builder::XmlMarkup.new, request_payload)
+      end
+
+      it 'fills with taxpayer info' do
+        @xml =~ /merchComments="([^"]+)"/
+        $1.should match("Tax Info: Carl Cogsley - 123456789")
+      end
+
+      it 'fills with signup IP' do
+        @xml =~ /merchComments="([^"]+)"/
+        $1.should match("Signup IP: 127.0.0.1")
+      end
+    end
+
     describe 'character filtering' do
       let(:client) { Geti::AppClient.new(test_credentials, {}) }
 

data/spec/remote/geti_app_client_spec.rb

@@ -42,6 +42,8 @@ describe Geti::AppClient, :remote => true do
 
       :routing_number => "490000018",
       :account_number => "123456789",
+
+      :ip => '127.0.0.1',
     }
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: geti
 version: !ruby/object:Gem::Version 
-  hash: 7
+  hash: 3
   prerelease: 
   segments: 
   - 1
-  - 4
+  - 5
   - 0
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors: 
 - Jamie Macey
@@ -15,11 +15,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-11-28 00:00:00 Z
+date: 2013-01-28 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: savon
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -28,12 +27,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
-  requirement: *id001
+  name: savon
   type: :runtime
+  version_requirements: *id001
+  prerelease: false
 - !ruby/object:Gem::Dependency 
-  name: httpi
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -42,12 +41,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
-  requirement: *id002
+  name: httpi
   type: :runtime
+  version_requirements: *id002
+  prerelease: false
 - !ruby/object:Gem::Dependency 
-  name: httpclient
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -56,12 +55,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
-  requirement: *id003
+  name: httpclient
   type: :runtime
+  version_requirements: *id003
+  prerelease: false
 - !ruby/object:Gem::Dependency 
-  name: rake
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - <
@@ -71,12 +70,12 @@ dependencies:
         - 0
         - 9
         version: "0.9"
-  prerelease: false
-  requirement: *id004
+  name: rake
   type: :development
+  version_requirements: *id004
+  prerelease: false
 - !ruby/object:Gem::Dependency 
-  name: bundler
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -87,12 +86,12 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  prerelease: false
-  requirement: *id005
+  name: bundler
   type: :development
+  version_requirements: *id005
+  prerelease: false
 - !ruby/object:Gem::Dependency 
-  name: jeweler
-  version_requirements: &id006 !ruby/object:Gem::Requirement 
+  requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -103,12 +102,12 @@ dependencies:
         - 8
         - 4
         version: 1.8.4
-  prerelease: false
-  requirement: *id006
+  name: jeweler
   type: :development
+  version_requirements: *id006
+  prerelease: false
 - !ruby/object:Gem::Dependency 
-  name: rcov
-  version_requirements: &id007 !ruby/object:Gem::Requirement 
+  requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -117,9 +116,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
-  requirement: *id007
+  name: rcov
   type: :development
+  version_requirements: *id007
+  prerelease: false
 description: API wrapper for GETI, an ACH provider
 email: jamie@tracefunc.com
 executables: []