get_your_rep 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c16d91fa3356cbf8023016ff512e0aa0eea194fd
-  data.tar.gz: 3e55d1025abf18ba15c704484edec851bb57be41
+  metadata.gz: b04541a6dc52698adf6cf3c5845c14e8b4439a34
+  data.tar.gz: ba0d7bacbc3c874e75691498917b27a81b96a44e
 SHA512:
-  metadata.gz: 0222b6b22f44fc6464544595dc25f171a858a0f4698eb3666b641b61d895b3bbd3c9aabf82cd5fcae3122784d833813736c15a4254af0056b24172fc1dc41ec4
-  data.tar.gz: e6ea659e4bc3c1261885d74d83d40392bb91ab95b9416568c7e2faa117e07f6410feb297fef05f9d276bc04529c0e7b591b250179879a35a7c6cececb82f3d97
+  metadata.gz: 8bb41c03e7575fb1ee3511102f689efcc6ef55116164f75aea0cc548d41f7a563e1400365059ea66124a32bcc7caa4d13f2a6ef64211805048996428abdfe328
+  data.tar.gz: df25182496f23887dcb28cbca5a5bce5fef20589929709b0a754cb030c3e9345c09e1636c1ff841808c7204aa60d1aae9a1807db7d7563de31868a3dfcf05b9a

data/README.md

@@ -1,6 +1,6 @@
 # Get yo' rep!
 
-This is the companion [gem](https://rubygems.org/gems/get_your_rep) for the [Phone Your Rep API] (https://github.com/thecristen/phone-your-rep-api)
+This is the companion [gem](https://rubygems.org/gems/get_your_rep) for the [Phone Your Rep API] (https://github.com/msimonborg/phone-your-rep-api)
 
 This gem sends requests to the Google Civic Information API and the OpenStates.org API for info on your representatives and parses the JSON responses into Ruby objects.
 
@@ -27,8 +27,9 @@ Add this line to your ~/.bashrc or ~/.bash_profile
 
 ## Usage
 
+Execute `reps` from the command line for a Command Line Interface.
 
-Send queries like this `reps = GetYourRep.all_reps(address)` to gather a Delegation of Representatives. This will get federal legislators from Google and state legislators form OpenStates.org
+In your app, send queries like this `reps = GetYourRep.all_reps(address)` to gather a Delegation of Representatives. This will get federal legislators from Google and state legislators form OpenStates.org
 
 `address` is your address. You can use just a zip code, but use a full address for the best results. Don't worry about commas, spaces, character case, or `.`s (`"123 1/2 main St., anywhere    CA 12345"` is A-OK)
 
@@ -40,7 +41,7 @@ You can iterate over a Delegation's reps like so: `delegetion.reps.each { |rep|
 
 There is also a shortcut for that: `delegation.each { |rep| rep.name }`.
 
-There is also a shortcut for that: `delegation.names`. Also works with `#first_names`, `#last_names`, and `#office_locations`.
+There's a shortcut for that, too: `delegation.names`. Also works with `#first_names`, `#last_names`, and `#office_locations`.
 
 Get Federal and State executives and legislators with `GetYourRep::Google.all_reps(address)`.
 
@@ -50,7 +51,7 @@ Get state legislators only with `GetYourRep::OpenStates.all_reps(address)`.
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment. Add `export GOOGLE_API_KEY="<YOUR_API_KEY>"` to your `.bashrc` or `.bash_profile` and then `bundle exec rake_test`.
+After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment. Add `export GOOGLE_API_KEY="<YOUR_API_KEY>"` to your `.bashrc` or `.bash_profile` and then `bundle exec rake test`.
 
 ## Contributing
 

data/Rakefile

@@ -6,7 +6,7 @@ require 'rake/testtask'
 Rake::TestTask.new do |t|
   t.libs << 'test'
   t.test_files = FileList['test/**/*test.rb']
-  t.verbose = true
+  t.verbose = false
 end
 
 task default: :test

data/lib/get_your_rep/responses/base.rb

@@ -7,6 +7,8 @@ module GetYourRep
     # Taken with gratitude from davidbella https://gist.github.com/davidbella/6918455
     def initialize(options = {})
       options.each do |attr, value|
+        # Recent responses from OpenStates have had '+' appended to some keys. Trim that off or it throws an error.
+        attr = attr.gsub('+', '')
         create_setters_from_opts(attr)
         create_getters_from_opts(attr)
         add_value_to_attr(attr, value)

data/lib/get_your_rep/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module GetYourRep
-  VERSION = '1.0.5' # :nodoc:
+  VERSION = '1.0.6' # :nodoc:
 end

data/spec.md

@@ -0,0 +1,7 @@
+# Specifications for the CLI Assessment
+
+Specs:
+- [x] Have a CLI for interfacing with the application # Can call `reps` from the command line to explore the CLI.
+- [x] Pull data from an external source # Uses HTTParty to parse JSON responses from two API sources.
+- [x] Implement both list and detail views # Reps are displayed in the CLI in a numbered list, and detail can be viewed by typing the corresponding number.
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: get_your_rep
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - msimonborg
@@ -161,6 +161,7 @@ files:
 - lib/get_your_rep/responses/open_states_office.rb
 - lib/get_your_rep/responses/open_states_rep.rb
 - lib/get_your_rep/version.rb
+- spec.md
 homepage: https://github.com/msimonborg/get-your-rep
 licenses:
 - MIT