get 0.3.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75d26babe2ad02eb00f3235b9de2c9891266e3da
-  data.tar.gz: 2cef8bd681cc576bccf3727129753f156644b34f
+  metadata.gz: 24209f31c15fd914e951892e126bd82340ed89a9
+  data.tar.gz: edbda8c1b863295e0caa8d593fc6e4cb73be3008
 SHA512:
-  metadata.gz: 33958398abb0fac7092d923355a5c2e9d4634ed0c34ae200266d9eb88a41c830c9cac9d397447ff17da331439a4ff01cfe91f4bca2aab7d9f181f93c2f2d21bf
-  data.tar.gz: 95b7c4b1f1576516d6c539ef260697b910e0194fb93da749d2fb79372a630d2c269ff6bba08fe22348ca653ee5d1b58104b4b2cf8895dd6c2f1a3f1077b631a2
+  metadata.gz: cdaa750abb6815f38de23fe6813b77f1f99cad718f27a7fe6abf5a28a1aea3e520316990c1f9b984c28c5a1c672398224966adda2b48f62ff315aeef825dfd14
+  data.tar.gz: 168495d26ce9cb4538a3869d11be9fa76fef286133ad9c6f6ab1a23a6276f9228b56d857227ad57ce7f541a37875c087e7671f5a42af9c5394eb8b6cf82e1004

data/README.md

@@ -33,6 +33,11 @@ With Options
 Get::UsersByLastName.run('Turner', limit: 10, offset: 20, order: { last_name: :desc })
 ```
 
+All records
+```ruby
+Get::AllUsers.run
+```
+
 #### Associations
 
 Associations use 'From', and are sugar for the chains we so often write in rails.
@@ -309,19 +314,21 @@ end
 By encapsulating the query in a class, we're able to stub it at the class level, which eliminates then need to create any dependencies.
 This will speed up tests (a little), but more importantly it makes them easier to read and write.
 
+
 ## Config
+<tt>Get</tt> uses the underlying Horza configuration, so all configuration options can be set on <tt>Get</tt> just like they would on <tt>Horza</tt>.
 
-**Define your adapter**
+***e.g. Defining your adapter***
 
 _config/initializers/get.rb_
 ```ruby
 Get.configure { |config| config.adapter = :active_record }
 ```
-You can reset the config at any time using `Get.reset`.
+For more details on configuration check out the <tt>Horza</tt> [documentation.](https://github.com/onfido/horza) 
 
 ## Adapters
 
-Get currently works with ActiveRecord.
+Get currently only works with ActiveRecord.
 
 ## Edge Cases
 

data/lib/get/builders/ancestry_builder.rb

@@ -8,7 +8,7 @@ module Get
           key: @key,
           collection: @result_entity.plural?,
           result_entity: @result_entity.symbolize,
-          store: Get.adapter.context_for_entity(@key.to_s.singularize.symbolize)
+          store: Get.adapter.context_for_entity(@key.to_s.singularize)
         }
       end
 

data/lib/get/builders/join_builder.rb

@@ -7,7 +7,7 @@ module Get
         {
           base_table: @result_entity.symbolize,
           join_table: @key,
-          store: Get.adapter.context_for_entity(@result_entity.singularize.symbolize)
+          store: Get.adapter.context_for_entity(@result_entity.singularize)
         }
       end
 

data/lib/get/builders/query_builder.rb

@@ -8,7 +8,7 @@ module Get
           key: @key,
           collection: @result_entity.plural?,
           result_entity: @result_entity.singularize.symbolize,
-          store: Get.adapter.context_for_entity(@result_entity.singularize.symbolize)
+          store: Get.adapter.context_for_entity(@result_entity.singularize)
         }
       end
 

data/lib/get/version.rb

@@ -0,0 +1,3 @@
+module Get
+  VERSION = '1.0.0'
+end

data/lib/get.rb

@@ -1,23 +1,22 @@
+require 'horza'
 require 'get/builders/base_builder'
 require 'get/builders/ancestry_builder'
 require 'get/builders/query_builder'
 require 'get/builders/join_builder'
 require 'get/builders'
-require 'get/configuration'
 require 'get/db'
 require 'get/errors'
 require 'get/parser'
 require 'get/run_methods'
-require 'horza'
+require 'get/version'
+
 
 module Get
-  extend Get::Configuration
+  extend Horza::SharedConfig
 
   GET_CLASS_REGEX = /^(.*)(By|From)(.*)/
 
   class << self
-    attr_writer :configuration
-
     def included(base)
       base.class_eval do
         extend ::Get::RunMethods

data/spec/get_spec.rb

@@ -13,35 +13,31 @@ else
     end
   end
 
-  module GetSpec
-    class Employer < ActiveRecord::Base
-      has_many :users
-      has_many :sports_cars
-    end
+  class Employer < ActiveRecord::Base
+    has_many :users
+    has_many :sports_cars
+  end
 
-    class User < ActiveRecord::Base
-      belongs_to :employer
-    end
+  class User < ActiveRecord::Base
+    belongs_to :employer
+  end
 
-    class SportsCar < ActiveRecord::Base
-      belongs_to :employer
-    end
+  class SportsCar < ActiveRecord::Base
+    belongs_to :employer
   end
+
 end
 
 describe Get do
   let(:last_name) { 'Turner' }
   let(:adapter) { :active_record }
 
-  # Preserve system config for other tests
-  before(:all) { @system_config = Get.configuration }
-  after(:all) { Get.configuration = @system_config }
-
   # Reset base config with each iteration
   before { Get.configure { |config| config.adapter = adapter } }
+  
   after do
-    GetSpec::User.delete_all
-    GetSpec::Employer.delete_all
+    User.delete_all
+    Employer.delete_all
     Get.reset
   end
 
@@ -51,37 +47,6 @@ describe Get do
     end
   end
 
-  context 'development_mode' do
-    before do
-      Get.reset
-      Get.configure do |config|
-        config.adapter = 'my_adapter'
-        config.development_mode = true
-      end
-    end
-    after do
-      Get.reset
-    end
-    it 'sets Horza to development mode' do
-      expect(Horza.configuration.development_mode).to be true
-    end
-  end
-
-  context 'namespaces' do
-    before do
-      Get.reset
-      Get.configure do |config|
-        config.adapter = 'my_adapter'
-        config.namespaces =  [GetSpec]
-      end
-    end
-    after do
-      Get.reset
-    end
-    it 'sets Horza to development mode' do
-      expect(Horza.configuration.namespaces).to eq [GetSpec]
-    end
-  end
 
   context '#adapter' do
     context 'when the adapter is set' do
@@ -91,31 +56,27 @@ describe Get do
     end
 
     context 'when the adapter is not set' do
-      before { Get.reset }
-      after { Get.reset }
-
       it 'throws error' do
-        expect { Get.adapter }.to raise_error(Get::Errors::Base)
+        Get.reset
+        expect { Get.adapter }.to raise_error(Horza::Errors::AdapterError)
       end
     end
   end
 
   context '#reset' do
     before do
-      Get.configure do |config|
-        config.adapter = 'my_adapter'
-      end
-      Get.reset
+      Get.configure { |config| config.constant_paths += ['my_path'] }
     end
     it 'resets the config' do
-      expect(Get.configuration.adapter).to be nil
+      Get.reset
+      expect(Get.configuration.constant_paths).to be_empty
     end
   end
 
   context '#run!' do
     context 'singular form' do
       context 'when the record exists' do
-        let!(:user) { GetSpec::User.create(last_name: last_name) }
+        let!(:user) { User.create(last_name: last_name) }
 
         context 'field in class name' do
           it 'gets the records based on By[KEY]' do
@@ -149,7 +110,7 @@ describe Get do
 
     context 'ancestry' do
       context 'valid ancestry with no saved parent' do
-        let(:user2) { GetSpec::User.create }
+        let(:user2) { User.create }
         it 'returns nil' do
           expect(Get::EmployerFromUser.run!(user2)).to be nil
         end
@@ -160,7 +121,7 @@ describe Get do
   context '#run' do
     context 'singular form' do
       context 'when the record exists' do
-        let!(:user) { GetSpec::User.create(last_name: last_name) }
+        let!(:user) { User.create(last_name: last_name) }
 
         context 'field in class name' do
           it 'gets the records based on By[KEY]' do
@@ -199,8 +160,8 @@ describe Get do
 
       context 'when records exist' do
         before do
-          match_count.times { GetSpec::User.create(last_name: last_name)  }
-          miss_count.times { GetSpec::User.create }
+          match_count.times { User.create(last_name: last_name)  }
+          miss_count.times { User.create }
         end
 
         context 'field in class name' do
@@ -243,8 +204,8 @@ describe Get do
         let(:miss_count) { 7 }
 
         before do
-          match_count.times { GetSpec::User.create(last_name: last_name)  }
-          miss_count.times { GetSpec::User.create }
+          match_count.times { User.create(last_name: last_name)  }
+          miss_count.times { User.create }
         end
 
         context 'when limit is passed' do
@@ -264,7 +225,7 @@ describe Get do
         context 'when order is passed' do
           it 'orders the response' do
             result = Get::UsersBy.run({ last_name: last_name }, order: { id: :asc })
-            ar_result = GetSpec::User.where(last_name: last_name).order('id asc')
+            ar_result = User.where(last_name: last_name).order('id asc')
 
             expect(result.first.id).to eq ar_result.first.id
             expect(result.last.id).to eq ar_result.last.id
@@ -281,9 +242,9 @@ describe Get do
 
     context 'associations' do
       context 'direct relation' do
-        let(:employer) { GetSpec::Employer.create }
-        let!(:user1) { GetSpec::User.create(employer: employer) }
-        let!(:user2) { GetSpec::User.create(employer: employer) }
+        let(:employer) { Employer.create }
+        let!(:user1) { User.create(employer: employer) }
+        let!(:user2) { User.create(employer: employer) }
 
         context 'ParentFromChild' do
           it 'returns parent' do
@@ -294,7 +255,7 @@ describe Get do
         context 'ChildrenFromParent' do
           it 'returns children' do
             result = Get::UsersFromEmployer.run(employer)
-            ar_result = GetSpec::User.where(employer_id: employer.id).order('id desc')
+            ar_result = User.where(employer_id: employer.id).order('id desc')
             expect(result.first.id).to eq ar_result.first.id
             expect(result.last.id).to eq ar_result.last.id
           end
@@ -307,14 +268,14 @@ describe Get do
         end
 
         context 'valid ancestry with no saved childred' do
-          let(:employer2) { GetSpec::Employer.create }
+          let(:employer2) { Employer.create }
           it 'returns empty collection error' do
             expect(Get::UsersFromEmployer.run(employer2).empty?).to be true
           end
         end
 
         context 'valid ancestry with no saved parent' do
-          let(:user2) { GetSpec::User.create }
+          let(:user2) { User.create }
           it 'returns nil' do
             expect(Get::EmployerFromUser.run(user2)).to be nil
           end
@@ -322,9 +283,9 @@ describe Get do
       end
 
       context 'using via' do
-        let(:employer) { GetSpec::Employer.create }
-        let(:user) { GetSpec::User.create(employer: employer) }
-        let(:sportscar) { GetSpec::SportsCar.create(employer: employer) }
+        let(:employer) { Employer.create }
+        let(:user) { User.create(employer: employer) }
+        let(:sportscar) { SportsCar.create(employer: employer) }
 
         before do
           employer.sports_cars << sportscar
@@ -342,13 +303,13 @@ describe Get do
       end
 
       context 'with options' do
-        let(:employer) { GetSpec::Employer.create }
+        let(:employer) { Employer.create }
         let(:match_count) { 20 }
         let(:miss_count) { 7 }
 
         before do
-          match_count.times { employer.users << GetSpec::User.create(employer: employer, last_name: last_name) }
-          miss_count.times { employer.users << GetSpec::User.create(employer: employer) }
+          match_count.times { employer.users << User.create(employer: employer, last_name: last_name) }
+          miss_count.times { employer.users << User.create(employer: employer) }
         end
 
         context 'when conditions are passed' do
@@ -375,7 +336,7 @@ describe Get do
         context 'when order is passed' do
           it 'orders response' do
             result = Get::UsersFromEmployer.run(employer.id, conditions: { last_name: last_name }, order: { id: :asc })
-            ar_result = GetSpec::User.where(employer_id: employer.id, last_name: last_name).order('id asc')
+            ar_result = User.where(employer_id: employer.id, last_name: last_name).order('id asc')
 
             expect(result.first.id).to eq ar_result.first.id
             expect(result.last.id).to eq ar_result.last.id
@@ -392,14 +353,14 @@ describe Get do
     end
 
     context 'joins' do
-      let(:employer) { GetSpec::Employer.create }
-      let(:employer2) { GetSpec::Employer.create }
+      let(:employer) { Employer.create }
+      let(:employer2) { Employer.create }
       let(:match_count) { 20 }
       let(:miss_count) { 7 }
 
       before do
-        match_count.times { employer2.users << GetSpec::User.create(employer: employer2) }
-        miss_count.times { employer.users << GetSpec::User.create(employer: employer) }
+        match_count.times { employer2.users << User.create(employer: employer2) }
+        miss_count.times { employer.users << User.create(employer: employer) }
       end
 
       context 'when no conditions are passed' do

metadata

@@ -1,111 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: get
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Blake Turner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-10 00:00:00.000000000 Z
+date: 2015-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: horza
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.2.15
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.2.15
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.2.15
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.2.15
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Encapsulate your database queries with dynamically generated classes
@@ -114,19 +100,19 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- LICENSE.txt
-- README.md
-- lib/get.rb
-- lib/get/builders.rb
 - lib/get/builders/ancestry_builder.rb
 - lib/get/builders/base_builder.rb
 - lib/get/builders/join_builder.rb
 - lib/get/builders/query_builder.rb
-- lib/get/configuration.rb
+- lib/get/builders.rb
 - lib/get/db.rb
 - lib/get/errors.rb
 - lib/get/parser.rb
 - lib/get/run_methods.rb
+- lib/get/version.rb
+- lib/get.rb
+- LICENSE.txt
+- README.md
 - spec/get_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/BlakeTurner/get
@@ -139,22 +125,21 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Get is a library designed to encapsulate Rails database queries and prevent
   query pollution in the view layer.
 test_files:
-- spec/spec_helper.rb
 - spec/get_spec.rb
-has_rdoc: 
+- spec/spec_helper.rb

data/lib/get/configuration.rb

@@ -1,39 +0,0 @@
-module Get
-  module Configuration
-    def configuration
-      @configuration ||= Config.new
-    end
-
-    def reset
-      @configuration = Config.new
-      @adapter, @adapter_map = nil, nil # Class-level cache clear
-    end
-
-    def configure
-      yield(configuration)
-    end
-
-    def adapter
-      raise ::Get::Errors::Base.new('Adapter has not been configured') unless configuration.adapter
-      @adapter ||= configuration.adapter
-    end
-  end
-
-  class Config
-    attr_accessor :adapter, :environment
-
-    def adapter=(adapter)
-      Horza.configure { |config| config.adapter = adapter }
-      @adapter = Horza.adapter
-    end
-
-    def development_mode=(mode)
-      Horza.configure { |config| config.development_mode = mode }
-    end
-
-    def namespaces=(namespaces)
-      raise ::Get::Errors::Base.new('namespaces must be an array') unless namespaces.is_a? Array
-      Horza.configure { |config| config.namespaces = namespaces }
-    end
-  end
-end