get 0.1.4.2 → 0.1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 90569f3f39dc605cd44d3e12143b16cdb02abaca
-  data.tar.gz: 1c9711f68ad0c458c143375ee8ce56188ad3f189
+  metadata.gz: 35ab11daa222833ce2a9b27474271d07df489689
+  data.tar.gz: 8ef6fe8751908e33a133bc5d99765c3859b77e59
 SHA512:
-  metadata.gz: d4c4a8030eabe0f73821f248f085432ef64807cde9667a5ea7b1655194a751fa8c55ccb4744f520a4d82bbd24b8967c60f7693a30de4981ebaf17156ec37f2d0
-  data.tar.gz: 7ac8e20c9c7c00f1b6380e6ec523406469970b53e3dd4424783c333f0c2dd91bd78271f8977520989d440c3e21d531e83215b1b3b0803914772880caed478be3
+  metadata.gz: 4048efdf151cd664d1c6006dd3ea2d10ec901f2c6d08a8b9bb6556f704c9c45b8bc64dd747549ebe0469e7ade6d851b57f78269d146277677271ad36a8a1bf0c
+  data.tar.gz: 2cc06292d2434ae9587187952779ebc8a4861ea2cf3f78be0c028c24c1717d730e92a0943dde2fbd76ee16ee551d1ee55a35eff501f628d3469a2099d1094624

data/README.md

@@ -226,6 +226,17 @@ You can reset the config at any time using `Get.reset`.
 
 Get currently works with ActiveRecord.
 
+## Edge Cases
+
+Some attributes contain the word 'by', ie. `Customer.invited_by`.
+Because of the way Get parses classnames, you won't be able to use the attribute-specific format.
+Use the more general form instead.
+
+```
+Get::CustomerByInvitedBy.run('John') #=> throws Get::Errors::InvalidClassName
+Get::CustomerBy.run(invited_by: 'John') #=> will work
+```
+
 ## Benchmarking
 
 Get requests generally run < 1ms slower than ActiveRecord requests.

data/lib/get/errors.rb

@@ -11,5 +11,8 @@ module Get
 
     class RecordNotFound < StandardError
     end
+
+    class InvalidClassName < StandardError
+    end
   end
 end

data/lib/get/parser.rb

@@ -1,9 +1,12 @@
 module Get
   class Parser
     CLASS_REGEX = /^(.*)(By|From)(.*)/
+    CLASS_NAME_BY_ERROR = 'You have multiple instances of "By" in your class. Please use open-ended form ie. Get::UserBy.run(params)'
     attr_accessor :class_name, :result_entity, :method
 
     def initialize(class_name)
+      raise Get::Errors::InvalidClassName.new(CLASS_NAME_BY_ERROR) if class_name.to_s.split('By').length > 2
+
       @class_name = class_name
       @match = class_name.to_s.match(CLASS_REGEX)
       @result_entity, @method, @key_string = @match.values_at(1, 2, 3) if @match

data/spec/get_spec.rb

@@ -312,6 +312,8 @@ describe Get::Parser do
   let(:query_name) { 'UserFromEmployer' }
 
   subject { Get::Parser }
+  before { Get.configure { |config| config.set_adapter(:active_record) } }
+  after { Get.reset }
 
   describe '#match?' do
     context 'when name is of ancestry type' do
@@ -331,6 +333,11 @@ describe Get::Parser do
         expect(subject.new('Blablabla').match?).to be false
       end
     end
+  end
 
+  context 'two instances of "By" in class name' do
+    it 'throws error' do
+      expect { subject.new('UserByInvitedByType') }.to raise_error Get::Errors::InvalidClassName
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: get
 version: !ruby/object:Gem::Version
-  version: 0.1.4.2
+  version: 0.1.5.0
 platform: ruby
 authors:
 - Blake Turner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-28 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: horza