gergich 0.1.17 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 07fde95880fbf7f7195ce8f7ca43cdfd47005d8c
-  data.tar.gz: 8c6f1be4ab8bb1e4ea565da45087cfa6a85d1f11
+  metadata.gz: 9da4c870097f2129eaa052c2b41b840da0cc096f
+  data.tar.gz: 4d3102825f2858c5e63cade4fb751d29f9c2a73b
 SHA512:
-  metadata.gz: 976fbe4fe6a0dff8babf88f8994206a31ce2cceef84ed06ffc828a0efc77da806272aebb07e4ee514f6341bd79f2eed63bb388c2dea98418b0feb2390605f2e2
-  data.tar.gz: f2b3b77e61633b7eb00b44a11679e77dcd98d6851d190d105879888d4b8c4832b97d0ce104882530a283ac7e1fb54efc13bcbe2f895fe1e6b369e7fb4f3907b8
+  metadata.gz: 011eb695e557e2c00074731bd9521d606ba13f0fa18d0fccd71095b7db8c1cc58e215eeeabee1fd80ac34075111621d3ece3fc85ccf0d2ccb5620686400ea1c3
+  data.tar.gz: b616b994af49ce7c2c714d3d40a7e8eee6cb613aede43e31d7e4cb106844d1acd538d02f71dfedab83aa0c0a5843ea02427603f9adff3552bdfc850c96821015

data/README.md

@@ -107,6 +107,7 @@ do `gergich comment` calls so you don't have to wire it up yourself.
 * `i18nliner`
 * `flake8`
 * `stylelint`
+* `shellcheck` - shellcheck json output
 * `custom:<path>:<class_name>` - file path and ruby class_name of a custom
   formatter.
 
@@ -140,6 +141,8 @@ gergich capture eslint eslint
 
 gergich capture i18nliner "rake i18nliner:check"
 
+gergich capture shellcheck "shellcheck --format json build.sh"
+
 gergich capture custom:./gergich/xss:Gergich::XSS "node script/xsslint"
 
 docker-compose run --rm web eslint | gergich capture eslint -

data/lib/gergich/capture/shellcheck_capture.rb

@@ -0,0 +1,27 @@
+require "json"
+
+module Gergich
+  module Capture
+    class ShellcheckCapture < BaseCapture
+      # https://github.com/koalaman/shellcheck/blob/6c068e7d/ShellCheck/Formatter/Format.hs#L41-L47
+      SEVERITY_MAP = {
+        "style" => "info",
+        "info" => "info",
+        "warning" => "warn",
+        "error" => "error"
+      }.freeze
+
+      def run(output)
+        JSON.parse(output).map do |warning|
+          severity = warning.fetch("level")
+          {
+            path: warning.fetch("file"),
+            position: warning.fetch("line"),
+            message: warning.fetch("message"),
+            severity: SEVERITY_MAP.fetch(severity)
+          }
+        end
+      end
+    end
+  end
+end

data/spec/gergich/capture/shellcheck_capture_spec.rb

@@ -0,0 +1,81 @@
+require_relative "../../support/capture_shared_examples"
+
+RSpec.describe Gergich::Capture::ShellcheckCapture do
+  let(:output) do
+    <<-'OUTPUT'
+[
+  {
+    "file": "bin/sync-translations.sh",
+    "line": 23,
+    "endLine": 23,
+    "column": 21,
+    "endColumn": 21,
+    "level": "style",
+    "code": 2006,
+    "message": "Use $(..) instead of legacy `..`."
+  },
+  {
+    "file": "bin/sync-translations.sh",
+    "line": 23,
+    "endLine": 23,
+    "column": 43,
+    "endColumn": 43,
+    "level": "warning",
+    "code": 2046,
+    "message": "Quote this to prevent word splitting."
+  },
+  {
+    "file": "bin/sync-translations.sh",
+    "line": 32,
+    "endLine": 32,
+    "column": 62,
+    "endColumn": 62,
+    "level": "info",
+    "code": 2086,
+    "message": "Double quote to prevent globbing and word splitting."
+  },
+  {
+    "file": "fail.sh",
+    "line": 3,
+    "endLine": 3,
+    "column": 12,
+    "endColumn": 12,
+    "level": "error",
+    "code": 1101,
+    "message": "Delete trailing spaces after \\ to break line (or use quotes for literal space)."
+  }
+]
+    OUTPUT
+  end
+
+  let(:comments) do
+    [
+      {
+        path: "bin/sync-translations.sh",
+        position: 23,
+        message: "Use $(..) instead of legacy `..`.",
+        severity: "info"
+      },
+      {
+        path: "bin/sync-translations.sh",
+        position: 23,
+        message: "Quote this to prevent word splitting.",
+        severity: "warn"
+      },
+      {
+        path: "bin/sync-translations.sh",
+        position: 32,
+        message: "Double quote to prevent globbing and word splitting.",
+        severity: "info"
+      },
+      {
+        path: "fail.sh",
+        position: 3,
+        message: "Delete trailing spaces after \\ to break line (or use quotes for literal space).",
+        severity: "error"
+      }
+    ]
+  end
+
+  it_behaves_like "a captor"
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gergich
 version: !ruby/object:Gem::Version
-  version: 0.1.17
+  version: 0.2.0
 platform: ruby
 authors:
 - Jon Jensen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-08 00:00:00.000000000 Z
+date: 2017-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -117,6 +117,7 @@ files:
 - lib/gergich/capture/flake8_capture.rb
 - lib/gergich/capture/i18nliner_capture.rb
 - lib/gergich/capture/rubocop_capture.rb
+- lib/gergich/capture/shellcheck_capture.rb
 - lib/gergich/capture/stylelint_capture.rb
 - lib/gergich/capture/swiftlint_capture.rb
 - lib/gergich/cli.rb
@@ -129,6 +130,7 @@ files:
 - spec/gergich/capture/flake8_capture_spec.rb
 - spec/gergich/capture/i18nliner_capture_spec.rb
 - spec/gergich/capture/rubocop_capture_spec.rb
+- spec/gergich/capture/shellcheck_capture_spec.rb
 - spec/gergich/capture/stylelint_capture_spec.rb
 - spec/gergich/capture/swiftlint_capture_spec.rb
 - spec/gergich/capture_spec.rb
@@ -155,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Command-line tool for adding Gerrit comments