geordi 2.8.0 → 2.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d495c07776a3b37bbc4a8a631fefc1faef059e39622bbb7d23ea7ae80e422a5d
-  data.tar.gz: 59e32fcc08b223576f916b32e39f11444474d3815add10cb8df8ea290b4beb49
+  metadata.gz: d129fad452aa0ec9658552b68ceb58190d3fb93b722ca8913ad00a68784ce3dc
+  data.tar.gz: 45905a2d5413c9cf5828b2a106f2bf32946efc6ab1229cfd9ed3012fa58a7cc0
 SHA512:
-  metadata.gz: e8090e437315b256f12e64dfff74b52d96734417af94d46dd5303aa74a41d2bf45b47d7abbb9d483f7f8794052e6bebaed336a0320c242b9a1c4eecfdde4cf69
-  data.tar.gz: bb359062fd81a8129bd48b3548bb4db513e6211bc1740003082e759d6cc5a3ba10abbf0db4e2d9a515c181b9b15b15950eafe9d733104a00e1f0789c20400750
+  metadata.gz: e91aa9acdb965944b192c23d2a43bebc49d25933b7152f56b99a3175311f4e84a7c0460961bb076b16a4cdfde648e19dc8ac072db35fd4414a3ecbdefb806b7a
+  data.tar.gz: b00fb2431da652f0cadd628bffb601c19434ba0fdd53d9ac99d463d7c6c2e365199efa271a90ada917e4d54e941c024a9f4dd990b7bc1bd4a24f4ffef87b55b0

data/CHANGELOG.md

@@ -9,6 +9,14 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 ### Breaking changes
 
 
+## 2.9.0 2020-01-03
+
+### Compatible changes
+- Fixes [#37](https://github.com/makandra/geordi/issues/37): `geordi cucumber` crashes with `--format=pretty`
+- Fixes [#27](https://github.com/makandra/geordi/issues/27): Cucumber rerun switch does work when passing files
+### Breaking changes
+
+
 ## 2.8.0 2020-01-02
 
 ### Compatible changes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    geordi (2.8.0)
+    geordi (2.9.0)
       thor (>= 0.18.0)
 
 GEM

data/features/cucumber.feature

@@ -64,6 +64,63 @@ Feature: The cucumber command
       And the output should contain "Features failed."
 
 
+  Scenario: A rerun should only consider the specified file
+    Note that we need a cucumber.yml to write the rerun.txt and read the rerun.txt for the reruns.
+
+    Given a file named "features/step_definitions/test_steps.rb" with:
+    """
+    Given /^this test fails$/ do
+      raise
+    end
+
+    Given /^I use puts with text "(.*)"$/ do |ann|
+      puts(ann)
+    end
+    """
+      And a file named "features/some.feature" with:
+      """
+      Feature: Failing feature
+        Scenario: Passing scenario
+          And I use puts with text "Running passing Feature"
+
+        Scenario: Failing scenario
+          And I use puts with text "Running failing Feature"
+          And this test fails
+      """
+      And an empty file named "tmp/rerun.txt"
+      And a file named "cucumber.yml" with:
+      """
+      <%
+      rerun_log = 'tmp/rerun.txt'
+      rerun_failures = File.file?(rerun_log) ? File.read(rerun_log).gsub("\n", ' ') : ''
+      log_failures = "--format=rerun --out=#{rerun_log}"
+      %>
+      default: features <%= log_failures %>
+      rerun: <%= rerun_failures %> <%= log_failures %>
+      """
+
+    When I run `geordi cucumber --rerun=1 features/some.feature`
+    Then the output should contain:
+    """
+    # Rerun #1 of 1
+    > Rerunning failed scenarios
+    > Run `geordi vnc` to view the Selenium test browsers
+
+    Using the rerun profile...
+
+    Running failing Feature
+    .F
+
+    (::) failed steps (::)
+
+     (RuntimeError)
+    features/some.feature:7:in `And this test fails'
+
+    Failing Scenarios:
+    cucumber -p rerun features/some.feature:5 # Scenario: Failing scenario
+    """
+
+
   Scenario: Running all features in a given subfolder
     Given a file named "features/sub/one.feature" with:
     """
@@ -191,3 +248,14 @@ Feature: The cucumber command
     When I run `geordi cucumber --containing given`
     Then the output should contain "Only: features/given.feature"
     But the output should not contain "other.feature"
+
+
+  Scenario: Passing a format argument will skip the default format for a single run
+    Given a file named "features/single.feature" with:
+    """
+    Feature: Running a single feature
+      Scenario: A single scenario
+    """
+
+    When I run `geordi cucumber features/single.feature --format=pretty --verbose`
+    Then the output should contain "b cucumber features/single.feature --format pretty"

data/lib/geordi/commands/cucumber.rb

@@ -88,7 +88,7 @@ def cucumber(*args)
         fail 'Features failed.' if (i == options.rerun) # All reruns done?
 
         announce "Rerun ##{ i + 1 } of #{ options.rerun }"
-        break if Geordi::Cucumber.new.run(files, cmd_opts, :verbose => options.verbose, :parallel => false)
+        break if Geordi::Cucumber.new.run([], cmd_opts, :verbose => options.verbose, :parallel => false)
       end
     end
 

data/lib/geordi/cucumber.rb

@@ -16,7 +16,7 @@ module Geordi
     VNC_ENV_VARIABLES = %w[DISPLAY BROWSER LAUNCHY_BROWSER]
 
     def run(files, cucumber_options, options = {})
-      self.argv = files + cucumber_options
+      self.argv = files + cucumber_options.map { |option| option.split('=') }.flatten
 
       consolidate_rerun_txt_files
       show_features_to_run

data/lib/geordi/version.rb

@@ -1,3 +1,3 @@
 module Geordi
-  VERSION = '2.8.0'
+  VERSION = '2.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geordi
 version: !ruby/object:Gem::Version
-  version: 2.8.0
+  version: 2.9.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-02 00:00:00.000000000 Z
+date: 2020-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor