geordi 2.7.0 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 17516fcb96c1a27828c5e43eea96d1ca0d8f72df42e467ff842a70a002b86459
-  data.tar.gz: 8985476313a0c6ed93e494878e388edd3ba72a8911c7785dfe53cc9f7e17c284
+  metadata.gz: d495c07776a3b37bbc4a8a631fefc1faef059e39622bbb7d23ea7ae80e422a5d
+  data.tar.gz: 59e32fcc08b223576f916b32e39f11444474d3815add10cb8df8ea290b4beb49
 SHA512:
-  metadata.gz: afcfaace06ff3ee48b5165de088849c537d73dea2ac544807793f59902634e07b879ca6968c12e0df3deb375686ea377fe63fd531724dae7a2125028fa9a0189
-  data.tar.gz: 1dbac4ddff4d8c4b505756bd7ea36a2d667141268ebf90f28fd6faec32b6afb092f1f4dc32ff6442f13b07a5bc84398530bd695e1668e23ce42076752a0f7989
+  metadata.gz: e8090e437315b256f12e64dfff74b52d96734417af94d46dd5303aa74a41d2bf45b47d7abbb9d483f7f8794052e6bebaed336a0320c242b9a1c4eecfdde4cf69
+  data.tar.gz: bb359062fd81a8129bd48b3548bb4db513e6211bc1740003082e759d6cc5a3ba10abbf0db4e2d9a515c181b9b15b15950eafe9d733104a00e1f0789c20400750

data/CHANGELOG.md

@@ -9,7 +9,13 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 ### Breaking changes
 
 
-## Unreleased
+## 2.8.0 2020-01-02
+
+### Compatible changes
+- Fixed [#77](https://github.com/makandra/geordi/issues/77): Remove deprecation warning for "Bundler.clean_system"
+
+
+## 2.7.0 2019-11-25
 
 ### Compatible changes
 - Fixed [#68](https://github.com/makandra/geordi/issues/68): The "cucumber" command now fails early when @solo features fail.
@@ -22,7 +28,6 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 ## 2.6.0 2019-11-04
 
 ### Compatible changes
-
 - Added [#73](https://github.com/makandra/geordi/issues/73): New command `chromdriver-update` allows you to update your
   chromedriver to the newest matching version.
 

data/Gemfile

@@ -8,5 +8,8 @@ gem 'rspec-mocks'
 gem 'highline'
 gem 'parallel_tests'
 gem 'launchy'
-gem 'tracker_api'
-# gem 'pry' # Not supported for 1.8.7
+
+if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('1.8.7')
+  gem 'pry'
+  gem 'tracker_api'
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    geordi (2.7.0)
+    geordi (2.8.0)
       thor (>= 0.18.0)
 
 GEM
@@ -19,6 +19,7 @@ GEM
     builder (3.2.3)
     childprocess (1.0.1)
       rake (< 13.0)
+    coderay (1.1.2)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
     cucumber (1.3.20)
@@ -44,6 +45,7 @@ GEM
     ice_nine (0.11.2)
     launchy (2.4.3)
       addressable (~> 2.3)
+    method_source (0.9.2)
     mimemagic (0.3.3)
     multi_json (1.13.1)
     multi_test (0.1.2)
@@ -51,6 +53,9 @@ GEM
     parallel (0.5.16)
     parallel_tests (0.6.18)
       parallel
+    pry (0.12.2)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
     rake (10.5.0)
     representable (3.0.4)
       declarative (< 0.1.0)
@@ -91,6 +96,7 @@ DEPENDENCIES
   highline
   launchy
   parallel_tests
+  pry
   rspec-mocks
   tracker_api
 

data/Rakefile

@@ -5,7 +5,11 @@ desc 'Default: Run all tests'
 task :default => :features
 
 task :features do
-  system 'bundle exec cucumber'
+  if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('1.8.7')
+    system 'bundle exec cucumber'
+  else
+    system 'bundle exec cucumber --tags "~@ruby>=1.9"'
+  end
 end
 
 task :readme do

data/features/commit.feature

@@ -1,4 +1,4 @@
-@announce-output
+@ruby>=1.9
 Feature: Creating a git commit from a Pivotal Tracker story
 
   Scenario: Extra arguments are forwarded to "git commit"

data/features/firefox.feature

@@ -18,20 +18,6 @@ Feature: The firefox/chrome command
     Then the output should contain "> Run `geordi vnc` to view the Selenium test browsers"
       And the output should contain "testcontent"
 
-
-    # Could not get this to work
-#  Scenario: Running a command with VNC and Firefox set up
-#    Given a mocked home directory
-#    Given a file named ".firefox-version" with "1337"
-#      And a file named "bin/firefoxes/1337/firefox" with "<fake>"
-#      And a file named "testfile" with "testcontent"
-#
-#    When I run `geordi firefox cat testfile`
-#    Then the output should contain "> VNC is ready"
-#      And the output should contain "> Firefox for Selenium set up"
-#      And the output should contain "testcontent"
-
-
   Scenario: Having a .firefox-version that is not installed yet
     Given a file named ".firefox-version" with "1337"
       And a file named "testfile" with "testcontent"

data/features/support/env.rb

@@ -1,5 +1,8 @@
 require 'aruba/cucumber'
-# require 'pry'
+
+if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('1.8.7')
+  require 'pry'
+end
 
 # Disables execution of Util.system! calls
 ENV['GEORDI_TESTING'] = 'true'

data/lib/geordi/util.rb

@@ -49,7 +49,16 @@ module Geordi
           puts "Util.system! #{ commands.join ', ' }"
         else
           # Remove Geordi's Bundler environment when running commands.
-          success = defined?(Bundler) ? Bundler.clean_system(*commands) : system(*commands)
+          success = if !defined?(Bundler)
+            system(*commands)
+          elsif Gem::Version.new(Bundler::VERSION) >= Gem::Version.new('2.1.2')
+            Bundler.with_unbundled_env do
+              system(*commands)
+            end
+          else
+            Bundler.clean_system(*commands)
+          end
+
           success or fail(options[:fail_message] || 'Something went wrong.')
         end
       end

data/lib/geordi/version.rb

@@ -1,3 +1,3 @@
 module Geordi
-  VERSION = '2.7.0'
+  VERSION = '2.8.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geordi
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.8.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-25 00:00:00.000000000 Z
+date: 2020-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor