geocode_records 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 92787a0bf5d0542da97fc0cc07baadeefb3b3e76
-  data.tar.gz: b2d11164ad2de539cc9cd89d1f354f08bf12bdca
+SHA256:
+  metadata.gz: 41292738054861f5efb53e50355e09445d4c120c582722309b9a2ef5da16721c
+  data.tar.gz: 5dd66f6b3150713e38613189c4ffce488c91532a936fc7aa17a4b676a233c786
 SHA512:
-  metadata.gz: d1b65fe2aea63da45dca35718cf4edf559fd51d949a33cefdac866436cb9eff02642215bd6e75f665ef8dbffa1cc170954db0a0429e78e7bb2884f4bc26ea793
-  data.tar.gz: ab4e697cf55ee682d69d299251647fcdb4c3ee145f144ca9e07a8c977c192a26aa926149f5eec8a5bc9e2681b569c2d296d56435fd8652de3cdb308b5a295dc2
+  metadata.gz: 21bf2350fc512ae6fa35b3f9e662070cad2bd6d6d1ecbaaf6a37061cee57b8652784dda2687756a377f694d2073de2ae889e19190d54ab918104496cdc9198c7
+  data.tar.gz: d3531bc7961870f437740ab83970869262ce63072e21d1d82ec2dffae0aa0054bbb80e90cebc853533dcbf89208df933dd64be7130d5ddb05f1fbf65ba03b6ab

data/CHANGELOG

@@ -1,3 +1,9 @@
+1.4.1 / 2018-11-23
+
+* Enhancements
+
+  * Don't leak creds in errors
+
 1.4.0 / 2018-04-13
 
 * Breaking changes

data/lib/geocode_records.rb

@@ -15,14 +15,6 @@ class GeocodeRecords
       Dir::Tmpname.create(hint[0,64].delete('"').gsub(/\W/,'_').squeeze) {}
     end
 
-    def system(*args)
-      result = Kernel.system(*args)
-      unless result
-        raise "failed command:\n#{Shellwords.join args}"
-      end
-      nil
-    end
-
     def psql(database_url, sql)
       system(
         'psql',
@@ -33,7 +25,7 @@ class GeocodeRecords
         '--no-psqlrc',
         '--pset', 'pager=off',
         '--command', sql
-      )
+      ) or raise("psql failed")
     end
   end
 

data/lib/geocode_records/geocode_csv.rb

@@ -60,7 +60,7 @@ class GeocodeRecords
       input_map.each do |ss, local|
         args += [ "--#{ss}-col", local.to_s ]
       end
-      GeocodeRecords.system(*args)
+      system(*args) or raise("smartystreets failed")
       memo
     end
 

data/lib/geocode_records/update_table_from_csv.rb

@@ -109,12 +109,12 @@ class GeocodeRecords
 
     def strip_csv
       memo = GeocodeRecords.new_tmp_path('stripped')
-      GeocodeRecords.system(
+      system(
         'xsv',
         'select', DESIRED_COLUMNS.join(','),
         path,
         out: memo
-      )
+      ) or raise("xsv failed")
       memo
     end
 

data/lib/geocode_records/version.rb

@@ -1,3 +1,3 @@
 class GeocodeRecords
-  VERSION = '1.4.0'
+  VERSION = '1.4.1'
 end

data/spec/spec_helper.rb

@@ -7,7 +7,7 @@ dbname = 'geocode_records_test'
 ENV['DATABASE_URL'] = "postgresql://127.0.0.1:#{ENV['PGPORT'] || 5432}/#{dbname}"
 
 unless ENV['FAST'] == 'true'
-  GeocodeRecords.system('createdb', ENV.fetch('DATABASE_URL')) rescue nil
+  system('createdb', ENV.fetch('DATABASE_URL')) rescue nil
   GeocodeRecords.psql(
     ENV.fetch('DATABASE_URL'),
     'CREATE EXTENSION IF NOT EXISTS postgis'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geocode_records
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Seamus Abshere
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-13 00:00:00.000000000 Z
+date: 2018-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -152,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Geocode an ActiveRecord::Relation with node_smartystreets