gemsmith 9.0.0 → 9.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b08284244aeaddea3f3d3b8b96080bc3e836b950
-  data.tar.gz: 1c5ffe0e06e10034acee7795a8bf8586325c783d
+  metadata.gz: e5f55d84251f20431e1121f296e9d86012d0a3a5
+  data.tar.gz: c675b86c73436f12fdebc56c10539e1d4a9b3c61
 SHA512:
-  metadata.gz: ba6952350cd01cbbf932a83ab3afefb4221a9540b8807109b12fc995c13e22763bf4d59532bbd8047463962f1c492a1627d628a0f02776fca5327eeb4eec2316
-  data.tar.gz: c7b95301f395bc829f2949aea66f9226a40012a30ded74e47b749328717ae3e24218a099f3304c4b516deed99cd00ef77ca6f8a0f4864f57911d96150c5ba486
+  metadata.gz: d486e73b98e1f8fc9c7407862fb30a8c9a4f6fdd1859d877db698523b9feb11d93989f793935ceb17ea3fcc3f0e7ec732b4bc3a6fbc29f95a0df817db7810686
+  data.tar.gz: e748b627bcceae7c034a904205b17b6d56f3e5e4fdc9bd741d56babdba1741dd2601cb7046ffbc5a193908e3d288f8a2edcc3e7e4c85e58e7f1cf72281a46b73

data/lib/gemsmith/cli.rb

@@ -28,6 +28,7 @@ module Gemsmith
       File.expand_path File.join(File.dirname(__FILE__), "templates")
     end
 
+    # rubocop:disable Metrics/MethodLength
     def self.configuration
       Runcom::Configuration.new file_name: Identity.file_name, defaults: {
         year: Time.now.year,
@@ -161,6 +162,7 @@ module Gemsmith
                   desc: "Add Patreon support.",
                   type: :boolean,
                   default: configuration.to_h.dig(:generate, :patreon)
+    # rubocop:disable Metrics/AbcSize
     def generate name
       print_cli_and_rails_engine_option_error && return if options.cli? && options.rails?
 

data/lib/gemsmith/credentials.rb

@@ -46,6 +46,7 @@ module Gemsmith
       credentials? && !String(credentials[key]).empty?
     end
 
+    # rubocop:disable Metrics/AbcSize
     def create
       return if valid?
 

data/lib/gemsmith/generators/cli.rb

@@ -4,6 +4,7 @@ module Gemsmith
   module Generators
     # Generates Command Line Interface (CLI) support.
     class CLI < Base
+      # rubocop:disable Metrics/AbcSize
       def run
         return unless configuration.dig(:generate, :cli)
 

data/lib/gemsmith/generators/gem.rb

@@ -4,6 +4,7 @@ module Gemsmith
   module Generators
     # Generates default gem support.
     class Gem < Base
+      # rubocop:disable Metrics/AbcSize
       def run
         cli.template "%gem_name%/bin/setup.tt", configuration
         cli.template "%gem_name%/Gemfile.tt", configuration

data/lib/gemsmith/generators/rails.rb

@@ -19,6 +19,7 @@ module Gemsmith
         cli.run "rails plugin new --skip #{configuration.dig :gem, :name} #{engine_options}"
       end
 
+      # rubocop:disable Metrics/AbcSize
       def create_generator_files
         cli.empty_directory "#{generator_root}/templates"
         cli.template "#{generator_root}/install/install_generator.rb.tt", configuration

data/lib/gemsmith/generators/rake.rb

@@ -1,40 +1,67 @@
 # frozen_string_literal: true
 
+require "refinements/arrays"
+
 module Gemsmith
   module Generators
     # Generates Rake support.
     class Rake < Base
+      using Refinements::Arrays
+
+      def generate_code_quality_task
+        return "" if code_quality_tasks.empty?
+        %(\ndesc "Run code quality checks"\ntask code_quality: %i[#{code_quality_tasks}]\n)
+      end
+
+      def generate_default_task
+        return "" if default_task.empty?
+        %(\ntask default: %i[#{default_task}]\n)
+      end
+
       def run
         cli.template "%gem_name%/Rakefile.tt", configuration
-        configure_rakefile
+        append_code_quality_task
+        append_default_task
       end
 
       private
 
       def rspec_task
-        "spec" if configuration.dig(:generate, :rspec)
+        configuration.dig(:generate, :rspec) ? "spec" : ""
       end
 
       def reek_task
-        "reek" if configuration.dig(:generate, :reek)
+        configuration.dig(:generate, :reek) ? "reek" : ""
       end
 
       def rubocop_task
-        "rubocop" if configuration.dig(:generate, :rubocop)
+        configuration.dig(:generate, :rubocop) ? "rubocop" : ""
       end
 
       def scss_lint_task
-        "scss_lint" if configuration.dig(:generate, :scss_lint)
+        configuration.dig(:generate, :scss_lint) ? "scss_lint" : ""
+      end
+
+      def code_quality_tasks
+        [reek_task, rubocop_task, scss_lint_task].compress.join " "
+      end
+
+      def code_quality_task
+        code_quality_tasks.empty? ? "" : "code_quality"
+      end
+
+      def default_task
+        [code_quality_task, rspec_task].compress.join " "
       end
 
-      def default_tasks
-        [rspec_task, reek_task, rubocop_task, scss_lint_task].compact
+      def append_code_quality_task
+        return if code_quality_task.empty?
+        cli.append_to_file "%gem_name%/Rakefile", generate_code_quality_task
       end
 
-      def configure_rakefile
-        return if default_tasks.empty?
-        cli.append_to_file "%gem_name%/Rakefile",
-                           %(\ntask default: %w[#{default_tasks.join(" ")}]\n)
+      def append_default_task
+        return if default_task.empty?
+        cli.append_to_file "%gem_name%/Rakefile", generate_default_task
       end
     end
   end

data/lib/gemsmith/identity.rb

@@ -12,7 +12,7 @@ module Gemsmith
     end
 
     def self.version
-      "9.0.0"
+      "9.1.0"
     end
 
     def self.version_label

data/lib/gemsmith/rake/publisher.rb

@@ -30,6 +30,7 @@ module Gemsmith
         @kernel = kernel
       end
 
+      # rubocop:disable Metrics/AbcSize
       def push
         creds = credentials.new key: gem_spec.allowed_push_key.to_sym,
                                 url: gem_spec.allowed_push_host

data/lib/gemsmith/rake/tasks.rb

@@ -29,6 +29,8 @@ module Gemsmith
         @publisher = publisher
       end
 
+      # rubocop:disable Metrics/AbcSize
+      # rubocop:disable Metrics/MethodLength
       def install
         desc "Update README (table of contents)"
         task :doc do

data/lib/gemsmith/templates/%gem_name%/.codeclimate.yml.tt

@@ -1,9 +1,9 @@
----
+prepare:
+  fetch:
+    - https://raw.githubusercontent.com/bkuhlmann/code_quality/v0.1.0/configurations/.rubocop.yml
 engines:
   shellcheck:
     enabled: true
-  bundler-audit:
-    enabled: true
   reek:
     enabled: <%= config.dig :generate, :reek %>
   rubocop:
@@ -16,13 +16,6 @@ engines:
       languages:
       - ruby
       - javascript
-  fixme:
-    enabled: true
-    config:
-      strings:
-        - TODO
-        - FIX
-        - DUPLICATE
 ratings:
   paths:
   - "app/**/*"

data/lib/gemsmith/templates/%gem_name%/.gitignore.tt

@@ -1,4 +1,6 @@
 *.gem
 .bundle
+.rubocop-http*
 pkg/*
 Gemfile.lock
+tmp

data/lib/gemsmith/templates/%gem_name%/.rubocop.yml.tt

@@ -1,50 +1,6 @@
+inherit_from:
+  - https://raw.githubusercontent.com/bkuhlmann/code_quality/v0.1.0/configurations/.rubocop.yml
 <%- if config.dig(:generate, :rails) -%>
-AllCops:
-  Exclude:
-    - "spec/dummy/**/*"
-    - "bin/rails"
-    - "vendor/**/*"
 Rails:
   Enabled: true
 <%- end -%>
-Style/AndOr:
-  EnforcedStyle: conditionals
-Style/CaseIndentation:
-  IndentOneStep: true
-Style/Documentation:
-  Enabled: false
-Style/EmptyMethod:
-  EnforcedStyle: expanded
-Style/MethodDefParentheses:
-  EnforcedStyle: require_no_parentheses
-Style/NumericLiterals:
-  Enabled: false
-Style/PercentLiteralDelimiters:
-  PreferredDelimiters:
-    "%w": "[]"
-    "%W": "[]"
-    "%i": "[]"
-    "%I": "[]"
-    "%r": "()"
-Style/SafeNavigation:
-  Enabled: false
-Style/SignalException:
-  EnforcedStyle: semantic
-Style/SingleLineBlockParams:
-  Enabled: false
-Style/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
-Style/VariableNumber:
-  EnforcedStyle: snake_case
-Metrics/BlockLength:
-  Exclude:
-    - "**/*.gemspec"
-    - "spec/**/*"
-Metrics/LineLength:
-  Max: 100
-Metrics/ParameterLists:
-  Max: 3

data/lib/gemsmith/templates/%gem_name%/.travis.yml.tt

@@ -3,7 +3,7 @@ language: ruby
 gemfile:
   - gemfiles/rails-<%= config.dig(:versions, :rails) %>.x.gemfile
 <%- end -%>
-before_install: gem update --system && gem update && gem cleanup
+before_install: gem update --system
 <%- if config.dig(:generate, :code_climate) -%>
 after_script: bundle exec codeclimate-test-reporter
 <%- end -%>

data/lib/gemsmith/templates/%gem_name%/CONTRIBUTING.md.tt

@@ -1,33 +1,25 @@
 # Overview
 
-Thanks for taking an interest in this open source project. Your support and involvement is greatly appreciated. The
-following details what you need to know in order to contribute.
+Thanks for taking an interest in this open source project. Your support and involvement is greatly
+appreciated. The following details what you need to know in order to contribute.
 
 # Requirements
 
-- Follow these [Basic Programming Styles](https://github.com/bkuhlmann/style_guides/blob/master/programming/basic.md).
-- Follow these [Code Review Styles](https://github.com/bkuhlmann/style_guides/blob/master/programming/code_reviews.md).
-- Follow these [Git Styles](https://github.com/bkuhlmann/style_guides/blob/master/programming/git.md).
-- Follow these [Bash Styles](https://github.com/bkuhlmann/style_guides/blob/master/programming/languages/bash.md).
-- Follow these [CSS Styles](https://github.com/bkuhlmann/style_guides/blob/master/programming/languages/css.md).
-- Follow these [Ruby Styles](https://github.com/bkuhlmann/style_guides/blob/master/programming/languages/ruby/ruby.md).
+Read through the [Programming Style
+Guides](https://github.com/bkuhlmann/style_guides/tree/master/programming).
 
 # Contributing Code
 
-0. Read the project README thoroughly before starting.
-0. Fork the master branch of the repository.
-0. Ensure there are no setup, usage, and/or test issues (again, follow the README).
-0. Add tests for new functionality (refactoring and documentation changes can be excluded).
-0. Ensure all tests pass.
-0. Push your feature branch and submit a pull request.
+0. Read the project README before starting.
+0. Fork the `master` branch of the repository.
+0. Ensure there are no setup, usage, and/or test issues (see README for details).
+0. Add tests for new functionality and ensure they pass.
+0. Submit a pull request and follow the instructions it provides.
 
 # Submitting Issues
 
 0. Submit an issue via the GitHub Issues tab (assuming one does not already exist).
-0. Clearly describe the issue (including steps to reproduce).
-0. Specify your enviroment setup (OS, browser, language, etc. with version info).
-0. Provide a stack dump (if possible).
-0. Explain any additional details that might help diagnose the problem quickly.
+0. Follow the instructions provided within the GitHub issue template.
 
 # Feedback
 

data/lib/gemsmith/templates/%gem_name%/spec/spec_helper.rb.tt

@@ -16,6 +16,7 @@ Dir[File.join(File.dirname(__FILE__), "support/shared_contexts/**/*.rb")].each d
 end
 
 RSpec.configure do |config|
+  config.color = true
   config.order = "random"
   config.disable_monkey_patching!
   config.filter_run_when_matching :focus

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gemsmith
 version: !ruby/object:Gem::Version
-  version: 9.0.0
+  version: 9.1.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -30,7 +30,7 @@ cert_chain:
   n/LUZ1dKhIHzfKx1B4+TEIefArObGfkLIDM8+Dq1RX7TF1k81Men7iu4MgE9bYBn
   3dE+xI3FdB5gWcdWxdtgRCmWjtXeYYyb4z6NQQ==
   -----END CERTIFICATE-----
-date: 2017-01-22 00:00:00.000000000 Z
+date: 2017-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -457,7 +457,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.9
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: A command line interface for smithing new Ruby gems.