gems-status 1.65.0 → 1.66.0

data/VERSION

@@ -1 +1 @@
-1.65.0
+1.66.0

data/lib/gems-status/checkers/not_a_security_alert_checker.rb

@@ -48,7 +48,7 @@ module GemsStatus
    private
 
     def match_name(str, name)
-      str =~ /[gem|ruby].*\b#{name}\b/ || str =~ /#{name}\b.*[gem|ruby].*\b/
+      str =~ /(gem|ruby).*\b#{name}\b/ || str =~ /\b#{name}\b.*(gem|ruby).*/
     end
 
     def message(gem)

data/test/test-not_a_security_alert_checker.rb

@@ -48,9 +48,22 @@ module GemsStatus
     def test_match_name
       ch = NotASecurityAlertChecker.new([])
       assert ch.match_name("rubygem mail", "mail")
+      assert ch.match_name("mail rubygem", "mail")
       assert !ch.match_name("mail","mail")
-      assert ch.match_name("ruby mail", "mail")
+      assert ch.match_name("gem mail", "mail")
+      assert ch.match_name("gem mail something", "mail")
+      assert ch.match_name("ruby something mail", "mail")
+      assert ch.match_name("ruby something mail something", "mail")
+      assert ch.match_name("something ruby something mail", "mail")
       assert ch.match_name("mail gem", "mail")
+      assert ch.match_name("mail something gem", "mail")
+      assert ch.match_name("mail gem something", "mail")
+      assert ch.match_name("mail ruby", "mail")
+      assert ch.match_name("something mail ruby", "mail")
+      assert ch.match_name("something mail ruby something", "mail")
+      assert ch.match_name("ruby something mail", "mail")
+      assert !ch.match_name("ruby somethingmail", "mail")
+      assert !ch.match_name("somethingmail ruby", "mail")
     end
 
     def test_key_for_emails
@@ -75,7 +88,7 @@ module GemsStatus
       assert_equal 1, ch.security_messages.length
     end
 
-    def test_look_in_emails_for_other_mail
+    def test_look_in_emails_for_gem_name
       mail = MockEmail.new
       def mail.subject
         "gem rails"
@@ -95,6 +108,106 @@ module GemsStatus
       assert_equal 1, ch.security_messages.length
     end
 
+    def test_look_in_emails_for_invalid_gem_name
+      mail = MockEmail.new
+      def mail.subject
+        "rails issue"
+      end
+      ch  = NotASecurityAlertChecker.new([])
+      ch.emails = {
+        "other" => [mail]
+      }
+      gem = MockGem.new
+      def gem.name
+        "rails"
+      end
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+      ch.look_in_emails(gem)
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+    end
+
+    def test_look_in_emails_for_other_gem
+      mail = MockEmail.new
+      def mail.subject
+        "gem rails"
+      end
+      ch  = NotASecurityAlertChecker.new([])
+      ch.emails = {
+        "other" => [mail]
+      }
+      gem = MockGem.new
+      def gem.name
+        "other"
+      end
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+      ch.look_in_emails(gem)
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+    end
+
+    def test_look_in_emails_for_ruby_and_gem_name
+      mail = MockEmail.new
+      def mail.subject
+        "ruby blablabla rails"
+      end
+      ch  = NotASecurityAlertChecker.new([])
+      ch.emails = {
+        "other" => [mail]
+      }
+      gem = MockGem.new
+      def gem.name
+        "rails"
+      end
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+      ch.look_in_emails(gem)
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 1, ch.security_messages.length
+    end
+
+    def test_look_in_emails_for_gem_name_in_a_word
+      mail = MockEmail.new
+      def mail.subject
+        "gem something_rails"
+      end
+      ch  = NotASecurityAlertChecker.new([])
+      ch.emails = {
+        "other" => [mail]
+      }
+      gem = MockGem.new
+      def gem.name
+        "rails"
+      end
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+      ch.look_in_emails(gem)
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+    end
+
+    def test_look_in_emails_for_gem_name_in_a_word_2
+      mail = MockEmail.new
+      def mail.subject
+        "gem rails_something"
+      end
+      ch  = NotASecurityAlertChecker.new([])
+      ch.emails = {
+        "other" => [mail]
+      }
+      gem = MockGem.new
+      def gem.name
+        "rails"
+      end
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+      ch.look_in_emails(gem)
+      assert_equal Hash, ch.security_messages.class
+      assert_equal 0, ch.security_messages.length
+    end
+
     def test_gem_uri_with_project_uri
       ch = NotASecurityAlertChecker.new([])
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gems-status
 version: !ruby/object:Gem::Version
-  version: 1.65.0
+  version: 1.66.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-19 00:00:00.000000000 Z
+date: 2013-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xml-simple
@@ -171,6 +171,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: gem-status compares rubygems information from different sources as for
   reporting which gems are outdated. Sources can be opensuse build service, rubygems.org
   or a gemfile.lock. Data compared is version and md5sum
@@ -235,7 +251,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -30078519537723814
+      hash: 2031904970203107107
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -244,7 +260,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -30078519537723814
+      hash: 2031904970203107107
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25