gems-status 0.49.0 → 0.50.0

data/VERSION

@@ -1 +1 @@
-0.49.0
+0.50.0

data/bin/gems-status

@@ -1,4 +1,7 @@
 #!/usr/bin/ruby
+# -*- coding: UTF-8 -*-
+
+require "erb"
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require "gems-status"
 
@@ -19,9 +22,9 @@ end
 
 conf_file = ARGV[0]
 begin
-  conf = YAML::load(File::open(conf_file))
+  conf = YAML::load(ERB.new(File::read(conf_file)).result)
 rescue
-  Utils::log_error("?", "There was a problem opening #{conf_file}")
+  GemsStatus::Utils::log_error("?", "There was a problem opening #{conf_file}")
 end
 gs = GemsStatus::GemStatus.new(conf)
 gs.execute

data/lib/gems-status.rb

@@ -15,12 +15,12 @@ module GemsStatus
   class GemStatus
     def initialize(conf)
       @conf = conf
+      Utils::known_licenses = @conf["licenses"]
       @gems_composite_command = nil
-      @gems_composite_command = GemsCompositeCommand.new(@conf["target"])
-      @conf["sources"].each do |c| 
-        gems = eval(c["classname"]).new(c)
-        @gems_composite_command.add_command(gems)
-      end
+      @gems_composite_command = GemsCompositeCommand.new
+      c = @conf["source"]
+      gems = eval(c["classname"]).new(c)
+      @gems_composite_command.command = gems
       if @conf["checkers"]
         @conf["checkers"].each do |c|
           checker = eval(c["classname"]).new(c)

data/lib/gems-status/checkers.rb

@@ -1,11 +1,11 @@
-require "gems-status/checkers/exists_in_upstream"
+require "gems-status/checkers/is_rubygems"
 require "gems-status/checkers/git_check_messages"
 require "gems-status/checkers/hg_check_messages"
 require "gems-status/checkers/not_a_security_alert_checker"
-require "gems-status/checkers/not_native_gem_checker"
-require "gems-status/checkers/not_rails_checker"
 require "gems-status/checkers/scm_check_messages"
 require "gems-status/checkers/scm_security_messages"
 require "gems-status/checkers/svn_check_messages"
 require "gems-status/checkers/print_gem_versions"
+require "gems-status/checkers/has_a_license"
+require "gems-status/checkers/is_not_gpl"
 

data/lib/gems-status/checkers/has_a_license.rb

@@ -0,0 +1,12 @@
+module GemsStatus
+  class HasALicense
+    def initialize(conf)
+    end
+    def check?(gem)
+      gem.license && !gem.license.empty?
+    end
+    def description
+      "This gem has not license"
+    end
+  end
+end

data/lib/gems-status/checkers/is_not_gpl.rb

@@ -0,0 +1,15 @@
+module GemsStatus
+  class IsNotGpl
+    def initialize(conf)
+    end
+    def check?(gem)
+      if !gem.license || gem.license.empty?
+       return true
+      end
+      gem.license.upcase != "GPL"
+    end
+    def description
+      "This gem is GPL"
+    end
+  end
+end

data/lib/gems-status/checkers/is_rubygems.rb

@@ -0,0 +1,36 @@
+require 'rubygems'
+require 'open-uri'
+require 'gems-status/checkers/gem_checker'
+require 'gems-status/utils'
+
+module GemsStatus
+
+  class IsRubygems < GemChecker
+
+    def initialize(configuration)
+      @md5 = nil
+      @gem_md5 = nil
+      super configuration
+    end
+
+    def check?(gem)
+      Utils::log_debug("Looking for #{gem.name}")
+      result = nil
+      gem_uri = "http://rubygems.org/downloads/#{gem.name}-#{gem.version}.gem" 
+      @md5 = Utils::download_md5(gem.name, gem.version, "http://rubygems.org/downloads")
+      @gem_md5 = gem.md5
+      !@md5 && !@gem_md5 && @gem_md5== @md5
+    end
+    
+    def description
+      if !@md5
+        "This gem does not exist in rubygems.org "
+      elsif !@gem_md5
+        "This gem does not exist in your server"
+      elsif @md5 != @gem_md5
+        "This gem has a different md5sum than in rubygems.org\nrubygems: #{@md5} your server #{@gem_md5}"
+      end
+    end
+  end
+
+end

data/lib/gems-status/checkers/not_a_security_alert_checker.rb

@@ -14,12 +14,7 @@ module GemsStatus
   class NotASecurityAlertChecker < GemChecker
     def initialize(conf)
       Utils::check_parameters('NotASecurityAlertChecker', conf, ["fixed", "source_repos", "email_username", "email_password", "mailing_lists", "email_to"])
-      begin
-        @fixed = YAML::load(File::open(conf["fixed"]))
-      rescue
-        Utils::log_error("?", "There was a problem opening #{conf["fixed"]}")
-        @fixed = []
-      end
+      @fixed = conf["fixed"]
       @source_repos = conf["source_repos"]
       @security_messages = {}
       @email_username = conf["email_username"]

data/lib/gems-status/checkers/print_gem_versions.rb

@@ -2,13 +2,7 @@ module GemsStatus
 
   class PrintGemVersions
     def initialize(conf)
-      Utils::check_parameters('PrintGemVersions', conf, ["licenses"])
-      begin
-        @licenses = YAML::load(File::open(conf["licenses"]))
-      rescue
-        Utils::log_error("?", "There was a problem opening #{conf["licenses"]}")
-        @licenses = []
-      end
+      @licenses = Utils::known_licenses
     end
 
     def check?(gem)

data/lib/gems-status/gem_simple.rb

@@ -11,37 +11,15 @@ module GemsStatus
       @dependencies = dependencies
     end
 
-    #TODO: write a test for this
-    def depends?(gem)
-      if !@dependencies
-        Utils::log_error(@name, "trying to get depends on a gem that has no info on dependencies #{@name} depends #{gem.name}")
-        return false
-      end
-      @dependencies.each do |dep|
-        return true if dep.name == gem.name
-      end
-      return false
+    def from_git?
+      return @gems_url && @gems_url.start_with?("git://")
     end
 
-    #TODO: write a test for this
-    def merge_deps(gem)
-      if !@dependencies || !gem.dependencies
-        Utils::log_error(@name, "trying to merge depends on a gem that has no info on dependencies #{@name} merge #{gem.name}")
-        return false
-      end
-      changes = false
-      gem.dependencies.each do |dep|
-        if !@dependencies.include?(dep)
-          changes = true
-          @dependencies << dep
-          Utils::log_debug("adding #{dep} to dependencies")
-        end
+    def license
+      if from_git?
+        return nil
       end
-      return changes
-    end
-
-    def from_git?
-      return @gems_url && @gems_url.start_with?("git://")
+      Utils::download_license(@name, @version, @gems_url)
     end
 
     def date

data/lib/gems-status/gems_composite_command.rb

@@ -1,23 +1,18 @@
 require "gems-status/gem_simple"
 require "gems-status/gems_command"
-require "gems-status/html_view"
+require "gems-status/text_view"
 
 module GemsStatus
 
   class GemsCompositeCommand < GemsCommand
-    attr_accessor :results, :checker_results
+    attr_accessor :results, :checker_results, :command
 
-    def initialize(target)
-      @commands = []
+    def initialize
+      @command = []
       @checkers = []
       @checker_results = {}
       @comments = {}
-      @results = {}
-      @target = target
-    end
-
-    def add_command(command)
-      @commands << command
+      @results = []
     end
 
     def add_checker(check_object)
@@ -25,88 +20,38 @@ module GemsStatus
     end
 
     def execute
-      threads = []
-      if !@commands then
-        return
-      end
-      @commands.each do |command|
-        threads << Thread.new { command.execute }
-      end
-      threads.each { |aThread| aThread.join }
-      @commands.each do |command|
-        @results[command.ident] = command.result
-      end
+      return unless @command
+      @command.execute
+      @results << @command.result
       @checkers.each do |check_object|
         Utils::log_debug "checking #{check_object.class.name}"
-        @results[@target].sort.each do |k, gems|
-          gems.each do |gem|
+        @results.each do |gems|
+          gems.each do |name, gem|
             if !check_object.check?(gem)  
-             @checker_results[k] = {} unless @checker_results[k]
-             @checker_results[gem.name][check_object.class.name] = "
-             <br/>#{gem.name} #{gem.version} #{gem.origin}: <br/>
-             #{check_object.description} " 
+              @checker_results[name] = {} unless @checker_results[name]
+              @checker_results[gem.name][check_object.class.name] = "#{check_object.description}" 
             end
           end
         end
       end
     end
 
-    def common_key?(k)
-      if !are_there_results?
-        return false
-      end
-      @results.each do |key, result|
-        if !result[k] then
-          return false
-        end
-      end
-      return true
-    end
-
     def add_comments(comments)
       @comments = comments
     end
 
     def are_there_results?
-      if !@results or @results.empty?
-        return false
-      end
-      if !@results.has_key?(@target)
-        return false
-      end
-      if @results.length<2
-        return false
-      end
-      return true
+      return @results && !@results.empty?
     end
 
     def print
-      html_view = HTMLView.new
-      html_view.print_head
-      ids = []
-      @commands.each { |c| ids << c.ident }
-      html_view.print_description(ids)
-      if !are_there_results?
-        return
-      end
-      @results[@target].sort.each do |k,v| 
-        if !common_key?(k) then 
-          Utils::log_error(k, "#{k} in #{@target} but not found in all the sources!")
-        end
-        if @checker_results[k]
-          checker_results = @checker_results[k]
-        else
-          checker_results = nil
-        end
-        if @comments[k]
-          comments = @comments[k]
-        else
-          comments = nil
-        end
-        html_view.print_results(k, @results, @target, checker_results, comments)
-        @comments.delete(k)
-      end
-      html_view.print_tail(@checker_results, @comments)
+      return if !are_there_results?
+      view = TextView.new
+      view.print_head
+      ids = @command.filename
+      view.print_description(ids)
+      view.print_results(@results, @checker_results, @comments)
+      view.print_tail
     end
   end
 end

data/lib/gems-status/sources.rb

@@ -1,3 +1 @@
-require "gems-status/sources/obs_gems"
 require "gems-status/sources/lockfile_gems"
-require "gems-status/sources/ruby_gems_gems"

data/lib/gems-status/sources/lockfile_gems.rb

@@ -11,13 +11,13 @@ require "gems-status/utils"
 module GemsStatus
 
   class LockfileGems < GemsCommand
+    attr_reader :filename
     def initialize(conf)
-      Utils::check_parameters('LockfileGems', conf, ["id", "filenames", "gems_url", "upstream_url"])
-      @filenames = conf['filenames']
+      Utils::check_parameters('LockfileGems', conf, ["id", "filename", "gems_url"])
+      @filename = conf['filename']
       @gems_url = conf['gems_url']
       @result = {}
       @ident = conf['id']
-      @upstream_url = conf['upstream_url']
     end
 
     def get_data(dirname, filename)
@@ -45,47 +45,30 @@ module GemsStatus
       return changes
     end
 
-    def update_dependencies
-      changes = false
-      @result.each do |k, gems|
-        gems.each do |gem|
-          changes = update_gem_dependencies(gem) || changes
-        end
-      end
-      update_dependencies if changes
-    end
-
     def execute
-      @filenames.each do |filename|
-        Utils::log_debug "reading #{filename}"
-        Dir.chdir(File.dirname(filename)) do
-          file_data = get_data(File::dirname(filename), File::basename(filename))
-          if file_data.empty?
-            Utils::log_error("?", "file empty #{filename}")
-            next
-          end
-          lockfile = Bundler::LockfileParser.new(file_data)
-          lockfile.specs.each do |spec|
-            name = spec.name
-            version = Gem::Version.create(spec.version)
-            dependencies = spec.dependencies
-            Utils::log_debug "dependencies for #{name} #{dependencies}"
-            if spec.source.class.name == "Bundler::Source::Git"
-              Utils::log_debug "this comes from git #{name} #{version}"
-              gems_url = spec.source.uri
-            else 
-              gems_url = @gems_url
-            end
-            @result[name] = [] if !@result[name]
-            @result[name] << RubyGemsGems_GemSimple.new(name, version , '', filename,
-                                                       gems_url, dependencies)
-            @result[name] << RubyGemsGems_GemSimple.new(name, version , '', @upstream_url,
-                                                     @upstream_url, dependencies)
+      Utils::log_debug "reading #{@filename}"
+      Dir.chdir(File.dirname(@filename)) do
+        file_data = get_data(File::dirname(@filename), File::basename(@filename))
+        if file_data.empty?
+          Utils::log_error("?", "file empty #{@filename}")
+          next
+        end
+        lockfile = Bundler::LockfileParser.new(file_data)
+        lockfile.specs.each do |spec|
+          name = spec.name
+          version = Gem::Version.create(spec.version)
+          dependencies = spec.dependencies
+          Utils::log_debug "dependencies for #{name} #{dependencies}"
+          if spec.source.class.name == "Bundler::Source::Git"
+            Utils::log_debug "this comes from git #{name} #{version}"
+            gems_url = spec.source.uri
+          else
+            gems_url = @gems_url
           end
+          @result[name] = RubyGemsGems_GemSimple.new(name, version , '', @filename,
+                                                     gems_url, dependencies)
         end
-        update_dependencies
       end
     end
-
   end
 end

data/lib/gems-status/text_view.rb

@@ -0,0 +1,40 @@
+require 'rubygems'
+require 'gems-status/gems_status_metadata'
+require 'gems-status/utils'
+
+module GemsStatus
+
+  class TextView
+
+    def print_description(app)
+      puts "gems-status report for #{app}"
+      puts "---"
+    end
+
+    def print_results(results, checker_results, comments)
+      results.each do |result|
+        result.each do |_, gem|
+          puts "#{gem.name}: #{gem.version} #{gem.license}"
+          next unless checker_results[gem.name]
+          checker_results[gem.name].each do |_, msg|
+            puts "#{msg}"
+          end
+          puts "#{comments[gem.name]}" if comments[gem.name]
+          puts ""
+        end
+      end
+
+    end
+
+    def print_head
+    end
+
+    def print_tail
+      puts "---"
+      date = Time.now.strftime('%a %b %d %H:%M:%S %Z %Y')
+      puts "run by https://github.com/jordimassaguerpla/gems-status"
+      puts "#{date} - version: #{GemsStatus::VERSION}"
+    end
+
+  end
+end