gems-status 0.23.0 → 0.25.0

data/lib/gems-status.rb

@@ -1,6 +1,4 @@
 #!/usr/bin/ruby
-
-
  
 require "rubygems"
 require "xmlsimple"
@@ -8,10 +6,9 @@ require "open-uri"
 require "yaml"
 
 require "gems-status/gem_simple"
-require "gems-status/obs_gems"
-require "gems-status/lockfile_gems"
-require "gems-status/ruby_gems_gems"
+require "gems-status/sources.rb"
 require "gems-status/gems_composite_command"
+require "gems-status/checkers"
 
 class GemStatus
   def initialize(conf_file)

data/lib/gems-status/checkers.rb

@@ -0,0 +1,11 @@
+require "gems-status/checkers/exists_in_upstream"
+require "gems-status/checkers/git_check_messages"
+require "gems-status/checkers/hg_check_messages"
+require "gems-status/checkers/not_a_security_alert_checker"
+require "gems-status/checkers/not_native_gem_checker"
+require "gems-status/checkers/not_rails_checker"
+require "gems-status/checkers/scm_check_messages"
+require "gems-status/checkers/scm_security_messages"
+require "gems-status/checkers/svn_check_messages"
+require "gems-status/checkers/print_gem_versions"
+

data/lib/gems-status/{exists_in_upstream.rb → checkers/exists_in_upstream.rb}

@@ -1,6 +1,6 @@
 require 'rubygems'
 require 'open-uri'
-require 'gems-status/gem_checker'
+require 'gems-status/checkers/gem_checker'
 require 'gems-status/utils'
 
 class ExistsInUpstream < GemChecker

data/lib/gems-status/{git_check_messages.rb → checkers/git_check_messages.rb}

@@ -1,8 +1,11 @@
 require "git"
 
-require "gems-status/scm_check_messages"
+require "gems-status/checkers/scm_check_messages"
 
 class GitCheckMessages < ScmCheckMessages
+  # This value is the maximum log entries that git.log accepts.
+  # It is a magic number found through testing.
+  MAX_NUM_MESSAGES = 8688
 
 private
 
@@ -17,7 +20,7 @@ private
       g = Git.clone(source_repo, name)
     end
     g.pull
-    return g.log
+    return g.log MAX_NUM_MESSAGES
   end
 
   def commit_key(commit)

data/lib/gems-status/{hg_check_messages.rb → checkers/hg_check_messages.rb}

@@ -1,6 +1,6 @@
 require "mercurial-ruby"
 
-require "gems-status/scm_check_messages"
+require "gems-status/checkers/scm_check_messages"
 
 class HgCheckMessages < ScmCheckMessages
   def initialize

data/lib/gems-status/{not_a_security_alert_checker.rb → checkers/not_a_security_alert_checker.rb}

@@ -2,11 +2,11 @@ require "gmail"
 require "json"
 require "open-uri"
 
-require "gems-status/gem_checker"
-require "gems-status/git_check_messages"
-require "gems-status/hg_check_messages"
-require "gems-status/svn_check_messages"
-require "gems-status/scm_security_messages"
+require "gems-status/checkers/gem_checker"
+require "gems-status/checkers/git_check_messages"
+require "gems-status/checkers/hg_check_messages"
+require "gems-status/checkers/svn_check_messages"
+require "gems-status/checkers/scm_security_messages"
 
 class NotASecurityAlertChecker < GemChecker
   def initialize(conf)
@@ -85,15 +85,19 @@ class NotASecurityAlertChecker < GemChecker
     "email_#{listname}_#{gem.name}_#{gem.origin}_#{email.uid}"
   end
 
+  def match_name(str, name)
+    str =~ /\b#{name}\b/
+  end
+
   def look_in_emails(gem)
     @emails.each do |listname, emails|
       emails.each do |email|
-        if listname.include?(gem.name)
+        if match_name(listname, gem.name)
           @security_messages[key_for_emails(listname, gem, email)] = email.subject
           Utils::log_debug "looking for security emails: listname matches gem #{gem.name}: #{listname}"
           next
         end
-        if email.subject.include?(gem.name)
+        if match_name(email.subject, gem.name)
           @security_messages[key_for_emails(listname, gem, email)] = email.subject
           Utils::log_debug "looking for security emails: subject matches gem #{gem.name}: #{email.subject}"
           next

data/lib/gems-status/{not_native_gem_checker.rb → checkers/not_native_gem_checker.rb}

@@ -1,7 +1,7 @@
 require 'rubygems/format'
 require 'rubygems/old_format'
 require 'open-uri'
-require 'gems-status/gem_checker'
+require 'gems-status/checkers/gem_checker'
 
 class NotNativeGemChecker < GemChecker
   def check?(gem)

data/lib/gems-status/{not_rails_checker.rb → checkers/not_rails_checker.rb}

@@ -1,7 +1,7 @@
 require 'rubygems/format'
 require 'rubygems/old_format'
 require 'open-uri'
-require 'gems-status/gem_checker'
+require 'gems-status/checkers/gem_checker'
 
 class NotRailsChecker < GemChecker
   RAILS_GEMS = ["rails", "railties","activesupport"]

data/lib/gems-status/{svn_check_messages.rb → checkers/svn_check_messages.rb}

@@ -1,4 +1,4 @@
-require "gems-status/scm_check_messages"
+require "gems-status/checkers/scm_check_messages"
 
 class SvnCheckMessages < ScmCheckMessages
 

data/lib/gems-status/gems_composite_command.rb

@@ -1,11 +1,6 @@
 require "gems-status/gem_simple"
 require "gems-status/gems_command"
-require "gems-status/not_native_gem_checker"
-require "gems-status/not_rails_checker"
-require "gems-status/exists_in_upstream"
-require "gems-status/view_results"
-require "gems-status/not_a_security_alert_checker"
-require "gems-status/print_gem_versions"
+require "gems-status/html_view"
 
 class GemsCompositeCommand < GemsCommand
   def initialize(target)

data/lib/gems-status/gems_status_metadata.rb

@@ -1,3 +1,3 @@
 module GemsStatusMetadata
-  VERSION = "0.23.0"
+  VERSION = "0.25.0"
 end

data/lib/gems-status/{view_results.rb → html_view.rb}

@@ -2,12 +2,16 @@ require 'rubygems'
 require 'gems-status/gems_status_metadata'
 require 'gems-status/utils'
 
-class ViewResults
-  @@patched = []
-  @@outdated = []
-  @@up_to_date = []
+class HTMLView
 
-  def ViewResults.print_description(ids)
+  def initialize()
+    @patched = []
+    @outdated = []
+    @up_to_date = []
+  end
+
+
+  def print_description(ids)
     puts "
     <h1>gems-status</h1>
     <p>This is a comparison between different gem sources:</p>
@@ -54,7 +58,7 @@ class ViewResults
     "
   end
 
-  def ViewResults.update_summary(gem_name, status)
+  def update_summary(gem_name, status)
     if status == "alert"
       @@patched << gem_name
     elsif status == "warning"
@@ -64,7 +68,7 @@ class ViewResults
     end
   end
 
-  def ViewResults.print_results(k, results, target, checker_results, comments)
+  def print_results(k, results, target, checker_results, comments)
     puts "<p>"
     puts "<table width='100%' class='table_results'>"
     version = results[target][k][0].version
@@ -141,7 +145,7 @@ class ViewResults
     end
   end
 
-  def ViewResults.print_head
+  def print_head
     puts "<html>
     <head>
     <style>
@@ -213,7 +217,7 @@ class ViewResults
     <body>"
   end
 
-  def ViewResults.print_hash(desc, data, style, anchor = false)
+  def print_hash(desc, data, style, anchor = false)
     return if !data or data.length == 0
     puts "<p>"
     puts "<h2>#{desc}: #{data.length}</h2>"
@@ -229,7 +233,7 @@ class ViewResults
     puts "</p>"
   end
 
-  def ViewResults.print_summary
+  def print_summary
     puts "<a name='summary'/><h1>Summary</h1>"
     puts "<p><h2>patched/errored #{@@patched.length}</h2>"
     puts "<ul>"
@@ -249,12 +253,12 @@ class ViewResults
     puts "</ul></p>"
   end
 
-  def ViewResults.print_tail(checker_results, comments)
+  def print_tail(checker_results, comments)
     puts "<h1>Others</h1>"
-    self.print_hash("comments", comments, "comment")
-    self.print_hash("errors", Utils::errors, "errors")
-    self.print_summary
-    self.print_hash("checks", checker_results, "summary", true)
+    print_hash("comments", comments, "comment")
+    print_hash("errors", Utils::errors, "errors")
+    print_summary
+    print_hash("checks", checker_results, "summary", true)
     puts "<a href='error.txt'>Check log</a>"
     date = Time.now.strftime('%a %b %d %H:%M:%S %Z %Y')
     puts "<p class='footer'>run by <a href=\"https://github.com/jordimassaguerpla/gems-status\">gems-status</a> - #{date} - version: #{GemsStatusMetadata::VERSION}</p>

data/lib/gems-status/sources.rb

@@ -0,0 +1,3 @@
+require "gems-status/sources/obs_gems"
+require "gems-status/sources/lockfile_gems"
+require "gems-status/sources/ruby_gems_gems"

data/lib/gems-status/{lockfile_gems.rb → sources/lockfile_gems.rb}

@@ -4,7 +4,7 @@ require "open-uri"
 require "zlib"
 
 require "bundler"
-require "gems-status/ruby_gems_gems_gem_simple"
+require "gems-status/sources/ruby_gems_gems_gem_simple"
 require "gems-status/gems_command"
 require "gems-status/utils"
 

data/lib/gems-status/{ruby_gems_gems.rb → sources/ruby_gems_gems.rb}

@@ -3,7 +3,7 @@ require "xmlsimple"
 require "open-uri"
 require "zlib"
 
-require "gems-status/ruby_gems_gems_gem_simple"
+require "gems-status/sources/ruby_gems_gems_gem_simple"
 require "gems-status/gems_command"
 require "gems-status/utils"
 

data/test/test-gems_command.rb

@@ -1,6 +1,6 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'test/unit'
-require 'gems_command'
+require 'gems-status'
 
 class TestGemsCommand < Test::Unit::TestCase
   def test_gem_name_wrong_name

data/test/test-gems_composite_command.rb

@@ -1,6 +1,6 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'test/unit'
-require 'gems_composite_command'
+require 'gems-status'
 
 class GemsCompositeCommandTest < GemsCompositeCommand
   attr_accessor :results

data/test/test-lockfile_gems.rb

@@ -1,6 +1,6 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'test/unit'
-require 'lockfile_gems'
+require 'gems-status'
 require 'rubygems/dependency'
 
 class LockfileGemsTest < LockfileGems

data/test/test-not_rails_checker.rb

@@ -1,20 +1,18 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'rubygems'
 require 'test/unit'
-require 'gems_command'
-require 'gem_simple'
-require 'not_rails_checker'
+require 'gems-status'
 
 class TestNotRailsChecker < Test::Unit::TestCase
   def test_gem_with_no_deps
     gem = GemSimple.new("name", Gem::Version.new("1.2.3"), nil, nil, nil, nil)
-    check = NotRailsChecker
+    check = NotRailsChecker.new nil
     result = check.check?(gem)
     assert(!result)
   end
   def test_gem_with_no_deps_2
     gem = GemSimple.new("name", Gem::Version.new("1.2.3"), nil, nil, nil, [])
-    check = NotRailsChecker
+    check = NotRailsChecker.new nil
     result = check.check?(gem)
     assert(result)
   end
@@ -25,7 +23,7 @@ class TestNotRailsChecker < Test::Unit::TestCase
     ]
 
     gem = GemSimple.new("name", Gem::Version.new("1.2.3"), nil, nil, nil, deps)
-    check = NotRailsChecker
+    check = NotRailsChecker.new nil
     result = check.check?(gem)
     assert(!result)
   end
@@ -36,7 +34,7 @@ class TestNotRailsChecker < Test::Unit::TestCase
     ]
 
     gem = GemSimple.new("name", Gem::Version.new("1.2.3"), nil, nil, nil, deps)
-    check = NotRailsChecker
+    check = NotRailsChecker.new nil
     result = check.check?(gem)
     assert(result)
   end
@@ -47,7 +45,7 @@ class TestNotRailsChecker < Test::Unit::TestCase
     ]
 
     gem = GemSimple.new("name", Gem::Version.new("1.2.3"), nil, nil, nil, deps)
-    check = NotRailsChecker
+    check = NotRailsChecker.new nil
     result = check.check?(gem)
     assert(!result)
   end

data/test/test-obs_gems.rb

@@ -1,6 +1,6 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'test/unit'
-require 'obs_gems'
+require 'gems-status'
 
 class OBSGemsTest < OBSGems
   attr_accessor :result

data/test/test-ruby_gems_gems.rb

@@ -1,6 +1,6 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'test/unit'
-require 'ruby_gems_gems'
+require 'gems-status'
 
 class RubyGemsGemsTest < RubyGemsGems
   def initialize

data/test/test-utils.rb

@@ -1,7 +1,7 @@
 $:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 require 'test/unit'
 require 'rubygems'
-require 'utils'
+require 'gems-status'
 
 class TestUtils < Test::Unit::TestCase
   def test_check_parameters_no_classname

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gems-status
 version: !ruby/object:Gem::Version 
-  hash: 67
+  hash: 123
   prerelease: 
   segments: 
   - 0
-  - 23
+  - 25
   - 0
-  version: 0.23.0
+  version: 0.25.0
 platform: ruby
 authors: 
 - Jordi Massaguer Pla
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-08-16 00:00:00 Z
+date: 2012-12-14 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: xml-simple
@@ -112,26 +112,28 @@ extra_rdoc_files: []
 files: 
 - LICENSE
 - lib/gems-status.rb
-- lib/gems-status/ruby_gems_gems.rb
 - lib/gems-status/gem_simple.rb
-- lib/gems-status/lockfile_gems.rb
-- lib/gems-status/print_gem_versions.rb
-- lib/gems-status/ruby_gems_gems_gem_simple.rb
-- lib/gems-status/not_native_gem_checker.rb
-- lib/gems-status/svn_check_messages.rb
+- lib/gems-status/sources/ruby_gems_gems.rb
+- lib/gems-status/sources/lockfile_gems.rb
+- lib/gems-status/sources/ruby_gems_gems_gem_simple.rb
+- lib/gems-status/sources/obs_gems.rb
+- lib/gems-status/html_view.rb
+- lib/gems-status/checkers/print_gem_versions.rb
+- lib/gems-status/checkers/not_native_gem_checker.rb
+- lib/gems-status/checkers/svn_check_messages.rb
+- lib/gems-status/checkers/scm_security_messages.rb
+- lib/gems-status/checkers/scm_check_messages.rb
+- lib/gems-status/checkers/git_check_messages.rb
+- lib/gems-status/checkers/hg_check_messages.rb
+- lib/gems-status/checkers/gem_checker.rb
+- lib/gems-status/checkers/exists_in_upstream.rb
+- lib/gems-status/checkers/not_rails_checker.rb
+- lib/gems-status/checkers/not_a_security_alert_checker.rb
 - lib/gems-status/gems_composite_command.rb
-- lib/gems-status/scm_security_messages.rb
-- lib/gems-status/scm_check_messages.rb
-- lib/gems-status/git_check_messages.rb
+- lib/gems-status/checkers.rb
 - lib/gems-status/gems_status_metadata.rb
-- lib/gems-status/hg_check_messages.rb
-- lib/gems-status/gem_checker.rb
-- lib/gems-status/exists_in_upstream.rb
-- lib/gems-status/not_rails_checker.rb
-- lib/gems-status/view_results.rb
-- lib/gems-status/obs_gems.rb
+- lib/gems-status/sources.rb
 - lib/gems-status/gems_command.rb
-- lib/gems-status/not_a_security_alert_checker.rb
 - lib/gems-status/utils.rb
 - bin/gems-status
 - test/Gemfile.lock.test
@@ -144,7 +146,6 @@ files:
 - test/test-obs_gems.rb
 - test/Gemfile.lock
 - test/Gemfile
-- test/gem_graph.png
 homepage: http://github.com/jordimassaguerpla/gems-status
 licenses: []
 
@@ -174,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: compares rubygems from different sources