geminstaller 0.5.2 → 0.5.3

data/History.txt

@@ -1,3 +1,13 @@
+== 0.5.3 / 2009-08-25
+* Many long overdue bugfixes and patches, see http://tinyurl.com/geminstaller-0-5-3-release for details.
+* Thanks to Greg Fitzgerald, Britt Crawford, John Trupiano, Gabriel Gironda, and Eric Hodel for patches and assistance.
+* Issues with case statement under Ruby 1.9
+* GemInstaller cannot distinguish between gems that have the ame name but capitalized differently.
+* add ./ci as default location for config file
+* Disable GemInstaller install in default rails preinitializer.rb, but fork if it is used
+* autogem() fails when run for newly-installed gem
+* Sometimes installing fails due to RubyGems cache not being cleared between multiple API calls
+
 == 0.5.2 / 2009-07-24
 * Support for Rubygems 1.3.5
 

data/README.txt

@@ -21,7 +21,7 @@ GemInstaller provides automated installation, loading and activation of RubyGems
 * Allow for common configs to be reused across projects or environments by supporting multiple config files, including common config file snippets, and defaults with overrides.
 * Allow for dynamic selection of gems, versions, and platforms to be used based on environment vars or any other logic.
 * Avoid the "works on demo, breaks on production" syndrome
-* Solve world hunger, prevent the global energy crisis, and wash your socks.
+* Find lost socks.
 
 == SYNOPSYS:
 

data/Rakefile

@@ -48,7 +48,7 @@ task :coverage do
   rm_rf "coverage"
   rm_rf "website/out/code/coverage"
   sh "mkdir -p website/out/code"
-  sh "rcov -o website/out/code/coverage test/test_all.rb"
+  sh "rcov -o website/out/code/coverage test_suites/test_all.rb"
 end
 
 task :coverage_no_fail do
@@ -70,6 +70,7 @@ task :diff_manifest => :clean do
     next if path =~ /dummyrepo/
     next if path =~ /\.iml|\.ipr|\.iws|\.kpf|\.tmproj|\.project/
     next if path =~ /\.idea/
+    next if path =~ /tmtags/
     next if path =~ /\.\/nbproject/
     next if path =~ /\.\/spec/
     next if path =~ /\.\/test_suites/
@@ -131,7 +132,7 @@ end
 
 desc 'Run All Smoketests'
 task :all_smoketest => [:git_submodule_update, :clean] do
-  run_smoketest 'test/test_all_smoketests.rb'
+  run_smoketest 'test_suites/test_all_smoketests.rb'
 end
 
 desc 'Run Install Smoketest'
@@ -173,6 +174,7 @@ task :git_submodule_update do
   end
 end
 
+# TODO: make these use submodule foreach option
 desc 'Git submodules init, update, and pull'
 task :git_submodule_pull => [:git_submodule_update] do
   if File.exist?(File.dirname(__FILE__) + "/.git")
@@ -181,6 +183,7 @@ task :git_submodule_pull => [:git_submodule_update] do
   end
 end
 
+# TODO: make these use submodule foreach option
 desc 'Git submodules init, update, pull, commit, and push - warning - does a commit and push to remote repo'
 task :git_submodule_commit_and_push => [:git_submodule_pull] do
   if File.exist?(File.dirname(__FILE__) + "/.git") && git_repo_writeable?

data/lib/geminstaller.rb

@@ -34,7 +34,7 @@ module GemInstaller
   end
 
   def self.version
-    "0.5.2"
+    "0.5.3"
   end
 
   def self.create_application(args = [], registry = nil)

data/lib/geminstaller/autogem.rb

@@ -3,6 +3,8 @@ module GemInstaller
     attr_writer :gem_command_manager, :gem_source_index_proxy
     def autogem(gems)
       @gem_source_index_proxy.refresh!
+      # REALLY refresh - refreshing the source_index directly isn't enough.
+      Gem.refresh
       @completed_names = []
       @completed_gems = []
       gems.each do |gem|

data/lib/geminstaller/config_builder.rb

@@ -6,7 +6,7 @@ module GemInstaller
     attr_reader :config_file_paths_array
     attr_writer :file_reader, :yaml_loader, :config_file_paths, :output_filter
     
-    def initialize(default_config_file_paths_array = ['geminstaller.yml','config/geminstaller.yml'])
+    def initialize(default_config_file_paths_array = ['geminstaller.yml','config/geminstaller.yml','ci/geminstaller.yml'])
       @default_config_file_paths_array = default_config_file_paths_array
     end
     

data/lib/geminstaller/exact_match_list_command.rb

@@ -5,7 +5,7 @@ module GemInstaller
       # This overrides the default RubyGems ListCommand behavior of doing a wildcard match.  This caused problems
       # when some gems (ActiveRecord-JDBC) caused exceptions during a remote list, causing a remote list
       # of other gems (activerecord) to fail as well
-      options[:name] = /^#{string}$/i
+      options[:name] = /^#{string}$/
       # Do a little metaprogramming magic to avoid calling the problematic execute method on the ListCommand
       # superclass, and instead directly call the method on the QueryCommand grandparent 'supersuperclass'
       unbound_execute_method = QUERY_COMMAND_CLASS.instance_method(:execute)

data/lib/geminstaller/gem_command_manager.rb

@@ -36,21 +36,18 @@ module GemInstaller
       run_args = ["dependency", name_regexp, "--version", version]
       run_args += additional_options
       output_lines = @gem_runner_proxy.run(run_args)
-      p output_lines
-      # dependency output has all lines in the first element
-      output_array = output_lines[0].split("\n")
       # drop the first line which just echoes the dependent gem
-      output_array.shift
+      output_lines.shift
       # drop the line containing 'requires' (rubygems < 0.9.0)
-      if output_array[0] == '  Requires'
-        output_array.shift
+      if output_lines[0] == '  Requires'
+        output_lines.shift
       end
       # drop all empty lines
-      output_array.reject! { |line| line == "" }
+      output_lines.reject! { |line| line == "" }
       # strip leading space
-      output_array.each { |line| line.strip! }
+      output_lines.each { |line| line.strip! }
       # convert into gems
-      output_gems = output_array.collect do |line|
+      output_gems = output_lines.collect do |line|
         name = line.split(' ')[0]
         version_spec = line.split(/[(,)]/)[1]
         GemInstaller::RubyGem.new(name, :version => version_spec)

data/lib/geminstaller/gem_runner_proxy.rb

@@ -15,6 +15,9 @@ module GemInstaller
       
       exit_status = nil
       begin
+        # The call below is to work around RubyGem's behavior of caching (only) the last-used source when
+        # multiple gem commands for gems on different sources are issued via the API
+        Gem.sources.replace Gem.default_sources
         gem_runner.run(args)
       rescue SystemExit => system_exit
         if GemInstaller::RubyGemsVersionChecker.matches?('>1.0.1')
@@ -30,7 +33,9 @@ module GemInstaller
       end
       output_lines = @output_listener.read!
       output_lines.push(exit_status) if exit_status
-      return output_lines
+      output_lines.collect do |line|
+        line.split("\n")
+      end.flatten
     end
     
     def create_gem_runner

data/lib/geminstaller/output_filter.rb

@@ -26,8 +26,8 @@ module GemInstaller
     
     def format_rubygems_message(type, message)
       prefix = case type
-      when :stdout : "[RubyGems:stdout] "
-      when :stderr : "[RubyGems:stderr] "
+      when :stdout then "[RubyGems:stdout] "
+      when :stderr then "[RubyGems:stderr] "
       end
       "#{prefix}#{message}"
     end
@@ -46,4 +46,4 @@ module GemInstaller
       return false
     end
   end
-end
+end

data/lib/geminstaller_rails_preinitializer.rb

@@ -31,7 +31,15 @@ module GemInstallerRailsPreinitializer
 
       # The 'install' method will auto-install gems as specified by the args and config
       # IMPORTANT NOTE:  Under recent RubyGems versions, this will install to ~/.gem
-      GemInstaller.install(args)
+      # The forking is a workaround to 'check_for_upgrade' in the configuration file, which causes
+      # script/console crashes on Mac OS X. See http://www.ruby-forum.com/topic/101243 for details
+      # It is probably best not to install from preinitializer - it has known problems
+      # under Passenger, and you should be installing your gems before you initialize rails anyway,
+      # via capistrano, chef, or some other mechanism.  So, it is commented for now.
+      # pid = fork do
+      #   GemInstaller.install(args)
+      # end
+      # Process.wait(pid)
 
       # The 'autogem' method will automatically add all gems in the GemInstaller config to your load path,
       # using the rubygems 'gem' method.  Note that only the *first* version of any given gem will be loaded.

data/website/src/code/index.page

@@ -23,7 +23,7 @@ These are some notes on the underlying design of GemInstaller, and the current s
 * I'm a proponent of high code coverage.  I check periodically to ensure I maintain close to 100% code coverage, not counting platform- and version-specific code blocks (and I'll get around to those some day).  Also, the sudo recursive invocation stuff still needs some tests, but that's a bit tricky to automate.
 * The tests are "harder" on Windows (but run fine on mac/linux).  The app should work fine, but testing is pretty tricky.  I have all tests working against the latest rubygems (1.0.1).  Here's what does and doesn't work with tests against latest rubygems on windows:
   * install_smoketest.rb and autogem_smoketest.rb work
-  * ruby test/test_all.rb works
+  * ruby test_suites/test_all.rb works
   * rake default test task does not work (this seems to be a problem with hoe on windows)
   * Sometimes test suite still hangs after a while, this is probably some orphaned EmbeddedGemServer process somewhere.  A reboot should fix it - this is windows, after all!
 * One of my motivations for creating GemInstaller was as an exercise to help me learn Ruby better.  If you see me doing anything obviously dumb or inefficient in the code or design, please let me know. Some of them I already know about, but haven't fixed, most I'm probably not aware of :)
@@ -65,7 +65,7 @@ Yeah, it's too manual.  Notes for improvement below.
 ** install_smoketest.rb and autogem_smoketest.rb should pass for all RubyGems versions on mac/linux (if they are in a working state)
 ** test_all, install_smoketest.rb and autogem_smoketest.rb should pass for latest RubyGems version on windows (if they are in a working state)
 * Make sure everything is checked in
-* Make a tag in git
+* Make a tag in git (git tag x.y.z; git push origin x.y.z)
 * rake clean package
 * Upload gem to rubyforge
 * rake publish_website

data/website/src/documentation/documentation.page

@@ -449,7 +449,8 @@ Here's an example of how <code>sudoers</code> might be configured to allow the l
 
 <pre><code>
   $ sudo visudo
-  add this line:
+  # ADD this line (Do NOT delete any existing lines, or you may 
+  # lose your sudo access and ability to administer your system!!!):
   <local user> ALL = NOPASSWD: /usr/local/bin/geminstaller, /usr/local/bin/ruby, /usr/local/bin/gem
 </code></pre>
 

data/website/src/faq.page

@@ -26,7 +26,7 @@ Q: What about gems like RMagick that have platform-specific binary dependencies?
 A: You are on your own, this is outside of the scope of GemInstaller.  The geminstaller.yml file is parsed with ERB, so you can put whatever hooks you want to perform necessary system setup and/or prereq validation.  You can also google or check the RMagick home page: "http://rmagick.rubyforge.org/":http://rmagick.rubyforge.org/.  For Debian systems, check out the "AptInstaller":http://github.com/ngauthier/aptinstaller tool.
 
 Q: Why don't the tests/specs run on Windows?<br/>
-A: This has been improved with GemInstaller 0.3.0.  Using RubyGems 1.0.1 on Windows, install_smoketest.rb, autogem_smoketest.rb, and ruby test/test_all.rb all work.  See references to 'windows' on the "Code Page":code/index.html for more details.
+A: This has been improved with GemInstaller 0.3.0.  Using RubyGems 1.0.1 on Windows, install_smoketest.rb, autogem_smoketest.rb, and ruby test_suites/test_all.rb all work.  See references to 'windows' on the "Code Page":code/index.html for more details.
 
 Q: Why else should I support GemInstaller?<br/>
 A: GemInstaller has an extensive, multifaceted and multiplatform suite of specs and tests which is actively maintained against the latest trunk version of RubyGems and run via Continuous Integration.  It is valuable for alerting about regressions in RubyGems itself.  For example, leading up to the the RubyGems 1.2.0 release, the GemInstaller spec suite identified several regression bugs in RubyGems which were promptly reported and proactively fixed by awesome Eric Hodel and others before the release.

data/website/src/index.page

@@ -16,7 +16,7 @@ GemInstaller provides automated installation, loading and activation of RubyGems
 * Allow for common configs to be reused across projects or environments by supporting multiple config files, including common config file snippets, and defaults with overrides.
 * Allow for dynamic selection of gems, versions, and platforms to be used based on environment vars or any other logic.
 * Avoid the "works on demo, breaks on production" syndrome.
-* Solve world hunger, prevent the global energy crisis, and wash your socks.
+* Find lost socks.
 
 GemInstaller can be used from the command line, or embedded to run automatically on startup for a Rails app or any other Ruby program.
 
@@ -46,6 +46,15 @@ Please "report any others that you find":http://thewoolleyweb.lighthouseapp.com/
 
 h2(#history). History
 
+* 0.5.3
+** Many long overdue bugfixes and patches, see http://tinyurl.com/geminstaller-0-5-3-release for details.
+** Thanks to Greg Fitzgerald, Britt Crawford, John Trupiano, Gabriel Gironda, and Eric Hodel for patches and assistance.
+** Issues with case statement under Ruby 1.9
+** GemInstaller cannot distinguish between gems that have the ame name but capitalized differently.
+** add ./ci as default location for config file
+** Disable GemInstaller install in default rails preinitializer.rb, but fork if it is used
+** autogem() fails when run for newly-installed gem
+** Sometimes installing fails due to RubyGems cache not being cleared between multiple API calls
 * 0.5.2
 ** Support for Rubygems 1.3.5.
 * 0.5.1
@@ -78,7 +87,7 @@ h2(#history). History
 ** Changes to work with RubyGems >= 0.9.5 and take advantage of new platform and auto-install features.  See "notes on RubyGems version compatibility":code/index.html#rubygems_compatibility
 ** On Linux/Mac, you can now specify a RUBYGEMS_VERSION environment var to test against a specific version of RubyGems.
 ** Improved smoketest.rb and autogem_test.rb
-** Tests now run on windows (only against latest rubygems, with it installed, and only via test/test_all.rb, not rake)
+** Tests now run on windows (only against latest rubygems, with it installed, and only via test_suites/test_all.rb, not rake)
 ** deprecated/disabled prefer_binary_platform
 ** many other small cleanups
 * 0.2.5

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: geminstaller
 version: !ruby/object:Gem::Version 
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors: 
 - Chad Woolley
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-24 00:00:00 -07:00
+date: 2009-08-25 00:00:00 -07:00
 default_executable: 
 dependencies: []