gemdiff 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d577add5820b621392c3ab65a71319522e6209dc
-  data.tar.gz: 42f85f98610070725bc02cb32a56bd3f966f69b3
+  metadata.gz: c039d85a194ef66692935ece9f322aa74312b735
+  data.tar.gz: 83636e6d83f61b0b7e510a95a05a12a6a12110bb
 SHA512:
-  metadata.gz: 89e7224884cb4db66e5b17ef3f5a5aaa99b7585c3059c306bf56866cbc307eb20cbe3da691afec7858d944273f2074d375d7221fa0b7c9578b91fc5055f275bb
-  data.tar.gz: de6bae83d8736adf99431ad7bdc3457319c84d4881245ac7c282a89bb79fca71d5da77a06b1665daa53801b37b99230ad7be70848934a71a1fa4ae25615b4db4
+  metadata.gz: cc606da75134d7dfb3d48a9d7ce6134300ed3cdcb42db6f501084b699d5353d03da99a866c64335a4901bbce178388aefffbd76c42f7a1980254c2f6a53a991f
+  data.tar.gz: 11b319b29d91a8fa3945c6d3f525d128a515aded241b90a1bf2e6b932e6d08c1bce350de9fc068578f71bdaecd1367a99f21b0ceefa69b5fdb401717ae2cd6c7

data/lib/gemdiff/outdated_gem.rb

@@ -1,8 +1,13 @@
 module Gemdiff
   class OutdatedGem
+
+    # gems that tag releases with tag names like 1.2.3
+    # keep it alphabetical
+    LIST_NO_V = %w[atomic haml thread_safe]
+
     attr_accessor :name, :old_version, :new_version
 
-    def initialize(name, old_version=nil, new_version=nil)
+    def initialize(name, old_version = nil, new_version = nil)
       @name = name
       @old_version = old_version
       @new_version = new_version
@@ -39,7 +44,7 @@ module Gemdiff
     end
 
     def compare_url
-      "#{repo}/compare/v#{old_version}...v#{new_version}"
+      "#{repo}/compare/#{compare_part}"
     end
 
     def compare
@@ -49,5 +54,23 @@ module Gemdiff
     def open
       `open #{repo}` if repo?
     end
+
+    private
+
+    def compare_part
+      if compare_type == :no_v
+        "#{old_version}...#{new_version}"
+      else
+        "v#{old_version}...v#{new_version}"
+      end
+    end
+
+    def compare_type
+      if LIST_NO_V.include?(@name)
+        :no_v
+      else
+        :default
+      end
+    end
   end
 end

data/lib/gemdiff/version.rb

@@ -1,3 +1,3 @@
 module Gemdiff
-  VERSION = '0.0.2'
+  VERSION = '0.1.0'
 end

data/test/outdated_gem_test.rb

@@ -14,9 +14,15 @@ module Gemdiff
 
     describe "#compare_url" do
       it "returns compare url" do
-        gem = OutdatedGem.new("x", "1", "2")
+        gem = OutdatedGem.new("x", "1.0", "2.0")
         gem.stubs repo: "http://github.com/x/x"
-        assert_equal "http://github.com/x/x/compare/v1...v2", gem.compare_url
+        assert_equal "http://github.com/x/x/compare/v1.0...v2.0", gem.compare_url
+      end
+
+      it "returns compare url with no v for exceptions" do
+        gem = OutdatedGem.new("haml", "4.0.0", "4.1.0")
+        gem.stubs repo: "http://github.com/haml/haml"
+        assert_equal "http://github.com/haml/haml/compare/4.0.0...4.1.0", gem.compare_url
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gemdiff
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Tee Parham