gem_watch 0.1.1 → 0.1.2

data/Rakefile

@@ -11,6 +11,7 @@ begin
     gem.homepage = "http://github.com/jakimowicz/gem_watch"
     gem.authors = ["Fabien Jakimowicz"]
     gem.rubyforge_project = "gemwatch"
+    gem.add_development_dependency "test-unit"
     gem.add_development_dependency "thoughtbot-shoulda"
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
   end

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/lib/gem_watch/command.rb

@@ -1,8 +1,6 @@
 # Pure ruby requires
 require 'optparse'
 require 'net/smtp'
-
-# Gems
 require 'yaml'
 
 # Internal stuff
@@ -72,7 +70,6 @@ END_OF_MESSAGE
       
       opts.on "-e", "--email-recipient=email1, email2, ...", "Email address to send results." do |email|
         @options.email_recipients = email
-        @options.stdout = false
       end
       
       opts.on "-s", "--email-subject=subject", "Subject used in the email." do |subject|
@@ -81,7 +78,6 @@ END_OF_MESSAGE
       
       opts.on "-f", "--email-from=email", "Email's sender." do |email|
         @options.email_recipient = email.split(',').collect {|email| email.strip}
-        @options.stdout = false
       end
       
       opts.separator ""
@@ -122,11 +118,13 @@ END_OF_MESSAGE
   # Given a <tt>yaml</tt> object and a <tt>key</tt> string, returns the value.
   # If <tt>key</tt> contains an underscore character, it will consider each word between underscores as a subtree.
   def yaml_value(yaml, key)
+    yaml[key].value
+  rescue
     if key.include?('_')
       first_key, sep, rest = key.partition('_')
-      yaml_value yaml[first_key], rest
+      yaml_value(yaml[first_key], rest) rescue nil
     else
-      yaml[key].value rescue nil
+      nil
     end
   end
 end

data/test/check_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+require 'gem_watch/check'
+
+class CheckTest < Test::Unit::TestCase
+  context "an empty check" do
+    setup do
+      @check = GemWatch::Check.new
+    end
+    
+    should "@impacts be an empty hash at initialization" do
+      assert_kind_of Hash, @check.impacts
+      assert @check.impacts.empty?
+    end
+  
+    should "passed? returns true if @impacts is empty" do
+      assert @check.passed?
+    end
+  end
+end

data/test/command_options_test.rb

@@ -0,0 +1,44 @@
+require 'test_helper'
+require 'gem_watch/command_options'
+
+class CommandOptionsTest < Test::Unit::TestCase
+  context "initialize empty object" do
+    setup do
+      @options = GemWatch::CommandOptions.new
+    end
+    
+    should "should initialize object with default values" do
+      GemWatch::CommandOptions::Defaults.each do |key, value|
+        assert_equal value, @options.send(key)
+      end
+    end
+    
+    should "email_recipients= accepts an Array attribute" do
+      emails = ['bob@test.com', 'alice@test.com']
+      @options.email_recipients = emails
+      assert_equal emails, @options.email_recipients
+    end
+    
+    should "email_recipients= accepts a String with only one email address" do
+      email = "bob@test.com"
+      @options.email_recipients = email
+      assert_equal [email], @options.email_recipients
+    end
+    
+    should "email_recipients= accepts a String with coma separated emails" do
+      emails = ['bob@test.com', 'alice@test.com']
+      @options.email_recipients = emails.join(', ')
+      assert_equal emails, @options.email_recipients
+    end
+    
+    should "stdout false if email_recipients is not empty" do
+      @options.email_recipients = 'bob@test.com'
+      assert_false @options.stdout
+    end
+
+    should "stdout false if email_recipients is empty" do
+      @options.email_recipients = ''
+      assert_true @options.stdout
+    end
+  end
+end

data/test/command_test.rb

@@ -0,0 +1,60 @@
+require 'test_helper'
+require 'gem_watch/command'
+
+# We must access to options in order to check them
+class GemWatch::Command
+  attr_reader :options
+end
+
+class CommandTest < Test::Unit::TestCase
+  
+  YamlData = {'stdout' => '1', 'email' => {'recipients' => 'bob@test.com, alice@test.com'}}
+  MinimalYamlData = {'email' => {'recipients' => 'bob@test.com'}}
+  
+  context "initialize empty command object and get access to protected stuff" do
+    setup do
+      GemWatch::Command.send(:public, *GemWatch::Command.protected_instance_methods)
+      @command = GemWatch::Command.new
+    end
+  
+    context "parse yaml data" do
+      setup do
+        @yaml = YAML.parse(YamlData.to_yaml)
+      end
+    
+      should "yaml_value returns value of a yaml object if key has no underscore" do
+        assert_equal YamlData['stdout'], @command.yaml_value(@yaml, 'stdout')
+      end
+    
+      should "yaml_value returns nested value if an underscore is present in key name" do
+        assert_equal YamlData['email']['recipients'], @command.yaml_value(@yaml, 'email_recipients')
+      end
+    
+      should "yaml_value returns nil if key is not found" do
+        assert_nil @command.yaml_value(@yaml, 'boggy_key')
+      end
+    end # context "parse yaml data"
+    
+    should "parse_options should set stdout to true if both email and stdout options are set" do
+      @command.parse_options ["--email-recipient=bob@test.com", "--stdout"]
+      assert_true @command.options.stdout
+    end
+    
+    should "parse_options handle a yaml file with no check definition and use default values" do
+      @command.parse_options ["--config=test/minimal_yaml_data.yml"]
+      assert_equal ['bob@test.com'], @command.options.email_recipients
+    end
+    
+    should "parse_options handle a complete yaml file" do
+      @command.parse_options ["--config=test/complete_yaml_data.yml"]
+      assert_equal ['admin@example.com'],   @command.options.email_recipients
+      assert_equal "Critical update !",     @command.options.email_subject
+      assert_equal "bob@service.com",       @command.options.email_from
+      assert_equal "127.0.0.1",             @command.options.smtp_host
+      assert_equal "25",                    @command.options.smtp_port
+      assert_equal "super_security, rails", @command.options.check_update_on
+    end
+    
+  end # context "initialize empty command ..."
+  
+end

data/test/complete_yaml_data.yml

@@ -0,0 +1,11 @@
+email:
+  recipients: admin@example.com
+  subject: Critical update !
+  from: bob@service.com
+
+smtp:
+  host: 127.0.0.1
+  port: 25
+
+check:
+  update_on: super_security, rails

data/test/minimal_yaml_data.yml

@@ -0,0 +1,2 @@
+email:
+  recipients: bob@test.com

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 require 'rubygems'
+gem 'test-unit'
 require 'test/unit'
 require 'shoulda'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: gem_watch
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Fabien Jakimowicz
@@ -9,9 +9,19 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-08-20 00:00:00 +02:00
+date: 2009-10-30 00:00:00 +01:00
 default_executable: gemwatch
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: test-unit
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+    version: 
 - !ruby/object:Gem::Dependency 
   name: thoughtbot-shoulda
   type: :development
@@ -44,10 +54,16 @@ files:
 - lib/gem_watch/checks/update.rb
 - lib/gem_watch/command.rb
 - lib/gem_watch/command_options.rb
-- test/gem_watch_test.rb
+- test/check_test.rb
+- test/command_options_test.rb
+- test/command_test.rb
+- test/complete_yaml_data.yml
+- test/minimal_yaml_data.yml
 - test/test_helper.rb
 has_rdoc: true
 homepage: http://github.com/jakimowicz/gem_watch
+licenses: []
+
 post_install_message: 
 rdoc_options: 
 - --charset=UTF-8
@@ -68,10 +84,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: gemwatch
-rubygems_version: 1.3.1
+rubygems_version: 1.3.5
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: watch over outdated gems and send an email to notice admin.
 test_files: 
-- test/gem_watch_test.rb
+- test/check_test.rb
+- test/command_options_test.rb
+- test/command_test.rb
 - test/test_helper.rb

data/test/gem_watch_test.rb

@@ -1,7 +0,0 @@
-require 'test_helper'
-
-class GemWatchTest < Test::Unit::TestCase
-  should "probably rename this file and start testing for real" do
-    flunk "hey buddy, you should probably rename this file and start testing for real"
-  end
-end