gem_velocity 0.0.9 → 0.0.10

data/README.md

@@ -10,17 +10,19 @@ This is a single line graph of a single version.
 
 This is a signle line graph that has an aggregated view of a major version (or bunch of single minor versions, etc).
 
-See specs and examples for more info.
+See specs and [examples](examples/) for more info.
 
 There is also the `Multiplexer`, this is a wrapper around being able to draw multiple lines at once. You pass it any number of the above and it will graph multiple lines together in one graph.
 
 ## Note
 
-There may be some inconstancies due to bad data coming back from the api. These are outlined in:
+There are inconstancies of some bad data coming back from the api. 
 
-[https://gist.github.com/shaiguitar/d2af997b7f58e24fd305](https://gist.github.com/shaiguitar/d2af997b7f58e24fd305)
+Sometimes this is due to older data, some historical data was deleted to accommodate for performance issues at the time.
 
-It seems it happens with older data. I'm investigating though with the help of the rubygems team as per [this](https://github.com/rubygems/rubygems.org/pull/606) and will hopefully have some progress soon.
+[This](https://github.com/rubygems/rubygems.org/pull/606) [this](https://github.com/rubygems/rubygems.org/issues/616) and [this](https://gist.github.com/shaiguitar/d2af997b7f58e24fd305) have a bit more info if you want to dig in yourself.
+
+There are some other smaller slight inconsistencies due to the [rubygems.org](https://github.com/rubygems/rubygems.org) counter implementation that I believe is being worked on as well.
 
 ## Requirements
 
@@ -38,14 +40,8 @@ This essentially completes you being able to manipulate the boundries of the gra
 
 ## Web UI
 
-Do you want to see this with ease (Hey, the api is easy. Whatever) on the web at `http://rubygems-velocity.org/gem/rails/4.0.0,3.2.14` or something similar?
-
-[Work](https://github.com/shaiguitar/gem_velocity_web) has been started to put it on a UI, but your feedback in necessary for it to be useful:
-
-So if you have any idea of how you'd like to use it, please put your thoughts on the [issue](https://github.com/shaiguitar/gem_velocities/issues/3)
-
-Lemme know.
+Do you want to just see this on web at `http://rubygems-velocity.org/gem/rails/4.0.0,3.2.14` or something similar?
 
-## Feedback
+[Work](https://github.com/shaiguitar/gem_velocity_web) has been started to put it on a UI, but your feedback/contributions will be necessary for it to be useful.
 
-Is appreciated! Also, contributions! Any (other) ideas?
+Feel free to put your thoughts on the [issue](https://github.com/shaiguitar/gem_velocities/issues/3) and or pull requests.

data/TODO

@@ -16,3 +16,13 @@ consolidate velocitator fixtrues or at least repeatable generators in specs.
 cassandra says to have an option to have the multiplexer start them from the same data (to see curve/adoption rate). I see it.
 
 hardcode a time limit of earliest_time since historical data is not reliable.
+
+speed the fuck out of it:
+
+  b = rails, 3.2.x
+  1.9.3-p392 :009 > puts Time.now ; file = b.graph; puts Time.now; puts file.inspect
+  2013-10-27 17:33:54 -0700
+  Wrote graph to /Users/shair/projects/gem_velocities2/gem_velocity_web/public/images/AggregatedVelocitator-rails-3.2.x.png
+  2013-10-27 17:46:53 -0700
+
+add total that is displayed on rubygems (vs total that it gets back and calculates per day).

data/lib/gem_velocity/velocitators/aggregated_velocitator.rb

@@ -14,10 +14,13 @@ class AggregatedVelocitator < BaseVelocitator
     @version = top_level_ver #with a wildcard/x
     @versions = @aggregated_versions = gem_data.versions.select{|v| v.match(/^#{Regexp.escape(remove_trailing_x(top_level_ver))}/) }
     super(gem_name, @aggregated_versions)
+
+    raise NoSuchVersion, "no versions found for #{@version}!" if @aggregated_versions.empty?
   end
 
   def default_start
-    base_earliest_time_for(@aggregated_versions)
+    earliest_start = @aggregated_versions.map{|v| Date.parse(time_built(v)) }.compact.min
+    time_format_str(earliest_start)
   end
 
   def default_max_value

data/lib/gem_velocity/velocitators/base_velocitator.rb

@@ -60,15 +60,18 @@ class BaseVelocitator
     @passed_min_value || default_min_value
   end
 
-  def totals
+  def totals_map_by_version
+    h = {}
     versions.map do |v|
-      gem_data.total_for_version(v)
+      total_for_version = gem_data.total_for_version(v)
+      h.merge!(v => total_for_version)
     end
+    h
   end
 
   def num_downloads
-    sum = totals.map {|t| t[:version_downloads]}.sum
-    ActiveSupport::NumberHelper.number_to_delimited(sum)
+    sum_of_all_versions = totals_map_by_version.values.map {|t| t[:version_downloads]}.sum
+    ActiveSupport::NumberHelper.number_to_delimited(sum_of_all_versions)
   end
 
   def time_built(version)
@@ -125,11 +128,6 @@ class BaseVelocitator
     [version]
   end
 
-  def base_earliest_time_for(verzionz)
-    earliest_start = verzionz.map{|v| Date.parse(time_built(v)) }.min
-    default_start = time_format_str(earliest_start)
-  end
-
   def base_max_for(verzionz)
     totals = []
     verzionz.each {|v|

data/lib/gem_velocity/version.rb

@@ -1,3 +1,3 @@
 module GemVelocity
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/single_velocitator_spec.rb

@@ -60,7 +60,7 @@ describe SingleVelocitator do
 
   it "holds the totals of the gem" do
     velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
-    velocitator.totals.first[:version_downloads].should eq 377
+    velocitator.totals_map_by_version["0.0.17"][:version_downloads].should eq 377
     #binding.pry
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gem_velocity
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 11
   prerelease: 
   segments: 
   - 0
   - 0
-  - 9
-  version: 0.0.9
+  - 10
+  version: 0.0.10
 platform: ruby
 authors: 
 - Shai Rosenfeld
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-10-27 00:00:00 Z
+date: 2013-10-28 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: gruff