gem_updater 4.4.0 → 4.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a04f3bf2dd4e041cd932e126d162e4a95b7ea2a2a2690a00e97f8a5f62ef6e3
-  data.tar.gz: 72af5a2dd171dd37b6281a92c9e6508c6bc6020eb5aa46b218158f4cfcb449ec
+  metadata.gz: 10e740d324e4bd91b5e7b8d6c7d2c4272b84eedf0cabcab2e5244c55779a4a2c
+  data.tar.gz: d7050c27a7791a3b185c08e088e29c9cf645908106d352027d3ddb02f826bdae
 SHA512:
-  metadata.gz: 62ccd70ebba5c0d6ea04a47f3cf8e6fd9df7b3c170e09e0af48c238468248e4f241bf17ff6028e31ef078efbf20901869d9c64f6ca64046dd616a9cc5dce94b9
-  data.tar.gz: 3e027d0ff378017f0206edab9216eec81d1baa18a8d5b7a6babc287524d917973d8a2127f15df9ea6eb7e00fd575497c10e7b96c20f5c2db233b5140b8054333
+  metadata.gz: 26be9e96400f04d892de240c28af03f02d5e5d23ec33d51bdbce015883df6bc4de2a1631da3ab42b1bada40384868a095f1b1e2c1a82fe1f6ca7cbd231656864
+  data.tar.gz: 55a53a16a210ef6380ca2bc3febafaf01ecd42de0693fa88fcabfe7302e195d9fe0ba69989bcc37b9638f085cb06a42fe33a3c78e1e691bb4557f291b043e90a

data/lib/gem_updater/ruby_gems_fetcher.rb

@@ -34,7 +34,7 @@ module GemUpdater
     # @param url [String] remote url
     # @return [Hash] parsed JSON
     def parse_remote_json(url)
-      JSON.parse(URI.open(url).read)
+      JSON.parse(URI.parse(url).open.read)
     end
 
     # Ask rubygems.org for source uri of gem.
@@ -67,25 +67,18 @@ module GemUpdater
     # Look if gem can be found in another remote
     #
     # @return [String|nil] uri of source code
-    # rubocop:disable Metrics/MethodLength
     def uri_from_other_sources
-      uri = nil
-      source.remotes.each do |remote|
-        break if uri
-
-        uri = case remote.host
-              when 'rubygems.org' then next # already checked
-              when 'rails-assets.org'
-                uri_from_railsassets
-              else
-                Bundler.ui.error "Source #{remote} is not supported, ' \
-                  'feel free to open a PR or an issue on https://github.com/MaximeD/gem_updater"
-              end
+      source.remotes.find do |remote|
+        case remote.host
+        when 'rubygems.org' then next # already checked
+        when 'rails-assets.org'
+          return uri_from_railsassets
+        else
+          Bundler.ui.error "Source #{remote} is not supported, ' \
+            'feel free to open a PR or an issue on https://github.com/MaximeD/gem_updater"
+        end
       end
-
-      uri
     end
-    # rubocop:enable Metrics/MethodLength
 
     # Ask rails-assets.org for source uri of gem.
     # API is at : https://rails-assets.org/packages/package_name

data/lib/gem_updater/source_page_parser.rb

@@ -33,7 +33,7 @@ module GemUpdater
       return unless uri
 
       Bundler.ui.warn "Looking for a changelog in #{uri}"
-      find_changelog(Nokogiri::HTML(URI.open(uri)))
+      find_changelog(Nokogiri::HTML(uri.open))
     rescue OpenURI::HTTPError # Uri points to nothing
       log_error("Cannot find #{uri}")
     rescue Errno::ETIMEDOUT # timeout
@@ -53,7 +53,7 @@ module GemUpdater
     def correct_uri(url)
       return unless url.is_a?(String) && !url.empty?
 
-      uri = URI(url)
+      uri = URI.parse(url)
       uri.scheme == 'http' ? known_https(uri) : uri
     end
 
@@ -68,9 +68,7 @@ module GemUpdater
       when HOSTS[:github]
         # remove possible subdomain like 'wiki.github.com'
         URI "https://github.com#{uri.path}"
-      when HOSTS[:bitbucket]
-        URI "https://#{uri.host}#{uri.path}"
-      when HOSTS[:rubygems]
+      when HOSTS[:bitbucket], HOSTS[:rubygems]
         URI "https://#{uri.host}#{uri.path}"
       else
         uri
@@ -147,14 +145,14 @@ module GemUpdater
       private
 
       # Find which link corresponds to changelog.
+      # Last one is taken as files come after directories. So if there is a directory plus a file
+      # matching a changelog name, we ensure file is preferred.
       #
       # @return [String, nil] url of changelog
       def find_changelog_link
-        changelog_names.find do |name|
-          node = doc.at_css(%([aria-labelledby="files"] a[title^="#{name}"]))
-
-          break node.attr('href') if node
-        end
+        changelog_names.map do |name|
+          doc.at_css(%([aria-labelledby="files"] a[title^="#{name}"]))
+        end.compact.last&.attr('href')
       end
 
       # Looks into document to find it there is an anchor to new gem version.
@@ -162,7 +160,7 @@ module GemUpdater
       # @param url [String] url of changelog
       # @return [String, nil] anchor's href
       def find_anchor(url)
-        changelog_page = Nokogiri::HTML(URI.open(url))
+        changelog_page = Nokogiri::HTML(URI.parse(url).open)
         anchor = changelog_page.css(%(a.anchor)).find do |element|
           element.attr('href').match(version.delete('.'))
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gem_updater
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
 authors:
 - Maxime Demolin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-17 00:00:00.000000000 Z
+date: 2021-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.78'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.78'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement