gem_updater 3.0.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 458c286b02adc73fdeac3eded5de4b65390c1bfa0374efc83651b773f96f2f7b
-  data.tar.gz: bf55e5150ee714581df3b41e4177878c2b432d44c369d8bdd1cf62ae8f435d21
+  metadata.gz: aa29e2d445cbfcb39630890068aa4c500968f5c4c1765f5dbed6e3d106e04a82
+  data.tar.gz: 16bc9ffd31ed48f1e00e0c776472be38fc8a978aead2aebaf708f0e89b637e4b
 SHA512:
-  metadata.gz: be83c20442e904d34c99f3674532ac80ff891e7a088abfe7f9d7867bad4c2208066ac57fd6861c508d3d47624a0f7946f72e48cb8d99abe4272e6aa3e7554287
-  data.tar.gz: 769a8fcbbe5b19d9e9c334079e5c3a84c1fbf0d4688aace73ee33b808ee8d4fd3728247b617985694b80365715a3787768b3a24a5d9ba10c811e8bf1b0b4f692
+  metadata.gz: 05c074149555f10115bf97de0ecd8b98806995b45df64a0dcbb28f8bc59faae181b113a267d857f04b9f5048886abfcff90ec22fc18af92a34664de7b684aadd
+  data.tar.gz: 5245415abd40b10897bacd6c5df56daf1339bf1fe4cb11b4878d15e1392250e41d26f21a17e05f74dcce02f91ae2ef267e1374131747252cf349d76fea4fb789

data/bin/gem_update

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 #!/usr/bin/env ruby
 require 'optparse'
 
 # Exit cleanly from an early interrupt
 Signal.trap('INT') { exit 1 }
 
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'gem_updater'
 
 Bundler.ui = Bundler::UI::Shell.new

data/lib/gem_updater.rb

@@ -1,12 +1,17 @@
+# frozen_string_literal: true
+
+require 'memoist'
 require 'gem_updater/gem_file'
 require 'gem_updater/ruby_gems_fetcher'
 require 'gem_updater/source_page_parser'
 
+# Base lib.
 module GemUpdater
-
   # Updater's main responsability is to fill changes
   # happened before and after update of `Gemfile`, and then format them.
   class Updater
+    extend Memoist
+
     attr_accessor :gemfile
 
     def initialize
@@ -43,23 +48,11 @@ module GemUpdater
 
     # For each gem, retrieve its changelog
     def fill_changelogs
-      threads = []
-
-      gemfile.changes.each do |gem_name, details|
-        threads << Thread.new do
-          if source_uri = find_source(gem_name, details[:source])
-            source_page = GemUpdater::SourcePageParser.new(
-              url: source_uri, version: details[:versions][:new]
-            )
-
-            if source_page.changelog
-              gemfile.changes[gem_name][:changelog] = source_page.changelog
-            end
-          end
+      [].tap do |threads|
+        gemfile.changes.each do |gem_name, details|
+          threads << Thread.new { retrieve_gem_changes(gem_name, details) }
         end
-      end
-
-      threads.each(&:join)
+      end.each(&:join)
     end
 
     # Find where is hosted the source of a gem
@@ -76,16 +69,26 @@ module GemUpdater
       end
     end
 
+    def retrieve_gem_changes(gem_name, details)
+      source_uri = find_source(gem_name, details[:source])
+      return unless source_uri
+
+      source_page = GemUpdater::SourcePageParser.new(
+        url: source_uri, version: details[:versions][:new]
+      )
+
+      gemfile.changes[gem_name][:changelog] = source_page.changelog if source_page.changelog
+    end
+
     # Get the template for gem's diff.
     # It can use a custom template.
     #
     # @return [ERB] the template
     def template
-      @template ||= begin
-        File.read("#{Dir.home}/.gem_updater_template.erb")
-      rescue Errno::ENOENT
-        File.read(File.expand_path('../../lib/gem_updater_template.erb', __FILE__))
-      end
+      File.read("#{Dir.home}/.gem_updater_template.erb")
+    rescue Errno::ENOENT
+      File.read(File.expand_path('../lib/gem_updater_template.erb', __dir__))
     end
+    memoize :template
   end
 end

data/lib/gem_updater/gem_file.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'bundler/cli'
 
 module GemUpdater
-
   # GemFile is responsible for handling `Gemfile`
   class GemFile
     attr_accessor :changes
@@ -21,21 +22,20 @@ module GemUpdater
     #
     # @return [Hash] gems for which there are differences.
     def compute_changes
-      get_spec_sets
+      spec_sets_diff!
 
       old_spec_set.each do |old_gem|
         updated_gem = new_spec_set.find { |new_gem| new_gem.name == old_gem.name }
+        next unless updated_gem && old_gem.version != updated_gem.version
 
-        if updated_gem && old_gem.version != updated_gem.version
-          fill_changes(old_gem, updated_gem)
-        end
+        fill_changes(old_gem, updated_gem)
       end
     end
 
     private
 
     # Get the two spec sets (before and after `bundle update`)
-    def get_spec_sets
+    def spec_sets_diff!
       @old_spec_set = spec_set
       reinitialize_spec_set!
       @new_spec_set = spec_set

data/lib/gem_updater/ruby_gems_fetcher.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'nokogiri'
 require 'open-uri'
 
 module GemUpdater
-
   # RubyGemsFetcher is a wrapper around rubygems API.
   class RubyGemsFetcher
-    HTTP_TOO_MANY_REQUESTS = '429'.freeze
+    HTTP_TOO_MANY_REQUESTS = '429'
     GEM_HOMEPAGES = %w[source_code_uri homepage_uri].freeze
 
     attr_reader :gem_name, :source
@@ -35,11 +36,10 @@ module GemUpdater
     def uri_from_rubygems
       return unless source.remotes.map(&:host).include?('rubygems.org')
 
-      if response = query_rubygems
-        response[
-          GEM_HOMEPAGES.find { |key| response[key] && !response[key].empty? }
-        ]
-      end
+      response = query_rubygems
+      return unless response
+
+      response[GEM_HOMEPAGES.find { |key| response[key] && !response[key].empty? }]
     end
 
     # Make the real query to rubygems
@@ -52,7 +52,7 @@ module GemUpdater
       # We may trigger too many requests, in which case give rubygems a break
       if e.io.status.include?(HTTP_TOO_MANY_REQUESTS)
         if (tries += 1) < 2
-          sleep 1 and retry
+          sleep 1 && retry
         end
       end
     end
@@ -60,6 +60,7 @@ module GemUpdater
     # Look if gem can be found in another remote
     #
     # @return [String|nil] uri of source code
+    # rubocop:disable Metrics/MethodLength
     def uri_from_other_sources
       uri = nil
       source.remotes.each do |remote|
@@ -70,24 +71,28 @@ module GemUpdater
               when 'rails-assets.org'
                 uri_from_railsassets
               else
-                Bundler.ui.error "Source #{remote} is not supported, feel free to open a PR or an issue on https://github.com/MaximeD/gem_updater"
+                Bundler.ui.error "Source #{remote} is not supported, ' \
+                  'feel free to open a PR or an issue on https://github.com/MaximeD/gem_updater"
               end
       end
 
       uri
     end
+    # rubocop:enable Metrics/MethodLength
 
     # Ask rails-assets.org for source uri of gem.
     # API is at : https://rails-assets.org/packages/package_name
     #
     # @return [String|nil] uri of source code
     def uri_from_railsassets
-      if response = query_railsassets
-        response['url'].gsub(/^git/, 'http')
-      end
+      response = query_railsassets
+      return unless response
+
+      response['url'].gsub(/^git/, 'http')
     end
 
     # Make the real query to railsassets
+    # rubocop:disable Lint/HandleExceptions
     def query_railsassets
       JSON.parse(
         open(
@@ -99,5 +104,6 @@ module GemUpdater
       # with html (instead of json) containing a 500...
     rescue OpenURI::HTTPError
     end
+    # rubocop:enable Lint/HandleExceptions
   end
 end

data/lib/gem_updater/source_page_parser.rb

@@ -1,11 +1,14 @@
+# frozen_string_literal: true
+
 require 'nokogiri'
 require 'open-uri'
 
 module GemUpdater
-
   # SourcePageParser is responsible for parsing a source page where
   # the gem code is hosted.
   class SourcePageParser
+    extend Memoist
+
     HOSTS = {
       github: /github.com/,
       bitbucket: /bitbucket.org/,
@@ -29,23 +32,16 @@ module GemUpdater
     def changelog
       return unless uri
 
-      @changelog ||= begin
-        Bundler.ui.warn "Looking for a changelog in #{uri}"
-        doc = Nokogiri::HTML(open(uri))
-
-        find_changelog(doc)
-
-      rescue OpenURI::HTTPError # Uri points to nothing
-        Bundler.ui.error "Cannot find #{uri}"
-        false
-      rescue Errno::ETIMEDOUT # timeout
-        Bundler.ui.error "#{uri} is down"
-        false
-      rescue ArgumentError => e # x-oauth-basic raises userinfo not supported. [RFC3986]
-        Bundler.ui.error e
-        false
-      end
+      Bundler.ui.warn "Looking for a changelog in #{uri}"
+      find_changelog(Nokogiri::HTML(URI.open(uri)))
+    rescue OpenURI::HTTPError # Uri points to nothing
+      log_error("Cannot find #{uri}")
+    rescue Errno::ETIMEDOUT # timeout
+      log_error("#{uri} is down")
+    rescue ArgumentError => e # x-oauth-basic raises userinfo not supported. [RFC3986]
+      log_error(e)
     end
+    memoize :changelog
 
     private
 
@@ -55,15 +51,10 @@ module GemUpdater
     # @param url [String] the url to parse
     # @return [URI] valid URI
     def correct_uri(url)
-      return unless String === url && !url.empty?
+      return unless url.is_a?(String) && !url.empty?
 
       uri = URI(url)
-
-      if uri.scheme == 'http'
-        known_https(uri)
-      else
-        uri
-      end
+      uri.scheme == 'http' ? known_https(uri) : uri
     end
 
     # Some uris are not https, but we know they should be,
@@ -73,13 +64,13 @@ module GemUpdater
     # @param uri [URI::HTTP]
     # @return [URI::HTTPS|URI::HTTP]
     def known_https(uri)
-      case
-      when uri.host =~ HOSTS[:github]
+      case uri.host
+      when HOSTS[:github]
         # remove possible subdomain like 'wiki.github.com'
         URI "https://github.com#{uri.path}"
-      when uri.host =~ HOSTS[:bitbucket]
+      when HOSTS[:bitbucket]
         URI "https://#{uri.host}#{uri.path}"
-      when uri.host =~ HOSTS[:rubygems]
+      when HOSTS[:rubygems]
         URI "https://#{uri.host}#{uri.path}"
       else
         uri
@@ -115,10 +106,15 @@ module GemUpdater
       MARKUP_FILES.include?(File.extname(file_name))
     end
 
+    def log_error(error_message)
+      Bundler.ui.error error_message
+      false
+    end
+
     # GitHubParser is responsible for parsing source code
     # hosted on github.com.
     class GitHubParser < SourcePageParser
-      BASE_URL = 'https://github.com'.freeze
+      BASE_URL = 'https://github.com'
 
       attr_reader :doc, :version
 
@@ -134,17 +130,16 @@ module GemUpdater
       # @return [String] the URL of changelog
       def changelog
         url = find_changelog_link
+        return unless url
 
-        if url
-          full_url = BASE_URL + url
-
-          if changelog_may_contain_anchor?(full_url)
-            anchor = find_anchor(full_url)
-            full_url += anchor if anchor
-          end
+        full_url = BASE_URL + url
 
-          full_url
+        if changelog_may_contain_anchor?(full_url)
+          anchor = find_anchor(full_url)
+          full_url += anchor if anchor
         end
+
+        full_url
       end
 
       private
@@ -165,12 +160,12 @@ module GemUpdater
       # @param url [String] url of changelog
       # @return [String, nil] anchor's href
       def find_anchor(url)
-        changelog_page = Nokogiri::HTML(open(url))
+        changelog_page = Nokogiri::HTML(URI.open(url))
         anchor = changelog_page.css(%(a.anchor)).find do |element|
           element.attr('href').match(version.delete('.'))
         end
 
-        anchor.attr('href') if anchor
+        anchor&.attr('href')
       end
     end
   end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: gem_updater
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Maxime Demolin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-10 00:00:00.000000000 Z
+date: 2019-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: memoist
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.16.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.16.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.68.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.68.1
 description: Updates the gems of your Gemfile and fetches the links pointing to where
   their changelogs are
 email: akbarova.armia@gmail.com
@@ -92,15 +120,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Update your gems and find their changelogs