gem_lint 0.0.1 → 0.0.2

data/CHANGELOG

@@ -1,2 +1,5 @@
+v0.0.2 (29th November 2010)
+* add a --detailed flag to the lint command
+
 v0.0.1 (29th November 2010)
 * initial release

data/README.rdoc

@@ -12,6 +12,7 @@ personally.
 
   gem install gem-lint
   gem lint somefile-0.0.1.gem
+  gem lint somefile-0.0.1.gem --detailed
 
 === API
 
@@ -46,10 +47,6 @@ suit (using "rake") green.
 
 Full source is on github at https://github.com/yob/gem-lint
 
-== Ideas
-
-* command for users to display extra info on a tag a gem failed
-
 == Further Reading
 
 * http://chneukirchen.github.com/rps/

data/lib/gem_lint/runner.rb

@@ -3,7 +3,8 @@
 module GemLint
   class Runner
 
-    attr_reader :tags, :tags_with_level, :email, :name, :version
+    attr_reader :tags, :tags_with_desc, :tags_with_level
+    attr_reader :email, :name, :version
 
     def initialize(filename)
       raise ArgumentError, "'#{filename}' does not exist" unless File.file?(filename.to_s)
@@ -18,6 +19,7 @@ module GemLint
       unpack_gem
       @tags    = collect_tags
       @tags_with_level = collect_tags_with_level
+      @tags_with_desc  = collect_tags_with_desc
       @email   = spec ? spec.email : nil
       @name    = spec ? spec.name : nil
       @version = spec ? spec.version.to_s : nil
@@ -38,6 +40,18 @@ module GemLint
       end
     end
 
+    def collect_tags_with_desc
+      if unpack_successful?
+        failed_strategies.map { |s|
+          ["#{s.level_char}: #{s.tag}", s.description]
+        }.sort_by { |arr|
+          arr.first
+        }
+      else
+        ["E: unpack-failed", "There was an error unpacking the gem file"]
+      end
+    end
+
     def collect_tags_with_level
       if unpack_successful?
         failed_strategies.map { |s|

data/lib/rubygems/commands/lint_command.rb

@@ -16,10 +16,39 @@ class Gem::Commands::LintCommand < Gem::Command
 
   def initialize
     super 'lint', description
+
+    add_option('-d', '--detailed', 'Display detailed output') do |value, opts|
+      options[:detailed] = true
+    end
   end
 
   def execute
     runner = GemLint::Runner.new(get_one_gem_name)
+
+    if options[:detailed]
+      detailed_output(runner)
+    else
+      short_output(runner)
+    end
+  end
+
+  private
+
+  def detailed_output(runner)
+    if runner.tags.empty?
+      puts "No test failures!"
+      puts
+    else
+      runner.tags_with_desc.each do |tag, desc|
+        puts "- #{tag}"
+        puts "  #{desc}"
+      end
+      puts
+      exit 1
+    end
+  end
+
+  def short_output(runner)
     if runner.tags.empty?
       puts "No test failures!"
       puts

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gem_lint
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: false
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - James Healy
@@ -75,7 +75,7 @@ dependencies:
         version: "2.0"
   type: :development
   version_requirements: *id004
-description: Adds a 'lint' command rubygems that will pront a list of possible errors in a gem
+description: Adds a 'lint' command rubygems that will print a list of possible errors in a gem
 email: 
 - james@yob.id.au
 executables: []