gem-search 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa5d29683d40347c2e64155c2eaec2d83a339595
-  data.tar.gz: ddabcfcf4e8f76e4678435f790c2ba4c329d0f67
+  metadata.gz: d6ff3a0f935a8163dae5b0184b2244d681de1b1b
+  data.tar.gz: e3ae44d76970cfabf800fbc3fe3db8d0fb69764c
 SHA512:
-  metadata.gz: 87f4cb2856f3830c13c762a777000a71a5453d0c73aa01e4c39c41a8f09c1f84136818cb51525ae6dd71542b8a9e5a2b7e32e894a986d5b88c01f3ef2f66c188
-  data.tar.gz: 2a4e03660736f1a56e27c4676ff808ef4139d47b7171dfda94cf3cdddf92624f90f3ea28e4591ce32b64e87a0d7c5229fc17e4a5a2d5c4f5699a8b6507814546
+  metadata.gz: 01886f5d4122f7e45c08ad2042a0540079f821ef86c7363af4440b8fcf39d6c3e9e2f4e00ddbb980aa3d1b60948c268cf33e7ffa2d0f6ee7266f30d4c5f20a56
+  data.tar.gz: 40d0eb2af445c882777d04aefe62aa03b65fd42718594a4acd3f1a1fc570510c75bd25ded9ea399ff5447dbf29aab3558498ccb302b1be50338aba014bb7cf2b

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+## v0.1.1
+
+* Change default sort option from n[ame] to do a[ll] (download) [7041464]
+* Fix default sort option doesn't work. [e404c6e]
+* Fix proxy doesn't work by not using authentication [210ea37]

data/README.md

@@ -1,7 +1,7 @@
-[![Build Status](https://secure.travis-ci.org/rochefort/gem-search.png)](http://travis-ci.org/rochefort/gem-search)
-[![Dependency Status](https://gemnasium.com/rochefort/gem-search.png)](https://gemnasium.com/rochefort/gem-search)
-[![Code Climate](https://codeclimate.com/github/rochefort/gem-search.png)](https://codeclimate.com/github/rochefort/gem-search)
-[![Gem Version](https://badge.fury.io/rb/gem-search.svg)](http://badge.fury.io/rb/gem-search)
+[![Build Status](http://img.shields.io/travis/rochefort/gem-search.svg?style=flat)](http://travis-ci.org/rochefort/gem-search)
+[![Dependency Status](http://img.shields.io/gemnasium/rochefort/gem-search.svg?style=flat)](https://gemnasium.com/rochefort/gem-search)
+[![Code Climate](http://img.shields.io/codeclimate/github/rochefort/gem-search.svg?style=flat)](https://codeclimate.com/github/rochefort/gem-search)
+[![Gem Version](http://img.shields.io/gem/v/gem-search.svg?style=flat)](http://badge.fury.io/rb/gem-search)
 
 # gem-search
 

data/lib/gem-search/command.rb

@@ -12,15 +12,17 @@ module Gem::Search
     ENABLE_SORT_OPT = {
       'v' => 'version_downloads',
       'a' => 'downloads',
+      'n' => 'name',
     }
 
     OPTS = Slop.parse(help: true) do
       banner "Usage: gem-search gem_name [options]\n"
       on :s, :sort, opt_description([
           'Sort by the item.',
-          '  [n]ame :default  eg. gem-search webkit',
+          '  default [a]ll',
+          '  [a]ll  :DL(all)  eg. gem-search webkit -s a',
           '  [v]er  :DL(ver)  eg. gem-search webkit -s v',
-          '  [a]ll  :DL(all)  eg. gem-search webkit -s a'
+          '  [n]ame :         eg. gem-search webkit -s n',
         ]), :argument => :optional
       on :v, :version, 'Display the version.'
     end
@@ -30,7 +32,11 @@ module Gem::Search
       validate
 
       gs = Executor.new
-      gs.search(ARGV[0], ENABLE_SORT_OPT[OPTS['sort']])
+      if ENABLE_SORT_OPT[OPTS['sort']]
+        gs.search(ARGV[0], ENABLE_SORT_OPT[OPTS['sort']])
+      else
+        gs.search(ARGV[0])
+      end
     rescue LibraryNotFound => e
       puts e.message
       abort
@@ -58,4 +64,4 @@ module Gem::Search
         end
       end
   end
-end
+end

data/lib/gem-search/executor.rb

@@ -8,9 +8,8 @@ module Gem::Search
     SEARCH_URL = "#{BASE_URL}/api/v1/search.json?query=%s&page=%d"
     MAX_REQUEST_COUNT = 20
 
-    def search(query, opt_sort='name')
+    def search(query, opt_sort='downloads')
       return unless query
-
       print 'Searching '
       gems = []
       (1..MAX_REQUEST_COUNT).each do |n|
@@ -31,8 +30,12 @@ module Gem::Search
       def search_rubygems(url)
         option = {}
         proxy = URI.parse(url).find_proxy
-        if proxy && proxy.user && proxy.password
-          option[:proxy_http_basic_authentication] = [proxy, proxy.user, proxy.password]
+        if proxy
+          if proxy.user && proxy.password
+            option[:proxy_http_basic_authentication] = [proxy, proxy.user, proxy.password]
+          else
+            option[:proxy] = proxy
+          end
         end
         JSON.parse(open(url, option).read)
       end

data/lib/gem-search/version.rb

@@ -1,3 +1,3 @@
 module Gem::Search
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/bin/gem-search_spec.rb

@@ -5,9 +5,10 @@ USAGE = <<-EOS
 Usage: gem-search gem_name [options]
 
     -s, --sort         Sort by the item.
-                        [n]ame :default  eg. gem-search webkit
-                        [v]er  :DL(ver)  eg. gem-search webkit -s v
+                        default [a]ll
                         [a]ll  :DL(all)  eg. gem-search webkit -s a
+                        [v]er  :DL(ver)  eg. gem-search webkit -s v
+                        [n]ame :         eg. gem-search webkit -s n
     -v, --version      Display the version.
     -h, --help         Display this help message.
 EOS
@@ -30,8 +31,7 @@ describe 'bin/gem-search' do
     it_behaves_like 'display an usage'
   end
 
-  # non-exisitng option: -x
-  context 'with -x' do
+  context 'with -x(non-exisitng option)' do
     subject { `#{BIN} -x` }
     it_behaves_like 'display an usage'
   end

data/spec/command_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+include Gem::Search
+
+describe Command do
+  describe '#run' do
+    before do
+      @executor = Executor.new
+      Executor.should_receive(:new).and_return(@executor)
+      ARGV.stub(:[]).with(0).and_return(query)
+      stub_request_search(1, dummy_search_result)
+      stub_request_no_result_with_page(2)
+    end
+    let(:query) {'factory-girl'}
+
+    context 'with no sort option' do
+      before do
+        Command::OPTS.stub(:[]).and_return(nil)
+      end
+      it 'called with no sort option' do
+        @executor.should_receive(:search).with(query).once
+        Command.new.run
+      end
+    end
+
+    context 'with sort option' do
+      before do
+        Command::OPTS.stub(:[]).and_return(nil)
+        Command::OPTS.stub(:[]).with('sort').and_return('a')
+      end
+      it 'called with sort option' do
+        @executor.should_receive(:search).with(query, 'downloads').once
+        Command.new.run
+      end
+    end
+  end
+end

data/spec/executor_spec.rb

@@ -37,8 +37,21 @@ describe Executor do
             |NAME                                                DL(ver)   DL(all)
             |-------------------------------------------------- -------- ---------
             |factory_girl (3.6.0)                                    541   2042859
+            |factory_girl_rails (3.5.0)                            39724   1238780
             |factory_girl_generator (0.0.3)                         8015     15547
+          EOS
+        end
+      end
+
+      context 'with sort option: [a]download' do
+        it 'display rubygems ordering by name' do
+          capture(:stdout) { @executor.search(query, 'download') }.should == <<-'EOS'.unindent
+            |Searching ..
+            |NAME                                                DL(ver)   DL(all)
+            |-------------------------------------------------- -------- ---------
+            |factory_girl (3.6.0)                                    541   2042859
             |factory_girl_rails (3.5.0)                            39724   1238780
+            |factory_girl_generator (0.0.3)                         8015     15547
           EOS
         end
       end
@@ -56,15 +69,15 @@ describe Executor do
         end
       end
 
-      context 'with sort option: [a]download' do
+      context 'with sort option: [n]ame' do
         it 'display rubygems ordering by name' do
-          capture(:stdout) { @executor.search(query, 'download') }.should == <<-'EOS'.unindent
+          capture(:stdout) { @executor.search(query, 'name') }.should == <<-'EOS'.unindent
             |Searching ..
             |NAME                                                DL(ver)   DL(all)
             |-------------------------------------------------- -------- ---------
             |factory_girl (3.6.0)                                    541   2042859
-            |factory_girl_rails (3.5.0)                            39724   1238780
             |factory_girl_generator (0.0.3)                         8015     15547
+            |factory_girl_rails (3.5.0)                            39724   1238780
           EOS
         end
       end
@@ -79,7 +92,7 @@ describe Executor do
       end
       let(:query) { 'cucumber-' }
       it 'display rubygems ordering by name' do
-        capture(:stdout) { @executor.search(query) }.should == <<-'EOS'.unindent
+        capture(:stdout) { @executor.search(query, 'name') }.should == <<-'EOS'.unindent
           |Searching ....
           |NAME                                                DL(ver)   DL(all)
           |-------------------------------------------------- -------- ---------
@@ -186,95 +199,6 @@ describe Executor do
   end
 
   private
-    def stub_request_search(page, body)
-      stub_request(:get, build_search_uri(query, page)).to_return(:status => 200, :body => body)
-    end
-
-    def stub_request_no_result_with_page(page)
-      stub_request(:get, build_search_uri(query, page)).to_return(:status => 200, :body => '[]')
-    end
-
-    def build_search_uri(query, page)
-      Executor::SEARCH_URL % [query, page]
-    end
-
-    def dummy_search_result
-      # top 3 gems searching with 'factory_girl'
-      # https://rubygems.org/api/v1/search.json?query=factory_girl
-      [{"name"=>"factory_girl",
-        "downloads"=>2042859,
-        "version"=>"3.6.0",
-        "version_downloads"=>541,
-        "platform"=>"ruby",
-        "authors"=>"Josh Clayton, Joe Ferris",
-        "info"=>
-         "factory_girl provides a framework and DSL for defining and\n                      using factories - less error-prone, more explicit, and\n                      all-around easier to work with than fixtures.",
-        "project_uri"=>"http://rubygems.org/gems/factory_girl",
-        "gem_uri"=>"http://rubygems.org/gems/factory_girl-3.6.0.gem",
-        "homepage_uri"=>"https://github.com/thoughtbot/factory_girl",
-        "wiki_uri"=>"",
-        "documentation_uri"=>"",
-        "mailing_list_uri"=>"",
-        "source_code_uri"=>"https://github.com/thoughtbot/factory_girl",
-        "bug_tracker_uri"=>"",
-        "dependencies"=>
-         {"development"=>
-           [{"name"=>"appraisal", "requirements"=>"~> 0.4"},
-            {"name"=>"aruba", "requirements"=>">= 0"},
-            {"name"=>"bourne", "requirements"=>">= 0"},
-            {"name"=>"cucumber", "requirements"=>"~> 1.1"},
-            {"name"=>"mocha", "requirements"=>">= 0"},
-            {"name"=>"rspec", "requirements"=>"~> 2.0"},
-            {"name"=>"simplecov", "requirements"=>">= 0"},
-            {"name"=>"sqlite3-ruby", "requirements"=>">= 0"},
-            {"name"=>"timecop", "requirements"=>">= 0"},
-            {"name"=>"yard", "requirements"=>">= 0"}],
-          "runtime"=>[{"name"=>"activesupport", "requirements"=>">= 3.0.0"}]}},
-       {"name"=>"factory_girl_rails",
-        "downloads"=>1238780,
-        "version"=>"3.5.0",
-        "version_downloads"=>39724,
-        "platform"=>"ruby",
-        "authors"=>"Joe Ferris",
-        "info"=>
-         "factory_girl_rails provides integration between\n    factory_girl and rails 3 (currently just automatic factory definition\n    loading)",
-        "project_uri"=>"http://rubygems.org/gems/factory_girl_rails",
-        "gem_uri"=>"http://rubygems.org/gems/factory_girl_rails-3.5.0.gem",
-        "homepage_uri"=>"http://github.com/thoughtbot/factory_girl_rails",
-        "wiki_uri"=>nil,
-        "documentation_uri"=>nil,
-        "mailing_list_uri"=>nil,
-        "source_code_uri"=>nil,
-        "bug_tracker_uri"=>nil,
-        "dependencies"=>
-         {"development"=>
-           [{"name"=>"aruba", "requirements"=>">= 0"},
-            {"name"=>"cucumber", "requirements"=>"~> 1.0.0"},
-            {"name"=>"rails", "requirements"=>"= 3.0.7"},
-            {"name"=>"rake", "requirements"=>">= 0"},
-            {"name"=>"rspec", "requirements"=>"~> 2.6.0"}],
-          "runtime"=>
-           [{"name"=>"factory_girl", "requirements"=>"~> 3.5.0"},
-            {"name"=>"railties", "requirements"=>">= 3.0.0"}]}},
-       {"name"=>"factory_girl_generator",
-        "downloads"=>15547,
-        "version"=>"0.0.3",
-        "version_downloads"=>8015,
-        "platform"=>"ruby",
-        "authors"=>"Les Hill",
-        "info"=>"Rails 3 generator for factory_girl",
-        "project_uri"=>"http://rubygems.org/gems/factory_girl_generator",
-        "gem_uri"=>"http://rubygems.org/gems/factory_girl_generator-0.0.3.gem",
-        "homepage_uri"=>"http://github.com/leshill/factory_girl_generator",
-        "wiki_uri"=>nil,
-        "documentation_uri"=>nil,
-        "mailing_list_uri"=>nil,
-        "source_code_uri"=>nil,
-        "bug_tracker_uri"=>nil,
-        "dependencies"=>{"development"=>[], "runtime"=>[]}}
-      ].to_json
-    end
-
     def dummy_search_result_name_size_is_42
       [{"name"=>"size_is_42_2345678901234567890123456789012",
         "downloads"=>1000,
@@ -290,4 +214,4 @@ describe Executor do
         "version_downloads"=>200}
       ].to_json
     end
-end
+end

data/spec/spec_helper.rb

@@ -25,8 +25,97 @@ def load_http_stubs(file_name)
   open(File.join(File.dirname(__FILE__), 'http_stubs', file_name)).read
 end
 
+def stub_request_search(page, body)
+  stub_request(:get, build_search_uri(query, page)).to_return(:status => 200, :body => body)
+end
+
+def stub_request_no_result_with_page(page)
+  stub_request(:get, build_search_uri(query, page)).to_return(:status => 200, :body => '[]')
+end
+
+def build_search_uri(query, page)
+  Executor::SEARCH_URL % [query, page]
+end
+
+def dummy_search_result
+  # top 3 gems searching with 'factory_girl'
+  # https://rubygems.org/api/v1/search.json?query=factory_girl
+  [{"name"=>"factory_girl",
+    "downloads"=>2042859,
+    "version"=>"3.6.0",
+    "version_downloads"=>541,
+    "platform"=>"ruby",
+    "authors"=>"Josh Clayton, Joe Ferris",
+    "info"=>
+     "factory_girl provides a framework and DSL for defining and\n                      using factories - less error-prone, more explicit, and\n                      all-around easier to work with than fixtures.",
+    "project_uri"=>"http://rubygems.org/gems/factory_girl",
+    "gem_uri"=>"http://rubygems.org/gems/factory_girl-3.6.0.gem",
+    "homepage_uri"=>"https://github.com/thoughtbot/factory_girl",
+    "wiki_uri"=>"",
+    "documentation_uri"=>"",
+    "mailing_list_uri"=>"",
+    "source_code_uri"=>"https://github.com/thoughtbot/factory_girl",
+    "bug_tracker_uri"=>"",
+    "dependencies"=>
+     {"development"=>
+       [{"name"=>"appraisal", "requirements"=>"~> 0.4"},
+        {"name"=>"aruba", "requirements"=>">= 0"},
+        {"name"=>"bourne", "requirements"=>">= 0"},
+        {"name"=>"cucumber", "requirements"=>"~> 1.1"},
+        {"name"=>"mocha", "requirements"=>">= 0"},
+        {"name"=>"rspec", "requirements"=>"~> 2.0"},
+        {"name"=>"simplecov", "requirements"=>">= 0"},
+        {"name"=>"sqlite3-ruby", "requirements"=>">= 0"},
+        {"name"=>"timecop", "requirements"=>">= 0"},
+        {"name"=>"yard", "requirements"=>">= 0"}],
+      "runtime"=>[{"name"=>"activesupport", "requirements"=>">= 3.0.0"}]}},
+   {"name"=>"factory_girl_rails",
+    "downloads"=>1238780,
+    "version"=>"3.5.0",
+    "version_downloads"=>39724,
+    "platform"=>"ruby",
+    "authors"=>"Joe Ferris",
+    "info"=>
+     "factory_girl_rails provides integration between\n    factory_girl and rails 3 (currently just automatic factory definition\n    loading)",
+    "project_uri"=>"http://rubygems.org/gems/factory_girl_rails",
+    "gem_uri"=>"http://rubygems.org/gems/factory_girl_rails-3.5.0.gem",
+    "homepage_uri"=>"http://github.com/thoughtbot/factory_girl_rails",
+    "wiki_uri"=>nil,
+    "documentation_uri"=>nil,
+    "mailing_list_uri"=>nil,
+    "source_code_uri"=>nil,
+    "bug_tracker_uri"=>nil,
+    "dependencies"=>
+     {"development"=>
+       [{"name"=>"aruba", "requirements"=>">= 0"},
+        {"name"=>"cucumber", "requirements"=>"~> 1.0.0"},
+        {"name"=>"rails", "requirements"=>"= 3.0.7"},
+        {"name"=>"rake", "requirements"=>">= 0"},
+        {"name"=>"rspec", "requirements"=>"~> 2.6.0"}],
+      "runtime"=>
+       [{"name"=>"factory_girl", "requirements"=>"~> 3.5.0"},
+        {"name"=>"railties", "requirements"=>">= 3.0.0"}]}},
+   {"name"=>"factory_girl_generator",
+    "downloads"=>15547,
+    "version"=>"0.0.3",
+    "version_downloads"=>8015,
+    "platform"=>"ruby",
+    "authors"=>"Les Hill",
+    "info"=>"Rails 3 generator for factory_girl",
+    "project_uri"=>"http://rubygems.org/gems/factory_girl_generator",
+    "gem_uri"=>"http://rubygems.org/gems/factory_girl_generator-0.0.3.gem",
+    "homepage_uri"=>"http://github.com/leshill/factory_girl_generator",
+    "wiki_uri"=>nil,
+    "documentation_uri"=>nil,
+    "mailing_list_uri"=>nil,
+    "source_code_uri"=>nil,
+    "bug_tracker_uri"=>nil,
+    "dependencies"=>{"development"=>[], "runtime"=>[]}}
+  ].to_json
+end
+
 class String
   def unindent
     gsub(/^\s+\|/, '')
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gem-search
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - rochefort
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-22 00:00:00.000000000 Z
+date: 2014-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slop
@@ -104,6 +104,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -116,6 +117,7 @@ files:
 - lib/gem-search/rendering.rb
 - lib/gem-search/version.rb
 - spec/bin/gem-search_spec.rb
+- spec/command_spec.rb
 - spec/executor_spec.rb
 - spec/http_stubs/cucumber-_1.json
 - spec/http_stubs/cucumber-_2.json
@@ -146,6 +148,7 @@ specification_version: 4
 summary: search gems with using rubygems.org API
 test_files:
 - spec/bin/gem-search_spec.rb
+- spec/command_spec.rb
 - spec/executor_spec.rb
 - spec/http_stubs/cucumber-_1.json
 - spec/http_stubs/cucumber-_2.json