gem-release 0.4.1 → 0.4.2

data/lib/gem_release/helpers.rb

@@ -69,5 +69,9 @@ module GemRelease
         yield
       end
     end
+
+    def run_cmd(command)
+      abort unless send(command)
+    end
   end
 end

data/lib/gem_release/version.rb

@@ -1,3 +1,3 @@
 module GemRelease
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

data/lib/rubygems/commands/bump_command.rb

@@ -35,21 +35,22 @@ class Gem::Commands::BumpCommand < Gem::Command
   def execute
     @new_version_number = nil
 
+    tasks = [:commit, :push, :tag, :release]
+
     # enforce option dependencies
     options[:push] = false if options[:tag] # push is performed as part of tag
     options[:commit] = options[:commit] || options[:push] || options[:tag] || options[:release]
 
     in_gemspec_dirs do
-      bump
+      run_cmd(:bump)
     end
 
     if @new_version_number == nil
       say "No version files could be found, so no actions were performed." unless quiet?
     else
-      commit  if options[:commit]
-      push    if options[:push]
-      tag     if options[:tag]
-      release if options[:release]
+      tasks.each do |task|
+        run_cmd(task) if options[task]
+      end
     end
   end
 
@@ -61,20 +62,21 @@ class Gem::Commands::BumpCommand < Gem::Command
         @new_version_number ||= version.new_number
         say "Bumping #{gem_name} from #{version.old_number} to version #{version.new_number}" unless quiet?
         version.bump!
-        `git add #{version.filename}` if options[:commit]
+        return system("git add #{version.filename}") if options[:commit]
       else
         say "Ignoring #{gem_name}. Version file #{version.filename} not found" unless quiet?
       end
+      true
     end
 
     def commit
       say "Creating commit" unless quiet?
-      `git commit -m "Bump to #{@new_version_number}"`
+      system("git commit -m \"Bump to #{@new_version_number}\"")
     end
 
     def push
       say "Pushing to the origin git repository" unless quiet?
-      `git push origin`
+      system('git push origin')
     end
 
     def release

data/lib/rubygems/commands/release_command.rb

@@ -28,12 +28,13 @@ class Gem::Commands::ReleaseCommand < Gem::Command
   end
 
   def execute
-    tag if options[:tag]
+    tasks = [:build, :push, :remove]
+    tasks.unshift(:tag) if options[:tag]
 
     in_gemspec_dirs do
-      build
-      push
-      remove
+      tasks.each do |task|
+        run_cmd(task)
+      end
     end
 
     say "All is good, thanks my friend.\n"
@@ -43,6 +44,7 @@ class Gem::Commands::ReleaseCommand < Gem::Command
 
     def build
       BuildCommand.new.invoke(gemspec_filename)
+      true
     end
 
     def push
@@ -53,11 +55,12 @@ class Gem::Commands::ReleaseCommand < Gem::Command
       args += "--quiet" if quiet?
 
       PushCommand.new.invoke(gem_filename, *args)
+      true
     end
 
     def remove
       say "Deleting left over gem file #{gem_filename}" unless quiet?
-      `rm #{gem_filename}`
+      system('rm #{gem_filename}')
     end
 
     def tag

data/lib/rubygems/commands/tag_command.rb

@@ -15,23 +15,24 @@ class Gem::Commands::TagCommand < Gem::Command
   end
 
   def execute
-    tag
-    push
+    [:tag, :push].each do |task|
+      run_cmd(task)
+    end
   end
 
   protected
 
     def tag
       say "Creating git tag #{tag_name}" unless quiet?
-      `git tag -am 'tag #{tag_name}' #{tag_name}`
+      system("git tag -am 'tag #{tag_name}' #{tag_name}")
     end
 
     def push
       say "Pushing to the origin git repository" unless quiet?
-      `git push origin`
+      return false unless system('git push origin')
 
       say "Pushing --tags to the origin git repository" unless quiet?
-      `git push --tags origin`
+      system('git push --tags origin')
     end
 
     def tag_name

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gem-release
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-13 00:00:00.000000000 Z
+date: 2013-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: test_declarative
@@ -99,3 +99,4 @@ signing_key:
 specification_version: 3
 summary: Release your ruby gems with ease
 test_files: []
+has_rdoc: