gem-open 0.1.1 → 0.1.2

data/Rakefile

@@ -10,8 +10,8 @@ end
 
 Jeweler::Tasks.new do |gem|
   gem.name = "gem-open"
-  gem.version = "0.1.1"
-  gem.summary = "Open gems into your favorite editor by running a specific gem command."
+  gem.version = "0.1.2"
+  gem.summary = "Open gems on your favorite editor by running a specific gem command like `gem open nokogiri`."
   gem.email = "fnando.vieira@gmail.com"
   gem.homepage = "http://github.com/fnando/open-gem"
   gem.authors = ["Nando Vieira"]

data/lib/rubygems/commands/open.rb

@@ -56,11 +56,15 @@ class Gem::Commands::OpenCommand < Gem::Command
   end
 
   def open(spec)
-    if ENV["GEM_EDITOR"]
-      system "#{ENV["GEM_EDITOR"]} #{spec.full_gem_path}"
+    editor = ENV["GEM_EDITOR"] || ENV["EDITOR"]
+
+    if editor
+      system "#{editor} #{spec.full_gem_path}"
     else
       say "You must set your editor in your .bash_profile or equivalent:"
       say "  export GEM_EDITOR='mate'"
+      say "or"
+      say "  export EDITOR='mate'"
       return terminate_interaction
     end
   end

data/test/gem_open_test.rb

@@ -3,7 +3,7 @@ gem "test-unit"
 require "test/unit"
 require "mocha"
 require "rubygems_plugin"
-require "FileUtils"
+require "FileUtils" unless defined?(FileUtils)
 
 class GemOpenTest < Test::Unit::TestCase
   def setup
@@ -31,6 +31,34 @@ class GemOpenTest < Test::Unit::TestCase
     @plugin.execute
   end
 
+  def test_open_gem_using_gem_editor_variable
+    ENV["GEM_EDITOR"] = "mate"
+    ENV["EDITOR"] = "vim"
+
+    gemname = "activesupport"
+
+    Gem::SourceIndex.expects(:installed_spec_directories).returns([File.dirname(__FILE__) + "/resources"])
+
+    @plugin.expects(:options).returns(:args => [gemname])
+    @plugin.expects(:system).with("mate #{@gemdir}/activesupport-3.0.0.beta3")
+
+    @plugin.execute
+  end
+
+  def test_open_gem_using_editor_variable
+    ENV["GEM_EDITOR"] = nil
+    ENV["EDITOR"] = "vim"
+
+    gemname = "activesupport"
+
+    Gem::SourceIndex.expects(:installed_spec_directories).returns([File.dirname(__FILE__) + "/resources"])
+
+    @plugin.expects(:options).returns(:args => [gemname])
+    @plugin.expects(:system).with("vim #{@gemdir}/activesupport-3.0.0.beta3")
+
+    @plugin.execute
+  end
+
   def test_gem_without_version
     gemname = "activesupport"
 
@@ -77,6 +105,7 @@ class GemOpenTest < Test::Unit::TestCase
 
   def test_unset_editor
     ENV["GEM_EDITOR"] = nil
+    ENV["EDITOR"] = nil
     gemname = "activesupport"
 
     Gem::SourceIndex.expects(:installed_spec_directories).returns([File.dirname(__FILE__) + "/resources"])
@@ -84,6 +113,8 @@ class GemOpenTest < Test::Unit::TestCase
     @plugin.expects(:options).returns(:args => [gemname])
     @plugin.expects(:say).with("You must set your editor in your .bash_profile or equivalent:")
     @plugin.expects(:say).with("  export GEM_EDITOR='mate'")
+    @plugin.expects(:say).with("or")
+    @plugin.expects(:say).with("  export EDITOR='mate'")
     @plugin.expects(:terminate_interaction)
 
     @plugin.execute

metadata

@@ -1,12 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: gem-open
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Nando Vieira
@@ -14,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-05-23 00:00:00 -03:00
+date: 2010-08-10 00:00:00 -03:00
 default_executable: 
 dependencies: []
 
@@ -44,22 +39,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
-summary: Open gems into your favorite editor by running a specific gem command.
+summary: Open gems on your favorite editor by running a specific gem command like `gem open nokogiri`.
 test_files: 
 - test/gem_open_test.rb