geet 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd0635ff3846a704465468c125761bd184c4f028
-  data.tar.gz: 7090288ba79f44a4029ae3ba7217d89e62246105
+  metadata.gz: 8b8ebebddfff4a1580ff80b555e1604ebbbd6844
+  data.tar.gz: e14113d4db63b088c94ae74f8c22969b778ffa91
 SHA512:
-  metadata.gz: 9ae2941d700748eddf8ae382ca8ee7c53ff1a9fe896b752628ceaf0c244ada04312eadea1da3fc9b4ff571bebe512393a48083dbb47e9477c528043c99a4d155
-  data.tar.gz: 41ecfe2ea7c10fff999d36403cbccdb9a5b5705b210aadd87f8009d1cc3f7555fe4b9320d9f3fc89a435cb2d101c838e517fb0621fa2ad1e8fe1c7156ce8a898
+  metadata.gz: b5b8165f6462cc767cc77d5c3380f825ff7b0c57636d9ae193336a6509a65da2056c66a89bc81e6b5d2b5e7dcba6ee98f2afb055779033330ef64b59b8d9456a
+  data.tar.gz: 74f65ee2ed758d85f64647e5c9d69c61069d03b5f96db5c750886e7a364ed3a8feb90417ac6a6e5c193b8fce9105fc9f7700b61e6a17a6c48e9c5746c5bb580f

data/.rubocop.yml

@@ -1,17 +1,42 @@
 inherit_from: .rubocop_todo.yml
-
 AllCops:
   TargetRubyVersion: 2.3
 
+Layout/ExtraSpacing:
+  Enabled: false
+
+Layout/SpaceAroundOperators:
+  Enabled: false
+
+Metrics/AbcSize:
+  Max: 32
+
 Metrics/LineLength:
   Max: 160
 
+Metrics/MethodLength:
+  Max: 29
+
+Metrics/PerceivedComplexity:
+  Exclude:
+    - 'lib/geet/services/create_issue.rb'
+
+Style/Documentation:
+  Enabled: false
+
 Style/DoubleNegation:
   Enabled: false
 
+Style/GuardClause:
+  Exclude:
+    - 'lib/geet/git/repository.rb'
+
 Style/NegatedIf:
   Enabled: false
 
+Style/Next:
+  Enabled: false
+
 Style/TrailingCommaInArguments:
   Enabled: false
 

data/.rubocop_todo.yml

@@ -1,52 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-10-17 11:41:36 +0200 using RuboCop version 0.50.0.
+# on 2017-11-02 21:37:33 +0100 using RuboCop version 0.49.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  Exclude:
-    - 'Gemfile'
-
-# Offense count: 3
-Metrics/AbcSize:
-  Max: 31
-
-# Offense count: 6
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 29
-
-# Offense count: 1
-Metrics/PerceivedComplexity:
-  Max: 8
-
-# Offense count: 9
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/geet/git_hub/account.rb'
-    - 'lib/geet/git_hub/api_helper.rb'
-    - 'lib/geet/git_hub/issue.rb'
-    - 'lib/geet/git_hub/pr.rb'
-    - 'lib/geet/git_hub/remote_repository.rb'
-    - 'lib/geet/helpers/configuration_helper.rb'
-    - 'lib/geet/helpers/os_helper.rb'
-    - 'lib/geet/services/create_issue.rb'
-    - 'lib/geet/services/create_pr.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'Gemfile'
+# Configuration parameters: MinBodyLength.
+# Style/GuardClause:
+#   Exclude:
+#     - 'lib/geet/git/repository.rb'

data/Gemfile

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
-gem "simple_scripting", "~> 0.9.3"
+gem 'simple_scripting', '~> 0.9.3'

data/README.md

@@ -8,22 +8,32 @@ This tool is very similar to [Hub](https://github.com/github/hub), but it suppor
 
 ## Samples
 
-Basic creation of an issue and a PR (both actions will open the pages with the result in the browser):
+### Create an issue (with label and assignees)
 
-    $ geet issue create 'Issue Title' 'Issue Description'
-    
-    $ geet pr create 'PR Title' 'Multi-line
-    > 
+Basic creation of an issue (after creation, will open the page in the browser):
+
+    $ geet issue create 'Issue title' 'Multi
+    > line
     > description'
 
-More advanced issue/PR creation, with label, reviewers and assignees:
+More advanced issue creation, with labels and assignees:
 
-    $ geet issue create 'Issue Title' 'Issue Description' --label-patterns bug,wip --assignee-patterns john
-    
-    $ geet pr create 'PR Title' 'Closes #1' --label-patterns "code review" --reviewer-patterns kevin,tom,adrian
+    $ geet issue create 'Issue title' 'Issue description' --label-patterns bug,wip --assignee-patterns john
 
 patterns are partial matches, so, for example, `johncarmack` will be matched as assignee in the first case.
 
+### Create a PR (with label, reviewers, and assigned to self)
+
+Basic creation of a PR (after creation, will open the page in the browser):
+
+    $ geet pr create 'PR title' 'Description'
+
+More advanced PR creation, with label and reviewers, assigned to self:
+
+    $ geet pr create 'PR title' 'Closes #1' --label-patterns "code review" --reviewer-patterns kevin,tom,adrian
+
+### List issues/PRs
+
 List the open issues, in default order (inverse creation date):
 
     $ geet issue list
@@ -38,6 +48,24 @@ List the open PRs, in default order (inverse creation date):
     $ geet pr list
     > 21. Add PRs listing support (https://github.com/saveriomiroddi/geet/pull/21)
 
-For the help:
+### Create a gist
+
+Create a private gist:
+
+    $ geet gist create /path/to/myfile
+
+Create a public gist, with description:
+
+    $ geet gist create --public /path/to/myfile 'Gist description'
+
+### Help
+
+Display the help:
+
+    $ geet [command [subcommand]]--help
+
+Examples:
 
     $ geet --help
+    $ geet pr --help
+    $ geet pr create --help

data/geet.gemspec

@@ -1,25 +1,26 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
-$LOAD_PATH << File.expand_path("lib", __dir__)
+$LOAD_PATH << File.expand_path('lib', __dir__)
 
-require "geet/version"
+require 'geet/version'
 
 Gem::Specification.new do |s|
-  s.name        = "geet"
+  s.name        = 'geet'
   s.version     = Geet::VERSION
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = '>= 2.2.0'
-  s.authors     = ["Saverio Miroddi"]
-  s.date        = "2017-10-30"
-  s.email       = ["saverio.pub2@gmail.com"]
-  s.homepage    = "https://github.com/saveriomiroddi/geet"
-  s.summary     = "Commandline interface for performing SCM (eg. GitHub) operations (eg. PR creation)."
-  s.description = "Commandline interface for performing SCM (eg. GitHub) operations (eg. PR creation)."
-  s.license     = "GPL-3.0"
+  s.authors     = ['Saverio Miroddi']
+  s.date        = '2017-11-02'
+  s.email       = ['saverio.pub2@gmail.com']
+  s.homepage    = 'https://github.com/saveriomiroddi/geet'
+  s.summary     = 'Commandline interface for performing SCM (eg. GitHub) operations (eg. PR creation).'
+  s.description = 'Commandline interface for performing SCM (eg. GitHub) operations (eg. PR creation).'
+  s.license     = 'GPL-3.0'
 
-  s.add_runtime_dependency "simple_scripting", "~> 0.9.3"
+  s.add_runtime_dependency 'simple_scripting', '~> 0.9.3'
 
   s.files         = `git ls-files`.split("\n")
-  s.executables   << "geet"
-  s.require_paths = ["lib"]
+  s.executables   << 'geet'
+  s.require_paths = ['lib']
 end

data/lib/geet/git_hub/abstract_issue.rb

@@ -25,7 +25,7 @@ module Geet
           include_issue = \
             filter.nil? ||
             filter == :pr && issue_data.key?('pull_request') ||
-            filter == :issue && ! issue_data.key?('pull_request')
+            filter == :issue && !issue_data.key?('pull_request')
 
           if include_issue
             number = issue_data.fetch('number')

data/lib/geet/git_hub/api_helper.rb

@@ -16,7 +16,7 @@ module Geet
       end
 
       def api_base_link
-        "https://api.github.com"
+        'https://api.github.com'
       end
 
       def api_repo_link

data/lib/geet/git_hub/gist.rb

@@ -5,8 +5,9 @@ require_relative 'abstract_issue'
 module Geet
   module GitHub
     class Gist
-      def self.create(repository, filename, content, api_helper, description: nil, publik: false)
+      def self.create(filename, content, api_helper, description: nil, publik: false)
         request_address = "#{api_helper.api_base_link}/gists"
+
         request_data = prepare_request_data(filename, content, description, publik)
 
         response = api_helper.send_request(request_address, data: request_data)
@@ -24,21 +25,23 @@ module Geet
         "https://gist.github.com/#{@id}"
       end
 
-      private
+      class << self
+        private
 
-      def self.prepare_request_data(filename, content, description, publik)
-        request_data = {
-          "public" => publik,
-          "files" => {
-            filename => {
-              "content" => content
+        def prepare_request_data(filename, content, description, publik)
+          request_data = {
+            'public' => publik,
+            'files' => {
+              filename => {
+                'content' => content
+              }
             }
           }
-        }
 
-        request_data['description'] = description if description
+          request_data['description'] = description if description
 
-        request_data
+          request_data
+        end
       end
     end
   end

data/lib/geet/git_hub/issue.rb

@@ -5,7 +5,7 @@ require_relative 'abstract_issue'
 module Geet
   module GitHub
     class Issue < AbstractIssue
-      def self.create(repository, title, description, api_helper)
+      def self.create(title, description, api_helper)
         request_address = "#{api_helper.api_repo_link}/issues"
         request_data = { title: title, body: description, base: 'master' }
 

data/lib/geet/git_hub/remote_repository.rb

@@ -28,11 +28,11 @@ module Geet
       end
 
       def create_gist(filename, content, description: nil, publik: false)
-        Geet::GitHub::Gist.create(@local_repository, filename, content, @api_helper, description: description, publik: publik)
+        Geet::GitHub::Gist.create(filename, content, @api_helper, description: description, publik: publik)
       end
 
       def create_issue(title, description)
-        Geet::GitHub::Issue.create(@local_repository, title, description, @api_helper)
+        Geet::GitHub::Issue.create(title, description, @api_helper)
       end
 
       def list_issues

data/lib/geet/helpers/configuration_helper.rb

@@ -20,7 +20,7 @@ module Geet
         ['-B', '--no-browse', "Don't open the gist link in the browser after creation"],
         'filename',
         '[description]'
-      ]
+      ].freeze
 
       ISSUE_CREATE_OPTIONS = [
         ['-n', '--no-open-issue',                           "Don't open the issue link in the browser after creation"],

data/lib/geet/services/create_gist.rb

@@ -13,11 +13,12 @@ module Geet
       #   :publik:      defaults to false
       #   :no_browse    defaults to false
       #
-      def execute(repository, filename, description: nil, publik: false, no_browse: false)
-        content = IO.read(filename)
+      def execute(repository, full_filename, description: nil, publik: false, no_browse: false)
+        content = IO.read(full_filename)
 
         puts 'Creating the gist...'
 
+        filename = File.basename(full_filename)
         gist = repository.create_gist(filename, content, description: description, publik: publik)
 
         if no_browse

data/lib/geet/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Geet
-  VERSION = "0.1.5"
+  VERSION = '0.1.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Saverio Miroddi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-30 00:00:00.000000000 Z
+date: 2017-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_scripting
@@ -78,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Commandline interface for performing SCM (eg. GitHub) operations (eg. PR