gds-sso 13.6.0 → 14.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 65a4fcbf1648eb48c5d242e5e215a962f480038d
-  data.tar.gz: f1ca91a7017fd9f8e6f42eadeec97de37aa55ff3
+SHA256:
+  metadata.gz: 7036817db86d0273dc3c3043b7c02eba7433cb83e4f4e56247adaa94c5bf2a2d
+  data.tar.gz: 574ec4a52e3e22e9bf71418a4fc1b9d456f9a4b6481ac0336b7f77e7f18301b5
 SHA512:
-  metadata.gz: 1446bb1a2f1abc78e47930ed8aa252ebb3f498651afe2a45bd1fa09bfaca0acbae876a8a9b067af9ccfc2942c474a2687db91d9f16e9e3644cd3cd90c7201bb9
-  data.tar.gz: 95d9db08ac05f26e3f9235b7c56af5c17a5287b261063fc44cffd021d37abb477e83e845719b6d9a6c6eff0d9c36b5ace1d0861ef451a152839afa11250c9574
+  metadata.gz: 15a96eb588756d3cfbe852458857de8fd231d93c490b34bd814c71642d1f038325878be9aef1b7c47b3e49ea0b7927b693a2663c91fc689f9e8095d4ccdc04bb
+  data.tar.gz: 8a7480215faa733cb3e318dc7914d32aa24234e6aceab00edbb5cbd8e51fe267dfb652631f8fd7bc8a7c525be6731ba71536430bc7d3cafc800118bedb379f47

data/Gemfile

@@ -1,10 +1,3 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in gds-sso.gemspec
 gemspec
-
-# Default rails. Overridden in gemfiles during multi-build
-gem 'rails', '4.2.4'
-
-# Gems added to resolve dependency resolution
-gem 'test-unit', '3.0.8'

data/README.md

@@ -102,7 +102,7 @@ authorise_user!(any_of: %w(edit create))
 authorise_user!(all_of: %w(edit create))
 ```
 
-The signon application makes sure that only users who have been granted access to the application can access it (e.g. they have the `signin` permission for your app).  This used to be left up to the applications themselves to check with the `require_signin_permission!` method.  This is now deprecated and can be removed from your controllers.  You should replace it with a call to `authenticate_user!` if you aren't already using that method, otherwise no signon authentication will be performed.
+The signon application makes sure that only users who have been granted access to the application can access it (e.g. they have the `signin` permission for your app).
 
 ### Authorisation for API Users
 
@@ -173,6 +173,7 @@ If your application needs different or extra permissions for access, you can spe
 GDS::SSO.config do |config|
   # other config here
   config.additional_mock_permissions_required = ["array", "of", "permissions"]
+end
 ```
 
 The mock bearer token will then ensure that the dummy api user has the required permission.

data/Rakefile

@@ -16,10 +16,4 @@ namespace :spec do
   end
 end
 
-require "gem_publisher"
-task :publish_gem do |t|
-  gem = GemPublisher.publish_if_updated("gds-sso.gemspec", :rubygems)
-  puts "Published #{gem}" if gem
-end
-
 task :default => ["spec"]

data/app/controllers/authentications_controller.rb

@@ -2,7 +2,6 @@ class AuthenticationsController < ActionController::Base
   include GDS::SSO::ControllerMethods
 
   before_action :authenticate_user!, :only => :callback
-  skip_before_action :require_signin_permission!, raise: false
   layout false
 
   def callback

data/lib/gds-sso/controller_methods.rb

@@ -43,13 +43,6 @@ module GDS
         end
       end
 
-      def require_signin_permission!
-        ActiveSupport::Deprecation.warn("require_signin_permission! is deprecated and will be removed in a future version. The signon application checks for signin permission during oauth and it is no longer optional. Note that your application will still need to call authorise_user! if it doesn't already.", caller)
-        authorise_user!('signin')
-      rescue PermissionDeniedException
-        render "authorisations/cant_signin", layout: "unauthorised", status: :forbidden
-      end
-
       def authenticate_user!
         warden.authenticate!
       end

data/lib/gds-sso/version.rb

@@ -1,5 +1,5 @@
 module GDS
   module SSO
-    VERSION = "13.6.0"
+    VERSION = "14.0.0"
   end
 end

data/spec/controller/api_user_controller_spec.rb

@@ -43,7 +43,7 @@ describe Api::UserController, type: :controller do
       request.env['warden'] = double("stub warden", :authenticate! => true, authenticated?: true, user: malicious_user)
 
       request.env['RAW_POST_DATA'] = user_update_json
-      put :update, params: { uid: @user_to_update.uid }
+      put :update, body: user_update_json, params: { uid: @user_to_update.uid }
 
       expect(response.status).to eq(403)
     end
@@ -56,7 +56,7 @@ describe Api::UserController, type: :controller do
       expect(request.env['warden']).to receive(:user).at_least(:once).and_return(@signon_sso_push_user)
 
       request.env['RAW_POST_DATA'] = user_update_json
-      put :update, params: { uid: @user_to_update.uid }
+      put :update, body: user_update_json, params: { uid: @user_to_update.uid }
 
       @user_to_update.reload
       expect(@user_to_update.name).to eq("Joshua Marshall")

data/spec/internal/app/controllers/example_controller.rb

@@ -1,7 +1,6 @@
 class ExampleController < ApplicationController
 
   before_action :authenticate_user!, :only => [:restricted, :this_requires_signin_permission]
-  before_action :require_signin_permission!, only: [:this_requires_signin_permission]
 
   def index
     render body: "jabberwocky"